[PATCH] D103228: [PoC][RISCV] Using pragma to register vector intrinsic

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaRISCV.cpp:21 + PP.getIdentifierTable(), PP.getLangOpts(), Builtin::RISCV_VECTOR_KIND); + Builtin::RegisterOverloadBuiltinFunc F = [](Sema &S, const Builtin::Info &BI, +

[PATCH] D103228: [PoC][RISCV] Using pragma to register vector intrinsic

kito-cheng added inline comments. Comment at: clang/lib/Sema/SemaRISCV.cpp:21 + PP.getIdentifierTable(), PP.getLangOpts(), Builtin::RISCV_VECTOR_KIND); + Builtin::RegisterOverloadBuiltinFunc F = [](Sema &S, const Builtin::Info &BI, +

[PATCH] D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: dexonsmith, bruno. DmitryPolukhin added a project: clang. DmitryPolukhin requested review of this revision. NFC changes required for https://reviews.llvm.org/D103142 Test Plan: check-clang Repository: rG LLVM Github Monorep

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 348183. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Split changes into NFC https://reviews.llvm.org/D103229 and the rest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h:57 + + void visitIfStmt(const ExplodedNode *Node, const ProgramStateRef State, + BugReporterContext &BRC, const Stmt *S, IMO, these three `visit` functio

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h:37 + +class GetNoteVisitor : public BugReporterVisitor { +private: vsavchenko wrote: > Sorry for picking on it again, but is it visiting "get notes"? Otherwise, it > is just

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. My bad! I forgot to submit the replies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD marked 9 inline comments as done. RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h:36 + +class FindWhereConstrained : public BugReporterVisitor { +private: vsavchenko wrote: > vsavchenko wrote: > > nit: class name

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

svenvh added inline comments. Comment at: clang/test/SemaOpenCL/storageclass.cl:22 +extern generic float g_generic_extern_var; +#ifndef __opencl_c_program_scope_global_variables +// expected-error@-17 {{program scope variable must reside in constant address space}} -

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h:37 + +class GetNoteVisitor : public BugReporterVisitor { +private: vsavchenko wrote: > RedDocMD wrote: > > vsavchenko wrote: > > > Sorry for picking on it again, but is it

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h:36 + +class FindWhereConstrained : public BugReporterVisitor { +private: RedDocMD wrote: > vsavchenko wrote: > > vsavchenko wrote: > > > nit: class name should be a noun (f

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin added a subscriber: bkramer. DmitryPolukhin added a comment. In D103142#2783665 , @dexonsmith wrote: > Naively, this sounds like it could be a non-trivial tax on build times. But > it looks like it's only called in Clang from `Sema::diagn

[PATCH] D103231: [clang][AST] Set correct DeclContext in ASTImporter lookup table for ParmVarDecl.

balazske created this revision. Herald added subscribers: whisperity, martong, teemperor, gamesh411, Szelethus, dkrupp, kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subs

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

luismarques added a comment. In D102839#2783636 , @ksyx wrote: > So it seems the better way to do this would definitely by adding a > subextension as the spec had changed. But I'd like also to ask how will GCC > deal with this option, and should we mak

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Adding such a feature like this needs unit tests, it won't be let in without them, you need to add them to clang/unittest/Format/Format.cpp You also need to update th

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

anastasiia_lukianenko updated this revision to Diff 348205. anastasiia_lukianenko edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/For

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

ksyx updated this revision to Diff 348206. ksyx marked an inline comment as done. ksyx edited the summary of this revision. ksyx added a comment. Implemented Zmmul subextension, and let `no-div` to be using this subextension instead of M itself. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D103235: [SPE] Disable strict-fp for SPE by default

qiucf created this revision. qiucf added reviewers: nemanjai, jhibbits, vit9696, kpn. Herald added subscribers: steven.zhang, kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed in PR50385

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

ksyx added a comment. In D102839#2784197 , @luismarques wrote: > In D102839#2783636 , @ksyx wrote: > >> So it seems the better way to do this would definitely by adding a >> subextension as the spec had changed.

[PATCH] D103235: [SPE] Disable strict-fp for SPE by default

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103235/new/ https://reviews.llvm.org/D103235 __

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn updated this revision to Diff 348210. fhahn added a comment. Thanks for the comments! Updates: - Only emit assumptions for optimized builds; the assumes are not helpful for unoptimized builds - Use builder::CreateAssumption instead of manually constructing assume calls - Add assert that c

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

luismarques added a comment. In D102839#2784275 , @ksyx wrote: > Thanks for mentioning that! Now, I changed the effect of `no-div` option into > choosing a proper extension and implemented the `Zmmul` subextension. Is this > solution acceptable or are t

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: llvm/include/llvm/IR/MatrixBuilder.h:242 +auto *Cmp = B.CreateICmpULT(Idx, NumElts); +if (!isa(Cmp)) { + Function *TheFn = rjmccall wrote: > xbolva00 wrote: > > Prefer e

[PATCH] D102478: [Matrix] Emit assumption that matrix indices are valid.

fhahn updated this revision to Diff 348212. fhahn marked an inline comment as done. fhahn added a comment. Fix clang-tidy warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102478/new/ https://reviews.llvm.org/D102478 Files: clang/lib/CodeG

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.cpp:86 + (SplitMax > 0 && SplitMax < ColumnWidth) ? SplitMax : ColumnWidth; + ColWidth += (is(tok::comment)) ? 1 : 0; + const auto *NextColEntry = Next; Personal style, don'

[PATCH] D103204: [clang-format] New BreakInheritanceList style AfterComma

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:1839 +/// \endcode +BILS_AfterComma }; Maybe add a comma, so that the next addition will not need to modify this line? Repository: rG LLVM Github Monorepo CH

[PATCH] D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:448 + + bool isSYCL() const { return SYCLIsDevice || SYCLIsHost; } }; FWIW, we also have `SYCLVersion != SYCL_None` as a possible way to express this. Perhaps we should ju

[clang] 7faffde - [clang-format] [NFC] realign documentation in Format.h...

Author: Max Sagebaum Date: 2021-05-27T13:12:55+02:00 New Revision: 7faffdeb48d3d81ba8fc1353f1a9a563a25adf6d URL: https://github.com/llvm/llvm-project/commit/7faffdeb48d3d81ba8fc1353f1a9a563a25adf6d DIFF: https://github.com/llvm/llvm-project/commit/7faffdeb48d3d81ba8fc1353f1a9a563a25adf6d.diff

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic updated this revision to Diff 348219. asavonic added a comment. - Disabled double or float return for x86 targets - Refactored checks into a separate function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98895/new/ https://reviews.llvm.o

[PATCH] D103175: [C++4OpenCL] Fix ICE with invalid use of half

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks Yeah I think this is the only case where `DefaultLvalueConversion` exits with an error at present. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh created this revision. svenvh added reviewers: Anastasia, azabaznov. svenvh added a project: clang. Herald added subscribers: ldrumm, jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add the `memory_scope_all_devices` enum value, which is restri

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

MyDeveloperDay added a comment. Are we happy with the way this behaves? I realise some of this needs semantic information but I think the fact it only handles 1 of these 4 cases leaves me feeling a little cold. (I just don't want to be having to defend this as to why it doesn't work in all case

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. But let's wait one or more days to see if others have more comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4762 + + for (ParmVarDecl *Param : FDecl->parameters

[PATCH] D103195: Add matchers for gtest's ASSERT_THAT, EXPECT_THAT, ON_CALL and EXPECT_CALL

ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/GtestMatchers.h:55-59 +/// Matcher for gtest's `ON_CALL` macro. When `Args` is `NoMatchers`, +/// this matches a mock call to a method without argument matchers e.g. +/// `ON_CALL(mock, TwoParamMethod)`; w

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

gchatelet updated this revision to Diff 348228. gchatelet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102760/new/ https://reviews.llvm.org/D102760 Files: clang/include/clang/Basic/Module.h llvm/include/llvm/ADT/Iter

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap created this revision. gergap added reviewers: djasper, berenm. gergap requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This re-applies the old patch D27651 , which was never landed, into the latest "

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

[PATCH] D103125: [Clang][WIP] Allow renaming of "clang"

probinson added a comment. In D103125#2782096 , @echristo wrote: > I'm also not a fan of this change. From a project perspective the binary is > clang and while people may wish to change the name for their own product > teams it seems like that onus sho

[clang] 8edd346 - Add support for #elifdef and #elifndef

Author: Aaron Ballman Date: 2021-05-27T08:57:47-04:00 New Revision: 8edd3464afbff65d7d5945b3a8b20009d6ff5deb URL: https://github.com/llvm/llvm-project/commit/8edd3464afbff65d7d5945b3a8b20009d6ff5deb DIFF: https://github.com/llvm/llvm-project/commit/8edd3464afbff65d7d5945b3a8b20009d6ff5deb.diff

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman closed this revision. aaron.ballman added a comment. I've landed in 8edd3464afbff65d7d5945b3a8b20009d6ff5deb CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 _

[PATCH] D66481: [C++20] Support for lambdas in unevaluated context

sjanel added a comment. Hello, Any news on this? GCC and MSVC support them since a while now. Thanks a lot in advance ! Stephane Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66481/new/ https://reviews.llvm.org/D66481 _

[PATCH] D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name

erichkeane added inline comments. Comment at: clang/include/clang/AST/Expr.h:2045 +// representation of the type (or type of the expression) in a way that permits +// us to properly encode information about the SYCL kernels. +class UniqueStableNameExpr final rjmc

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

kito-cheng added a comment. Personally I prefer to deprecate `-mno-div` soon, but based on the rule for RISC-V GNU toolchain, it need to wait `Zmmul` extension frozen. My plan is deprecate the `-mno-div` and emit warning to tell user should use `Zmmul` instead once it frozen. CHANGES SINCE LAS

[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

Quuxplusone added inline comments. Comment at: llvm/include/llvm/ADT/IterableTraits.h:17-31 +namespace detail { + +template auto is_forward_iterator(...) -> std::false_type; + +template +auto is_forward_iterator(int) -> decltype( +std::next(std::declval()),

[PATCH] D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:448 + + bool isSYCL() const { return SYCLIsDevice || SYCLIsHost; } }; erichkeane wrote: > aaron.ballman wrote: > > FWIW, we also have `SYCLVersion != SYCL_None` as a possib

[clang] ce276b7 - Fix -Wswitch warning; NFC

Author: Aaron Ballman Date: 2021-05-27T09:24:43-04:00 New Revision: ce276b7a6448d9c30f55235392c38b0416e91bbb URL: https://github.com/llvm/llvm-project/commit/ce276b7a6448d9c30f55235392c38b0416e91bbb DIFF: https://github.com/llvm/llvm-project/commit/ce276b7a6448d9c30f55235392c38b0416e91bbb.diff

[PATCH] D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name

erichkeane added inline comments. Comment at: clang/test/CodeGenSYCL/unique_stable_name.cpp:86-89 + // FIXME: Ensure that j is incremented because VLAs are terrible. + int j = 55; + puts(__builtin_sycl_unique_stable_name(int[++j])); + // CHECK: call spir_func void @puts(i8 ad

[PATCH] D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name

aaron.ballman added inline comments. Comment at: clang/test/CodeGenSYCL/unique_stable_name.cpp:86-89 + // FIXME: Ensure that j is incremented because VLAs are terrible. + int j = 55; + puts(__builtin_sycl_unique_stable_name(int[++j])); + // CHECK: call spir_func void @puts(i8

[PATCH] D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, thanks Erich! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103112/new/ https://reviews.llvm.org/D103112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D103195: Add matchers for gtest's ASSERT_THAT, EXPECT_THAT, ON_CALL and EXPECT_CALL

hokein added inline comments. Comment at: clang/include/clang/ASTMatchers/GtestMatchers.h:34 +enum class MockArgs { + NoMatchers, ymandel wrote: > hokein wrote: > > worth comments. > > > > out of curiosity, what do we call this `Matchers`? I'd be careful to

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

martong added a comment. Alright, I see your point. I agree that solving the problem of "$a +$b +$c constrained and then $a + $c got constrained" requires canonicalization. However, canonicalization seems to be not trivial to implement. And there are some other easier cases that I think we could (

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh updated this revision to Diff 348245. svenvh edited the summary of this revision. svenvh added a comment. Update change to be header-only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103241/new/ https://reviews.llvm.org/D103241 Files: clang/lib/Headers/opencl-c-base.h clan

[clang] 758f51c - Speculatively fix a -Woverloaded-virtual diagnostic; NFC

Author: Aaron Ballman Date: 2021-05-27T09:49:39-04:00 New Revision: 758f51c14ac3d4f243fce83e9733e2aea44dbd9e URL: https://github.com/llvm/llvm-project/commit/758f51c14ac3d4f243fce83e9733e2aea44dbd9e DIFF: https://github.com/llvm/llvm-project/commit/758f51c14ac3d4f243fce83e9733e2aea44dbd9e.diff

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTIONA

[clang] caf86d2 - Speculatively fix this harder and with improved spelling capabilities.

Author: Aaron Ballman Date: 2021-05-27T09:54:09-04:00 New Revision: caf86d2959d5e900ed29af5e0ae2be23e3d299c5 URL: https://github.com/llvm/llvm-project/commit/caf86d2959d5e900ed29af5e0ae2be23e3d299c5 DIFF: https://github.com/llvm/llvm-project/commit/caf86d2959d5e900ed29af5e0ae2be23e3d299c5.diff

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a reviewer: thakis. jamieschmeiser added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D103231: [clang][AST] Set correct DeclContext in ASTImporter lookup table for ParmVarDecl.

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Thanks, looks good to me, with a nit in the tests. Comment at: clang/unittests/AST/ASTImporterTest.cpp:6199 + EXPECT_TRUE(ImportedF);

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348248. gergap added a comment. fixing some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files: clang/unittests/Format/FormatTest.cpp Index: clang/unittes

[clang] eba69b5 - Reimplement __builtin_unique_stable_name-

Author: Erich Keane Date: 2021-05-27T07:12:20-07:00 New Revision: eba69b59d1a30dead07da2c279c8ecfd2b62ba9f URL: https://github.com/llvm/llvm-project/commit/eba69b59d1a30dead07da2c279c8ecfd2b62ba9f DIFF: https://github.com/llvm/llvm-project/commit/eba69b59d1a30dead07da2c279c8ecfd2b62ba9f.diff L

[PATCH] D103112: Reimplement __builtin_unique_stable_name as __builtin_sycl_unique_stable_name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeba69b59d1a3: Reimplement __builtin_unique_stable_name- (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monore

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

gergap updated this revision to Diff 348257. gergap added a comment. arc diff again because previous diff didn't contain all changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103245/new/ https://reviews.llvm.org/D103245 Files: clang/lib/Form

[clang] 023fbf3 - Correct the 'KEYALL' mask.

Author: Erich Keane Date: 2021-05-27T07:20:32-07:00 New Revision: 023fbf3df32d4100b57597a4e748c94931c1b936 URL: https://github.com/llvm/llvm-project/commit/023fbf3df32d4100b57597a4e748c94931c1b936 DIFF: https://github.com/llvm/llvm-project/commit/023fbf3df32d4100b57597a4e748c94931c1b936.diff L

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

azabaznov added inline comments. Comment at: clang/include/clang/Basic/OpenCLExtensions.def:113 OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_order_seq_cst, false, 300, OCL_C_30) +OPENCL_OPTIONALCOREFEATURE(__opencl_c_atomic_scope_all_devices, false, 300, OCL_C_30) OPENCL_OPTI

[clang] 96ef4f4 - Hopefully fix the Clang sphinx doc build.

Author: Aaron Ballman Date: 2021-05-27T10:27:01-04:00 New Revision: 96ef4f4a24918642f2133522c8c686bd5cf8dc63 URL: https://github.com/llvm/llvm-project/commit/96ef4f4a24918642f2133522c8c686bd5cf8dc63 DIFF: https://github.com/llvm/llvm-project/commit/96ef4f4a24918642f2133522c8c686bd5cf8dc63.diff

[PATCH] D102507: [HIP] Support in device code

yaxunl added a comment. In D102507#2760025 , @tra wrote: > In effect this patch applies `__host__ __device__` to a subset of the > standard library headers and whatever headers *they* happen to include. While > it may happen to work, I'm not at all conf

[PATCH] D103252: [C++4OpenCL] Fix missing address space on implicit move assignment operator

olestrohm created this revision. olestrohm added reviewers: Anastasia, svenvh. olestrohm added a project: clang. Herald added subscribers: ldrumm, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. This fixes the missing address space on `this` in the impl

[clang] 767d34e - Disable misc-no-recursion checking in Clang

Author: Aaron Ballman Date: 2021-05-27T10:39:04-04:00 New Revision: 767d34e3bdddef6c1871006dd0a2d06a4e1bcd5d URL: https://github.com/llvm/llvm-project/commit/767d34e3bdddef6c1871006dd0a2d06a4e1bcd5d DIFF: https://github.com/llvm/llvm-project/commit/767d34e3bdddef6c1871006dd0a2d06a4e1bcd5d.diff

[PATCH] D103157: Disable misc-no-recursion checking in Clang

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks! I've committed in 767d34e3bdddef6c1871006dd0a2d06a4e1bcd5d . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D103142: [clang][clangd] Use reverse header map lookup in suggestPathToFileForDiagnostics

DmitryPolukhin updated this revision to Diff 348264. DmitryPolukhin added a comment. Fix forgotten comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103142/new/ https://reviews.llvm.org/D103142 Files: clang/include/clang/Lex/HeaderMap.h cl

[PATCH] D102839: [RISCV][Clang] Add -mno-div option to disable hardware int division

asb added a comment. In D102839#2784585 , @kito-cheng wrote: > Personally I prefer to deprecate `-mno-div` soon, but based on the rule for > RISC-V GNU toolchain, it need to wait `Zmmul` extension frozen. > My plan is deprecate the `-mno-div` and emit w

[clang] 85f5272 - [OpenCL][NFC] Fix typos in test

Author: Sven van Haastregt Date: 2021-05-27T16:06:33+01:00 New Revision: 85f5272ffc58d73089bf77f0451b37176aa6b64f URL: https://github.com/llvm/llvm-project/commit/85f5272ffc58d73089bf77f0451b37176aa6b64f DIFF: https://github.com/llvm/llvm-project/commit/85f5272ffc58d73089bf77f0451b37176aa6b64f.

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

melver marked 3 inline comments as done. melver added a comment. Ping. To reviewers: Do note the `feature` vs. `extension` discussion. Summary: We think to be consistent with other sanitizers and avoid confusion, we must make this a `feature`, too. Thanks. Repository: rG LLVM Github Monorep

[PATCH] D103188: [clang-tidy] modernize-loop-convert: limit use of auto

eddy-geek added a subscriber: sammccall. eddy-geek added a comment. Builds ok, ready for review. I can't edit reviewers now, can someone help? @sammccall ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103188/new/ https://reviews.llvm.org/D103188

[PATCH] D102736: Fix tmp files being left on Windows builds.

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Yeah, this is good. My remaining comments are all speculations about how to improve this further in the future, but they aren't directly applicable to the goal here. Repository:

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 348283. ASDenysPetrov added a comment. Herald added a subscriber: manas. @vsavchenko Reworked the algorithm. I hope this is the final version. Honestly, I also have the most optimized version but it has twice more similar(but different) code and `goto

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 348284. ASDenysPetrov added a comment. @vsavchenko Reworked the algorithm. I hope this is the final version. Honestly, I also have the most optimized version but it has twice more similar(but different) code and gotos. I decided not to present it. Let

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

aaronpuchert added a comment. In D102026#2780384 , @delesley wrote: > Thanks for taking the time to discuss things with me. :-) Thank you as well! > Wrt. to the TEST_LOCKED_FUNCTION, I agree that you can simulate the behavior > using Assert and Lock.

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 348286. ASDenysPetrov added a comment. Mistakenly erased with another patch. Restored. But anyway this revision should be //abandoned //as irrelevant any more. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97388/new/ https://reviews.llvm.org/

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D103159#2784845 , @melver wrote: > Ping. FWIW, the usual practice is to ping after no activity on the review for about a week. That

[clang] 3d64677 - Thread safety analysis: Factor out function for merging locks (NFC)

Author: Aaron Puchert Date: 2021-05-27T17:44:48+02:00 New Revision: 3d64677c28072867ea6025a22805977386b767f8 URL: https://github.com/llvm/llvm-project/commit/3d64677c28072867ea6025a22805977386b767f8 DIFF: https://github.com/llvm/llvm-project/commit/3d64677c28072867ea6025a22805977386b767f8.diff

[clang] cf0b337 - Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

Author: Aaron Puchert Date: 2021-05-27T17:46:04+02:00 New Revision: cf0b337c1b1f064c81fe40124ddba178572778d6 URL: https://github.com/llvm/llvm-project/commit/cf0b337c1b1f064c81fe40124ddba178572778d6 DIFF: https://github.com/llvm/llvm-project/commit/cf0b337c1b1f064c81fe40124ddba178572778d6.diff

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

ASDenysPetrov abandoned this revision. ASDenysPetrov added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97388/new/ https://reviews.llvm.org/D97388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D102025: Thread safety analysis: Factor out function for merging locks (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG3d64677c2807: Thread safety analysis: Factor out function for merging locks (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D102026: Thread safety analysis: Allow exlusive/shared joins for managed and asserted capabilities

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaronpuchert marked 2 inline comments as done. Closed by commit rGcf0b337c1b1f: Thread safety analysis: Allow exlusive/shared joins for managed and asserted… (authored

[clang] 7922ff6 - [AIX] Add -lc++abi and -lunwind for linking

Author: jasonliu Date: 2021-05-27T15:48:53Z New Revision: 7922ff601094585c4b46b2640b7d07986f722c1b URL: https://github.com/llvm/llvm-project/commit/7922ff601094585c4b46b2640b7d07986f722c1b DIFF: https://github.com/llvm/llvm-project/commit/7922ff601094585c4b46b2640b7d07986f722c1b.diff LOG: [AIX

[PATCH] D102813: [AIX] Add -lc++abi and -lunwind for linking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7922ff601094: [AIX] Add -lc++abi and -lunwind for linking (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D97340: [HIP] Support Spack packages

yaxunl added a comment. In D97340#2778073 , @haampie wrote: > Hi Yaxunl, > >> The patch should not cause circular dependency on HIP or device library. > > I'm not saying this patch introduces a circular dependency, I'm saying you > are trying to solve an

[PATCH] D103229: [clang] NFC: split HeaderMapTest to have re-usable header map implementation for testing

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM; thanks for splitting this out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103229/new/ https://reviews.llvm.org/D103229 ___

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 348294. ASDenysPetrov added a comment. Fixed the issue. Added more unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedCons

[clang] 6d2c095 - [HIP] Check compatibility of -fgpu-sanitize with offload arch

Author: Yaxun (Sam) Liu Date: 2021-05-27T12:06:42-04:00 New Revision: 6d2c0950205f50f926ba5e362e845faff22582b7 URL: https://github.com/llvm/llvm-project/commit/6d2c0950205f50f926ba5e362e845faff22582b7 DIFF: https://github.com/llvm/llvm-project/commit/6d2c0950205f50f926ba5e362e845faff22582b7.dif

[PATCH] D102975: [HIP] Check compatibility of -fgpu-sanitize with offload arch

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d2c0950205f: [HIP] Check compatibility of -fgpu-sanitize with offload arch (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D92639: [analyzer] Add control flow arrows to the analyzer's HTML reports

ASDenysPetrov added a comment. Herald added a subscriber: manas. @vsavchenko How about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 ___ cfe-commits maili

[clang] 5c18d11 - [SPE] Disable strict-fp for SPE by default

Author: Qiu Chaofan Date: 2021-05-28T00:14:35+08:00 New Revision: 5c18d1136665f74b15c0df599f56ac3e2e947fb8 URL: https://github.com/llvm/llvm-project/commit/5c18d1136665f74b15c0df599f56ac3e2e947fb8 DIFF: https://github.com/llvm/llvm-project/commit/5c18d1136665f74b15c0df599f56ac3e2e947fb8.diff L

[PATCH] D103235: [SPE] Disable strict-fp for SPE by default

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c18d1136665: [SPE] Disable strict-fp for SPE by default (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D103159: [Clang] Enable __has_feature(coverage_sanitizer)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4fbc66cd6d90: [Clang] Enable __has_feature(coverage_sanitizer) (authored by melver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 4fbc66c - [Clang] Enable __has_feature(coverage_sanitizer)

Author: Marco Elver Date: 2021-05-27T18:24:21+02:00 New Revision: 4fbc66cd6d90d8d5169c43fcc1b1e26e8a98d3a9 URL: https://github.com/llvm/llvm-project/commit/4fbc66cd6d90d8d5169c43fcc1b1e26e8a98d3a9 DIFF: https://github.com/llvm/llvm-project/commit/4fbc66cd6d90d8d5169c43fcc1b1e26e8a98d3a9.diff L

[PATCH] D103218: [Fuchsia][CMake] Add missing include path.

hctim added a comment. Thanks for the keen eye on the Fuchsia bots, I didn't see this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103218/new/ https://reviews.llvm.org/D103218 ___ cfe-commits mailing l

[PATCH] D103241: [OpenCL] Add memory_scope_all_devices

svenvh updated this revision to Diff 348309. svenvh added a comment. Restrict feature macro definition to SPIR target only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103241/new/ https://reviews.llvm.org/D103241 Files: clang/lib/Headers/opencl-c-base.h clang/test/Headers/opencl-

  1   2   >