craig.topper added inline comments.
================
Comment at: clang/lib/Sema/SemaRISCV.cpp:21
+ PP.getIdentifierTable(), PP.getLangOpts(), Builtin::RISCV_VECTOR_KIND);
+ Builtin::RegisterOverloadBuiltinFunc F = [](Sema &S, const Builtin::Info &BI,
+ unsigned ID) {
----------------
Can we capture Sema in the lambda capture list here so that it's not really
passed to initializeTargetOverloadBuiltins. I don't think forward declaring
Sema in Builtins.h is a good idea since the "Basic" library isn't supposed to
know about Sema. That probably means you need to use a std::function instead of
a function pointer.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103228/new/
https://reviews.llvm.org/D103228
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
