[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit updated this revision to Diff 330568. atirit added a comment. Added comments for the previous commit's changes and cleaned up those changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 Files: cl

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added a comment. I would like to request that this commit be considered for merging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 ___ cfe-commits mailin

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit updated this revision to Diff 330570. atirit added a comment. Attempting to fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/U

[PATCH] D98622: [-Wcalled-once-parameter] Let escapes overwrite MaybeCalled states

vsavchenko created this revision. vsavchenko added a reviewer: NoQ. Herald added a subscriber: Charusso. vsavchenko requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit makes escapes symmetrical, meaning that having escape before and

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330573. kbobyrev marked an inline comment as done. kbobyrev added a comment. Herald added a project: clang-tools-extra. Add the variable to Features.inc.in and canonicalize. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

HazardyKnusperkeks added a comment. Please add a note to the release notes and also a test for a range based for with initializer (c++20). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429 __

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3669-3688 +bool lineContainsBreakingTokens = false; +const FormatToken *breakingSearchToken = &Right; +while ((breakingSearchToken = breakingSearchToken->Next)) { + bool hasBreakingCo

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3690-3691 +return (isAllowedByAfterEnum && isAllowedByShortEnums) || (Line.startsWith(tok::kw_class) && Style.BraceWrapping.AfterClass) || (Line.startsWith(tok::

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Let some time to others to have a look before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98214/new/ https://reviews.llvm.o

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

azabaznov added a comment. > Do you also get fatal error: 'opencl-c-base.h' file not found? If so, we > might need at least to file a clang bug that we should look at before the > next release. I'm able to reproduce it when not setting `-target` option explicitly: $ ./build_release/bin/c-ind

[PATCH] D98539: [OpenCL] Set target as spir for c-index-test for OpenCL

azabaznov added a comment. @Anastasia, thanks for landing this! Sorry for delay, I though that this can wait until Monday Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98539/new/ https://reviews.llvm.org/D98539 ___

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 330578. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamesp

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

CarolineConcatto added a comment. Hi @ bsmith, Thank you for adding me as a reviewer, although I don't think I am the more qualified to approve or not this patch. But I have a question: Why is this patch only changing int_aarch64_neon_frintn and not int_aarch64_sve_frintn? Is there a particula

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

lebedev.ri added a comment. I think the implicit question is: won't this regress headers that are meant to be compatible with earlier standards? Did the original review mention anything about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9756

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer added inline comments. Comment at: clang/test/CodeGen/arm_acle.c:908 +#if __ARM_64BIT_STATE && defined(__ARM_FEATURE_RNG) +// AArch64-v8_3-LABEL: @test_rndr( +// AArch64-v8_3-NEXT: entry: stelios-arm wrote: > SjoerdMeijer wrote: > > Not sure if I am

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm added inline comments. Comment at: clang/test/CodeGen/arm_acle.c:908 +#if __ARM_64BIT_STATE && defined(__ARM_FEATURE_RNG) +// AArch64-v8_3-LABEL: @test_rndr( +// AArch64-v8_3-NEXT: entry: SjoerdMeijer wrote: > stelios-arm wrote: > > SjoerdMeijer wrot

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:12 +if (ENABLE_GRPC_REFLECTION) + set(REFLECTION_LIBRARY grpc++_reflection) kadircet wrote: > kbobyrev wrote: > > kadircet wrote: > > > can we move this pie

[PATCH] D98548: [clang][Sema] Don't try to initialize implicit variable of invalid anonymous union/struct

tmatheson added a comment. This seems quite an early point to bail out, so it will prevent some errors/warnings associated with initialization from being emitted. For example, this warning is currently emitted but would be suppressed by this patch: union { virtual int a(); int b = 'c'

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S updated this revision to Diff 330588. Max_S added a comment. Changed the option to EmptyLineAfterAccessModifier and allowed the options Never, Leave and Always. Updated the tests accordingly and also added an entry in the changelog. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330589. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files: clang-to

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

Max_S added a comment. As already described in the update I changed the option name and how it behaves. It is now more in line with EmptyLineBeforeAccessModifier. I hope this was the correct way to push the rewrite, since all line remarks are now off. Comment at: clang/inclu

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

njames93 added a comment. In D97563#2625513 , @lebedev.ri wrote: > I think the implicit question is: won't this regress headers that are meant > to be compatible with earlier standards? > Did the original review mention anything about this? Clang-tidy al

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330592. kbobyrev added a comment. Include Features.inc in Server.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin added a comment. In D97563#2624680 , @njames93 wrote: > Is DAG required because the header file warnings are printed in a different > order depending on things like platform? @njames93 Thank you for review! Yes, on Windows build bot showed

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith added a comment. > Why is this patch only changing int_aarch64_neon_frintn and not > int_aarch64_sve_frintn? > Is there a particular reason to do so? Things are done slightly differently for SVE in this regard, in principal yes, we could emit roundeven instead of frintn from the ACLE int

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 330596. DmitryPolukhin added a comment. Rebase again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files: clang-tools-extra/clang-tidy/modernize/ConcatNested

[clang] 1974065 - [AST] Add generator for source location introspection

Author: Stephen Kelly Date: 2021-03-15T10:52:44Z New Revision: 19740652c4c4329e2b9e77f96e5e31c360b4e8bb URL: https://github.com/llvm/llvm-project/commit/19740652c4c4329e2b9e77f96e5e31c360b4e8bb DIFF: https://github.com/llvm/llvm-project/commit/19740652c4c4329e2b9e77f96e5e31c360b4e8bb.diff LOG:

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

luismarques added a comment. This makes sense to me but I'm not quite sure about the implications, especially when we consider compatibility. I think we need more eyes on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https:

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

paulwalker-arm added a comment. In D98487#2625673 , @bsmith wrote: >> Why is this patch only changing int_aarch64_neon_frintn and not >> int_aarch64_sve_frintn? >> Is there a particular reason to do so? > > Things are done slightly differently for SVE in

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

awarzynski added a comment. I tried reproducing the CI failures reported at the top (in particular `intrinsic_module_path.f90`), but haven't had much luck. @arnamoy10 - how about you? Could you `clang-format` this patch when uploading the next diff? Thank you! Comment at: fl

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

thopre added a comment. In D97125#2603832 , @thopre wrote: > Requesting review since the logic has changed. This time I've also tested > isfinite against glibc's result. All looks good. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

aaron.ballman added a comment. The attribute bits look fine to me aside from the documentation request. Comment at: clang/include/clang/Basic/Attr.td:738 let Args = [UnsignedArgument<"Count">, DefaultIntArgument<"Offset", 0>]; let Documentation = [PatchableFunctionEntryDo

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

dmgreen added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:476 - // intrinsic. - def int_aarch64_neon_frintn : AdvSIMD_1FloatArg_Intrinsic; - If you are removing the old intrinsic (which is great), then it will need some AutoUpgrade c

[PATCH] D97119: [flang][driver] Add options for -std=f2018

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:3535-3536 MarshallingInfoFlag>; -def pedantic : Flag<["-", "--"], "pedantic">, Group, Flags<[CC1Option]>, - MarshallingInfoFlag>; +def pedantic : Flag<["-", "--"], "pedantic">, Group, Flags<

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 330616. stelios-arm added a comment. Added tests in `arm_acle.c`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98264/new/ https://reviews.llvm.org/D98264 Files: clang/include/clang/Basic/BuiltinsAArch64.def clang/lib/Basic/Targets/AArch64.

[PATCH] D98134: [RFC][POC] Introduce callback argument encoding mode into callback metadata

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:432 If a statement is marked ``nomerge`` and contains call expressions, those call -expressions inside the statement will not be merged during optimization. This +expressions inside the state

[PATCH] D98521: [clang-tidy] Fix readability-identifer-naming duplicating prefix or suffix for replacements.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Good catch, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98521/new/ https://reviews.llvm.org/D98521 __

[PATCH] D93164: [AST] Add generator for source location introspection

thakis added a comment. ast-dump-tool is still somewhere in lib/ instead of in tools/ in the reland as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 ___

[clang] c0cd527 - [ast-dump-tool] fix regression if --empty-implementation but --json-input-path is not

Author: Nico Weber Date: 2021-03-15T08:48:26-04:00 New Revision: c0cd5274ccdbe57edb20b0375b73a75c70a48882 URL: https://github.com/llvm/llvm-project/commit/c0cd5274ccdbe57edb20b0375b73a75c70a48882 DIFF: https://github.com/llvm/llvm-project/commit/c0cd5274ccdbe57edb20b0375b73a75c70a48882.diff LO

[PATCH] D98295: [Clang] Add addrsig attribute to mark global functions/variables as address significant.

aaron.ballman added a comment. I'm not opposed to the attribute per se, but I'd like to understand the motivation behind it a bit more. It seems like it solves a special edge case for a specific linker and I'm wondering if that's sufficient motivation for the community to support the attribute

[PATCH] D97717: [SYCL] Rework the SYCL driver options

jansvoboda11 requested changes to this revision. jansvoboda11 added a comment. This revision now requires changes to proceed. I like the simplification of the command line interface. I have concerns about changing the tests just to make them pass though. Comment at: clang/unit

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith updated this revision to Diff 330629. bsmith added a comment. Herald added a subscriber: dexonsmith. - Add AutoUpgrade code to convert aarch64.neon.frintn to roundeven - Add test for above AutoUpgrade Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D98416: [clang-tidy] Fix cppcoreguidelines-narrowing-conversions false positive

aaron.ballman added a comment. Herald added a project: clang-tools-extra. > However this has opened a can of worms. Currenty float a = > std::numeric_limits::infinity(); is marked as narrowing. I think this is technically not narrowing, per http://eel.is/c++draft/dcl.init.list#7.2, because the

[clang] 6badd3c - [ASTMatchers] Fix documentation for hasAnyBody matcher

Author: Nathan James Date: 2021-03-15T13:06:49Z New Revision: 6badd3c52dc8a9c0a253a48722c569bfea4f URL: https://github.com/llvm/llvm-project/commit/6badd3c52dc8a9c0a253a48722c569bfea4f DIFF: https://github.com/llvm/llvm-project/commit/6badd3c52dc8a9c0a253a48722c569bfea4f.diff LOG:

[PATCH] D98583: [ASTMatchers] Fix documentation for hasAnyBody matcher

This revision was automatically updated to reflect the committed changes. Closed by commit rG6badd3c52dc8: [ASTMatchers] Fix documentation for hasAnyBody matcher (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98583/new/ https:

[clang] ff91206 - [ASTMatchers][Dynamic] Add missing matchers from Registry

Author: Nathan James Date: 2021-03-15T13:07:39Z New Revision: ff9120636e9c890b4db735d252d16b92091dde55 URL: https://github.com/llvm/llvm-project/commit/ff9120636e9c890b4db735d252d16b92091dde55 DIFF: https://github.com/llvm/llvm-project/commit/ff9120636e9c890b4db735d252d16b92091dde55.diff LOG:

[PATCH] D98556: [ASTMatchers][Dynamic] Add missing matchers from Registry

This revision was automatically updated to reflect the committed changes. Closed by commit rGff9120636e9c: [ASTMatchers][Dynamic] Add missing matchers from Registry (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98556/new/ htt

[PATCH] D98030: [IR] Add vscale_range IR function attribute

paulwalker-arm added inline comments. Comment at: clang/test/CodeGen/arm-sve-vector-bits-vscale-range.c:10-14 +// CHECK-128: attributes #0 = { {{.*}} vscale_range(1,1) {{.*}} } +// CHECK-256: attributes #0 = { {{.*}} vscale_range(2,2) {{.*}} } +// CHECK-512: attributes #0 = { {{.

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Thanks, nice one, LGTM. Comment at: llvm/test/CodeGen/AArch64/rand.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

kito-cheng added a comment. GCC use `vr` for vector register and `vm` for vector mask register. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98616/new/ https://reviews.llvm.org/D98616 ___ cfe-commits ma

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

jrtc27 added a comment. In D98616#2626093 , @kito-cheng wrote: > GCC use `vr` for vector register and `vm` for vector mask register. How does that even work? Aren't multi character strings a set of options? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

dmgreen added a comment. Thanks. This looks sensible, from what I can tell. Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:158 ]>; +def SDTFPRoundEvenOp : SDTypeProfile<1, 1, [ // froundeven + SDTCisFP<0>, SDTCisFP<1>, SDTCisOpSmallerThanOp<0, 1>, SDTCisSameNu

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

jrtc27 added a comment. In D98616#2626094 , @jrtc27 wrote: > In D98616#2626093 , @kito-cheng > wrote: > >> GCC use `vr` for vector register and `vm` for vector mask register. > > How does that even work? Aren't mul

[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

jansvoboda11 added inline comments. Comment at: clang/lib/Lex/LiteralSupport.cpp:1639 const char *Prefix = ThisTokBuf; - while (ThisTokBuf[0] != '(') + while (ThisTokBuf - Prefix < 16 && ThisTokBuf[0] != '(') ++ThisTokBuf; beccadax wrote

[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

jansvoboda11 updated this revision to Diff 330647. jansvoboda11 added a comment. Implement suggested improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94950/new/ https://reviews.llvm.org/D94950 Files: clang/lib/Lex/LiteralSupport.cpp

[PATCH] D94950: [clang][lex] Speculative fix for buffer overrun on raw string parse

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG23cc8ebf59c6: [clang][lex] Speculative fix for buffer overrun on raw string parse (authored by jansvoboda11). Changed prior to commit: https://rev

[clang] 23cc8eb - [clang][lex] Speculative fix for buffer overrun on raw string parse

Author: Jan Svoboda Date: 2021-03-15T15:13:47+01:00 New Revision: 23cc8ebf59c661ebb988370a0edbcda37b61080a URL: https://github.com/llvm/llvm-project/commit/23cc8ebf59c661ebb988370a0edbcda37b61080a DIFF: https://github.com/llvm/llvm-project/commit/23cc8ebf59c661ebb988370a0edbcda37b61080a.diff L

[clang] 74c270f - [ASTMatchers] Don't forward matchers in MapAnyOf

Author: Nathan James Date: 2021-03-15T14:16:52Z New Revision: 74c270f33eb16d336b4ab834e18b27f8efcbabe8 URL: https://github.com/llvm/llvm-project/commit/74c270f33eb16d336b4ab834e18b27f8efcbabe8 DIFF: https://github.com/llvm/llvm-project/commit/74c270f33eb16d336b4ab834e18b27f8efcbabe8.diff LOG:

[PATCH] D98497: [ASTMatchers] Don't forward matchers in MapAnyOf

This revision was automatically updated to reflect the committed changes. Closed by commit rG74c270f33eb1: [ASTMatchers] Don't forward matchers in MapAnyOf (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98497/new/ https://revi

[clang-tools-extra] 0333dde - [clang-tidy] Fix readability-identifer-naming duplicating prefix or suffix for replacements.

Author: Nathan James Date: 2021-03-15T14:20:48Z New Revision: 0333dde923c42219863f314d6c9fc0dcd352ef02 URL: https://github.com/llvm/llvm-project/commit/0333dde923c42219863f314d6c9fc0dcd352ef02 DIFF: https://github.com/llvm/llvm-project/commit/0333dde923c42219863f314d6c9fc0dcd352ef02.diff LOG:

[PATCH] D98521: [clang-tidy] Fix readability-identifer-naming duplicating prefix or suffix for replacements.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0333dde923c4: [clang-tidy] Fix readability-identifer-naming duplicating prefix or suffix for… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang-tools-extra] da55af7 - [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

Author: Dmitry Polukhin Date: 2021-03-15T07:32:45-07:00 New Revision: da55af7f1d348c133774d8e8117d60462363fef5 URL: https://github.com/llvm/llvm-project/commit/da55af7f1d348c133774d8e8117d60462363fef5 DIFF: https://github.com/llvm/llvm-project/commit/da55af7f1d348c133774d8e8117d60462363fef5.dif

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGda55af7f1d34: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D98616: [RISCV] Add inline asm constraint 'v' in Clang for RISC-V 'V'.

kito-cheng added a comment. Provide more implementation detail on GCC, - if a letter are used as a prefix of multi-char constraint, then it can't be used as a single letter constraint - e.g. If we defined `vr` and `vm` then we can't define `v` as constraint - constraint with same prefix should

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

atirit added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3683 +Style.BraceWrapping.AfterEnum; +bool isLineTooBig = (strlen(Right.TokenText.data()) + + Right.OriginalColumn) > Style.ColumnLimit; curdeius wro

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 330670. stelios-arm added a comment. Change the `rand.ll` llc arguments to the ones that are only relevant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98264/new/ https://reviews.llvm.org/D98264 Files: clang/include/clang/Basic/BuiltinsAAr

[PATCH] D98404: [clangd] Optionally add reflection for clangd-index-server

kbobyrev updated this revision to Diff 330675. kbobyrev added a comment. Add explicit CMake option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98404/new/ https://reviews.llvm.org/D98404 Files: clang-tools-extra/clangd/CMakeLists.txt clang-t

[PATCH] D98487: [AArch64][SVE/NEON] Add support for FROUNDEVEN for both NEON and fixed length SVE

bsmith added inline comments. Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:158 ]>; +def SDTFPRoundEvenOp : SDTypeProfile<1, 1, [ // froundeven + SDTCisFP<0>, SDTCisFP<1>, SDTCisOpSmallerThanOp<0, 1>, SDTCisSameNumEltsAs<0, 1> dmgreen wrote: >

[clang] f60b353 - Stop traping on sNaN in __builtin_isinf

Author: Thomas Preud'homme Date: 2021-03-15T15:38:08Z New Revision: f60b35340fd70acb3c8003349931f085305886ad URL: https://github.com/llvm/llvm-project/commit/f60b35340fd70acb3c8003349931f085305886ad DIFF: https://github.com/llvm/llvm-project/commit/f60b35340fd70acb3c8003349931f085305886ad.diff

[PATCH] D97125: Stop traping on sNaN in __builtin_isinf

This revision was automatically updated to reflect the committed changes. Closed by commit rGf60b35340fd7: Stop traping on sNaN in __builtin_isinf (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97125/new/ https://reviews.llvm.or

[PATCH] D98246: [clangd] Add basic monitoring info request for remote index server

kbobyrev updated this revision to Diff 330681. kbobyrev marked 6 inline comments as done. kbobyrev added a comment. Herald added a project: clang-tools-extra. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98246/new/ https:/

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not handlings SourceRange highlights

whisperity created this revision. whisperity added reviewers: aaron.ballman, njames93. whisperity added projects: clang, clang-tools-extra. Herald added subscribers: martong, gamesh411, Szelethus, dkrupp, rnkovacs, xazax.hun. whisperity requested review of this revision. Herald added a subscriber:

[clang] 33b1f3f - [clang][patch] Solve PR49479, File scope fp pragma should propagate to functions nested in struct, and initialization expressions

Author: Melanie Blower Date: 2021-03-15T12:15:20-04:00 New Revision: 33b1f3f42cb9fc4fed9501ed49e4805f134e7a1b URL: https://github.com/llvm/llvm-project/commit/33b1f3f42cb9fc4fed9501ed49e4805f134e7a1b DIFF: https://github.com/llvm/llvm-project/commit/33b1f3f42cb9fc4fed9501ed49e4805f134e7a1b.diff

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not handlings SourceRange highlights

whisperity updated this revision to Diff 330687. whisperity added a comment. **NFC** I originally wrote a Release Notes entry about this, which I forgot to commit before I generated the patch file I uploaded, this is fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98211: Solve PR49479, File scope fp pragma should propagate to functions nested in struct, and initialization expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG33b1f3f42cb9: [clang][patch] Solve PR49479, File scope fp pragma should propagate to… (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98

[PATCH] D97785: [SystemZ][z/OS] Distinguish between text and binary files on z/OS

zibi added a comment. LGTM, I just wonder if we can make an extra parameter to be default. I notice some places that is a default parameter but not in all instances. With default parameter some of the calls might be simplified if there is no need to override it. Comment at:

[PATCH] D98030: [IR] Add vscale_range IR function attribute

bsmith updated this revision to Diff 330691. bsmith marked 3 inline comments as done. bsmith added a comment. - Prevent vscale_range(0,0) from crashing and instead don't add the attribute - Improve CHECK lines in arm-sve-vector-bits-vscale-range.c test - Test vscale_range(0,0) case and move some t

[PATCH] D98433: [clang] [C++2b] [P1102] Accept lambdas without parameter list ().

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1438 -// Parse trailing-return-type[opt]. -if (Tok.is(tok::arrow)) { - FunLocalRangeEnd = Tok.getLocation(); - SourceRange Range; - TrailingReturnType = - ParseTrai

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 330694. stelios-arm added a comment. Typo fix for `__ARM_FEATURE_RNG` macro check in `aarch64-target-features.c`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98264/new/ https://reviews.llvm.org/D98264 Files: clang/include/clang/Basic/Builti

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

aaron.ballman added a comment. Thank you for looking into this! It looks like there are some unit test failures from the change: https://buildkite.com/llvm-project/premerge-checks/builds/29754#a9b04ab5-e326-4ff1-beea-773f21a33349 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

jdoerfert resigned from this revision. jdoerfert added a comment. I see the need for this to work, unsure if this is the right way, we need to make progress though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96769/new/ https://reviews.llvm.org/

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

whisperity added a comment. In D98635#2626455 , @aaron.ballman wrote: > It looks like there are some unit test failures from the change: > https://buildkite.com/llvm-project/premerge-checks/builds/29754#a9b04ab5-e326-4ff1-beea-773f21a33349 Strange becau

[PATCH] D98610: [RISCV] Support clang -fpatchable-function-entry && GNU function attribute 'patchable_function_entry'

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/patchable-function-entry.ll:1-3 +;; Test the function attribute "patchable-function-entry". +; RUN: llc -mtriple=riscv32 < %s | FileCheck %s --check-prefixes=CHECK,32 +; RUN: llc -mtriple=riscv64 < %s | FileCheck %

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3579 +SectionCBVector.push_back(SectionCB); + } +} else { jdoerfert wrote: > Why do we unpack the children here instead of making a single call back for > the Captur

[clang] 3997076 - [CMake] Require python 3.6 if enabling LLVM test targets

Author: Christopher Tetreault Date: 2021-03-15T09:50:39-07:00 New Revision: 39970764af39415ad62136ff75b0f89577c18037 URL: https://github.com/llvm/llvm-project/commit/39970764af39415ad62136ff75b0f89577c18037 DIFF: https://github.com/llvm/llvm-project/commit/39970764af39415ad62136ff75b0f89577c180

[PATCH] D95635: [CMake] Require python 3.6 if enabling LLVM test targets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39970764af39: [CMake] Require python 3.6 if enabling LLVM test targets (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia updated this revision to Diff 330698. Anastasia added a comment. Updated Driver test to check -x option. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96771/new/ https://reviews.llvm.org/D96771 Files: clang/include/clang/Basic/LangStandard.h clang/include/clang/Driver/Typ

[PATCH] D98635: [libtooling][clang-tidy] Fix diagnostics not respecting and highlighting fed SourceRanges

whisperity added a comment. In D98635#2626464 , @whisperity wrote: > Strange because I specifically ran both `check-clang` **and** > `check-clang-tools` locally, but will look into this. Turns out there is a `check-clang-extra-unit` too, and it looks lik

[PATCH] D98499: [clangd] Introduce ASTHooks to FeatureModules

sammccall added a comment. Herald added a project: clang-tools-extra. I'm getting a little nervous about the amount of stuff we're packing into modules without in-tree examples. I should split out some of the "standard" features into modules as that's possible already. My model for modules usin

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. I had a second thought about the extension name and I realized that the reason why I initially wanted to use `clcpp` is that it aligns better with `clc++` which is used in `-cl-std`. Even though from the RFC the preference was towards `cppcl` it felt like there was no

[PATCH] D98505: [clangd] Propagate data in diagnostics

sammccall added inline comments. Herald added a project: clang-tools-extra. Comment at: clang-tools-extra/clangd/Diagnostics.h:58 + /// If true, Clangd will populate the data field in LSP diagnostic + /// representation. This is used to prevent extra data transfer with old + /

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Agreed. Lack of save temps is causing grief when debugging, so I keep on applying this patch locally. Let's go with this for now. and change to something better when we think

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 330711. arnamoy10 added a comment. Clang-formatting and addressing reviewers' comments: Moved the default directory append to `setFortranOpts()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 Files: cl

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added a comment. This has been merged, closing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D96875: [flang][driver] Add -fdebug-module-writer option

arnamoy10 added a comment. Abandon CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96875/new/ https://reviews.llvm.org/D96875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

ronlieb accepted this revision. ronlieb added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96769/new/ https://reviews.llvm.org/D96769 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D98411: [OpenCL] Respect calling convention for builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rGfcfd3fda7190: [OpenCL] Respect calling convention for builtin (authored by ldrumm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98411/new/ https://reviews

[clang] 9628cb1 - [NFC] Use higher level constructs to check for whitespace/newlines in the lexer

Author: serge-sans-paille Date: 2021-03-15T18:27:19+01:00 New Revision: 9628cb1feef63d764c57fd0652016f9188000e2f URL: https://github.com/llvm/llvm-project/commit/9628cb1feef63d764c57fd0652016f9188000e2f DIFF: https://github.com/llvm/llvm-project/commit/9628cb1feef63d764c57fd0652016f9188000e2f.d

[PATCH] D98637: [NFC] Use higher level constructs to check for whitespace/newlines in the lexer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9628cb1feef6: [NFC] Use higher level constructs to check for whitespace/newlines in the lexer (authored by serge-sans-paille). Herald added a project

[clang] 4aa510b - Allow __ieee128 as an alias to __float128 on ppc

Author: serge-sans-paille Date: 2021-03-15T18:28:26+01:00 New Revision: 4aa510be78a75a4da82657fe433016f00dad0784 URL: https://github.com/llvm/llvm-project/commit/4aa510be78a75a4da82657fe433016f00dad0784 DIFF: https://github.com/llvm/llvm-project/commit/4aa510be78a75a4da82657fe433016f00dad0784.d

  1   2   >