CarolineConcatto added a comment. Hi @ bsmith,
Thank you for adding me as a reviewer, although I don't think I am the more qualified to approve or not this patch. But I have a question: Why is this patch only changing int_aarch64_neon_frintn and not int_aarch64_sve_frintn? Is there a particular reason to do so? As you said in the commit message the ISD node for FROUNDEVEN exists now. If so it would be too much to explain that in the commit message? Thank you, Carol Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98487/new/ https://reviews.llvm.org/D98487 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
