[PATCH] D95782: [Syntax] Support condition for IfStmt.

hokein added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:803 + bool TraverseIfStmt(IfStmt *S) { +bool Result = [&, this]() { sammccall wrote: > is it clear to you what all this code is doing? > It does seem to fit the pattern used e

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321334. kbobyrev marked 5 inline comments as done and an inline comment as not done. kbobyrev added a comment. Fix a couple problems pointed out during the review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:334 + DynTypedNodeList Parents(DynTypedNode::create(RenamedDecl)); + auto GetSingleParent = [&](DynTypedNode Node) -> const DynTypedNode * { +Parents = Ctx.getParents(Node); ---

[clang] 6c1a233 - [Syntax] Support condition for IfStmt.

Author: Haojian Wu Date: 2021-02-04T09:15:30+01:00 New Revision: 6c1a23303de9d957cf45ebd04daba862519e393d URL: https://github.com/llvm/llvm-project/commit/6c1a23303de9d957cf45ebd04daba862519e393d DIFF: https://github.com/llvm/llvm-project/commit/6c1a23303de9d957cf45ebd04daba862519e393d.diff LO

[PATCH] D95782: [Syntax] Support condition for IfStmt.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c1a23303de9: [Syntax] Support condition for IfStmt. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

kbobyrev updated this revision to Diff 321336. kbobyrev marked an inline comment as done. kbobyrev added a comment. Pass const ref to DynTypedNode in helper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Looks good, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95925/new/ https://reviews.llvm.org/D95925 __

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:411 + if (const auto *EnclosingFor = Parent->get()) +return CheckCompoundStmt(EnclosingFor->getBody(), NewName); + another case we could add is FunctionDecl, if we rename

[clang-tools-extra] 5eec9a3 - [clangd] Detect rename conflicits within enclosing scope

Author: Kirill Bobyrev Date: 2021-02-04T09:45:42+01:00 New Revision: 5eec9a380a24bf0611c676b5da4933949c787a6b URL: https://github.com/llvm/llvm-project/commit/5eec9a380a24bf0611c676b5da4933949c787a6b DIFF: https://github.com/llvm/llvm-project/commit/5eec9a380a24bf0611c676b5da4933949c787a6b.diff

[PATCH] D95925: [clangd] Detect rename conflicits within enclosing scope

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eec9a380a24: [clangd] Detect rename conflicits within enclosing scope (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG225ccf0c50a8: [clang][cli] Command line round-trip for HeaderSearch options (authored by jansvoboda11). Changed prior to commit: https://reviews.l

[clang] 225ccf0 - [clang][cli] Command line round-trip for HeaderSearch options

Author: Jan Svoboda Date: 2021-02-04T10:18:34+01:00 New Revision: 225ccf0c50a8d4e03b51f2f09a8e8776328363d8 URL: https://github.com/llvm/llvm-project/commit/225ccf0c50a8d4e03b51f2f09a8e8776328363d8 DIFF: https://github.com/llvm/llvm-project/commit/225ccf0c50a8d4e03b51f2f09a8e8776328363d8.diff L

[clang] 6625680 - [clang-cl] Remove the /fallback option

Author: Hans Wennborg Date: 2021-02-04T10:33:16+01:00 New Revision: 6625680a581c5e29c53d9f58d864cc6cd3cd05f6 URL: https://github.com/llvm/llvm-project/commit/6625680a581c5e29c53d9f58d864cc6cd3cd05f6 DIFF: https://github.com/llvm/llvm-project/commit/6625680a581c5e29c53d9f58d864cc6cd3cd05f6.diff

[PATCH] D95876: [clang-cl] Remove the /fallback option

This revision was automatically updated to reflect the committed changes. Closed by commit rG6625680a581c: [clang-cl] Remove the /fallback option (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95876/new/ https://reviews.llvm.org/D

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

azabaznov updated this revision to Diff 321348. azabaznov added a comment. Renamed language options and adjusted comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 Files: clang/include/clang/Basic/L

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

tbaeder updated this revision to Diff 321349. tbaeder added a comment. Here a version without the local static bools. If this is good to go, I can add some tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 Files: clang/include/clang/Driv

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 ___

[PATCH] D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang

ostannard created this revision. ostannard added reviewers: serge-sans-paille, jnspaulsson, bzEq, tnfchris. Herald added subscribers: danielkiss, kristof.beyls. ostannard requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows the -fsta

[PATCH] D95778: [OpenCL] Introduce new language options for OpenCL keywords.

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95778/new/ https://reviews.llvm.org/D95778 ___ cfe-commits mailing list cfe-commits

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:433 PreambleSymbols.update( -Uri, std::make_unique(std::move(*IF->Symbols)), +FilePath ? *FilePath : (consumeError(FilePath.takeError()), Uri), +std::make_unique(s

[PATCH] D96009: [clangd] Improve name conflict detection

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Follow-up on D95925

[PATCH] D95886: [OpenCL][Docs] Link page explaining tooling for offline compilation

Anastasia updated this revision to Diff 321369. Anastasia added a comment. Addressed Sven's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95886/new/ https://reviews.llvm.org/D95886 Files: clang/docs/UsersManual.rst Index: clang/docs/UsersManual.rst ===

[PATCH] D95886: [OpenCL][Docs] Link page explaining tooling for offline compilation

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95886/new/ https://reviews.llvm.org/D95886 ___ cfe-commits mailing list cfe-co

[PATCH] D95976: [OpenMP] Simplify offloading parallel call codegen

ggeorgakoudis updated this revision to Diff 321375. ggeorgakoudis added a comment. Fix type for IfCond, formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95976/new/ https://reviews.llvm.org/D95976 Files: clang/lib/CodeGen/CGOpenMPRuntimeG

[clang] 4874ff0 - Revert "[hip][cuda] Enable extended lambda support on Windows."

Author: Nico Weber Date: 2021-02-04T07:10:46-05:00 New Revision: 4874ff02417916cc9ff994b34abcb5e563056546 URL: https://github.com/llvm/llvm-project/commit/4874ff02417916cc9ff994b34abcb5e563056546 DIFF: https://github.com/llvm/llvm-project/commit/4874ff02417916cc9ff994b34abcb5e563056546.diff LO

[clang] 3a1513c - [flang][driver] Add forced form flags and -ffixed-line-length

Author: Faris Rehman Date: 2021-02-04T12:24:15Z New Revision: 3a1513c142f4a1ddb97d882a12c89f90cb2529ac URL: https://github.com/llvm/llvm-project/commit/3a1513c142f4a1ddb97d882a12c89f90cb2529ac DIFF: https://github.com/llvm/llvm-project/commit/3a1513c142f4a1ddb97d882a12c89f90cb2529ac.diff LOG:

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a1513c142f4: [flang][driver] Add forced form flags and -ffixed-line-length (authored by FarisRehman). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D95860: [clang][Frontend] Fix a crash in DiagnosticRenderer.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. In D95860#2539453 , @balazske wrote: > Probably it is not worth to find a better solution. In the case of > CloneChecker the range starts and ends

[PATCH] D96016: Release notes: Deprecate the clang-cl /fallback flag (patch for the release/12.x branch)

hans created this revision. hans added a reviewer: tstellar. hans requested review of this revision. Herald added a project: clang. As discussed in https://lists.llvm.org/pipermail/cfe-dev/2021-January/067524.html The flag has been removed on the main branch in D95876

[PATCH] D96009: [clangd] Improve name conflict detection

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:343 const auto *Parent = GetSingleParent(DynTypedNode::create(RenamedDecl)); - if (!Parent || !Parent->ge

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

thakis added a comment. Hi, a whole bunch of cuda-related tests failed on windows with this in (http://45.33.8.238/win/32620/summary.html). Did you run check-clang before committing? I reverted this for now in 4874ff02417916cc9ff994b34abcb5e563056546

[clang] 62e4f22 - [clang] Add AddClang.cmake to the list of the CMake modules that are installed

Author: Andrzej Warzynski Date: 2021-02-04T12:38:38Z New Revision: 62e4f22e297ade62fd1e463e7c846df96148ffc4 URL: https://github.com/llvm/llvm-project/commit/62e4f22e297ade62fd1e463e7c846df96148ffc4 DIFF: https://github.com/llvm/llvm-project/commit/62e4f22e297ade62fd1e463e7c846df96148ffc4.diff

[PATCH] D94533: [clang] Add AddClang.cmake to the list of the CMake modules that are installed

This revision was automatically updated to reflect the committed changes. Closed by commit rG62e4f22e297a: [clang] Add AddClang.cmake to the list of the CMake modules that are installed (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 321385. azabaznov added a comment. Features remain defined in header for OpenCL C 2.0; adjusted the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files: clan

[PATCH] D96017: [clang-check] Add tokens-dump in clang-check.

hokein created this revision. hokein added a reviewer: kbobyrev. hokein requested review of this revision. Herald added a project: clang. It is useful for syntax-tree developement. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96017 Files: clang/tools/clang-check/ClangCheck

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry, forgot to stamp this! Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:419 CollectMainFileRefs(CollectMainFileRefs), + PreambleSymbols(IndexC

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/features.cl:1 +// RUN: %clang_cc1 -triple spir-unknown-unknown -finclude-default-header %s -E -dM -o - -x cl -cl-std=CL2.0 -cl-ext=-all \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=FEATURES -

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman added inline comments. Comment at: clang/test/Sema/reserved-identifier.c:49-50 +// FIXME: According to clang declaration context layering, _preserved belongs to +// the translation unit, so we emit a warning. It's unclear that's what the +// standard mandate, but i

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi updated this revision to Diff 321392. Budovi added a comment. Changes: - Added release notes - Changed the documentation (tried to make it more clear in response to the confusion about the added option) Hopefully there is a full context in the patch this time. CHANGES SINCE LAST ACTION

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

Budovi added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IndentAccessModifiers** (``bool``) + Makes an indentation level for record (``class``, ``struct``, ``union``) Budovi wrote: > curdeius wrote: > > curdeius wrote: > > > The

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov added inline comments. Comment at: clang/test/SemaOpenCL/features.cl:1 +// RUN: %clang_cc1 -triple spir-unknown-unknown -finclude-default-header %s -E -dM -o - -x cl -cl-std=CL2.0 -cl-ext=-all \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=FEATURES -

[PATCH] D96009: [clangd] Improve name conflict detection

kbobyrev updated this revision to Diff 321398. kbobyrev marked an inline comment as done. kbobyrev added a comment. Use FunctionProtoTypeLoc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96009/new/ https://reviews.llvm.org/D96009 Files: clang-to

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/features.cl:1 +// RUN: %clang_cc1 -triple spir-unknown-unknown -finclude-default-header %s -E -dM -o - -x cl -cl-std=CL2.0 -cl-ext=-all \ +// RUN: | FileCheck -match-full-lines %s --check-prefix=FEATURES -

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

ASDenysPetrov added a comment. Herald added a subscriber: nullptr.cpp. Hi, folk! Please, review this tiny patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95799/new/ https://reviews.llvm.org/D95799 _

[clang] 0c65993 - [OpenCL] Fix default address space in template argument deduction.

Author: Anastasia Stulova Date: 2021-02-04T13:51:53Z New Revision: 0c65993be186640463ac90415113474d35889dbb URL: https://github.com/llvm/llvm-project/commit/0c65993be186640463ac90415113474d35889dbb DIFF: https://github.com/llvm/llvm-project/commit/0c65993be186640463ac90415113474d35889dbb.diff

[PATCH] D95624: [OpenCL][PR48896] Fix default address space in template argument deduction

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c65993be186: [OpenCL] Fix default address space in template argument deduction. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0fb4341 - [OpenCL][Docs] Link page explaining tooling for offline compilation.

Author: Anastasia Stulova Date: 2021-02-04T14:01:27Z New Revision: 0fb4341519ef3ac06518ba56bb100277d89cdf11 URL: https://github.com/llvm/llvm-project/commit/0fb4341519ef3ac06518ba56bb100277d89cdf11 DIFF: https://github.com/llvm/llvm-project/commit/0fb4341519ef3ac06518ba56bb100277d89cdf11.diff

[PATCH] D95886: [OpenCL][Docs] Link page explaining tooling for offline compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fb4341519ef: [OpenCL][Docs] Link page explaining tooling for offline compilation. (authored by Anastasia). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96027: [clangd] Trace queue state for each TUScheduler action.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, javed.absar. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The new trace event includes

[PATCH] D96032: [flang][driver] Add support for -fopenmp and -fopenacc

FarisRehman created this revision. Herald added subscribers: dang, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added a reviewer: jansvoboda11. FarisRehman requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscr

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. Core LLVM parts LGTM, thanks! I'm going to mark this as accepted, given that the other parts have been reviewed earlier already Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev created this revision. v.g.vassilev added reviewers: rsmith, lhames, rjmccall, teemperor, aprantl. Herald added a subscriber: mgorny. v.g.vassilev requested review of this revision. In http://lists.llvm.org/pipermail/llvm-dev/2020-July/143257.html we have mentioned our plans to make

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. We're getting close :). Comment at: clang/unittests/Format/FormatTest.cpp:19056 +TEST_F(FormatTest, IndentAccessModifiers) { + FormatStyle Style = getLLVMStyle

[PATCH] D94661: [clang-format] [PR19056] Add support for access modifiers indentation

curdeius added a comment. Don't forget to mark comments as Done when... they're done :). Comment at: clang/docs/ClangFormatStyleOptions.rst:2039 +**IndentAccessModifiers** (``bool``) + Makes an indentation level for record (``class``, ``struct``, ``union``)

[PATCH] D96016: Release notes: Deprecate the clang-cl /fallback flag (patch for the release/12.x branch)

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. Yes, go ahead and push this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96016/new/ https://reviews.llvm.org/D96016 _

[PATCH] D96036: [clang][codegen] Remember string used to create llvm::Regex for optimization remarks

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Regular expression patterns passed through the command line are being used to create an i

[PATCH] D95776: [OpenCL] Add macro definitions of OpenCL C 3.0 features

azabaznov updated this revision to Diff 321425. azabaznov added a comment. Adjusted test one more time: moved header functionality into separate test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95776/new/ https://reviews.llvm.org/D95776 Files:

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

yaxunl added a comment. LGTM. It also avoid redundant check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[PATCH] D96043: Treat opencl_unroll_hint subject errors as semantic rather than parse errors

aaron.ballman created this revision. aaron.ballman added a reviewer: Anastasia. Herald added subscribers: zzheng, yaxunl. aaron.ballman requested review of this revision. Herald added a project: clang. While working on a downstream project, I noticed some issues with the `opencl_unroll_hint` impl

[PATCH] D96044: DebugInfo: Emit "LocalToUnit" flag on local member function decls.

jyknight created this revision. jyknight added a reviewer: dblaikie. Herald added a subscriber: inglorion. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, the definition was so-marked, but the declaration was not. This

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX updated this revision to Diff 321442. ArcsinX added a comment. - Remove default value of `IdxContents` in `FileSymbols` constructor. - Fix index contents for the preamble index (Symbols => Symbols|Relations). - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D94952: [clangd] Take into account what is in the index (symbols, references, etc.) at indexes merge

ArcsinX marked 3 inline comments as done. ArcsinX added a comment. Thank you for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94952/new/ https://reviews.llvm.org/D94952 ___ cfe-commits mailing l

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

jdoerfert added a comment. Test still missing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95915/new/ https://reviews.llvm.org/D95915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] a83475d - [Hexagon] Add -mv68 option to driver

Author: Krzysztof Parzyszek Date: 2021-02-04T10:29:34-06:00 New Revision: a83475d34b4550ff5bd40430d6537e630eb761f1 URL: https://github.com/llvm/llvm-project/commit/a83475d34b4550ff5bd40430d6537e630eb761f1 DIFF: https://github.com/llvm/llvm-project/commit/a83475d34b4550ff5bd40430d6537e630eb761f1

[clang] 985a42f - [flang][driver] Add support for `-J/-module-dir`

Author: Arnamoy Bhattacharyya Date: 2021-02-04T16:31:40Z New Revision: 985a42fdf8ae3117442ea129b684569fa6942a71 URL: https://github.com/llvm/llvm-project/commit/985a42fdf8ae3117442ea129b684569fa6942a71 DIFF: https://github.com/llvm/llvm-project/commit/985a42fdf8ae3117442ea129b684569fa6942a71.di

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

This revision was automatically updated to reflect the committed changes. Closed by commit rG985a42fdf8ae: [flang][driver] Add support for `-J/-module-dir` (authored by arnamoy10, committed by awarzynski). Changed prior to commit: https://reviews.llvm.org/D95448?vs=320617&id=321448#toc Reposit

[clang] 1d51c69 - [clang][Arm] Fix handling of -Wa,-march=

Author: David Spickett Date: 2021-02-04T16:36:15Z New Revision: 1d51c699b9e2ebc5bcfdbe85c74cc871426333d4 URL: https://github.com/llvm/llvm-project/commit/1d51c699b9e2ebc5bcfdbe85c74cc871426333d4 DIFF: https://github.com/llvm/llvm-project/commit/1d51c699b9e2ebc5bcfdbe85c74cc871426333d4.diff LOG

[PATCH] D95872: [clang][Arm] Fix handling of -Wa,-march=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. DavidSpickett marked an inline comment as done. Closed by commit rG1d51c699b9e2: [clang][Arm] Fix handling of -Wa,-march= (authored by DavidSpickett). Repository: rG

[PATCH] D96049: [Timer] On macOS count number of executed instructions

ahoppen created this revision. Herald added subscribers: dexonsmith, hiraditya, mgorny. ahoppen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In addition to wall time etc. this should allow us to get less noisy values fo

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 321451. poelmanc added a comment. Herald added a subscriber: nullptr.cpp. Change loop end condition in `findLineEnd` and add several `assert` statements. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68682/new/ https://reviews.llvm.org/D68682 File

[PATCH] D95915: [clang][driver] Only warn once about invalid -stdlib value

Hahnfeld added inline comments. Comment at: clang/include/clang/Driver/ToolChain.h:169-177 + mutable bool isCXXStdlibTypeCached; + mutable CXXStdlibType cxxStdlibType; + + mutable bool isRuntimeLibTypeCached; + mutable RuntimeLibType runtimeLibType; + + mutable bool isUnwind

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

teemperor added a comment. A more general comment: You have to `std::move` your `llvm::Error` variables when the result is `llvm::Expected` (otherwise this won't compile). Comment at: clang/include/clang/Interpreter/Transaction.h:1 +//===--- Transaction.h - Incremental Compila

[PATCH] D96050: [OpenCL] Do not enforce ASTContext for OCL2Qual

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Do not enforce that the expression to obtain the `QualType` for an OpenCL type s

[PATCH] D96051: [OpenCL] Support enum and typedef args in TableGen BIFs

svenvh created this revision. svenvh added a reviewer: Anastasia. svenvh added a project: clang. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. Add enum and typedef argument support to `-fdeclare-opencl-builtins`, which was

[PATCH] D96052: [clang] add new unwind inline asm clobber which lowers to throwable inline assembly

cynecx created this revision. cynecx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96052 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp clang/lib/

[PATCH] D96036: [clang][codegen] Remember string used to create llvm::Regex for optimization remarks

dexonsmith accepted this revision. dexonsmith added a comment. LGTM! I also have a couple of optional suggestions to consider. Comment at: clang/include/clang/Basic/CodeGenOptions.h:286 + +bool isEnabled() const { return Regex != nullptr; } + This could als

[PATCH] D96053: [clang] add new unwind inline asm clobber which lowers to throwable inline assembly

cynecx created this revision. cynecx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96053 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp clang/lib/

[PATCH] D95790: [clang][cli] Documentation of CompilerInvocation parsing/generation

Bigcheese added inline comments. Comment at: clang/docs/InternalsManual.rst:711 +required for parsing or generating the command line argument. + +**Positive Flag** You should create a separate section here for listing the classes. Comment at: c

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman updated this revision to Diff 321465. aaron.ballman set the repository for this revision to rG LLVM Github Monorepo. aaron.ballman added a comment. Herald added a project: clang. Updating based on review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added a comment. In D95691#2540667 , @rjmccall wrote: > In D95691#2540619 , @rsmith wrote: > >> In D95691#2540450 , @rjmccall wrote: >> >>> The warning is a bit

[PATCH] D96049: [Timer] On macOS count number of executed instructions

ahoppen updated this revision to Diff 321467. ahoppen added a comment. Fixed an issue caused by me using an old revions as the commit's base. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96049/new/ https://reviews.llvm.org/D96049 Files: clang-

[PATCH] D96054: Support unwinding from inline assembly

cynecx created this revision. cynecx requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D96054 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.cpp clang/lib/

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman marked an inline comment as not done. aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDeclCXX.cpp:874-876 +if (!getLangOpts().CPlusPlus) + Diag(Tok, diag::warn_cxx_static_assert_in_c) + << FixItHint::CreateReplacement(Tok.getL

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD updated this revision to Diff 321476. RedDocMD added a comment. Updated to use new function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95877/new/ https://reviews.llvm.org/D95877 Files: clang/include/clang/StaticAnalyzer/Core/PathSens

[PATCH] D95745: Support unwinding from inline assembly

cynecx updated this revision to Diff 321479. cynecx added a comment. clang-format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 Files: clang/lib/Basic/TargetInfo.cpp clang/lib/CodeGen/CGStmt.c

[PATCH] D95877: [analyzer] Fix static_cast on pointer-to-member handling

RedDocMD added a comment. @vsavchenko, after some experimentation, I found out that handling reinterpret_cast will be a real pain. Consider the following: struct Base { int field; }; struct Derived : public Base {}; struct DoubleDerived : public Derived {}; struct Some

[PATCH] D96056: [clang][cli] Generate and round-trip CodeGen options

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implements generation of rem

[PATCH] D96058: [CodeComplete] Guess type for designated initializers

sammccall created this revision. sammccall added a reviewer: kadircet. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables: - completion in { .x.^ } - completion in { .x = { .^ } } - type-based ranking of candidates for

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 321501. varungandhi-apple added a comment. 1. Update whitespace and add documentation for swiftasynccall. 2. Update commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://rev

[PATCH] D95691: Implement P2173 for attributes on lambdas

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; Uh, I think we're a couple standard releases past the po

[PATCH] D95691: Implement P2173 for attributes on lambdas

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; rjmccall wrote: > Uh, I think we're a couple standa

[PATCH] D95691: Implement P2173 for attributes on lambdas

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; aaron.ballman wrote: > rjmccall wrote: > > Uh, I thin

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

fhahn added a comment. Herald added a reviewer: jansvoboda11. @atmnpatel reverse ping. Just curious if you think you'll have time to follow up on this patch soonish? Otherwise I'm probably going to add at least the `-fno-finite-loops` option, because we have users which code breaks due to the `

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel added a comment. @fhahn Sorry for the hold up, I don't think I'll get to this relatively soon, I'll abandon this one and D94366 to sweep the board. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/ne

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

atmnpatel added a comment. Wait actually, we're gonna need D94366 anyways, I'll get address @xbolva00's comments by eod. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94367/new/ https://reviews.llvm.org/D94367 __

[PATCH] D94367: [Clang][Driver] Add -ffinite-loops flags

fhahn added a comment. In D94367#2542809 , @atmnpatel wrote: > Wait actually, we're gonna need D94366 > anyways, I'll get address @xbolva00's comments by eod. FWIW I think we should sort this one (D94367

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

kpn added a comment. This looks like a definite step forward. Thank you! Can you do an AArch64 test case showing long double? Right now there's no 128-bit test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95948/new/ https://reviews.llvm.or

[PATCH] D96000: Don't emit coverage mapping for excluded functions

vsk added inline comments. Comment at: clang/test/CodeGen/profile-filter.c:27 +// EXCLUDE: @__covrec_{{[0-9A-F]+}}u = linkonce_odr hidden constant <{ i64, i32, i64, i64, [{{.*}} x i8] }> <{ {{.*}} }>, section "__llvm_covfun" +// EXCLUDE-NOT: @__covrec_{{[0-9A-F]+}}u = linkonce_o

[PATCH] D95948: Stop traping on sNaN in __builtin_isnan

mibintc added a comment. Should we add tests for mlong-double-64, -80, -128? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95948/new/ https://reviews.llvm.org/D95948 ___ cfe-commits mailing list cfe-comm

[PATCH] D96058: [CodeComplete] Guess type for designated initializers

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks! LG with a small concern around possible effects on member completions for uninstantiated templates. Comment at: clang/lib/Parse/ParseInit.cpp:163 +Designator

  1   2   >