aaron.ballman added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticGroups.td:269 +def CXXPre2BCompatPedantic : + DiagGroup<"c++98-c++11-c++14-c++17-c++20-compat-pedantic", [CXXPre2BCompat]>; ---------------- rjmccall wrote: > Uh, I think we're a couple standard releases past the point at which we > should have reconsidered this schema. I guess the problem is that we can't > say `-Wpre-c++23-compat` without jumping the gun. Is there a problem with > `-Wc++20-compat` and then having the earlier warning groups imply the later > ones? That seems to be what we do with `-Wc++98-compat`; did we abandon that > approach intentionally? @rsmith may have more background here. I was following the pattern already in the file, but I tend to agree that this pattern is not leading us somewhere good. FWIW, I ran into a similar situation with this on the C side of things in D95396, so we should probably be consistent there too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95691/new/ https://reviews.llvm.org/D95691 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
