curdeius added a comment.

Don't forget to mark comments as Done when... they're done :).



================
Comment at: clang/docs/ClangFormatStyleOptions.rst:2039
 
+**IndentAccessModifiers** (``bool``)
+  Makes an indentation level for record (``class``, ``struct``, ``union``)
----------------
Budovi wrote:
> Budovi wrote:
> > curdeius wrote:
> > > curdeius wrote:
> > > > The name `IndentAccessModifiers` is misleading for me. Access modifiers 
> > > > are public, protected, private.
> > > Hmm, actually that's the description that is misleading.
> > Hm. Will go through the bug report again to see how people describe it. I'm 
> > open to suggestions, but I'll need to fix it anyway because I see a grammar 
> > mistake.
> > 
> > The current way I tried to go about it is that, without this option, 
> > modifiers don't have their own indentation level. Without the offset given 
> > by the `AccessModifierOffset` they would just be flush with the record 
> > members.
> > 
> > The introduced option creates a level designated for the access modifiers 
> > by shifting the members further to the right.
> Hopefully the description is better this time.
Much better indeed! Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94661/new/

https://reviews.llvm.org/D94661

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to