Bigcheese added inline comments.
================ Comment at: clang/docs/InternalsManual.rst:711 +required for parsing or generating the command line argument. + +**Positive Flag** ---------------- You should create a separate section here for listing the classes. ================ Comment at: clang/docs/InternalsManual.rst:770 +The key path defaults to an empty ``std::vector<std::string>``. Values specified +with each appearance of the option on command line are appended to the vector. + ---------------- ================ Comment at: clang/docs/InternalsManual.rst:843 +implementation is still possible. + The Lexer and Preprocessor Library ---------------- Past this you should add a section providing instructions on how to actually add marshaling for an option, and cover what to do if the automatic infrastructure isn't enough. ================ Comment at: clang/docs/InternalsManual.rst:590 +the driver options in ``clang/Driver/Options.td``. The information making up an +option definition include the name and prefix (for example ``-std=``), form and +position of the option value, help text, aliases and more. Each option may ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95790/new/ https://reviews.llvm.org/D95790 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
