[PATCH] D95571: [clangd] Remove some obsolete options that are now always on

sammccall updated this revision to Diff 319776. sammccall added a comment. group retired flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95571/new/ https://reviews.llvm.org/D95571 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tool

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

jhenderson added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:74 +// RUN: not clang-offload-bundler -type=i -targets=host-%itanium_abi_triple,openmp-powerpc64le-ibm-linux-gnu,openmp-x86_64-pc-linux-gnu -inputs=%t.i,%t.tgt1,%t.tgt2.notexist -outputs=%t.

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! there are also some comments on `ASTWorker::PublishMu` talking about semantic highlights publishing. Comment at: clang-tools-extra/clangd/SemanticHighligh

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

kadircet added a comment. oh also in addition to `This should not land until the new protocol has feature parity, see D77702.`, it might be better to hold on to it a little bit longer, since it is touching lots of pieces and might make cherry-picking some fixes that touch the same files harder

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

sammccall marked an inline comment as done. sammccall added a comment. In D95576#2527407 , @kadircet wrote: > oh also in addition to `This should not land until the new protocol has > feature parity, see D77702.`, it might be better to hold on to it a lit

[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

sammccall updated this revision to Diff 319779. sammccall added a comment. Remove some comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95576/new/ https://reviews.llvm.org/D95576 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-

[PATCH] D95448: [flang][driver] Add support for `-J/-module-dir`

awarzynski added a comment. @arnamoy10 , could you also add tests that show that `-J/-module-dir` is taken into account when deciding where to put module files? Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95448/new/ https://reviews.ll

[PATCH] D95166: Disable rosegment for old Android versions.

vitalybuka added a comment. Out Android build bot is broken after this patch http://lab.llvm.org:8011/#/builders/77/builds/3234 Run Build Command(s):/usr/bin/ninja cmTC_578f8 && [1/2] Building C object CMakeFiles/cmTC_578f8.dir/testCCompiler.c.o [2/2] Linking C executable cmTC_578f8 FAILE

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319780. tbaeder added a comment. Answered one of my questions by adding a new function directly to `Sema`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/include/clang/Sema/Sema.h clang/lib

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319784. kentsommer added a comment. Turn SortIncludes into an enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst

[clang] 01b9e61 - [Clang][Codegen] Truncate initializers of union bitfield members

Author: Tomas Matheson Date: 2021-01-28T09:19:19Z New Revision: 01b9e613c28b833327ab4de93d0638a5c8d3514f URL: https://github.com/llvm/llvm-project/commit/01b9e613c28b833327ab4de93d0638a5c8d3514f DIFF: https://github.com/llvm/llvm-project/commit/01b9e613c28b833327ab4de93d0638a5c8d3514f.diff LOG

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01b9e613c28b: [Clang][Codegen] Truncate initializers of union bitfield members (authored by tmatheson). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer marked an inline comment as done. kentsommer added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion.

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319786. kentsommer added a comment. Remove improper enum mapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst cl

[clang] 01b9e61 - [Clang][Codegen] Truncate initializers of union bitfield members

Author: Tomas Matheson Date: 2021-01-28T09:19:19Z New Revision: 01b9e613c28b833327ab4de93d0638a5c8d3514f URL: https://github.com/llvm/llvm-project/commit/01b9e613c28b833327ab4de93d0638a5c8d3514f DIFF: https://github.com/llvm/llvm-project/commit/01b9e613c28b833327ab4de93d0638a5c8d3514f.diff LOG

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:399 +IO.enumCase(Value, "false", FormatStyle::SI_Never); +IO.enumCase(Value, "", FormatStyle::SI_CaseInsensitive); +IO.enumCase(Value, "true", FormatStyle::SI_CaseInsensitive); Is

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added inline comments. Comment at: clang/lib/Format/Format.cpp:399 +IO.enumCase(Value, "false", FormatStyle::SI_Never); +IO.enumCase(Value, "", FormatStyle::SI_CaseInsensitive); +IO.enumCase(Value, "true", FormatStyle::SI_CaseInsensitive); cu

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added a comment. Concerning the `--sort-includes` command-line flag. I'd rather keep it as is and, if need be, work on accepting an **optional** string argument. Please update release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2286 +**IncludeSortAlphabetically** (``bool``) + Specify if sorting should be done in an alphabetical and + case sensitive fashion. kentsommer wrote: > HazardyKnusperkeks wrote:

[PATCH] D95532: [clang][cli] Use variadic macros for parsing/generating

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG374862d71c1a: [clang][cli] Use variadic macros for parsing/generating (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.or

[clang] 374862d - [clang][cli] Use variadic macros for parsing/generating

Author: Jan Svoboda Date: 2021-01-28T10:35:02+01:00 New Revision: 374862d71c1a2f63557a27f1555b37ff0f75117e URL: https://github.com/llvm/llvm-project/commit/374862d71c1a2f63557a27f1555b37ff0f75117e DIFF: https://github.com/llvm/llvm-project/commit/374862d71c1a2f63557a27f1555b37ff0f75117e.diff L

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

curdeius added a comment. I see little value in not checking FallbackStyle (even if it's not used). However, I do see value in an early warning (error) on an incorrect style that can pop up later if not caught soon enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

curdeius added a comment. I return the question, are there any workflows that would benefit from the proposed behaviour? Apart from those that have already a faulty config? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95538/new/ https://reviews.l

[clang] 374862d - [clang][cli] Use variadic macros for parsing/generating

Author: Jan Svoboda Date: 2021-01-28T10:35:02+01:00 New Revision: 374862d71c1a2f63557a27f1555b37ff0f75117e URL: https://github.com/llvm/llvm-project/commit/374862d71c1a2f63557a27f1555b37ff0f75117e DIFF: https://github.com/llvm/llvm-project/commit/374862d71c1a2f63557a27f1555b37ff0f75117e.diff L

[clang] 2393b03 - Revert "[clang][cli] Use variadic macros for parsing/generating"

Author: Jan Svoboda Date: 2021-01-28T10:48:43+01:00 New Revision: 2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7 URL: https://github.com/llvm/llvm-project/commit/2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7 DIFF: https://github.com/llvm/llvm-project/commit/2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7.diff L

[clang] 2393b03 - Revert "[clang][cli] Use variadic macros for parsing/generating"

Author: Jan Svoboda Date: 2021-01-28T10:48:43+01:00 New Revision: 2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7 URL: https://github.com/llvm/llvm-project/commit/2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7 DIFF: https://github.com/llvm/llvm-project/commit/2393b03239c56b9bc1f6fd8bef5cdedaf0570bc7.diff L

[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

kadircet added a comment. > I see little value in not checking FallbackStyle (even if it's not used). note that this patch doesn't disable fallbackstyle checking, it is still checked, but not eagerly. > However, I do see value in an early warning (error) on an incorrect style > that can pop up

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. In D95017#2527512 , @curdeius wrote: > Concerning the `--sort-includes` command-line flag. I'd rather keep it as is > and, if need be, work on accepting an **optional** string argument. > Please update release notes. @curdeius

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius added a comment. I was thinking of https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst#clang-format. Look at the history to see how it was written before. Also, you may change the revision title if you want (it will become the commit message). Repository: rG

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing updated this revision to Diff 319797. yubing added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix some bugs in lowerTileDPBSSD, lowerTileStore, lowerTileLoad Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D93585: [AArch64][Clang][Linux] Enable out-of-line atomics by default.

SjoerdMeijer added a comment. In D93585#2526774 , @ilinpv wrote: > Clang driver tests for outline atomics were added. Thanks! Is there a way we can test `-rtlib=libgcc`? Comment at: clang/lib/Driver/ToolChains/Linux.cpp:855 +const

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319804. kentsommer added a comment. Added release notes, updated commit message and summary Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/Clang

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319806. kentsommer added a comment. Fixed release notes typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D95562: [ASTMatchers] Fix traversal below range-for elements

steveire updated this revision to Diff 319809. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95562/new/ https://reviews.llvm.org/D95562 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp clang/unittests/ASTMatcher

[PATCH] D95557: [WebAssembly] Prototype i8x16 to i32x4 widening instructions

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. This does not yet have i64x2 version of the instructions in https://github.com/WebAssembly/simd/pull/395 yet, right? Comment at: llvm/lib/Target/WebAssembly/WebAssemblyIns

[PATCH] D94827: [SimplifyCFG] If provided, preserve Dominator Tree

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8cfa963463d0: [SimplifyCFG] If provided, preserve Dominator Tree (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 526c42e - [OpenCL] Hide sampler-less read_image builtins before CL1.2

Author: Sven van Haastregt Date: 2021-01-28T11:14:19Z New Revision: 526c42e76c12d9cfe83dfa5957fe1715ab8d1faf URL: https://github.com/llvm/llvm-project/commit/526c42e76c12d9cfe83dfa5957fe1715ab8d1faf DIFF: https://github.com/llvm/llvm-project/commit/526c42e76c12d9cfe83dfa5957fe1715ab8d1faf.diff

[clang] 526c42e - [OpenCL] Hide sampler-less read_image builtins before CL1.2

Author: Sven van Haastregt Date: 2021-01-28T11:14:19Z New Revision: 526c42e76c12d9cfe83dfa5957fe1715ab8d1faf URL: https://github.com/llvm/llvm-project/commit/526c42e76c12d9cfe83dfa5957fe1715ab8d1faf DIFF: https://github.com/llvm/llvm-project/commit/526c42e76c12d9cfe83dfa5957fe1715ab8d1faf.diff

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer updated this revision to Diff 319819. kentsommer added a comment. NFC Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNo

[PATCH] D95536: [clang][sema] Note decl location on missing member

tbaeder updated this revision to Diff 319820. tbaeder added a comment. Fixed the Lambda oddity as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95536/new/ https://reviews.llvm.org/D95536 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaExpr.

[PATCH] D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. This fixes the issue with exponential traversal times for deeply nested lambdas. Please add a test though. For example, this one: void f() { [] { [] { [] { [] { [] {

[PATCH] D95573: [ASTMatchers] Avoid pathological traversal over nested lambdas

alexfh added a comment. Thanks for the prompt fix, btw! Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:2064 + if (const auto *MD = dyn_cast(D)) { +if (const auto *RD = MD->getParent()) { + if (RD->isLambda()) { Please specify the type expli

[clang] 083d151 - Apply https://reviews.llvm.org/D42519

Author: Russell Gallop Date: 2021-01-07T17:37:18Z New Revision: 083d1519465718fb7f7bbe65597ffc23e612ba19 URL: https://github.com/llvm/llvm-project/commit/083d1519465718fb7f7bbe65597ffc23e612ba19 DIFF: https://github.com/llvm/llvm-project/commit/083d1519465718fb7f7bbe65597ffc23e612ba19.diff LOG

[PATCH] D95017: [clang-format] add case aware include sorting

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D95119#2525925 , @MaskRay wrote: > `#!/usr/bin/env perl -w` (2 arguments) unfortunately does not work on Linux > and many other systems.

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Oops, didn't mean to accept. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:349-351 +triple = "" +if hasattr(self.config, 'host_triple'): +triple = self.config.host_triple jhenderson wrote: > abhina.sreeskantharajan wr

[PATCH] D95607: Fix traversal with hasDescendant into lambdas

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95607 Files: clang/lib/ASTMatchers/ASTMat

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319839. abhina.sreeskantharajan added a comment. Address syntax comments, and add a list of supported error code substitutions in the guide. If these changes are ok, I would like to start making changes to all affected testcases. Repositor

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity updated this revision to Diff 319840. whisperity marked 9 inline comments as done. whisperity added a comment. - NFC Code style and organisation fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new/ https://reviews.llvm.org/D695

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:284 +/// The default value for the MinimumLength check option. +static constexpr unsigned DefaultMinimumLength = 2; + aaron.ballman wrote: > It

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

jhenderson added a comment. One nit, but otherwise looks good to me, thanks! Please go ahead with the other test updates. Do you plan on doing them in this patch? Comment at: llvm/docs/TestingGuide.rst:545 + + The following error codes are supported: ENOENT, EISDIR. + --

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

FarisRehman updated this revision to Diff 319842. FarisRehman marked 12 inline comments as done. FarisRehman added a comment. Address review comment Address the review comment by @awarzynski Summary of changes: - Shorten help text - Add method AddFortranDialectOptions to Flang.cpp - Change styl

[clang] 0024efc - Relax test expectations in debug-info-gline-tables-only-codeview.cpp

Author: Hans Wennborg Date: 2021-01-28T14:40:11+01:00 New Revision: 0024efc69ea6cd0b630cd11cef5991b7edb73ffc URL: https://github.com/llvm/llvm-project/commit/0024efc69ea6cd0b630cd11cef5991b7edb73ffc DIFF: https://github.com/llvm/llvm-project/commit/0024efc69ea6cd0b630cd11cef5991b7edb73ffc.diff

[clang] 0024efc - Relax test expectations in debug-info-gline-tables-only-codeview.cpp

Author: Hans Wennborg Date: 2021-01-28T14:40:11+01:00 New Revision: 0024efc69ea6cd0b630cd11cef5991b7edb73ffc URL: https://github.com/llvm/llvm-project/commit/0024efc69ea6cd0b630cd11cef5991b7edb73ffc DIFF: https://github.com/llvm/llvm-project/commit/0024efc69ea6cd0b630cd11cef5991b7edb73ffc.diff

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan added a comment. In D95246#2527961 , @jhenderson wrote: > One nit, but otherwise looks good to me, thanks! Please go ahead with the > other test updates. Do you plan on doing them in this patch? This was my initial thought. But if

[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

FarisRehman marked an inline comment as done. FarisRehman added inline comments. Comment at: flang/lib/Frontend/CompilerInstance.cpp:151-158 + if (invoc.frontendOpts().fortranForm_ == FortranForm::Unknown) { +// Switch between fixed and free form format based on the

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

abhina.sreeskantharajan updated this revision to Diff 319844. abhina.sreeskantharajan added a comment. Add currently in TestingGuide. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.llvm.org/D95246 Files: clang/test/Driv

[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

jhenderson added a comment. In D95246#2527999 , @abhina.sreeskantharajan wrote: > In D95246#2527961 , @jhenderson > wrote: > >> One nit, but otherwise looks good to me, thanks! Please go ahead with the >> other t

[clang-tools-extra] dfd2374 - [clang-tidy] Remove unnecessary #ifdef

Author: Alexander Kornienko Date: 2021-01-28T15:00:07+01:00 New Revision: dfd2374ab6c393d675e7b4583bc279b2d7e9b51f URL: https://github.com/llvm/llvm-project/commit/dfd2374ab6c393d675e7b4583bc279b2d7e9b51f DIFF: https://github.com/llvm/llvm-project/commit/dfd2374ab6c393d675e7b4583bc279b2d7e9b51f

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from the list order nit. Thanks! Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:155 REGISTER_MATCHER(callExpr); + REGISTER_MATCHER(invoca

[clang-tools-extra] dfd2374 - [clang-tidy] Remove unnecessary #ifdef

Author: Alexander Kornienko Date: 2021-01-28T15:00:07+01:00 New Revision: dfd2374ab6c393d675e7b4583bc279b2d7e9b51f URL: https://github.com/llvm/llvm-project/commit/dfd2374ab6c393d675e7b4583bc279b2d7e9b51f DIFF: https://github.com/llvm/llvm-project/commit/dfd2374ab6c393d675e7b4583bc279b2d7e9b51f

[PATCH] D95616: Change extension handling for -fdeclare-opencl-builtins

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Until now, the `-fdeclare-opencl-builtins` option behaved differently compared t

[PATCH] D95523: [OpenCL] Add cl_khr_subgroup_ballot to TableGen BIFs

svenvh updated this revision to Diff 319860. svenvh added a comment. Add test after rebasing on dependent commit (D95616 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95523/new/ https://reviews.llvm.org/D95523

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 319862. aaron.ballman added a comment. Rebasing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 updated this revision to Diff 319868. jansvoboda11 added a comment. Ensure Diags get used only once, add disabling flag, clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94472/new/ https://reviews.llvm.org/D94472 Files: clang/

[PATCH] D94472: [clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:593-594 +def round_trip_args : Flag<["-"], "round-trip-args">, Flags<[CC1Option, NoDriverOption]>, + HelpText<"Performs 'parse-generate-parse' round-trip of command line arguments.">; +def

[PATCH] D95608: [OpenCL][PR48896] Fix address space in binding of initializer lists to references

Anastasia updated this revision to Diff 319869. Anastasia retitled this revision from "[OpenCL][PR48896] Fix address space when binding vector literals to references" to "[OpenCL][PR48896] Fix address space in binding of initializer lists to references". Anastasia edited the summary of this revis

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

Anastasia added inline comments. Comment at: lib/Sema/SemaInit.cpp:4806-4808 + if ((RefRelationship == Sema::Ref_Related && + (T1CVRQuals | T2CVRQuals) != T1CVRQuals) || + !T1Quals.isAddressSpaceSupersetOf(T2Quals)) { ebevhan wrote: > Sorry for the re

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

abhina.sreeskantharajan updated this revision to Diff 319873. abhina.sreeskantharajan retitled this revision from "[SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued" to "[test] Use host platform specific error message substitution in lit tests ". abh

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie updated this revision to Diff 319871. haampie added a comment. Herald added a subscriber: arphaman. I dropped the awk bits, since there's no portable way to do it there, and replaced all `perl -w` with `perl` and `use warnings`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9511

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

jansvoboda11 added a comment. In D95514#2526064 , @dexonsmith wrote: > Well, the compiler developers are the users, since `-cc1` isn't for > end-users. I acknowledge it's a tradeoff. IMO, without actually seeing it in > practice, it seems a bit nicer to

[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

Bigcheese added a comment. In D95514#2528324 , @jansvoboda11 wrote: > In D95514#2526064 , @dexonsmith > wrote: > >> Well, the compiler developers are the users, since `-cc1` isn't for >> end-users. I acknowledge

[PATCH] D95628: WIP: clang-scan-deps: Skip the disk when scanning modules dependencies

dexonsmith created this revision. dexonsmith added reviewers: Bigcheese, arphaman, sammccall. Herald added subscribers: ributzka, tschuett. dexonsmith requested review of this revision. Herald added a project: clang. Modules dependendency scanning builds lightweight modules (based on minimized pre

[PATCH] D95369: [WIP][clang][cli] Generate and round-trip analyzer options

jansvoboda11 updated this revision to Diff 319894. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95369/new/ https://reviews.llvm.org/D95369 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[PATCH] D95629: [clang][analyzer] Own string keys in AnalyzerOptions::ConfigTable

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. jansvoboda11 requested review of this re

[PATCH] D95614: [clang-tidy] Applied clang-tidy fixes. NFC

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95614/new/ https://reviews.llvm.org/D95614 ___

[PATCH] D94942: [clangd] Add tweak for implementing abstract class

njames93 updated this revision to Diff 319898. njames93 added a comment. - Fix an issue where replacements could conflict with each other. - Add support for defining method stubs instead of just declaring them, possibly need a way to configure this behaviour. - Change tests to ignore whitespace b

[PATCH] D95366: [WIP][clang][cli] Generate and round-trip preprocessor options

jansvoboda11 updated this revision to Diff 319902. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95366/new/ https://reviews.llvm.org/D95366 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[clang] cfcc111 - [NFC] Disallow unused prefixes under clang/test/CodeGenCXX

Author: Mircea Trofin Date: 2021-01-28T09:47:21-08:00 New Revision: cfcc1110d7733ad6c275eefd1773d243a719f9f3 URL: https://github.com/llvm/llvm-project/commit/cfcc1110d7733ad6c275eefd1773d243a719f9f3 DIFF: https://github.com/llvm/llvm-project/commit/cfcc1110d7733ad6c275eefd1773d243a719f9f3.diff

[PATCH] D95499: [NFC] Disallow unused prefixes under clang/test/CodeGenCXX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfcc1110d773: [NFC] Disallow unused prefixes under clang/test/CodeGenCXX (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] cfcc111 - [NFC] Disallow unused prefixes under clang/test/CodeGenCXX

Author: Mircea Trofin Date: 2021-01-28T09:47:21-08:00 New Revision: cfcc1110d7733ad6c275eefd1773d243a719f9f3 URL: https://github.com/llvm/llvm-project/commit/cfcc1110d7733ad6c275eefd1773d243a719f9f3 DIFF: https://github.com/llvm/llvm-project/commit/cfcc1110d7733ad6c275eefd1773d243a719f9f3.diff

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader updated this revision to Diff 319909. bader added a comment. Addressed comment from Ronan in regression tests and synced them with the latest status. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.llvm.org/D71016 F

[PATCH] D71016: [SYCL] Implement OpenCL kernel function generation

bader commandeered this revision. bader edited reviewers, added: Fznamznon; removed: bader. bader added inline comments. Comment at: clang/test/CodeGenSYCL/device-functions.cpp:2 +// RUN: %clang_cc1 -triple spir64 -fsycl-is-device -S -emit-llvm %s -o - | FileCheck %s + +template

[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

RedDocMD added a comment. @kromanenkov I guess it won't work then. Thanks for the idea! Now that I think about it removing duplicates is probably not the right thing to do. The problem arises because the call PTMD->getCXXBaseList() should ideally return the list of previous casts, but instead r

[PATCH] D95017: [clang-format] Add case aware include sorting.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. I like this much better LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 ___ cfe-commit

[PATCH] D95516: [WIP][clang][cli] Benchmark command line round-trip

jansvoboda11 updated this revision to Diff 319917. jansvoboda11 added a comment. Remove hard-coded arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95516/new/ https://reviews.llvm.org/D95516 Files: clang/CMakeLists.txt clang/benchmarks/

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

tra added a comment. In D69322#2523058 , @tra wrote: > @hliao -- Can you take a look at > https://bugs.llvm.org/show_bug.cgi?id=48866. This patch may be relevant there. @rnk Reid, looks like this patch does fix a lambda mangling issue in CUDA on Window

[PATCH] D95634: [PowerPC][Power10] Fix XXSPLI32DX not correctly exploiting specific cases

Conanap created this revision. Conanap added reviewers: nemanjai, saghir, PowerPC. Conanap added projects: LLVM, clang, PowerPC. Herald added a subscriber: kbarton. Conanap requested review of this revision. Some cases may be transformed into 32 bit splats before hitting the boolean statement, wh

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj marked 8 inline comments as done. timwoj added a comment. No problem, sorry it took a bit of back-and-forth there. Is there any way this can sneak into 12.0? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/

[PATCH] D95634: [PowerPC][Power10] Fix XXSPLI32DX not correctly exploiting specific cases

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM as long as the nits are addressed on the commit. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8611 Subtarget.hasPrefixInstrs()) { -if (convertT

[PATCH] D95634: [PowerPC][Power10] Fix XXSPLI32DX not correctly exploiting specific cases

lei accepted this revision. lei added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95634/new/ https://reviews.llvm.org/D95634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D95557: [WebAssembly] Prototype i8x16 to i32x4 widening instructions

tlively added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1279 +(I32x4.vt (int_wasm_widen_signed + (I8x16.vt V128:$vec), (i32 timm:$idx], + "i32x4.widen_i8x16_s\t$dst, $vec, $idx", aheejin

[PATCH] D95557: [WebAssembly] Prototype i8x16 to i32x4 widening instructions

tlively added a comment. In D95557#2527731 , @aheejin wrote: > This does not yet have i64x2 version of the instructions in > https://github.com/WebAssembly/simd/pull/395 yet, right? Yes, that's intentional. These are the only versions implemented in V8 a

[PATCH] D95557: [WebAssembly] Prototype i8x16 to i32x4 widening instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b68b64dcc5b: [WebAssembly] Prototype i8x16 to i32x4 widening instructions (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 4b68b64 - [WebAssembly] Prototype i8x16 to i32x4 widening instructions

Author: Thomas Lively Date: 2021-01-28T10:59:32-08:00 New Revision: 4b68b64dcc5bcd6f29779b820791611c60438385 URL: https://github.com/llvm/llvm-project/commit/4b68b64dcc5bcd6f29779b820791611c60438385 DIFF: https://github.com/llvm/llvm-project/commit/4b68b64dcc5bcd6f29779b820791611c60438385.diff

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

ctetreau created this revision. Herald added subscribers: teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, mgorny. ctetreau requested review of this revision. Herald a

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rnk added inline comments. Comment at: clang/include/clang/AST/DeclCXX.h:395-400 /// The number used to indicate this lambda expression for name /// mangling in the Itanium C++ ABI. unsigned ManglingNumber : 31; +/// The device side mangling number. +unsi

[PATCH] D95635: [CMake] Actually require python 3.6 or greater

yln added a comment. LGTM, thanks! (I got bitten by this.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95635/new/ https://reviews.llvm.org/D95635 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. One more ping. Please, pay attention to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commi

  1   2   >