bader commandeered this revision. bader edited reviewers, added: Fznamznon; removed: bader. bader added inline comments.
================ Comment at: clang/test/CodeGenSYCL/device-functions.cpp:2 +// RUN: %clang_cc1 -triple spir64 -fsycl-is-device -S -emit-llvm %s -o - | FileCheck %s + +template <typename T> ---------------- keryell wrote: > Missing description about the purpose of this test Done. ================ Comment at: clang/test/SemaSYCL/fake-accessors.cpp:2 +// RUN: %clang_cc1 -I %S/Inputs -fsycl-is-device -ast-dump %s | FileCheck %s + +#include <sycl.hpp> ---------------- keryell wrote: > Missing description about the purpose of this test. > I am struggling about understanding what this test is for... > OK, after coming back later, I think I got it. I was confused by the fact > that in the kernels you are using both true accessors (A, B & C) *and* some > objects with names similar to SYCL accessor. > Is it possible to have some tests without true accessors? Added a new test case w/o SYCL accessor and description of the test. ================ Comment at: clang/test/SemaSYCL/mangle-kernel.cpp:3 +// RUN: %clang_cc1 -triple spir-unknown-unknown-unknown -I %S/Inputs -I %S/../Headers/Inputs/include/ -fsycl-is-device -ast-dump %s | FileCheck %s --check-prefix=CHECK-32 +#include <sycl.hpp> +#include <stdlib.h> ---------------- keryell wrote: > Missing description about the purpose of this test Done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71016/new/ https://reviews.llvm.org/D71016 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
