kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
Thanks, LGTM! there are also some comments on `ASTWorker::PublishMu` talking about semantic highlights publishing. ================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:17 +// https://github.com/microsoft/vscode-languageserver-node/blob/release/protocol/3.16.0-next.1/protocol/src/protocol.semanticTokens.proposed.ts +// We supported a pre-standard `textDocument/semanticHighlighting` notification, +// but this has been removed. ---------------- not sure if this sentence will help anyone. if you choose to drop this one, i suppose the former can also be rephrased as `Protocol details can be found at ...` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95576/new/ https://reviews.llvm.org/D95576 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
