Anastasia added inline comments.
================
Comment at: lib/Sema/SemaInit.cpp:4806-4808
+ if ((RefRelationship == Sema::Ref_Related &&
+ (T1CVRQuals | T2CVRQuals) != T1CVRQuals) ||
+ !T1Quals.isAddressSpaceSupersetOf(T2Quals)) {
----------------
ebevhan wrote:
> Sorry for the really late comment on this, but shouldn't this be:
> ```
> if (RefRelationship == Sema::Ref_Related &&
> ((T1CVRQuals | T2CVRQuals) != T1CVRQuals ||
> !T1Quals.isAddressSpaceSupersetOf(T2Quals))) {
> ```
>
> Currently, this fails on AS qualification regardless of ref-compatibility.
Sorry for noticing this late. I agree this doesn't look right... I will create
a patch to fix this.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58634/new/
https://reviews.llvm.org/D58634
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
