[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

rapgenic updated this revision to Diff 313259. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93600/new/ https://reviews.llvm.org/D93600 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tools-extra/clangd/test/system-include-extractor.test Index: clang-tools-extra/clang

[PATCH] D93600: [clangd] When querying drivers by binary, look in PATH too

rapgenic marked 3 inline comments as done. rapgenic added a comment. I think I have fixed what you asked! About the test, I thought it would be reasonable to test the three cases separately, however I cannot get it to work with a single test file (I think it's some problem with the generated fi

[PATCH] D93679: [clang[cli] Port getAllArgumentValues to the marshalling infrastructure

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D84673: Port DiagnosticOpts to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D

[PATCH] D93452: [clangd] Trim memory periodically

njames93 added a comment. I feel like we need some kind of entry for this in release notes given how much of an issue it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93452/new/ https://reviews.llvm.org/D93452

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 added a comment. In D84924#2466564 , @aaron.ballman wrote: > Agreed, but I don't think the current behavior in this patch is cautious > enough. I like that we have to specify "please apply fixits from notes" > explicitly. I think that's the rig

[PATCH] D86844: [LoopDeletion] Allows deletion of possibly infinite side-effect free loops

fhahn added inline comments. Comment at: clang/test/Misc/loop-opt-setup.c:26 // Check br i1 to make sure the loop is gone, there will still be a label branch for the infinite loop. // CHECK-LABEL: Helper This comment needs updating, there's no loop there now

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru updated this revision to Diff 313271. sylvestre.ledru added a comment. Error only on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 Files: clang/include/clang/Basic/DiagnosticDriv

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

njames93 updated this revision to Diff 313272. njames93 added a comment. Only apply fixes from notes if there is exactly one fix found in them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 Files: clang

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 __

[clang] 4d59c8f - -fstack-clash-protection: Return an actual error when used on unsupported OS

Author: Sylvestre Ledru Date: 2020-12-22T12:06:08+01:00 New Revision: 4d59c8fdb955ea0d668b854f467e12bce05a8857 URL: https://github.com/llvm/llvm-project/commit/4d59c8fdb955ea0d668b854f467e12bce05a8857 DIFF: https://github.com/llvm/llvm-project/commit/4d59c8fdb955ea0d668b854f467e12bce05a8857.dif

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d59c8fdb955: -fstack-clash-protection: Return an actual error when used on unsupported OS (authored by sylvestre.ledru). Repository: rG LLVM Gith

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This is follow up to D93393 . Without th

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov added a comment. Thank to @steakhal for the new tests. //All// previous result differences have **gone** in `FFMPEG` and `twin` but a new //one// **appeared** in `PostgreSQL`. /src/common/d2s.c Line 895 Memory copy function overflows the destination buffer alpha.unix.cstring.Ou

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX added reviewers: sammccall, kadircet. ArcsinX added a comment. I also want to propose the similar patch for fuzzyFind() (as a part of this patch or a separate one), but I faced the following problem: `Test.cpp` #define FOO 1 This example creates empty dynamic index for main file symb

[clang-tools-extra] 4b3633c - [clangd] Reuse buffer for JSONTransport::sendMessage

Author: Nathan James Date: 2020-12-22T11:30:56Z New Revision: 4b3633cf2cb67220763494427f6db250bbd87494 URL: https://github.com/llvm/llvm-project/commit/4b3633cf2cb67220763494427f6db250bbd87494 DIFF: https://github.com/llvm/llvm-project/commit/4b3633cf2cb67220763494427f6db250bbd87494.diff LOG:

[PATCH] D93531: [clangd] Reuse buffer for JSONTransport::sendMessage

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b3633cf2cb6: [clangd] Reuse buffer for JSONTransport::sendMessage (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93531/new/ https://

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

thakis added a comment. This seems to break all tests on all platforms: http://45.33.8.238/linux/35854/step_7.txt As far as I can tell, RenderSCPOptions is called unconditinoally and the error message is emitted at its start, before any Args.hasFlag checks -- so it's emitted every time a windo

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

thakis added a comment. Also, rnk's comment above wasn't addressed as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 ___ cfe-commits mailing l

[clang] 00065d5 - Revert "-fstack-clash-protection: Return an actual error when used on unsupported OS"

Author: Nico Weber Date: 2020-12-22T06:51:19-05:00 New Revision: 00065d5cbd02b0f3fccb34881b58bcd0852b3970 URL: https://github.com/llvm/llvm-project/commit/00065d5cbd02b0f3fccb34881b58bcd0852b3970 DIFF: https://github.com/llvm/llvm-project/commit/00065d5cbd02b0f3fccb34881b58bcd0852b3970.diff LO

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

thakis added a comment. reverted in 00065d5cbd02b0f3fccb34881b58bcd0852b3970 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 __

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru added a comment. Thanks for the revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92245/new/ https://reviews.llvm.org/D92245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] 3b879fc - [ASTMatchers] Traverse-ignore range-for implementation details

Author: Stephen Kelly Date: 2020-12-22T12:09:32Z New Revision: 3b879fc97305849026db0e856920d318fadbc04b URL: https://github.com/llvm/llvm-project/commit/3b879fc97305849026db0e856920d318fadbc04b DIFF: https://github.com/llvm/llvm-project/commit/3b879fc97305849026db0e856920d318fadbc04b.diff LOG:

[PATCH] D93596: [ASTMatchers] Traverse-ignore range-for implementation details

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b879fc97305: [ASTMatchers] Traverse-ignore range-for implementation details (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93596/

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

steveire created this revision. steveire added a reviewer: aaron.ballman. steveire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Because we don't know in ASTMatchFinder whether we're matching in AsIs or IgnoreUnlessSpelledInSource mode, w

[PATCH] D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1976 + tok::kw_co_yield, tok::equal, tok::kw_delete, + tok::kw_sizeof, tok::kw_throw) ||

[PATCH] D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer

MyDeveloperDay updated this revision to Diff 313295. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. remove unrelated change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93626/new/ https://reviews.llvm.org/D93626 Files: clang/lib/Format/TokenAnnotato

[PATCH] D93688: [ASTMatchers] Ensure that we can match inside lambdas

steveire updated this revision to Diff 313296. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93688/new/ https://reviews.llvm.org/D93688 Files: clang/include/clang/ASTMatchers/ASTMatchersInternal.h clang/lib/AST

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

MyDeveloperDay updated this revision to Diff 313297. MyDeveloperDay added a comment. remove //= and //~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93490/new/ https://reviews.llvm.org/D93490 Files: clang/lib/Format/BreakableToken.cpp clang/unittests/Format/FormatTestComments.cpp

[clang] c4fc8a2 - [clang-format] NFC keep the code clang-formatted

Author: mydeveloperday Date: 2020-12-22T12:46:14Z New Revision: c4fc8a21d1dbfd2e269a59533808913b46faa8ce URL: https://github.com/llvm/llvm-project/commit/c4fc8a21d1dbfd2e269a59533808913b46faa8ce DIFF: https://github.com/llvm/llvm-project/commit/c4fc8a21d1dbfd2e269a59533808913b46faa8ce.diff LOG

[PATCH] D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM now. I tried to find other cases where this change may change the behaviour but couldn't. Have you tried applying to some bigger repo and see what you get? The best would be a repo wi

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 313303. AMDChirag marked an inline comment as done. AMDChirag added a comment. Updated code according to the changes in LLVM side of things. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://re

[PATCH] D84924: [clang-tidy] Added command line option `fix-notes`

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.h:231 +/// If \p AnyFix is true and there is no FixIt attached to the Message, +/// returns the first FixIt attached to any notes in the message. +/// If no FixIt is found, r

[clang] 63a2481 - [clang][cli] Implement `getAllArgValues` marshalling

Author: Jan Svoboda Date: 2020-12-22T14:11:16+01:00 New Revision: 63a24816f561a5d8e28ca7054892bd8602618be4 URL: https://github.com/llvm/llvm-project/commit/63a24816f561a5d8e28ca7054892bd8602618be4 DIFF: https://github.com/llvm/llvm-project/commit/63a24816f561a5d8e28ca7054892bd8602618be4.diff L

[PATCH] D93631: [clang][cli] Implement `getAllArgValues` marshalling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63a24816f561: [clang][cli] Implement `getAllArgValues` marshalling (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D91054: [Clang][OpenMP] Frontend work for sections - D89671

AMDChirag updated this revision to Diff 313307. AMDChirag added a comment. Updated `BGenCallbackTy` to `StorableBodyGenCallbackTy`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91054/new/ https://reviews.llvm.org/D91054 Files: clang/lib/CodeGen

[PATCH] D93628: [clang] NFC: Refactor custom class into a lambda in CompilerInvocation

jansvoboda11 updated this revision to Diff 313309. jansvoboda11 added a comment. Extract SFINAE check into function again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93628/new/ https://reviews.llvm.org/D93628 Files: clang/lib/Frontend/Compiler

[PATCH] D93628: [clang] NFC: Refactor custom class into a lambda in CompilerInvocation

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:176 +static auto makeFlagToValueNormalizer(T Value) { + return makeFlagToValueNormalizer(uint64_t(Value)); } dexonsmith wrote: > (not a behaviour change but) I wonder if t

[clang] bef9eb8 - [clang] NFC: Refactor custom class into a lambda in CompilerInvocation

Author: Jan Svoboda Date: 2020-12-22T14:45:29+01:00 New Revision: bef9eb84b2fb17b22ca771c8c5c34a85f141168d URL: https://github.com/llvm/llvm-project/commit/bef9eb84b2fb17b22ca771c8c5c34a85f141168d DIFF: https://github.com/llvm/llvm-project/commit/bef9eb84b2fb17b22ca771c8c5c34a85f141168d.diff L

[PATCH] D93628: [clang] NFC: Refactor custom class into a lambda in CompilerInvocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbef9eb84b2fb: [clang] NFC: Refactor custom class into a lambda in CompilerInvocation (authored by jansvoboda11). Repository: rG LLVM Github Monore

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

RKSimon added a comment. I'm sorry I've only just started looking at this - are you saying that you want to handle all "insertelement undef" cases in one go and not just a series of patcches after this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 313315. LuoYuanke added a comment. Address Pengfei's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files: clang/test/CodeGen/X86/amx_api.c llvm/includ

[PATCH] D91302: Handle template instantiations better in clang-tidy check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:26-28 + // The first argument of an overloaded member operator is the implicit object + // argument of the method which should not be matched against a paramet

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko updated this revision to Diff 313316. vsavchenko added a comment. Herald added a subscriber: arphaman. Fix block.c test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93630/new/ https://reviews.llvm.org/D93630 Files: clang/lib/Parse/Pa

[PATCH] D93695: [clang-tidy] Update uses of deprecated Transformer APIs in StringFindStrContainsCheck.

ymandel created this revision. ymandel added a reviewer: tdl-g. Herald added a subscriber: xazax.hun. ymandel requested review of this revision. Herald added a project: clang. Migrates `change` to `changeTo`; changes to new constructor API (2-arg construct + `setRule`); refactors use of `addInclud

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:6230 /// LHS < RHS, return -1. int ASTContext::getFloatingTypeOrder(QualType LHS, QualType RHS) const { FloatingRank LHSR = getFloatingRank(LHS); nemanjai wrote: > hubert.

[PATCH] D93453: [flang][driver] Add support for `-I`

FarisRehman updated this revision to Diff 313319. FarisRehman added a comment. Address review comments Summary of changes: - Add a regression test for -I - Move claiming of -I option to the dedicated parsing preprocessing options method - Rename SearchDirectoriesFromI to SearchDirectoriesFromDa

[PATCH] D91303: Simplify implementation of container-size-empty

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:56 - hasEitherOperand(ignoringImpCasts( - anyOf(integerLiteral(equals(1)), -

[PATCH] D93401: [flang][driver] Add support for `-D`, `-U`

awarzynski added a comment. @FarisRehman , thank you for updating this! I have two high-level comments: 1. In your summary: > Change the way the driver handles end-of-line characters in macro definitions. That's a a bit misleading - which driver do you mean? You're not changing the behavior of

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

nlopes added a comment. This patch regressed the following test of Transforms/InstCombine/abs-1.ll: (need to drop NSW in this case). define i8 @nabs_canonical_3(i8 %x) { %0: %cmp = icmp slt i8 %x, 0 %neg = sub nsw i8 0, %x %abs = select i1 %cmp, i8 %x, i8 %neg ret i8 %abs }

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:118 +/// behavior of clang-tidy. +virtual llvm::Optional +getCheckTraversalKind() const; steveire wrote: > sammccall wrote: > > I don't really get why th

[PATCH] D93683: [clangd] Do not take stale definition from the static index.

ArcsinX updated this revision to Diff 313320. ArcsinX added a comment. - Simplify test. - Revert PreambleSymbols.update() first argument change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93683/new/ https://reviews.llvm.org/D93683 Files: clan

[PATCH] D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer

MyDeveloperDay added a comment. In D93626#2467745 , @curdeius wrote: > LGTM now. I tried to find other cases where this change may change the > behaviour but couldn't. Have you tried applying to some bigger repo and see > what you get? The best would be

[PATCH] D93633: [format] Add overload to parseConfiguration that accept llvm::MemoryBufferRef

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93633/new/ https://reviews.llvm.org/D93633 _

[PATCH] D93698: [clang][cli] Port a CommaJoined option to the marshalling infrastructure

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D93699: [clang][cli] Port getAllArgumentValues to the marshalling infrastructure

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

LuoYuanke updated this revision to Diff 313326. LuoYuanke added a comment. Rebase and fix lit test case failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files: clang/test/CodeGen/X86/amx_api.c l

[PATCH] D93700: [clang][cli] Report the actual argument parsing result

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D93700 Files: clang/lib

[PATCH] D93701: [clang][cli] NFC: Make Diags optional in normalizer

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is needed for a future patch, where we start using normalizers in contexts where no

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is necessary for a future patch, where we start using these macros in multiple place

[PATCH] D93626: [clang-format] PR48535 clang-format Incorrectly Removes Space After C Style Cast When Type Is Not a Pointer

curdeius added a comment. In D93626#2467927 , @MyDeveloperDay wrote: > In D93626#2467745 , @curdeius wrote: > >> LGTM now. I tried to find other cases where this change may change the >> behaviour but couldn't. Ha

[PATCH] D93699: [clang][cli] Port getAllArgumentValues to the marshalling infrastructure

jansvoboda11 abandoned this revision. jansvoboda11 added a comment. Duplicate of D93679 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93699/new/ https://reviews.llvm.org/D93699 ___

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

aaron.ballman added a comment. In D93110#2460375 , @vsavchenko wrote: > In D93110#2458613 , @aaron.ballman > wrote: > >> Have you explored how this attribute will work with clang frontend >> diagnostics or clang-t

[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:264 + SmallVector DeadInsts; + SmallVector DeadBitcasts; + Maybe better to use BitCastInst? Comment at: llvm/lib/Target/X86/X86LowerAMXType.cpp:274 + if (

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Thank you for working on this, it's a problem that's annoyed me for a while but I've never found a satisfactory solution to. Unfortunately, it causes us to reject valid

[PATCH] D93703: [libTooling] Change `addInclude` to use expansion locs.

ymandel created this revision. ymandel added a reviewer: tdl-g. ymandel requested review of this revision. Herald added a project: clang. This patch changes the default range used to anchor the include insertion to use an expansion loc. This ensures that the location is valid, when the user relie

[PATCH] D93702: [clang][cli] NFC: Make marshalling macros reusable

jansvoboda11 updated this revision to Diff 313335. jansvoboda11 added a comment. Add newline at the end of file, simplify macro forwarding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93702/new/ https://reviews.llvm.org/D93702 Files: clang/lib/

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 313337. jansvoboda11 added a comment. Rebase, undo NFC changes. Replace the previous diagnostic option tagging system implemented in TableGen with less intrusive backend check. Extract prep patches. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313346. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:26-28 + // The first argument of an overloaded member operator is the implicit object + // argument of the method which s

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added a comment. I still need to figure out why Clang built in release mode replaces spaces in an error message by newlines and indents: $ ./build.noindex/debug/bin/clang -c clang/test/Driver/fmessage-length.c -fmessage-length=nan clang-12: error: invalid argu

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 313347. jansvoboda11 added a comment. Remove unnecessary if braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files: clang/include/clang/Basic/DiagnosticOpt

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

aqjune added a comment. In D93586#2467844 , @RKSimon wrote: > I'm sorry I've only just started looking at this - are you saying that you > want to handle all "insertelement undef" cases in one go and not just a > series of patcches after this one? It wi

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. @aaron.ballman I totally agree, but I also would like to understand. `__attribute__` is a GNU extension, right? Then why does it affect the grammar of C? I always thought that attributes should be somewhat transparent for parsers, but it looks like in this situatio

[PATCH] D91302: Handle template instantiations better in clang-tidy check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:56 +AST_MATCHER(Expr, usedInBooleanContext) { + std::string exprName = "__booleanContextExpr"; + auto result = Comment at:

[PATCH] D90670: Simplifying memory globalization from the front end to move optimizations to the middle end.

josemonsalve2 updated this revision to Diff 313352. josemonsalve2 added a comment. Modifying 3 more tests to reflect changes in this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90670/new/ https://reviews.llvm.org/D90670 Files: clang/lib/

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

aaron.ballman added a comment. In D93630#2468168 , @vsavchenko wrote: > @aaron.ballman I totally agree, but I also would like to understand. > `__attribute__` is a GNU extension, right? Correct. > Then why does it affect the grammar of C? I always thou

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313354. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:118 +/// behavior of clang-tidy. +virtual llvm::Optional +getCheckTraversalKind() const; aaron.ballman wrote: > steveire wrote: > > sammccall wrote: > > > I d

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

jasonliu added inline comments. Comment at: clang/include/clang/Sema/Sema.h:505 +// AlignPackInfo::getFromRawEncoding, it should not be inspected directly. +uint32_t getRawEncoding(const AlignPackInfo &Info) const { + std::uint32_t Encoding{}; this g

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko added a comment. In D93630#2468197 , @aaron.ballman wrote: > However, taking a step back -- what attributes would need this functionality > (and couldn't be written on something within the expression statement)? It is still good old `suppress

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313360. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

hvdijk added a comment. In D52050#2466874 , @glaubitz wrote: > However, that's not the same as whether we're on an x86_64 system or on an > x32 system determines which GNU triplet to use and which include and library > search paths are our primary ones.

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313361. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D93630: [Attr] Apply GNU-style attributes to expression statements

vsavchenko updated this revision to Diff 313362. vsavchenko added a comment. Maintain previous behavior unless preceeded by a statement attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93630/new/ https://reviews.llvm.org/D93630 Files: cla

[PATCH] D91303: Simplify implementation of container-size-empty

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp:56 - hasEitherOperand(ignoringImpCasts( - anyOf(integerLiteral(equals(1)), -

[PATCH] D91303: Simplify implementation of container-size-empty

steveire updated this revision to Diff 313370. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91303/new/ https://reviews.llvm.org/D91303 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D93586: [InstCombine] use poison as placeholder for undemanded elems

spatel added a comment. In D93586#2467248 , @aqjune wrote: >> There are 792 files in llvm/test, most of which are in test/Transform (119) >> and test/CodeGen(655). >> The transition will be swiftly done (if there's no other issue hopefully) by >> the nex

[PATCH] D93490: [clang-format] PR48539 ReflowComments breaks Qt translation comments

JVApen added a comment. In D93490#2467733 , @MyDeveloperDay wrote: > remove // = and // ~ cases Wouldn't it make sense to explicitly document that `//=` and `//~` are not put in here as reflowing them results in wrong results? CHANGES SINCE LAST ACTIO

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. As discussed in the OpenMP in LLVM call on December 9th, we should go ahead with this patch and add support for the missing features, e.g., dependent selectors, afterwards. LGTM Reposi

[PATCH] D91944: OpenMP 5.0 metadirective

jdoerfert added a comment. (Please make sure all clang and clang-tidy tests pass properly so we can merge the patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91944/new/ https://reviews.llvm.org/D91944

[PATCH] D91944: OpenMP 5.0 metadirective

ABataev added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:8383-8388 + DeclarationNameInfo DirName; + getDerived().getSema().StartOpenMPDSABlock(OMPD_metadirective, DirName, + nullptr, D->getBeginLoc()); + StmtResult R

[PATCH] D52050: [Driver] Fix architecture triplets and search paths for Linux x32

jrtc27 added a comment. In D52050#2466874 , @glaubitz wrote: > In D52050#2441164 , @glaubitz wrote: > >> In D52050#2441141 , @jrtc27 wrote: >> >>> What gets done currently fo

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. One more ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D91303: [clang-tidy] readability-container-size-empty: simplify implementation

steveire updated this revision to Diff 313381. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91303/new/ https://reviews.llvm.org/D91303 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchFinder.h:118 +/// behavior of clang-tidy. +virtual llvm::Optional +getCheckTraversalKind() const; steveire wrote: > aaron.ballman wrote: > > steveire wrote: > > >

[PATCH] D91302: Handle template instantiations better in clang-tidy check

steveire updated this revision to Diff 313385. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91302/new/ https://reviews.llvm.org/D91302 Files: clang-tools-extra/clang-tidy/readability/ContainerSizeEmptyCheck.cpp

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire updated this revision to Diff 313386. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80623/new/ https://reviews.llvm.org/D80623 Files: clang/include/clang/ASTMatchers/ASTMatchFinder.h clang/lib/ASTMatch

[clang] 85d4a4b - Revert "Fix memory leak complicated non-type template arguments."

Author: Arthur Eubanks Date: 2020-12-22T10:18:07-08:00 New Revision: 85d4a4bcc717a31ff40c4bd979dd6d78beb84b43 URL: https://github.com/llvm/llvm-project/commit/85d4a4bcc717a31ff40c4bd979dd6d78beb84b43 DIFF: https://github.com/llvm/llvm-project/commit/85d4a4bcc717a31ff40c4bd979dd6d78beb84b43.diff

[clang] ab7a60e - Revert "Fix MSVC "not all control paths return a value" warnings. NFCI."

Author: Arthur Eubanks Date: 2020-12-22T10:18:07-08:00 New Revision: ab7a60eb4100ab197665b86f682dad0e787a4fed URL: https://github.com/llvm/llvm-project/commit/ab7a60eb4100ab197665b86f682dad0e787a4fed DIFF: https://github.com/llvm/llvm-project/commit/ab7a60eb4100ab197665b86f682dad0e787a4fed.diff

  1   2   >