njames93 added a comment. In D84924#2466564 <https://reviews.llvm.org/D84924#2466564>, @aaron.ballman wrote:
> Agreed, but I don't think the current behavior in this patch is cautious > enough. I like that we have to specify "please apply fixits from notes" > explicitly. I think that's the right behavior we want. But if there are > multiple fixits attached to the notes for a diagnostic, I don't think we > should assume that the first fix-it is the correct one to apply -- I think > the user should have to manually pick the variant they want in that case. So > I think the behavior should be to apply the fixits from notes if there's only > a single fixit to be applied. WDYT? I can agree with that, One thing I like about using clangd is it will show you all available fixes, letting you pick and choose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84924/new/ https://reviews.llvm.org/D84924 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
