jansvoboda11 added inline comments.
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:176
+static auto makeFlagToValueNormalizer(T Value) {
+ return makeFlagToValueNormalizer(uint64_t(Value));
}
----------------
dexonsmith wrote:
> (not a behaviour change but) I wonder if this correct for signed types, where
> the conversion back to `T` could change sign if it's a negative value. Should
> there be an assertion that the value is `>= 0`? (Probably to do separately /
> outside this patch)
It might be good to be defensive here. I'll put that into a follow-up.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93628/new/
https://reviews.llvm.org/D93628
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
