[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

jansvoboda11 updated this revision to Diff 311134. jansvoboda11 added a comment. This revision is now accepted and ready to land. Add forgotten CC1Option check in parsing macro, extract denormalizer changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

Re: [clang] ea66410 - Revert "Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.""""

Hi Artem, Looks like this patch has some layer violations, I tried to fix that but there is a main issue not easy to fix -- the issue is that there is a cycle dependency: 1. PlistPathDiagnosticConsumer.cpp (now being moved to clangAnalysis target), and this file calls a method from clang::ASTUnit

[clang] 5663bf2 - Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis."

Author: Haojian Wu Date: 2020-12-11T10:16:13+01:00 New Revision: 5663bf201f5c444d6fb56fb1bd471bc53c17d837 URL: https://github.com/llvm/llvm-project/commit/5663bf201f5c444d6fb56fb1bd471bc53c17d837 DIFF: https://github.com/llvm/llvm-project/commit/5663bf201f5c444d6fb56fb1bd471bc53c17d837.diff LO

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 311137. nullptr.cpp added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp cla

[PATCH] D93008: [clang][cli] Do not marshall only CC1Option flags in BoolOption

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. @Bigcheese, can you please go through this again and let me know it it looks good to you now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93008/new/ https://reviews.ll

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

qiucf added a comment. In D92080#244 , @craig.topper wrote: > I don't think I understand the whole picture here. Why would only builtins > get mutated? Does a call to "modf" still call "modf"? But __builtin_modf will > call modf128? Is there a corre

[PATCH] D92298: [AST][RecoveryAST] Preserve type for member call expr if argments are not matched.

hokein updated this revision to Diff 311142. hokein marked an inline comment as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92298/new/ https://reviews.llvm.org/D92298 Files: clang/include/clang/S

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

sammccall added a comment. Thanks for doing this! Go-to-def-on-auto has been bugging me, it'll be great to have it :-) Overall the patch looks really solid, with nice tests. The one thing I'd suggest is splitting the two features (hover and go-to-def) into separate patches. e.g. here, I'm not t

[clang] 556e4eb - [AST][RecoveryAST] Preserve type for member call expr if argments are not matched.

Author: Haojian Wu Date: 2020-12-11T10:38:03+01:00 New Revision: 556e4eba4404acdc003ce344a62de846c0661be2 URL: https://github.com/llvm/llvm-project/commit/556e4eba4404acdc003ce344a62de846c0661be2 DIFF: https://github.com/llvm/llvm-project/commit/556e4eba4404acdc003ce344a62de846c0661be2.diff LO

[PATCH] D92298: [AST][RecoveryAST] Preserve type for member call expr if argments are not matched.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked 4 inline comments as done. Closed by commit rG556e4eba4404: [AST][RecoveryAST] Preserve type for member call expr if argments are not… (authored by hokein

[PATCH] D93094: [clang][cli] Prevent double denormalization

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. If both flags created through BoolOptio

[PATCH] D93094: [clang][cli] Prevent double denormalization

jansvoboda11 added inline comments. Comment at: clang/unittests/Frontend/CompilerInvocationTest.cpp:267 - ASSERT_THAT(GeneratedArgs, Contains(StrEq("-fdebug-pass-manager"))); + ASSERT_EQ(count(GeneratedArgs, "-fdebug-pass-manager"), 1); ASSERT_THAT(GeneratedArgs, Not(Conta

[clang-tools-extra] 38d32e4 - [clangd] Reorder the class field to avoid -Wreorder-ctor warning, NFC.

Author: Haojian Wu Date: 2020-12-11T10:46:54+01:00 New Revision: 38d32e4fd70cc2b1f6ec10b578a56e631e8ed658 URL: https://github.com/llvm/llvm-project/commit/38d32e4fd70cc2b1f6ec10b578a56e631e8ed658 DIFF: https://github.com/llvm/llvm-project/commit/38d32e4fd70cc2b1f6ec10b578a56e631e8ed658.diff LO

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn added a comment. In D92041#2446366 , @sammccall wrote: > Sorry for the delay here. Kadir is out on vacation. > > Yikes - it's a shame reusing our existing type printing doesn't do the right > thing, but injected-classname and partial specializations

[PATCH] D92041: [clangd] Add hover info for `this` expr

sammccall added a comment. In D92041#2448176 , @xndcn wrote: > In D92041#2446366 , @sammccall wrote: > >> Sorry for the delay here. Kadir is out on vacation. >> >> Yikes - it's a shame reusing our existing type prin

[PATCH] D80109: [AST][RecoveryExpr] Preserve type for broken member call expr.

hokein updated this revision to Diff 311148. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80109/new/ https://reviews.llvm.org/D80109 Files: clang/lib/Sema/SemaOverload.cpp clang/test/AST/ast-dump-recovery.cpp

[PATCH] D92041: [clangd] Add hover info for `this` expr

sammccall added a comment. Sorry, I didn't really address your question. I think the difficulty in making this a printingpolicy is that going from `type-parameter-0-0` to the spelled parameter is going from a canonical type to its alias, and isn't really possible in the general case, just in a

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

melver updated this revision to Diff 311157. melver added a comment. Check aliases exist in test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92846/new/ https://reviews.llvm.org/D92846 Files: clang/test/CodeGen/asan-globals-alias.cpp llvm/lib

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp updated this revision to Diff 311158. nullptr.cpp added a comment. Fix format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92936/new/ https://reviews.llvm.org/D92936 Files: clang/lib/Sema/SemaInit.cpp clang/lib/Sema/SemaStmt.cpp

[PATCH] D93101: [Clang][Codegen] Truncate initializers of union bitfield members

tmatheson created this revision. tmatheson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If an initial value is given for a bitfield that does not fit in the bitfield, the value should be truncated. Constant folding for expressions did no

[PATCH] D92846: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc28b18af1962: [KernelAddressSanitizer] Fix globals exclusion for indirect aliases (authored by melver). Repository: rG LLVM Github Monorepo CHANG

[clang] c28b18a - [KernelAddressSanitizer] Fix globals exclusion for indirect aliases

Author: Marco Elver Date: 2020-12-11T12:20:40+01:00 New Revision: c28b18af19621e6b5cca257ef7139ba93833df0c URL: https://github.com/llvm/llvm-project/commit/c28b18af19621e6b5cca257ef7139ba93833df0c DIFF: https://github.com/llvm/llvm-project/commit/c28b18af19621e6b5cca257ef7139ba93833df0c.diff L

[PATCH] D93102: [Clang][Sema] Detect section type conflicts between functions and variables

tmatheson created this revision. Herald added a reviewer: aaron.ballman. tmatheson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If two variables are declared with __attribute__((section(name))) and the implicit section types (e.g. read o

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92721/new/ https://reviews.llvm.org/D92721 __

[clang-tools-extra] 4c5e0c7 - Remove references to the ast_type_traits namespace

Author: Alexander Kornienko Date: 2020-12-11T12:39:33+01:00 New Revision: 4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed URL: https://github.com/llvm/llvm-project/commit/4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed DIFF: https://github.com/llvm/llvm-project/commit/4c5e0c7fd801ccc52d3b137fa685d4215a6c57ed

[PATCH] D93103: Enable the _ExtInt extension on the BPF Target

seanyoung created this revision. seanyoung added reviewers: erichkeane, jtmott-intel. seanyoung added a project: clang. seanyoung requested review of this revision. Herald added a subscriber: cfe-commits. I need to use _ExtInt on the BPF target. Simply switching it on seems to work fine. I'm a n

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

jansvoboda11 created this revision. jansvoboda11 added a reviewer: dexonsmith. Herald added a subscriber: dang. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit https://reviews.llvm.org/rGe5158b52730d323bb8cd2cba6dc6

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. In D87188#2447958 , @lebedev.ri wrote: > Just to be sure, i just run the entire compilation of `vc1_block-aarch64.c` > through alive2, and as far as i can tell, it did not report any IR-level > miscompilations. > So either the o

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 updated this revision to Diff 311166. jansvoboda11 added a comment. Rebase, migrate more options, switch to using BoolOption Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/inclu

[PATCH] D83979: [clang][cli] Port LangOpts option flags to new option parsing system

jansvoboda11 added a comment. This is now ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D87188: [InstCombine] Canonicalize SPF to abs intrinc

mstorsjo added a comment. FWIW, the issue is reproducible for an aarch64-linux-gnu target as well. If it would help someone, I could make a prepackaged build for that target, with object files + this single source function that breaks it + sample input files to run it with. Repository: rG L

[PATCH] D92936: [Sema] Fix deleted function problem in implicitly movable test

nullptr.cpp added a comment. Note: The failed test has nothing to do with this patch. Comment at: clang/lib/Sema/SemaInit.cpp:4146 CXXConstructorDecl *CtorDecl = cast(Best->Function); - if (Kind.getKind() == InitializationKind::IK_Default && - Entity.getType().isConstQ

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2442573 , @bader wrote: > In D89909#2439837 , @Anastasia wrote: > >> In D89909#2423750 , @bader wrote: >> It was mentioned that the

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 updated this revision to Diff 311182. jansvoboda11 added a comment. This revision is now accepted and ready to land. Rebase, fix tests and update them to use the new `-f[no-]legacy-pass-manager`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 updated this revision to Diff 311183. jansvoboda11 added a comment. Remove comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 Files: clang/unittests/Frontend/CompilerInvocationTest.cpp

[PATCH] D43002: [CodeView] Emit S_OBJNAME record

rnk added a comment. I think the biggest concern here is what to do about `/Fa` / `-save-temps`. If we do nothing, the S_OBJNAME record will change if you run the same compilation twice with and without those flags. Generally, we strive to ensure that the directly emitted object file is identic

[PATCH] D92954: [clang-offload-bundler] Add option -list

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:188 + + if (Error Err = Func()) +return Err; tra wrote: > Now, if we could save the triple in a `BundleInfo`

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 requested review of this revision. jansvoboda11 added a comment. @dexonsmith could you look at this again? I've now reworked the pass manager tests. They now work regardless of the `LLVM_ENABLE_NEW_PASS_MANAGER` value and use the new `-f[no-]legacy-pass-manager` flags. Repository:

[PATCH] D92954: [clang-offload-bundler] Add option -list

yaxunl updated this revision to Diff 311187. yaxunl marked 3 inline comments as done. yaxunl added a comment. Revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92954/new/ https://reviews.llvm.org/D92954 Files: clang/test/Driver/clang-offload-bundler.c clang

[PATCH] D92857: [clang][cli] Don't always emit -f[no-]experimental-new-pass-manager

jansvoboda11 updated this revision to Diff 311190. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92857/new/ https://reviews.llvm.org/D92857 Files: clang/unittests/Frontend/CompilerInvocationTest.cpp llvm/in

[PATCH] D92857: [clang][cli] [clang][cli] Don't always emit -f[no-]legacy-pass-manager

jansvoboda11 updated this revision to Diff 311193. jansvoboda11 added a comment. Extract default value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92857/new/ https://reviews.llvm.org/D92857 Files: clang/unittests/Frontend/CompilerInvocationTes

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko created this revision. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: aaron.ballman. vsavchenko requested review of this revision. Herald ad

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

jansvoboda11 updated this revision to Diff 311198. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92774/new/ https://reviews.llvm.org/D92774 Files: clang/unittests/Frontend/CompilerInvocationTest.cpp Index: c

[PATCH] D92857: [clang][cli] [clang][cli] Don't always emit -f[no-]legacy-pass-manager

jansvoboda11 updated this revision to Diff 311201. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92857/new/ https://reviews.llvm.org/D92857 Files: clang/unittests/Frontend/CompilerInvocationTest.cpp llvm/in

[PATCH] D93110: [analyzer] Implement a first version of suppressions via attributes

vsavchenko added a comment. Right now, I reused existing `suppress` attribute. However I did it in a rather unconventional manner. I allowed 0 arguments in one spelling and >1 in another, which seems odd. I can see a couple other possible solutions here: - Choose a "keyword" that would be use

[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

njames93 created this revision. njames93 added reviewers: sammccall, hokein. Herald added subscribers: usaxena95, kadircet, arphaman. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. We should be using enumMem

[PATCH] D85984: [analyzer] Add a new checker alpha.cplusplus.CPlusPlus11Lock

ASDenysPetrov added a comment. A gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85984/new/ https://reviews.llvm.org/D85984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

sammccall added a comment. Thanks! Most of the changes in this patch are to the internal infrastructure, which predates LSP semanticTokens and doesn't need to have names that match (in many cases the names don't closely match C++ convention). I think only the `toSemanticTokenType` change is need

[PATCH] D92782: [CodeGen][AMDGPU] Fix ICE for static initializer IR generation

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92782/new/ https://reviews.llvm.org/D92782

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

jansvoboda11 updated this revision to Diff 311208. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92775/new/ https://reviews.llvm.org/D92775 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

njames93 added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:51 Enum, - EnumConstant, + EnumMember, Typedef, sammccall wrote: > `HighlightingKind` is an internal enum that doesn't match LSP naming, so no > need for changes

[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

njames93 updated this revision to Diff 311215. njames93 marked an inline comment as done. njames93 added a comment. Remove changes to internal infrastructure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93113/new/ https://reviews.llvm.org/D93113

[PATCH] D93094: [clang][cli] Prevent double denormalization

jansvoboda11 updated this revision to Diff 311216. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93094/new/ https://reviews.llvm.org/D93094 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[PATCH] D83892: [clang][cli] Port CodeGen option flags to new option parsing system

jansvoboda11 updated this revision to Diff 311217. jansvoboda11 added a comment. Remove whitespace change, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83892/new/ https://reviews.llvm.org/D83892 Files: clang/include/clang/Driver/Options.

[PATCH] D92761: [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts

joechrisellis added reviewers: c-rhodes, aeubanks. joechrisellis added subscribers: aeubanks, c-rhodes. joechrisellis added a comment. Adding reviewers @c-rhodes and @aeubanks because `git blame` tells me they've touched the surrounding code. 🙂 Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] 62b4a69 - [clangd] Use enumMember instead of enumConstant

Author: Nathan James Date: 2020-12-11T14:46:13Z New Revision: 62b4a69969c38158ce0c49803c50c32a76bbbe14 URL: https://github.com/llvm/llvm-project/commit/62b4a69969c38158ce0c49803c50c32a76bbbe14 DIFF: https://github.com/llvm/llvm-project/commit/62b4a69969c38158ce0c49803c50c32a76bbbe14.diff LOG:

[PATCH] D93113: [clangd] Use enumMember instead of enumConstant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62b4a69969c3: [clangd] Use enumMember instead of enumConstant (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://reviews.llvm.org/D71726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84018: Port Preprocessor and PreprocessorOutput option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch, as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84018/new/ https://reviews.llvm.org/D

[PATCH] D92940: [X86] Convert fadd/fmul _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Thanks for bringing this refactor. I also verified that ICC and GCC both do reduce math in an binary tree way, though sometimes ICC has a different LSB from GCC and Clang. ==

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

qchateau updated this revision to Diff 311219. qchateau added a comment. - Remove the patches affecting hover - Add tests in ASTTests.cpp to test the behavior of getDeducedType for auto and decltype - Add missing comment - Create a locateSymbolForType function (which uses targetDecl) - Remove the

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. This is not functionally correct. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:9345 + return DAG.getBitcast(Op.getValueType(), SplatNode); +

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

yaxunl updated this revision to Diff 311225. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92720/new/ https://reviews.llvm.org/D92720 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/hip-unbundle-preproc.hip Index: clang/tes

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

qchateau marked 3 inline comments as done. qchateau added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:689 +const NamedDecl *D = Deduced->getTypePtr()->getAsTagDecl(); +if (!D) + continue; sammccall wrote: > there are m

[PATCH] D84018: Port Preprocessor and PreprocessorOutput option flags to new option parsing system

jansvoboda11 updated this revision to Diff 311226. jansvoboda11 added a comment. Rebase, undo unecessary move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84018/new/ https://reviews.llvm.org/D84018 Files: clang/include/clang/Driver/O

[PATCH] D84018: Port Preprocessor and PreprocessorOutput option flags to new option parsing system

jansvoboda11 added a reviewer: dexonsmith. jansvoboda11 added a comment. Ready for a review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84018/new/ https://reviews.llvm.org/D84018 ___ cfe-commits maili

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

yaxunl marked an inline comment as done. yaxunl added a comment. In D92720#2437621 , @tra wrote: > `-E` by default prints preprocessed output to stdout. CUDA will print > preprocessed output from all subcompilations. What does HIP do in this case? > Prin

[PATCH] D84188: Port FileSystem options to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84188/new/ https://reviews.llvm.org/D8

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Looks good, thanks again! If you don't yet have LLVM commit access, I can commit this for you, let me know which email address to associate it with. (https://llvm.org/docs/DeveloperPolicy

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps added a comment. In D84467#2423636 , @vsk wrote: > Thank you, lgtm! Thank you! I also would like to ask if you could commit it for me as I don't have access for that. Note that a handful of tests have binary files which were not uploaded wit

[PATCH] D92039: [-Wcalled-once-parameter] Introduce 'called_once' attribute

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1774 + let LangOpts = [ObjC]; + let Documentation = [Undocumented]; +} aaron.ballman wrote: > No new undocumented attributes, please. Su

[PATCH] D92854: [flang][driver] Add support for `-fsyntax-only`

awarzynski updated this revision to Diff 311231. awarzynski added a comment. Fine-tune the output for consistency with `flang`/`f18` This is just a minor change to make sure that: - `flang-new -fc1 -fsyntax-only`, and - `f18 -fparse-only` are as similar as possible. Repository: rG LLVM Gith

[clang-tools-extra] 8a4390d - Reland [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

Author: Sam McCall Date: 2020-12-11T17:34:53+01:00 New Revision: 8a4390dc4768fcd929a7231717980ccb28f124f7 URL: https://github.com/llvm/llvm-project/commit/8a4390dc4768fcd929a7231717980ccb28f124f7 DIFF: https://github.com/llvm/llvm-project/commit/8a4390dc4768fcd929a7231717980ccb28f124f7.diff LO

[PATCH] D92761: [clang][AArch64][SVE] Avoid going through memory for VLAT <-> VLST casts

aeubanks resigned from this revision. aeubanks added a comment. I'm unfamiliar with this code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92761/new/ https://reviews.llvm.org/D92761 ___ cfe-commits mail

[clang-tools-extra] 4d956af - Revert [clangd] Extract per-dir CDB cache to its own threadsafe class. NFC

Author: Sam McCall Date: 2020-12-11T17:35:50+01:00 New Revision: 4d956af594c5adc9d566d1846d86dd89c70c9c0b URL: https://github.com/llvm/llvm-project/commit/4d956af594c5adc9d566d1846d86dd89c70c9c0b DIFF: https://github.com/llvm/llvm-project/commit/4d956af594c5adc9d566d1846d86dd89c70c9c0b.diff LO

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

vsk added a comment. In D84467#2448934 , @alanphipps wrote: > In D84467#2423636 , @vsk wrote: > >> Thank you, lgtm! > > Thank you! I also would like to ask if you could commit it for me as I don't > have access for

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

qchateau updated this revision to Diff 311247. qchateau marked an inline comment as done. qchateau added a comment. - Reintroduce test with a FIXME comment - locateSymbolForType returns a vector instead of an optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D92977: [clangd] Improve hover and goToDefinition on auto and dectype

qchateau added a comment. I've updated the patch with your latest comments. Please commit this patch for me, using "quentin.chat...@gmail.com", I'll probably ask for commit access after a few successful reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D84467: Add support for Branch Coverage in LLVM Source-Based Code Coverage

alanphipps added a comment. In D84467#2449045 , @vsk wrote: > Unfortunately I don't think I'll be able to commit this on your behalf. Would > you be open to obtaining commit access from Chris and landing this directly? > I ask because, for a patch of thi

[PATCH] D93023: Replace deprecated %T in 2 tests.

MaskRay added a comment. My build directory is `/tmp/RelA`. After `sudo apt install gcc-10-riscv64-linux-gnu`, % /tmp/RelA/bin/llvm-lit -vv riscv32-toolchain-extra.c ... Exit Code: 1 Command Output (stderr): -- /home/ray/llvm/clang/test/Driver/riscv32-toolchain-extra.c:28:34: erro

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn updated this revision to Diff 311256. xndcn added a comment. Thank you, it works like a charm! For class withou template, `getHoverInfo(QualType ...)` will add namespace scope by default, so I have to add `SuppressScope` printpolicy here. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D93084: [VE] Optimize toolchain regression test

MaskRay added a comment. LG. I don't have a system VE toolchain and the tests still pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 ___ cfe-commits mailing

[PATCH] D93084: [VE] Optimize toolchain regression test

MaskRay added inline comments. Comment at: clang/test/Driver/ve-toolchain.cpp:115 +// DEF-SAME: "-z" "max-page-size=0x400" +// DEF-SAME: "crtbegin.o" +// DEF-SAME: "-lc++" "-lc++abi" "-lunwind" "-lpthread" "-ldl" You probably should add an empty file in `basi

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov added a comment. @steakhal Thank you for your invaluable analysis! > What do you think @ASDenysPetrov ? I think if there is any difference then I have to inspect the changes deeper. I tryed to make this changes in a way of not changing any behaviour. Let me back to this patch a bi

[clang-tools-extra] 709112b - [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

Author: Zinovy Nis Date: 2020-12-11T21:09:51+03:00 New Revision: 709112bce4424a5436f0bb699c62b3fbc837fbb6 URL: https://github.com/llvm/llvm-project/commit/709112bce4424a5436f0bb699c62b3fbc837fbb6 DIFF: https://github.com/llvm/llvm-project/commit/709112bce4424a5436f0bb699c62b3fbc837fbb6.diff LO

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

This revision was automatically updated to reflect the committed changes. Closed by commit rG709112bce442: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of… (authored by zinovy.nis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

craig.topper added a comment. In D92080#2448094 , @qiucf wrote: > In D92080#244 , @craig.topper > wrote: > >> I don't think I understand the whole picture here. Why would only builtins >> get mutated? Does a c

[PATCH] D85788: [Clang test] Update to allow passing extra default clang arguments in use_clang

aqjune added a comment. In D85788#2444136 , @guiand wrote: > IMO it's better to just one-and-done programatically add `-Xclang > -disable-noundef-analysis` to all the tests' RUN lines. That way there are no > hidden flags. If a script for this can be wr

Re: [clang] ea66410 - Revert "Revert "Revert "Revert "[analyzer] NFC: Move path diagnostic consumer implementations to libAnalysis.""""

Hmm, indeed, thanks for reverting, i'll get this fixed. Weird that i'm not getting any compile errors locally or from buildbots. Shared libs buildbots are usually very loud about this stuff. On 12/11/20 12:51 AM, Haojian Wu wrote: Hi Artem, Looks like this patch has some layer violations, I

[PATCH] D84188: Port FileSystem options to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84188/new/ https://reviews.llvm.org/D84188 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D84018: [clang][cli] Port Preprocessor and PreprocessorOutput option flags to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84018/new/ https://reviews.llvm.org/D84018

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

NoQ added inline comments. Comment at: clang/lib/Analysis/PlistPathDiagnosticConsumer.cpp:993 MacroLoc = LocAndUnit->first; PPToUse = &LocAndUnit->second->getPreprocessor(); } We were reverted because there's still a dependency on `ASTUnit` which liv

[PATCH] D93134: [FPEnv] Teach the IRBuilder about invoke's correct use of the strictfp attribute.

kpn created this revision. kpn added reviewers: spatel, rjmccall, andrew.w.kaylor, mibintc, sepavloff. kpn requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Similar to D69312 , and documented

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies marked 4 inline comments as done. ffrankies added a comment. @aaron.ballman Thank you! If there are no further comments, could you please commit this on my behalf? My GitHub username is ffrankies . Comment at: clang-tools-extra/clang-t

[PATCH] D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis.

steakhal added inline comments. Comment at: clang/lib/Analysis/PlistPathDiagnosticConsumer.cpp:993 MacroLoc = LocAndUnit->first; PPToUse = &LocAndUnit->second->getPreprocessor(); } NoQ wrote: > We were reverted because there's still a dependency on `

[PATCH] D92160: [clang] Fix wrong FDs are used for files with same name in Tooling

dexonsmith added a comment. In D92160#2447861 , @OikawaKirie wrote: > Replies from the original author Hao Zhang > > llvm::ErrorOr > FileManager::getFile(StringRef Filename, bool openFile, bool CacheFailure) { > // Froce using the absolute path to

[PATCH] D91261: [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives.

cchen accepted this revision. cchen added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91261/new/ https://reviews.llvm.org/D91261 ___ cf

[PATCH] D92427: [OPENMP51] Add present modifier in defaultmap clause

cchen added inline comments. Comment at: clang/test/OpenMP/target_defaultmap_codegen_01.cpp:1523 -// CK26-DAG: [[SIZES:@.+]] = {{.+}}constant [3 x i64] [i64 4096, i64 4, i64 {{.+}}] +// CK26-DAG: [[SIZES:@.+]] = {{.+}}constant [3 x i64] [i64 4, i64 4096, i64 {{.+}}] // Map t

[clang] 7b3470b - Consider reference, pointer, and pointer-to-member TemplateArguments to be different if they have different types.

Author: Richard Smith Date: 2020-12-11T13:26:33-08:00 New Revision: 7b3470baf8bab1919e3ad4c18e2b776c1f7be2d5 URL: https://github.com/llvm/llvm-project/commit/7b3470baf8bab1919e3ad4c18e2b776c1f7be2d5 DIFF: https://github.com/llvm/llvm-project/commit/7b3470baf8bab1919e3ad4c18e2b776c1f7be2d5.diff

[PATCH] D91488: Consider reference, pointer, and pointer-to-membber TemplateArguments to be different if they have different types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b3470baf8ba: Consider reference, pointer, and pointer-to-member TemplateArguments to be… (authored by rsmith). Repository: rG LLVM Github Monorep

  1   2   >