steakhal added inline comments.
================
Comment at: clang/lib/Analysis/PlistPathDiagnosticConsumer.cpp:993
MacroLoc = LocAndUnit->first;
PPToUse = &LocAndUnit->second->getPreprocessor();
}
----------------
NoQ wrote:
> We were reverted because there's still a dependency on `ASTUnit` which lives
> in `libFrontend`. I guess i'll simplify the virtual method to return
> `(MacroLoc, PPToUse)` directly (?) (the old method will still remain on
> `CrossTranslationUnitContext`).
I don't see much uses of this function in the codebase. Why do you think it
worth keeping it?
As a side-note, I'm planning to upstream some serious changes in macro
expansion handling. Which will change the highlighted parts, probably resolving
this circular dependency too.
Let me polish my work, and expect the patch on monday or tuesday.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92432/new/
https://reviews.llvm.org/D92432
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
