njames93 added inline comments.
================ Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:51 Enum, - EnumConstant, + EnumMember, Typedef, ---------------- sammccall wrote: > `HighlightingKind` is an internal enum that doesn't match LSP naming, so no > need for changes there. It doesn't strictly need it, But I do like the consistency of it being EnumMember throughout. I'll revert though as its not essential. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93113/new/ https://reviews.llvm.org/D93113 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
