MaskRay added inline comments.
================ Comment at: clang/test/Driver/ve-toolchain.cpp:115 +// DEF-SAME: "-z" "max-page-size=0x4000000" +// DEF-SAME: "crtbegin.o" +// DEF-SAME: "-lc++" "-lc++abi" "-lunwind" "-lpthread" "-ldl" ---------------- You probably should add an empty file in `basic_ve_tree` so that users who don't have a system ve toolchain (most upstream developers) have `"...basic_ve_tree/...crtbegin.o"` instead of `"crtbegin.o"` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
