[PATCH] D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding

gribozavr2 added inline comments. Comment at: clang/include/clang/AST/CommentLexer.h:244 + /// command, including command marker. + SmallString<16> VerbatimBlockEndCommandName; + I'm not a fan of this change to `Lexer` because it breaks the grouping of fields:

[PATCH] D90014: [clangd] Add support for multiple DecisionForest model experiments.

usaxena95 updated this revision to Diff 300582. usaxena95 added a comment. Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90014/new/ https://reviews.llvm.org/D90014 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-tools-extra

[PATCH] D88790: [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

nridge added a comment. Review ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88790/new/ https://reviews.llvm.org/D88790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D90134: [clangd] Increase the TooMany limit for index-based textual navigation to 5

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. nridge requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Repository: rG LLVM Github Monorepo

[PATCH] D90134: [clangd] Increase the TooMany limit for index-based textual navigation to 5

nridge added a comment. My experience using this feature in real codebases has been that we take this early-exit too often; the limit of 3 is fairly easy to hit due to things like layers of wrappers that repeat a function name. Bumping the limit to 5 has increased the usefulness for me. Repos

[PATCH] D78784: [clangd] Add some logging to explain why textual fallback navigation failed

nridge abandoned this revision. nridge added a comment. Abandoning as per discussion. Running this locally has led me to propose D90134 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78784/new/ https://reviews.llv

[PATCH] D90133: clang-format: Allow fallback-style to take formatting arguments

Chizi123 updated this revision to Diff 300586. Chizi123 added a comment. Accidentally added patch to commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90133/new/ https://reviews.llvm.org/D90133 Files: clang/lib/Format/Format.cpp Index: clang/lib/Format/Format.cpp ===

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

mzh updated this revision to Diff 300587. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.llvm.org/D90130 Files: clang/tes

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

mzh marked 2 inline comments as done. mzh added a comment. Thanks @dvyukov All done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.llvm.org/D90130 ___ cfe-commits mailing list

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

mzh updated this revision to Diff 300588. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.llvm.org/D90130 Files: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp compiler-rt/lib/sanitizer_common/sanitizer_platform.h

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

dvyukov added a comment. This now looks like a patch for some other change :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.llvm.org/D90130 ___ cfe-commits mailing list cfe-com

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

mzh added a comment. In D90130#2352826 , @dvyukov wrote: > This now looks like a patch for some other change :) Sorry! It's my first time with llvm patch submission. I think it's ok now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

nikic added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1439 if (CodeGenOpts.OptimizationLevel == 0) { + PB.runRegisteredEPCallbacks(MPM, Level, CodeGenOpts.DebugPassManager); + It should be possible to simplify this function a lot no

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

dvyukov accepted this revision. dvyukov added a comment. This revision is now accepted and ready to land. Looks good to me. Do you want me to merge this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.llvm.org/D9013

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein updated this revision to Diff 300590. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89946/new/ https://reviews.llvm.org/D89946 Files: clang/lib/Sema/SemaOve

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12814 // end up here. return SemaRef.BuildCallExpr(/*Scope*/ nullptr, NewFn.get(), LParenLoc, MultiExprArg(Args.data(), Args.size()), sammccall wrote:

[PATCH] D88790: [libTooling] Recognize sccache as a compiler wrapper in compilation database commands

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Sorry about missing this... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88790/new/ https://reviews.llvm.org/D88790

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! LG with comment nit Comment at: clang/lib/Sema/SemaOverload.cpp:12808 + // using RecoveryExpr. + return SemaRef.CreateRecoveryExpr(CallE.get()->getBeginLoc(),

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

krasimir added a comment. This looks reasonable. I'm curious about DiagnosticsEngine: previously we were using the defaults for `client` and `ShouldOwnClient` ctor params (`nullptr` and `true`). If this usage leads to crashes, isn't the issue in `DiagnosticsEngine` itself? Repository: rG LL

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

mzh added a comment. In D90130#2352831 , @dvyukov wrote: > Looks good to me. > Do you want me to merge this change? Sure, Thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.

[PATCH] D90134: [clangd] Increase the TooMany limit for index-based textual navigation to 5

kadircet added a comment. > My experience using this feature in real codebases has been that we take this > early-exit too often; the limit of 3 is fairly easy to hit due to things like > layers of wrappers that repeat a function name. Bumping the limit to 5 has > increased the usefulness for m

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kkleine added a comment. @dblaikie sorry for the late feedback. The `LLVM_ENABLE_WERROR:BOOL` will "Stop and fail the build, if a compiler warning is triggered. Defaults to OFF." I wonder if any other test fails from clang tidy because. My test explicitly checks that a warning is issued (e.g. `

[PATCH] D89942: Disable LTO and LLD for bootstrap builds on systems unsupported by LLD

serge-sans-paille added inline comments. Comment at: clang/CMakeLists.txt:668 +message(STATUS "Using system linker for stage3 builds on Apple") +set(BOOTSTRAP_LLVM_ENABLE_LLD OFF CACHE BOOL "") + else() Should you also disable LTO here? Repository: r

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein updated this revision to Diff 300601. hokein marked an inline comment as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89946/new/ https://reviews.llvm.org/D89946 Files: clang/lib/Sema/SemaOv

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12808 + // using RecoveryExpr. + return SemaRef.CreateRecoveryExpr(CallE.get()->getBeginLoc(), +CallE.get()->getEndLoc(), {CallE.get()}); sammccall wro

[clang] d3205bb - [Annotation] Allows annotation to carry some additional constant arguments.

Author: Tyker Date: 2020-10-26T10:50:05+01:00 New Revision: d3205bbca3e0002d76282878986993e7e7994779 URL: https://github.com/llvm/llvm-project/commit/d3205bbca3e0002d76282878986993e7e7994779 DIFF: https://github.com/llvm/llvm-project/commit/d3205bbca3e0002d76282878986993e7e7994779.diff LOG: [A

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3205bbca3e0: [Annotation] Allows annotation to carry some additional constant arguments. (authored by Tyker). Changed prior to commit: https://re

[PATCH] D90140: [clang][RecoveryExpr] Add tests for ObjectiveC.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. to demonstrate it works for some cases. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90140 Files: clang/test/AST/ast-dump-recovery.m

[PATCH] D89936: clang-tidy: adding "--clang-tidy-config=" to specify custom config file

DmitryPolukhin added a comment. I'm not sure that we need additional option to read configuration from file but, if we do need, I think this diff needs some improvements + test for new option. Comment at: clang-tools-extra/clang-tidy/ClangTidyOptions.cpp:324 +llvm::sys::f

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

sammccall added a comment. This isn't the only place where we use such characters. While I'm not sure spelling these literally is a hill we want to die on, I think u8 literals are so poorly understood that trying to do this consistently isn't going to be that simple. As noted, clang is always

[PATCH] D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding

njames93 updated this revision to Diff 300622. njames93 added a comment. Keep VerbatimBlockEndCommandName after LexerState while preserving smaller size Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90127/new/ https://reviews.llvm.org/D90127 Files

[PATCH] D88645: [Annotation] Allows annotation to carry some additional constant arguments.

thakis added a comment. Looks like this broke tests: http://45.33.8.238/linux/31159/step_12.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88645/new/ https://reviews.llvm.org/D8

[PATCH] D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding

njames93 added inline comments. Comment at: clang/include/clang/AST/CommentLexer.h:244 + /// command, including command marker. + SmallString<16> VerbatimBlockEndCommandName; + gribozavr2 wrote: > I'm not a fan of this change to `Lexer` because it breaks the gr

[PATCH] D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding

njames93 updated this revision to Diff 300623. njames93 added a comment. Fix field initialisation order in constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90127/new/ https://reviews.llvm.org/D90127 Files: clang/include/clang/AST/Commen

[PATCH] D89748: SourceManager: Use the same fake SLocEntry whenever it fails to load

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89748/new/ https://reviews.llvm.org/D89748 ___ cfe-commits mailing list cfe-comm

[PATCH] D80499: Remove obsolete ignore*() matcher uses

alexfh added a comment. In D80499#2352339 , @steveire wrote: > @alexfh This change is based on the behavior of AST Matchers being changed to > ignore invisible/implicit AST nodes by default. As the default was not > changed in the end, this patch would n

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 300629. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 300630. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files: clang/include/clang/AST/ASTNodeTraverser.h clang/include/clang/AST/

[PATCH] D90130: Add mips64 support in lib/tsan/go/buildgo.sh

dvyukov closed this revision. dvyukov added a comment. Landed in https://github.com/llvm/llvm-project/commit/5cad535ccfebf9b41a57cf2788d8de7a765f7f35 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90130/new/ https://reviews.llvm.org/D90130 ___

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGefa9aaad703e: [clang] Suppress "follow-up" diagnostics on recovery call expressions. (authored by hokein). Repository: rG LLVM Github Monorepo CH

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

dmikis added a comment. > If this usage leads to crashes, isn't the issue in DiagnosticsEngine itself? I don't know design intent behind `DiagnosticsEngine`. As far as I can understand from source code it doesn't try to create any consumers by itself yet requires one to be provided (there're as

[clang] efa9aaa - [clang] Suppress "follow-up" diagnostics on recovery call expressions.

Author: Haojian Wu Date: 2020-10-26T12:40:00+01:00 New Revision: efa9aaad703e6b150980ed1a74b4e7c9da7d85a2 URL: https://github.com/llvm/llvm-project/commit/efa9aaad703e6b150980ed1a74b4e7c9da7d85a2 DIFF: https://github.com/llvm/llvm-project/commit/efa9aaad703e6b150980ed1a74b4e7c9da7d85a2.diff LO

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

njames93 added a comment. In D80531#2352944 , @kkleine wrote: > @dblaikie sorry for the late feedback. The `LLVM_ENABLE_WERROR:BOOL` will > "Stop and fail the build, if a compiler warning is triggered. Defaults to > OFF." I wonder if any other test fails

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kkleine added a comment. @njames93 I could do that but the original Macros had were defined without a semicolon at the end and one had to add it manually. See this revision in which I replaced some occurrences of `DISALLOW_COPY_AND_ASSIGN`: eaebcbc67926a18befaa297f1778edde63baec9b

[clang] e499186 - [clang-fuzzer] CreateAndRunJITFunc - fix use after move static analyzer warning.

Author: Simon Pilgrim Date: 2020-10-26T12:24:18Z New Revision: e4991867fb5ace434640bfacfd28720ad031d33c URL: https://github.com/llvm/llvm-project/commit/e4991867fb5ace434640bfacfd28720ad031d33c DIFF: https://github.com/llvm/llvm-project/commit/e4991867fb5ace434640bfacfd28720ad031d33c.diff LOG:

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

njames93 added a comment. In D80531#2353314 , @kkleine wrote: > @njames93 I could do that but the original Macros had were defined without a > semicolon at the end and one had to add it manually. See this revision in > which I replaced some occurrences o

[PATCH] D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly.

kiranchandramohan added a comment. This change probably requires the X86 target. // REQUIRES: x86-registered-target Builds which target AArch64 only have been failing due to this change. http://lab.llvm.org:8011/#/builders/32/builds/291 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D33029: [clang-format] add option for dangling parenthesis

catskul added a comment. @MyDeveloperDay I'm going to upload a re-based version of this. Should I rebase it off the top of master? Tip of 11? and/or create a new diff/review for each? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llvm.org/D33029

[PATCH] D33029: [clang-format] add option for dangling parenthesis

catskul added inline comments. Comment at: include/clang/Format/Format.h:793 + /// \endcode + bool DanglingParenthesis; + stringham wrote: > djasper wrote: > > stringham wrote: > > > djasper wrote: > > > > I don't think this is a name that anyone will intuitive

[PATCH] D88913: [FPEnv] Use strictfp metadata in casting nodes

sepavloff added a comment. Generally the patch looks good. But the need to expect incorrect values in tests is a concern. Maybe this is a consequence of storing exception behavior in a separate field of CGFPOptionsRAII. This misbehavior should be fixed. Comment at: clang/test

[clang-tools-extra] 58d0ef2 - [clangd] Fix remote index build failures due to lack of proto dependency

Author: Kirill Bobyrev Date: 2020-10-26T14:14:47+01:00 New Revision: 58d0ef2d0466a893ab400f6a9829057b9d851038 URL: https://github.com/llvm/llvm-project/commit/58d0ef2d0466a893ab400f6a9829057b9d851038 DIFF: https://github.com/llvm/llvm-project/commit/58d0ef2d0466a893ab400f6a9829057b9d851038.diff

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire added a comment. Many of the changes which were part of a previous iteration of this change were related to the change of default behavior of matchers. As the default is no longer changed, those changes fell away. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

miyuki added inline comments. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1088 + ID.Add(Range.getEnd()); + ID.Add(static_cast(Loc)); } dexonsmith wrote: > I'm surprised you need this `static_cast`, can you explain why it was > necessary? `Loc` is an obj

[PATCH] D90127: [clang][NFC] Rearrange Comment Token and Lexer fields to reduce padding

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/CommentLexer.h:74 /// contains the length of the string that starts at TextPtr. unsigned IntVal; Coul

[PATCH] D90116: [clangd] Escape Unicode characters to fix Windows builds

kbobyrev added a comment. Hmm, I see. From the looks of it, the solution for several projects would be add_compile_options("$<$:/utf-8>") add_compile_options("$<$:/utf-8>") But I'm not sure if it makes sense in our case and I don't see many `add_compile_options` in LLVM. Also, I don't have

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev updated this revision to Diff 300660. kbobyrev added a comment. Only drop the bits about "they're all considered methods", update XRefs.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89935/new/ https://reviews.llvm.org/D89935 Files:

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

kbobyrev updated this revision to Diff 300661. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89935/new/ https://reviews.llvm.org/D89935 Files: clang-tools-extra/clangd/FindSymbols.cpp clang-to

[clang-tools-extra] 1704704 - [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

Author: Kirill Bobyrev Date: 2020-10-26T15:31:59+01:00 New Revision: 1704704e762f232e827849ee881ebe74b5db7ef1 URL: https://github.com/llvm/llvm-project/commit/1704704e762f232e827849ee881ebe74b5db7ef1 DIFF: https://github.com/llvm/llvm-project/commit/1704704e762f232e827849ee881ebe74b5db7ef1.diff

[PATCH] D89935: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1704704e762f: [clangd] NFC: Update FIXME comment regarding lack of c/dtor support (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHA

[PATCH] D90140: [clang][RecoveryExpr] Add tests for ObjectiveC.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/AST/ast-dump-recovery.m:8 +void k(Foo *foo) { + // CHECK: ObjCMessageExpr {{.*}} 'void' contains-errors + // CHECK-CHECK: |-Implicit

[PATCH] D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions.

sammccall added a comment. Still LG thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89946/new/ https://reviews.llvm.org/D89946 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

sammccall updated this revision to Diff 300674. sammccall marked an inline comment as done. sammccall added a comment. Style changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90023/new/ https://reviews.llvm.org/D90023 Files: clang/include/cl

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:157-184 + /// Iterator over children (common base for const/non-const). + /// Not invalidated by tree mutations (holds a stable node pointer). + template + class child_iterator_base +

[PATCH] D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, steakhal, krememek, xazax.hun. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. A

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin marked an inline comment as done. DiggerLin added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames =

[PATCH] D89055: [analyzer] Wrong type cast occures during pointer dereferencing after type punning

ASDenysPetrov added a comment. In D89055#2336709 , @NoQ wrote: > Ugh, sorry, no, that's `evalCast()`. Like `evalBinOp()` etc. My bad. Can we > also use `evalCast()`? I dived into `evalCast()`. Initially I had to figure it out and rework it to find the r

[clang] 32efb81 - [analyzer] [NFC] Simplify SVal::getAsLocSymbol function using existing functions

Author: Denys Petrov Date: 2020-10-26T17:00:29+02:00 New Revision: 32efb81ea60a9e99571923bf9308598f6cd341f2 URL: https://github.com/llvm/llvm-project/commit/32efb81ea60a9e99571923bf9308598f6cd341f2 DIFF: https://github.com/llvm/llvm-project/commit/32efb81ea60a9e99571923bf9308598f6cd341f2.diff

[PATCH] D89982: [analyzer] [NFC] Simplify SVal::getAsLocSymbol function using existing functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32efb81ea60a: [analyzer] [NFC] Simplify SVal::getAsLocSymbol function using existing functions (authored by ASDenysPetrov). Repository: rG LLVM Gi

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

teemperor added a subscriber: v.g.vassilev. teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Maybe arc didn't correctly apply the patch, but this causes a few LLDB tests to fail on my machine: lldb-api :: commands/expressi

[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas requested review of this revision. Provide an iterator for `List` that iterates through elements and delimiters on pairs. This iterator is robust to missing elements. For instance,

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

v.g.vassilev added a comment. Thanks for the patch!! This is a super hot place for us (mostly due to boost). I will try it on our end and let you know! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89749/new/ https://reviews.llvm.org/D89749

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

emankov added a comment. D89832 eliminates 47332 on Windows as well. Tested against the same CUDA versions as for D89752 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:182 +/// The element, or nullptr if past-the-end. +NodeT *asPointer() const { return N; } + };

[PATCH] D69844: [clang][Basic] Integrate SourceLocation with FoldingSet, NFCI

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Analysis/PathDiagnostic.cpp:1088 + ID.Add(Range.getEnd()); + ID.Add(static_cast(Loc)); } miyuki wrote: > dexonsmith wr

[PATCH] D90163: [Syntax] Disallow invalid Node operations

sammccall created this revision. sammccall added reviewers: gribozavr, eduucaldas. Herald added a project: clang. Herald added a subscriber: cfe-commits. sammccall requested review of this revision. Copy/move break invariants (move could be fixed). Node/Tree should have no public constructors, the

[PATCH] D90165: Clang is crashing after generating the right diagnostic for a re-declaration of a friend method - Fix for PR47544.

zahiraam created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. zahiraam requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D90165 Files: clang/lib/Parse/ParseCXXInlineMethods.cpp clang/test/SemaCXX/invalid

[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

gribozavr2 added a comment. Could you add tests that verify the pairing of elements and delimiters? Comment at: clang/include/clang/Tooling/Syntax/Tree.h:214 + /// elements and delimiters are represented as null pointers. Below we give + /// examples of what this iteration wo

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:182 +/// The element, or nullptr if past-the-end. +NodeT *asPointer() const { return N; } + }; gribozavr2 wrote: > "nodePoi

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

sammccall updated this revision to Diff 300691. sammccall marked an inline comment as done. sammccall added a comment. Simplify ConstChildIterator cross-constructor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90023/new/ https://reviews.llvm.org/D

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

dexonsmith planned changes to this revision. dexonsmith added a comment. In D89749#2353651 , @v.g.vassilev wrote: > Thanks for the patch!! This is a super hot place for us (mostly due to > boost). I will try it on our end and let you know! Great! In D8

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:182 +/// The element, or nullptr if past-the-end. +NodeT *asPointer() const { return N; } + }; sammccall wrote: > gribozavr2 wrote: > > "nodePointer()" ? > I find thi

[PATCH] D89158: [NewPM] Run all EP callbacks under -O0

aeubanks added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1439 if (CodeGenOpts.OptimizationLevel == 0) { + PB.runRegisteredEPCallbacks(MPM, Level, CodeGenOpts.DebugPassManager); + nikic wrote: > It should be possible to simplify this

[PATCH] D90023: [Syntax] Add iterators over children of syntax trees.

eduucaldas accepted this revision. eduucaldas added a comment. Thanks for the instructive replies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90023/new/ https://reviews.llvm.org/D90023 ___ cfe-commits

[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

eduucaldas marked an inline comment as done. eduucaldas added a comment. In D90161#2353736 , @gribozavr2 wrote: > Could you add tests that verify the pairing of elements and delimiters? Those are surfaced through the previous tests, via `getElementsAsNod

[PATCH] D89832: [CUDA] Extract CUDA version from cuda.h if version.txt is not found

tra closed this revision. tra added a comment. Landed in rGe7fe125b776b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89832/new/ https://reviews.llvm.org/D89832 __

[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

eduucaldas updated this revision to Diff 300696. eduucaldas added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90161/new/ https://reviews.llvm.org/D90161 Files: clang/include/clang/Tooling/Syntax/Tree.h clang/unittests

[PATCH] D88106: [SyntaxTree] Provide iterator-like functions for Lists

eduucaldas abandoned this revision. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Tree.h:252 + Kind = IteratorKind::NotSentinel; + if (isElement(Begin)) +Current = getWithDelimiter(cast(Begin)); Sin

[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

sammccall added a comment. (I started to review this, but now the current diff has only your changes against the first diff, rather than against master - can you upload a new diff?) Comment at: clang/include/clang/Tooling/Syntax/Tree.h:231 + /// `ElementAndDelimiter` acts as

[PATCH] D89488: FileManager: Shrink FileEntryRef to the size of a pointer

arphaman added inline comments. Comment at: clang/lib/Basic/FileManager.cpp:217 FileEntry *FE; -if (LLVM_LIKELY(FE = Value.dyn_cast())) - return FileEntryRef(SeenFileInsertResult.first->first(), *FE); -return getFileRef(*Value.get(), openFile, CacheFailure); +

[PATCH] D89498: HeaderSearch: Simplify use of FileEntryRef in HeaderSearch::LookupFile, NFC

dexonsmith added a comment. I committed this on Friday as 74910cbbd8d1df824ab1d5e742c50641d0fee907 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89498/new/ https://reviews.llvm.org/D89498 __

[PATCH] D89749: SourceManager: Don't allocate an SLocEntry until it's loaded

teemperor added a comment. >> The tests are just loading a Clang module and then trying to import some >> Decls into another ASTContext, so I don't think the error here is specific >> to LLDB. We just don't have any ASTImporter tests that exercise modules. > > I'll add one. I'm actually not eve

[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

eduucaldas updated this revision to Diff 300702. eduucaldas added a comment. Diff against master, sorry about that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90161/new/ https://reviews.llvm.org/D90161 Files: clang/include/clang/Tooling/Syntax

[PATCH] D90079: Avoid unnecessary uses of `MDNode::getTemporary`, NFC

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. The `push_back(nullptr)` reads weird to me, but it is an accurate reflection of what the IR will look like. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90079/new/ https://reviews

[PATCH] D90054: Added remotely ran compiler-rt tests.

aorlov updated this revision to Diff 300708. aorlov added a comment. Disable compiler-rt crt tests for cross ARM builders since the tests are broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90054/new/ https://reviews.llvm.org/D90054 Files:

[clang] c686dfd - Unconfuse gcc5.3 after 2e204e23911b1f / D87528

Author: Nico Weber Date: 2020-10-26T12:55:38-04:00 New Revision: c686dfd61705f33419875b22eb08bd197a72cd18 URL: https://github.com/llvm/llvm-project/commit/c686dfd61705f33419875b22eb08bd197a72cd18 DIFF: https://github.com/llvm/llvm-project/commit/c686dfd61705f33419875b22eb08bd197a72cd18.diff LO

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In the RFC it has been discussed to either use target address spaces or perhaps to introduce a new attribute to reflect a semantic needed for SYCL, but it seems to me in this change you are building on top of the existing language address space attribute with new entr

[PATCH] D90161: [SyntaxTree] Provide iterators for Lists

sammccall added a comment. This seems like more implementation and API complexity than is justified by the problems it's solving. I do think it's possible to drastically simplify it (I've left some suggestions here) but if not, I think we should move it to its own header. Com

[clang] dd7095f - [clang][unittest] Don't hardcode the string "Assertion"

Author: Benjamin Kramer Date: 2020-10-26T18:10:56+01:00 New Revision: dd7095f52bda36e0f3cd37574a1cb97c7a46cffe URL: https://github.com/llvm/llvm-project/commit/dd7095f52bda36e0f3cd37574a1cb97c7a46cffe DIFF: https://github.com/llvm/llvm-project/commit/dd7095f52bda36e0f3cd37574a1cb97c7a46cffe.dif

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

jasonliu added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:520 Options.DataSections = CodeGenOpts.DataSections; - Options.IgnoreXCOFFVisibility = CodeGenOpts.IgnoreXCOFFVisibility; Options.UniqueSectionNames = CodeGenOpts.UniqueSectionNames;

  1   2   3   >