kkleine added a comment.

@dblaikie sorry for the late feedback. The `LLVM_ENABLE_WERROR:BOOL` will "Stop 
and fail the build, if a compiler warning is triggered. Defaults to OFF." I 
wonder if any other test fails from clang tidy because. My test explicitly 
checks that a warning is issued (e.g. `// CHECK-MESSAGES-DEFAULT: 
:[[@LINE-2]]:3: warning: prefer deleting`) and when the `LLVM_ENABLE_WERROR` 
propagates to this piece, it will indeed fail the build. But I wonder why this 
doesn't happen to the other clang-tidy checks. @njames93  @Eugene.Zelenko any 
ideas?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80531/new/

https://reviews.llvm.org/D80531

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to