This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1704704e762f: [clangd] NFC: Update FIXME comment regarding
lack of c/dtor support (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89935/new/
https://reviews.llvm.org/D89935
Files:
clang-tools-extra/clangd/FindSymbols.cpp
clang-tools-extra/clangd/XRefs.cpp
Index: clang-tools-extra/clangd/XRefs.cpp
===================================================================
--- clang-tools-extra/clangd/XRefs.cpp
+++ clang-tools-extra/clangd/XRefs.cpp
@@ -1284,8 +1284,8 @@
SM, Lexer::getLocForEndOfToken(NameLoc, 0, SM, Ctx.getLangOpts()));
index::SymbolInfo SymInfo = index::getSymbolInfo(&ND);
- // FIXME: this is not classifying constructors, destructors and operators
- // correctly (they're all "methods").
+ // FIXME: This is not classifying constructors, destructors and operators
+ // correctly.
SymbolKind SK = indexSymbolKindToSymbolKind(SymInfo.Kind);
TypeHierarchyItem THI;
Index: clang-tools-extra/clangd/FindSymbols.cpp
===================================================================
--- clang-tools-extra/clangd/FindSymbols.cpp
+++ clang-tools-extra/clangd/FindSymbols.cpp
@@ -179,8 +179,8 @@
return llvm::None;
index::SymbolInfo SymInfo = index::getSymbolInfo(&ND);
- // FIXME: this is not classifying constructors, destructors and operators
- // correctly (they're all "methods").
+ // FIXME: This is not classifying constructors, destructors and operators
+ // correctly.
SymbolKind SK = indexSymbolKindToSymbolKind(SymInfo.Kind);
DocumentSymbol SI;
Index: clang-tools-extra/clangd/XRefs.cpp
===================================================================
--- clang-tools-extra/clangd/XRefs.cpp
+++ clang-tools-extra/clangd/XRefs.cpp
@@ -1284,8 +1284,8 @@
SM, Lexer::getLocForEndOfToken(NameLoc, 0, SM, Ctx.getLangOpts()));
index::SymbolInfo SymInfo = index::getSymbolInfo(&ND);
- // FIXME: this is not classifying constructors, destructors and operators
- // correctly (they're all "methods").
+ // FIXME: This is not classifying constructors, destructors and operators
+ // correctly.
SymbolKind SK = indexSymbolKindToSymbolKind(SymInfo.Kind);
TypeHierarchyItem THI;
Index: clang-tools-extra/clangd/FindSymbols.cpp
===================================================================
--- clang-tools-extra/clangd/FindSymbols.cpp
+++ clang-tools-extra/clangd/FindSymbols.cpp
@@ -179,8 +179,8 @@
return llvm::None;
index::SymbolInfo SymInfo = index::getSymbolInfo(&ND);
- // FIXME: this is not classifying constructors, destructors and operators
- // correctly (they're all "methods").
+ // FIXME: This is not classifying constructors, destructors and operators
+ // correctly.
SymbolKind SK = indexSymbolKindToSymbolKind(SymInfo.Kind);
DocumentSymbol SI;
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
