[PATCH] D84147: Use typedef to represent storage type in FPOption and FPOptionsOverride

This revision was automatically updated to reflect the committed changes. Closed by commit rG21cd7b72a3d4: Use typedef to represent storage type in FPOption and FPOptionsOverride (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 21cd7b7 - Use typedef to represent storage type in FPOption and FPOptionsOverride

Author: Serge Pavlov Date: 2020-07-21T14:35:50+07:00 New Revision: 21cd7b72a3d4d1d5efaadc09533655090b678e57 URL: https://github.com/llvm/llvm-project/commit/21cd7b72a3d4d1d5efaadc09533655090b678e57 DIFF: https://github.com/llvm/llvm-project/commit/21cd7b72a3d4d1d5efaadc09533655090b678e57.diff

[clang] 7af852d - [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer.

Author: Haojian Wu Date: 2020-07-21T09:38:09+02:00 New Revision: 7af852dcbff9a4d5034e6deaadb7b630c548c6fa URL: https://github.com/llvm/llvm-project/commit/7af852dcbff9a4d5034e6deaadb7b630c548c6fa DIFF: https://github.com/llvm/llvm-project/commit/7af852dcbff9a4d5034e6deaadb7b630c548c6fa.diff LO

[Differential] D81395: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7af852dcbff9: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D81395?vs=271928&id=279039#toc Repository: rG L

[PATCH] D81395: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7af852dcbff9: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D81395?vs=271928&id=279436#toc Repository: rG L

[clang-tools-extra] 566b498 - [clang] Set the error-bit for ill-formed semantic InitListExpr.

Author: Haojian Wu Date: 2020-07-21T09:39:44+02:00 New Revision: 566b49884d69f88147c1ca18fd4512f73a3c15e3 URL: https://github.com/llvm/llvm-project/commit/566b49884d69f88147c1ca18fd4512f73a3c15e3 DIFF: https://github.com/llvm/llvm-project/commit/566b49884d69f88147c1ca18fd4512f73a3c15e3.diff LO

[PATCH] D84140: [clang] Set the error-bit for ill-formed semantic InitListExpr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG566b49884d69: [clang] Set the error-bit for ill-formed semantic InitListExpr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84140/new/

[PATCH] D83652: Merge some of the PCH object support with modular codegen

llunak added a comment. > @llunak Would you be able to test this on anything you've got? No, but thinking more about this, I think dllexport specifically voids the possible problems I listed. If I'm getting it right, dllexport is used only for code in the current library, so codegen won't creat

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

HsiangKai added a comment. In D80802#2155802 , @fpallares wrote: > Apologies we didn't identify this earlier but with the change of the mask > register layout (`MLEN=1`) the overlap constraints involving the mask > register were modified: > > //**RVV-0.8

[PATCH] D83759: [clangd] Port lit tests to Windows

njames93 added a comment. In D83759#2163622 , @ArcsinX wrote: > What do you think of this patch? I'm not sure if Windows is important OS for > developers. Windows is most certainly an important OS for developers and something the whole llvm project has

[PATCH] D83759: [clangd] Port lit tests to Windows

kadircet added a comment. hi, sorry for the late replay :/ We discussed this offline with Sam and are both concerned with the duplications it introduces, haven't really thought about a nice way to address this yet. As you mentioned the background-index test in itself looks a lot better do, so

[PATCH] D84176: [CMake][CTE] Add "check-clang-tools-..." targets to test only a particular Clang extra tool

whisperity added a comment. @lebedev.ri If you have an idea on who's competent in accepting this change, please update the //reviewers// field, I'm in the dark here. Also, should the commands be called `check-clang-tools-clang-tidy` or `check-clang-`**`extra`**`-clang-tidy` instead? Repositor

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

kbobyrev updated this revision to Diff 279447. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address post-LGTM comments, rebase on top of HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https://reviews.llvm.org

[Differential] D83826: [clangd] Don't send invalid messages from remote index

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeef162c330b0: [clangd] Don't send invalid messages from remote ind

[PATCH] D83826: [clangd] Don't send invalid messages from remote index

This revision was automatically updated to reflect the committed changes. Closed by commit rGeef162c330b0: [clangd] Don't send invalid messages from remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83826/new/ https:

[clang-tools-extra] eef162c - [clangd] Don't send invalid messages from remote index

Author: Kirill Bobyrev Date: 2020-07-21T11:05:03+02:00 New Revision: eef162c330b02fdc53ec33e5549635be5c5911fa URL: https://github.com/llvm/llvm-project/commit/eef162c330b02fdc53ec33e5549635be5c5911fa DIFF: https://github.com/llvm/llvm-project/commit/eef162c330b02fdc53ec33e5549635be5c5911fa.diff

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

MyDeveloperDay added a subscriber: djasper. MyDeveloperDay added a comment. > Thanks for assistance and review. And sorry about the extra noise. No worries on my part about the noise, firstly this was a really nice clean, quick review but also the noise is part of the learning for us all (especi

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. just reopening to formally accept Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/ https://reviews.llvm.org/D84090 __

[PATCH] D83759: [clangd] Port lit tests to Windows

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:18 # Test that the index is writing files in the expected location. # RUN: ls %t/.cache/clangd/index/foo.cpp.*.idx # RUN: ls %t/sub_dir/.cac

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

alexfh added a comment. In D83223#2147306 , @aaron.ballman wrote: > In D83223#2147247 , @njames93 wrote: > > > In D83223#2147072 , @aaron.ballman > > wrote: > > > > > > /

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

pengfei created this revision. pengfei added reviewers: zequanwu, rnk, asbirlea. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sometimes we also want to avoid merging inline assembly. This patch add the nomerge function attribute to inline assembly. Repository: rG LLVM

[clang-tools-extra] 4470b8c - [clangd] Fix assertions for D83826

Author: Kirill Bobyrev Date: 2020-07-21T11:20:31+02:00 New Revision: 4470b8c6a6b16de3b4f1f3c4cf81137a9fe4c8a1 URL: https://github.com/llvm/llvm-project/commit/4470b8c6a6b16de3b4f1f3c4cf81137a9fe4c8a1 DIFF: https://github.com/llvm/llvm-project/commit/4470b8c6a6b16de3b4f1f3c4cf81137a9fe4c8a1.diff

[PATCH] D84222: [AST][RecoveryExpr] Error-dependent expression should not be treat as a nullptr pointer constant.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/Expr.cpp:3747 case NPC_ValueDependentIsNull: - if (isTypeDependent() || getType()->isIntegralType(Ctx)) + if ((!containsErr

[PATCH] D83817: [clangd] Add remote index support for Clangd itself

kbobyrev updated this revision to Diff 279457. kbobyrev added a comment. Add flag description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes updated this revision to Diff 279455. c-rhodes added a comment. - Make helpers static in ASTContext. - Use `getCharWidth`. - `s/vector-length-sized/vector-length-specific`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83551/new/ https://reviews.llvm.org/D83551 Files: clang/

[PATCH] D84226: [AST][RecoveryExpr] Support dependent binary operator in C for error recovery.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84226 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaOverload.cpp clang/test/AST/ast-dum

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

vhscampos added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82948/new/ https://reviews.llvm.org/D82948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D84226: [AST][RecoveryExpr] Support dependent binary operator in C for error recovery.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:14243 + // FIXME: this early typo correction can be removed now, since we support the + // dependent binary operator in C. std::tie(LHS, RHS) = CorrectDelayedTyposI

[PATCH] D83759: [clangd] Port lit tests to Windows

kadircet added inline comments. Comment at: clang-tools-extra/clangd/test/background-index.test:18 # Test that the index is writing files in the expected location. # RUN: ls %t/.cache/clangd/index/foo.cpp.*.idx # RUN: ls %t/sub_dir/.cache/clangd/index/foo.h.*.idx -

[clang-tools-extra] 7d591e1 - [clangd] Complete the fix for (Local|Remote)IndexRoot confusion

Author: Kirill Bobyrev Date: 2020-07-21T11:53:17+02:00 New Revision: 7d591e123e0eb2d3415840de9c2b45c3742f0eaa URL: https://github.com/llvm/llvm-project/commit/7d591e123e0eb2d3415840de9c2b45c3742f0eaa DIFF: https://github.com/llvm/llvm-project/commit/7d591e123e0eb2d3415840de9c2b45c3742f0eaa.diff

[clang] 76c0577 - [Analyzer] Handle unique_ptr::swap() in SmartPtrModeling

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-07-21T12:05:27+02:00 New Revision: 76c0577763505ea3db1017a9aab579c1c2f135d0 URL: https://github.com/llvm/llvm-project/commit/76c0577763505ea3db1017a9aab579c1c2f135d0 DIFF: https://github.com/llvm/llvm-project/commit/76c0577763505ea3db1017a9a

[clang-tools-extra] 3ad0181 - [clangd] Fix null check after D82739.

Author: Haojian Wu Date: 2020-07-21T12:15:17+02:00 New Revision: 3ad0181169dc8efcdec7166a76a4624d73bdad48 URL: https://github.com/llvm/llvm-project/commit/3ad0181169dc8efcdec7166a76a4624d73bdad48 DIFF: https://github.com/llvm/llvm-project/commit/3ad0181169dc8efcdec7166a76a4624d73bdad48.diff LO

[Differential] D83772: [Windows] Fix limit on command line size

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4020ef7c474: [Windows] Fix limit on command line size (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.

[PATCH] D83772: [Windows] Fix limit on command line size

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4020ef7c474: [Windows] Fix limit on command line size (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llv

[PATCH] D83817: [clangd] Add remote index support for Clangd itself

kbobyrev updated this revision to Diff 279472. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tools-extra/clangd/CMakeLists.txt clang-too

[PATCH] D81728: [InstCombine] Add target-specific inst combining

dmgreen added inline comments. Comment at: llvm/test/CodeGen/Thumb2/mve-intrinsics/predicates.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: opt -instcombine %s | llc -mtriple=thumbv8.1m.main -mattr=+mve.fp -verify-machineinstrs -o -

[PATCH] D81728: [InstCombine] Add target-specific inst combining

dmgreen added a comment. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81728/new/ https://reviews.llvm.org/D81728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D84213: [clang-tools-extra] Disable -Wsuggest-override for unittests/

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84213/new/ https://reviews.llvm.org/D84213

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

chill added a comment. I don't think this behaviour is correct with regard to the specification (AAELF64 2020Q2): > Static linkers processing ELF relocatable objects must set the feature bit in > the output object or image > only if all the input objects have the corresponding feature bit set.

[PATCH] D83759: [clangd] Port lit tests to Windows

ArcsinX updated this revision to Diff 279482. ArcsinX added a comment. Revert tests split; Replace '\' with '/' in background-index.test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 Files: clang-tools

[PATCH] D83665: [OpenCL] Fixed missing address space for templated copy constructor

olestrohm updated this revision to Diff 279485. olestrohm added a comment. The code now directly adds the __generic address space to the pointee type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83665/new/ https://reviews.llvm.org/D83665 Files: clang/lib/Sema/SemaTemplateDeduction.

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

DavidSpickett added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:476 +// -mfpu=none, -march=armvX+nofp or -mcpu=X+nofp is *very* similar to +// -mfloat-abi=soft, only that it should not disable MVE-I. Features.insert(Features.end(), -

Re: [clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

On Mon, Jul 20, 2020 at 5:44 PM David Blaikie wrote: > > Should the warning be disabled for LLVM overall, rather than only for > this subproject? (& be good tohave some details in the commit at least > of why this warning is being disabled - how it is noisy/unhelpful/etc) Thank you for pointing o

[PATCH] D82948: [Driver][ARM] Disable unsupported features when nofp arch extension is used

chill added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:476 +// -mfpu=none, -march=armvX+nofp or -mcpu=X+nofp is *very* similar to +// -mfloat-abi=soft, only that it should not disable MVE-I. Features.insert(Features.end(),

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev updated this revision to Diff 279497. kbobyrev added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Check gRPC version for system-installed APT package on Debian-like Linux distros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

riccibruno added a comment. In D84090#2162389 , @MyDeveloperDay wrote: > Nit:clang-format the patch > > Here is a Tip as to what I do (In case it helps other): > > 1. I generate the diff off the staged items so I've already git added all the > files I'm

[PATCH] D83970: [ASTImporter] Refactor ASTImporter to support custom downstream tests

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Ok, LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83970/new/ https://reviews.llvm.org/D83970

[clang] 7b5bddf - [clang] Partially revert "Disable a few formatting options for test/"

Author: Bruno Ricci Date: 2020-07-21T14:53:37+01:00 New Revision: 7b5bddfd034ef42c92c67731743399df844d5f43 URL: https://github.com/llvm/llvm-project/commit/7b5bddfd034ef42c92c67731743399df844d5f43 DIFF: https://github.com/llvm/llvm-project/commit/7b5bddfd034ef42c92c67731743399df844d5f43.diff L

[PATCH] D83652: Merge some of the PCH object support with modular codegen

hans added a comment. > Thanks for checking! So, in summary: This seems to work fine for Chromium, > but Chromium isn't really exercising this functionality (only insofar as the > functionality is enabled, but essentially a no-op)? Yup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D81385: Fix libdl linking for libclang in standalone mode

hans added a comment. In D81385#2162911 , @mstorsjo wrote: > Ping @beanz > > @hans - I think this is something that would be wanted to have fixed in the > release branch (it's a regression for certain build configurations, afaik) - > the fix awaits an ac

[PATCH] D83992: [ASTImporter] Add Visitor for TypedefNameDecl's

vabridgers added a comment. I discussed with Gabor. We don't feel comfortable landing this without a covering negative test case, so I'll work on that a little more, see what I can come up with. Thanks Gabor! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D81385: Fix libdl linking for libclang in standalone mode

lebedev.ri added a comment. In D81385#2164235 , @hans wrote: > In D81385#2162911 , @mstorsjo wrote: > > > Ping @beanz > > > > @hans - I think this is something that would be wanted to have fixed in the > > release

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

thakis added a comment. We're seeing some build warnings in ffmpeg due to this not being in yet. Could you try to land it soon? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82699/new/ https://reviews.llvm.org/D82699 ___

[PATCH] D83759: [clangd] Fixes in lit tests

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! as i mentioned please watch out for buildbot breakages after landing this. (and again let me know if I should land this for you) Repository: rG LLVM Github Monorepo CHAN

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 added a comment. I experienced 2 crashes with and without this patch using commit `1af9fc82132da7c876e8f70c4e986cc9c59010ee` on master: I have used the clang built on that revision to analyse itself, and also used the patched version (with this current revision applied) to do the same.

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus marked an inline comment as done. Szelethus added a comment. In D82598#2162496 , @xazax.hun wrote: > In D82598#2162239 , @Szelethus wrote: > > > I chased my own tail for weeks before realizing that there i

[PATCH] D84182: [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region.

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. I verified that 46012 is fixed with this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84182/new/ https://reviews.llvm.org/D84182 _

[clang] 2015741 - [ASTImporter] Refactor ASTImporter to support custom downstream tests

Author: Vince Bridgers Date: 2020-07-21T10:34:17-05:00 New Revision: 20157410862d376c624cc24bffd9730290a16142 URL: https://github.com/llvm/llvm-project/commit/20157410862d376c624cc24bffd9730290a16142 DIFF: https://github.com/llvm/llvm-project/commit/20157410862d376c624cc24bffd9730290a16142.diff

[PATCH] D83970: [ASTImporter] Refactor ASTImporter to support custom downstream tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG20157410862d: [ASTImporter] Refactor ASTImporter to support custom downstream tests (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo

[Differential] D83970: [ASTImporter] Refactor ASTImporter to support custom downstream tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20157410862d: [ASTImporter] Refactor ASTImporter to support custom

[PATCH] D84221: [OpenMP] Add missing RUN lines for OpenMP 4.5

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. Thank you. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84221/new/ https://reviews.llvm.org/D84221 ___

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3067-3068 + unsigned Type = getOpenMPSimpleClauseType(OMPC_map, PP.getSpelling(Tok)); + if (Type < OMPC_MAP_MODIFIER_unknown) +return OMPC_MAP_MODIFIER_unknown; + return static_cast(Type); -

[PATCH] D83759: [clangd] Fixes in lit tests

ArcsinX added a comment. In D83759#2164296 , @kadircet wrote: > as i mentioned please watch out for buildbot breakages after landing this. > (and again let me know if I should land this for you) Thanks for review. Yes, could you please land this for me

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

xazax.hun added inline comments. Comment at: clang/lib/Analysis/LiveVariables.cpp:317-320 for (Stmt *Child : S->children()) { -if (Child) - AddLiveStmt(val.liveStmts, LV.SSetFact, Child); +if (const auto *E = dyn_cast_or_null(Child)) + AddLiveExpr(val.liveExp

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

logan-5 created this revision. logan-5 added a reviewer: mgorny. logan-5 added a project: clang. Herald added a subscriber: cfe-commits. Yesterday I enabled `-Wsuggest-override` in the main LLVM build and have been fighting with the -Werror bots ever since. The key culprits making this difficult

[clang-tools-extra] fa42b7c - [clang-tools-extra] Disable -Wsuggest-override for unittests/

Author: Logan Smith Date: 2020-07-21T09:11:53-07:00 New Revision: fa42b7cf2949802ff0b8a63a2e111a2a68711067 URL: https://github.com/llvm/llvm-project/commit/fa42b7cf2949802ff0b8a63a2e111a2a68711067 DIFF: https://github.com/llvm/llvm-project/commit/fa42b7cf2949802ff0b8a63a2e111a2a68711067.diff L

[PATCH] D84213: [clang-tools-extra] Disable -Wsuggest-override for unittests/

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa42b7cf2949: [clang-tools-extra] Disable -Wsuggest-override for unittests/ (authored by logan-5). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84213/new/

[PATCH] D84246: [clang][LTO] Pass-through remarks options and set auto hotness threshold

weiwang created this revision. Herald added subscribers: llvm-commits, cfe-commits, dang, dexonsmith, steven_wu, MaskRay, hiraditya, eraman, arichardson, inglorion, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added projects: clang, LLVM. Expand remarks hot

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

balazske added a comment. Maybe the assert `b.hasValue()` is related to the problems in D83115 or D83961 ? The changes in those affect the same functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

Quuxplusone added a comment. For GTest and GMock specifically, it would be a good medium-term idea to try to upstream patches into those libraries. I did eventually have success upstreaming fixes for `-Wdeprecated` into GTest, for example: https://github.com/google/googletest/pull/2815 Disablin

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

danielkiss added a comment. > If any function has the attribute "sign-return-address", then the output note > section should have PAC bit set. The return address signing is completely > local > to the function, and functions with or without return address signing can be > freely mixed with eac

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

logan-5 added a comment. In D84244#2164537 , @Quuxplusone wrote: > For GTest and GMock specifically, it would be a good medium-term idea to try > to upstream patches into those libraries. I did eventually have success > upstreaming fixes for `-Wdeprecate

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/Analysis/LiveVariables.cpp:317-320 for (Stmt *Child : S->children()) { -if (Child) - AddLiveStmt(val.liveStmts, LV.SSetFact, Child); +if (const auto *E = dyn_cast_or

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks updated this revision to Diff 279563. aeubanks added a comment. Rename OptNoneInstrumentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://reviews.llvm.org/D83519 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/inclu

[PATCH] D83519: [NewPM] Support optnone under new pass manager

This revision was automatically updated to reflect the committed changes. Closed by commit rGb13b85818218: [NewPM] Support optnone under new pass manager (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://review

[clang] b13b858 - [NewPM] Support optnone under new pass manager

Author: Arthur Eubanks Date: 2020-07-21T09:53:43-07:00 New Revision: b13b85818218aa17cee4c987cbf835208c06cf10 URL: https://github.com/llvm/llvm-project/commit/b13b85818218aa17cee4c987cbf835208c06cf10 DIFF: https://github.com/llvm/llvm-project/commit/b13b85818218aa17cee4c987cbf835208c06cf10.diff

[PATCH] D84248: [analyzer][StdLibraryFunctionsChecker] Add POSIX time handling functions

martong created this revision. martong added reviewers: Szelethus, gamesh411, balazske. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: cl

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

aqjune added a comment. Made a patch at https://reviews.llvm.org/D84250 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360 ___ cfe-commits mailing list cfe-commi

[PATCH] D83772: [Windows] Fix limit on command line size

max-kudr added a comment. This commit is now failing LLDB Windows buildbot builds http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17702. Please fix or revert. E:\build_slave\lldb-x64-windows-ninja\llvm-project\lldb\sour

[PATCH] D83812: [clang][RelativeVTablesABI] Do not emit stubs for architectures that support a PLT relocation

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83812/new/ https://reviews.llvm.org/D83812 __

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

asoffer updated this revision to Diff 279572. asoffer added a comment. Construct types for default metadata explicitly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83820/new/ https://reviews.llvm.org/D83820 Files: clang/include/clang/Tooling/T

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3067-3068 + unsigned Type = getOpenMPSimpleClauseType(OMPC_map, PP.getSpelling(Tok)); + if (Type < OMPC_MAP_MODIFIER_unknown) +return OMPC_MAP_MODIFIER_unknown

[PATCH] D81728: [InstCombine] Add target-specific inst combining

nhaehnle accepted this revision. nhaehnle added a comment. This revision is now accepted and ready to land. This has had a month of good review that has been addressed, I'd say it's good to go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81728/ne

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

krisb added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80873/new/ https://reviews.llvm.org/D80873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/CMakeLists.txt:751 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +if(MSVC AND NOT BOOTSTRAP_CMAKE_SYSTEM_NAME) + set(${CLANG_STAGE}_LINKER -DCMAKE_LINKER=

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:430 + AT->getKeyword() == AutoTypeKeyword::Auto && + !hasAnyNestedLocalQualifiers(F->getDeclaredReturnType())) +return; aaron.bal

[clang] e5b3202 - [libTooling] In Clang Transformer, change `Metadata` field to deferred evaluation.

Author: Andy Soffer Date: 2020-07-21T18:05:49Z New Revision: e5b3202b6f9484590c9e70b8bb82d2778d1ca4fe URL: https://github.com/llvm/llvm-project/commit/e5b3202b6f9484590c9e70b8bb82d2778d1ca4fe DIFF: https://github.com/llvm/llvm-project/commit/e5b3202b6f9484590c9e70b8bb82d2778d1ca4fe.diff LOG: [

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe5b3202b6f94: [libTooling] In Clang Transformer, change `Metadata` field to deferred… (authored by asoffer, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3067-3068 + unsigned Type = getOpenMPSimpleClauseType(OMPC_map, PP.getSpelling(Tok)); + if (Type < OMPC_MAP_MODIFIER_unknown) +return OMPC_MAP_MODIFIER_unknown; + return static_cast(Type); -

[clang-tools-extra] ff63d6b - [clangd] Fixes in lit tests

Author: Aleksandr Platonov Date: 2020-07-21T21:21:40+03:00 New Revision: ff63d6be93dc5958bf35d92919ce6fafcc611e89 URL: https://github.com/llvm/llvm-project/commit/ff63d6be93dc5958bf35d92919ce6fafcc611e89 DIFF: https://github.com/llvm/llvm-project/commit/ff63d6be93dc5958bf35d92919ce6fafcc611e89.

[PATCH] D83759: [clangd] Fixes in lit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGff63d6be93dc: [clangd] Fixes in lit tests (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 F

[PATCH] D83592: [Parser] Add comment to skipped regions

vsk added a comment. The testing looks really good. Just a few more requests for documentation (inline). Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:309 + /// Return a new SpellingRegion for the SkippedRange if it's valid. + Optional adjustSkippedRange(SourceManag

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

aaron.ballman removed a reviewer: aaron.ballman. aaron.ballman added a comment. While this looks reasonable to me, I don't feel comfortable signing off on it because Templates Are Complicated (switching myself to a subscriber instead). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84048

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Also, what about compatibility with declare mapper? Can you add tests for it? Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7809-7813 +MapValuesArrayTy CurOffsets{llvm::ConstantInt::get(CGF.CGM.Int64Ty, 0)}; +MapValuesArrayTy CurCounts{llvm:

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu updated this revision to Diff 279595. zequanwu marked 2 inline comments as done. zequanwu retitled this revision from "[Parser] Add comment to skipped regions" to "[Coverage] Add comment to skipped regions". zequanwu edited the summary of this revision. zequanwu added a comment. - Addres

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

ABataev added a comment. In D83261#2162904 , @Meinersbur wrote: > In D83261#2162561 , @ABataev wrote: > > > 1. OMPChildren class uses standard TrailingObjects harness instead of > > manual calculation. > > > I was

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

aaron.ballman added a comment. LGTM, though I have a possible code simplification if you think it's an improvement. Comment at: clang-tools-extra/clang-tidy/bugprone/BoolPointerImplicitConversionCheck.cpp:78 + + if (const auto *DeclRef = Result.Nodes.getNodeAs("expr")) { +

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane updated this revision to Diff 279598. erichkeane added a comment. Also make sure to update the the cxx_dr_status.html document. Additionally, I sent out a CWG message on the reflector about this: https://godbolt.org/z/bEr61T My implementation has this as ambiguous, but the wording ma

[PATCH] D83592: [Coverage] Add comment to skipped regions

MaskRay added a comment. New tests should use `[[#@LINE]]` instead of `[[@LINE]]` https://llvm.org/docs/CommandGuide/FileCheck.html > To support legacy uses of @LINE as a special string variable, FileCheck also > accepts the following uses of @LINE with string substitution block syntax: > [[@L

[PATCH] D84225: [CFE] Add nomerge function attribute to inline assembly.

zequanwu accepted this revision. zequanwu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84225/new/ https://reviews.llvm.org/D84225 __

  1   2   3   >