kadircet added a comment. hi, sorry for the late replay :/
We discussed this offline with Sam and are both concerned with the duplications it introduces, haven't really thought about a nice way to address this yet. As you mentioned the background-index test in itself looks a lot better do, so we can land that one separately and think about the rest in the meantime. ================ Comment at: clang-tools-extra/clangd/test/background-index.test:18 # Test that the index is writing files in the expected location. # RUN: ls %t/.cache/clangd/index/foo.cpp.*.idx # RUN: ls %t/sub_dir/.cache/clangd/index/foo.h.*.idx ---------------- are you sure these don't need changes on windows bots ? AFAICT this contains both backslashes(coming from %t) and forwards slashes, and command is `ls` which might not be available on a default windows prompt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
