kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/test/background-index.test:18 # Test that the index is writing files in the expected location. # RUN: ls %t/.cache/clangd/index/foo.cpp.*.idx # RUN: ls %t/sub_dir/.cache/clangd/index/foo.h.*.idx ---------------- ArcsinX wrote: > kadircet wrote: > > are you sure these don't need changes on windows bots ? AFAICT this > > contains both backslashes(coming from %t) and forwards slashes, and command > > is `ls` which might not be available on a default windows prompt. > I am not sure. How I can check it? The only thing I can say, that I tested > this on mingw and visual studio builds on my local machine. > > > this contains both backslashes(coming from %t) and forwards slashes, > For me that was OK, but I agree that `ls > %t/.cache/clangd/index/foo.cpp.*.idx` should be replaced with `ls > %/t/.cache/clangd/index/foo.cpp.*.idx`. > > As for `ls`, it's a part of mingw, so I think `ls` absence probability is the > same as for `sed` > I am not sure. How I can check it? The only thing I can say, that I tested > this on mingw and visual studio builds on my local machine. unfortunately there is no good way (that I know of) for checking these, apart from landing the patch and monitoring the buildbots(http://lab.llvm.org:8011/) for breakages and reverting/fixing forward accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83759/new/ https://reviews.llvm.org/D83759 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
