[clang] 4431d64 - Support ExtVectorType conditional operator

Author: Min-Yih Hsu Date: 2020-06-02T16:35:42Z New Revision: 4431d64c10cb681986e752420f1136f259daa5a7 URL: https://github.com/llvm/llvm-project/commit/4431d64c10cb681986e752420f1136f259daa5a7 DIFF: https://github.com/llvm/llvm-project/commit/4431d64c10cb681986e752420f1136f259daa5a7.diff LOG: S

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

pratlucas updated this revision to Diff 267905. pratlucas added a comment. Addressing review comments and extending tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79721/new/ https://reviews.llvm.org/D79721 Files: clang/lib/CodeGen/CGBuilti

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. Still: Did you think about implementing it in the compiler instead of the runtime? Comment at: clang/include/clang/AST/OpenMPClause.h:4676-4677 explicit MappableComponent() = default; -explicit MappableComponent(Expr *AssociatedExpression, +

[PATCH] D79710: [clang][BFloat] add create/set/get/dup intrinsics

stuij marked an inline comment as done. stuij added inline comments. Comment at: clang/include/clang/Basic/arm_neon.td:1854 + def VDUP_LANE_BF : WOpInst<"vdup_lane", ".qI", "bQb", OP_DUP_LN>; + def VDUP_LANEQ_BF: WOpInst<"vdup_laneq", ".QI", "bQb", OP_DUP_LN> { +let isLaneQ

[PATCH] D81008: [AST] Record SourceLocation for TypoExpr.

sammccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:6158 public: - TypoExpr(QualType T) : Expr(TypoExprClass, T, VK_LValue, OK_Ordinary) { + TypoExpr(QualType T, SourceLocation Start, SourceLocation End) + : Expr(TypoExprClass, T, VK_LValue, OK_Ord

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

pratlucas marked 5 inline comments as done. pratlucas added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10334 Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy)); -auto Alignment = CharUnits::fromQuantity( -BuiltinID == NEON

[PATCH] D80462: Fix floating point math function attributes definition.

michele.scandale updated this revision to Diff 267907. michele.scandale added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80462/new/ https://reviews.llvm.org/D80462 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGEx

cfe-commits@lists.llvm.org

pratlucas added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10366 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy));

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu added a comment. Thank you @Anastasia ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80574/new/ https://reviews.llvm.org/D80574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

cfe-commits@lists.llvm.org

LukeGeeson updated this revision to Diff 267909. LukeGeeson added a comment. Added CHECK-NEXT lines, tested whole functions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80752/new/ https://reviews.llvm.org/D80752 Files: clang/include/clang/Basic/arm_neon.td clang/lib/CodeGen/CGBuil

cfe-commits@lists.llvm.org

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10366 +auto Alignment = CGM.getNaturalPointeeTypeAlignment( +E->getArg(0)->IgnoreParenCasts()->getType()); Ops[0] = Builder.CreateBitCast(Op

cfe-commits@lists.llvm.org

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll:4 +; CHECK-LABEL: test_vbfdot_f32 +; CHECK: bfdot v0.2s, v1.4h, v2.4h +define <2 x float> @test_vbfdot_f32(<2 x float> %r, <4

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

myhsu added a comment. > Btw does your change fix this bug: > https://bugs.llvm.org/show_bug.cgi?id=33103 As mentioned in the description, this patch only affect C code not C++ code. So strictly speaking this patch doesn't fix the bug, but if the same code attached in the bug report is compile

[PATCH] D80925: Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context.

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1009 + Actions, Sema::ExpressionEvaluationContext::Unevaluated, + Sema::ReuseLambdaContextDecl); + Res = Actions.TransformToPotentiallyEvaluated(Res.get()); --

[PATCH] D80574: [ExtVector] Support ExtVectorType conditional operator

This revision was automatically updated to reflect the committed changes. Closed by commit rG4431d64c10cb: Support ExtVectorType conditional operator (authored by myhsu). Changed prior to commit: https://reviews.llvm.org/D80574?vs=267277&id=267913#toc Repository: rG LLVM Github Monorepo CHA

[clang] 170b686 - [Clang] Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

Author: Zequan Wu Date: 2020-06-02T10:21:02-07:00 New Revision: 170b6869b563dd3393d99f3e03d389b9058d5f24 URL: https://github.com/llvm/llvm-project/commit/170b6869b563dd3393d99f3e03d389b9058d5f24 DIFF: https://github.com/llvm/llvm-project/commit/170b6869b563dd3393d99f3e03d389b9058d5f24.diff LOG

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

NoQ accepted this revision. NoQ added a comment. Thank you! Please commit :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80903/new/ https://reviews.llvm.org/D80903 ___ cfe-commits mailing list cfe-co

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang marked 4 inline comments as done. dang added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:396-400 /// Record code for the signature that identifiers this AST file. SIGNATURE = 1, + /// Record code for the signature of the

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 267914. dang added a comment. Address some of the code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/ https://reviews.llvm.org/D80383 Files: clang/include/clang/Basic/Module.h clang/

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu updated this revision to Diff 267922. zequanwu added a comment. Rebase and address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.org/D79895 Files: clang/include/clang/Analysis/Analyses/UninitializedValues.h clang/include/clang/Basi

cfe-commits@lists.llvm.org

LukeGeeson marked an inline comment as done. LukeGeeson added inline comments. Comment at: llvm/test/CodeGen/AArch64/aarch64-bf16-dotprod-intrinsics.ll:4 +; CHECK-LABEL: test_vbfdot_f32 +; CHECK: bfdot v0.2s, v1.4h, v2.4h +define <2 x float> @test_vbfdot_f32(<2 x float> %r, <4

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin marked an inline comment as not done. kmclaughlin added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10676 +ConstantSDNode *C = dyn_cast(Dup->getOperand(0)); +uint64_t ExtVal = C->getZExtValue(); + efriedma wrot

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

kmclaughlin updated this revision to Diff 267919. kmclaughlin marked 2 inline comments as done. kmclaughlin added a comment. - Added a truncate of ExtVal in performSVEAndCombine - Changed the assert added to performSignExtendInRegCombine in the previous revision CHANGES SINCE LAST ACTION http

[PATCH] D79511: [ObjC] Add compatibility mode for type checking of qualified id block parameters.

steven_wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2382 + // Foundation/NSItemProvider.h. + CC1Args.push_back("-fcompatibility-qualified-id-block-type-checking"); } Not that I know there is a better place to put this option, th

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

hans added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.h:320 + /// Executable and command-line used to create a given CompilerInvocation. + const char *BuildTool = nullptr; + ArrayRef CommandLineArgs; aganea wrote: > hans wrote: > > T

[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

NoQ added a comment. In D77866#2068484 , @Szelethus wrote: > > Also a regular reminder that we wouldn't have had this conversation if we > > had hashtags instead of packages (#CallAndMessage #NullDereference #C++ > > #AllPlatforms #UndefinedBehavior #Sec

[PATCH] D80925: Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context.

ABataev updated this revision to Diff 267927. ABataev added a comment. Rebase + fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80925/new/ https://reviews.llvm.org/D80925 Files: clang/include/clang/Basic/TokenKinds.def clang/lib/Parse/Pars

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 267920. pestctrl added a comment. Tests need to contain the full error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/Diagn

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

This revision was automatically updated to reflect the committed changes. Closed by commit rG170b6869b563: [Clang] Add a new warning to warn when passing uninitialized variables as const… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D80439: Replace separator in OpenMP variant name mangling.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks a lot! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80439/new/ https://reviews.llvm.org/D80439 ___ cfe-commits maili

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

Ah, thanks for the context/update! On Tue, Jun 2, 2020 at 12:37 AM Jean-Baptiste Lespiau wrote: > Yes it was: https://reviews.llvm.org/D80800#2065643 > > Thanks to Sam, I understand the situation better, but I have been slowed > down quite a lot by the fact that > (a) the logic to print types is

[PATCH] D80925: Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80925/new/ https://reviews.llvm.org/D80925 ___

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: hlopko, eduucaldas. I changed `markStmtChild` to ignore implicit expressions the same way as `markExprChild` does it already. The test that I modified crashes without

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1084 PP.getHeaderSearchInfo().getHeaderSearchOpts().ModulesHashContent) { -Signature = createSignature(StringRef(Buffer.begin(), StartOfUnhashedControl

cfe-commits@lists.llvm.org

miyuki added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16160 } case WebAssembly::BI__builtin_wasm_narrow_s_i8x16_i16x8: case WebAssembly::BI__builtin_wasm_narrow_u_i8x16_i16x8: This chunk does not belong to the patch

[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

xazax.hun added a comment. In D77866#2069144 , @NoQ wrote: > Like, i mean, the tree of packages that we currently have is a wrong > abstraction. I totally agree with this. > The most ad-hoc approach that's better than the current situation would be >

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:396-400 /// Record code for the signature that identifiers this AST file. SIGNATURE = 1, + /// Record code for the signature of the

[clang] 7096e04 - [Sema] Use isAlwaysUninit for -Wuninitialized-const-reference after D79895

Author: Fangrui Song Date: 2020-06-02T11:25:04-07:00 New Revision: 7096e04a6831d4668c39b388ccd166f84de69191 URL: https://github.com/llvm/llvm-project/commit/7096e04a6831d4668c39b388ccd166f84de69191 DIFF: https://github.com/llvm/llvm-project/commit/7096e04a6831d4668c39b388ccd166f84de69191.diff

[PATCH] D81019: Syntax tree: ignore implicit expressions at the top level of statements

gribozavr updated this revision to Diff 267937. gribozavr added a comment. Refactored makeStmtChild to have fewer redundant checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81019/new/ https://reviews.llvm.org/D81019 Files: clang/lib/Tooling

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

amccarth added a comment. Does the full path to the tool end up only in the object file, or does this make it all the way to the final executable or library? Does embedding full paths affect distributed builds or build reproducibility? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

mgehre added inline comments. Comment at: llvm/lib/Support/YAMLTraits.cpp:904 + std::string &Val) { + Val.clear(); + size_t CurrentPos = 0; DmitryPolukhin wrote: > mgehre wrote: > > I wonder whether using StringRef::spl

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2047788 , @jdoerfert wrote: > In D79744#2047482 , @arsenm wrote: > > > For the purpose here, only the callee exists. This is essentially a > > freestanding function, the entry poin

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

nickdesaulniers added a comment. May I please have a non-Googler to review+(accept|reject) the revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80828/new/ https://reviews.llvm.org/D80828 ___ cfe

[clang] 2f7269b - Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context.

Author: Alexey Bataev Date: 2020-06-02T14:27:33-04:00 New Revision: 2f7269b6773de2750f9cd1417ef5f21cd6cf7a91 URL: https://github.com/llvm/llvm-project/commit/2f7269b6773de2750f9cd1417ef5f21cd6cf7a91 DIFF: https://github.com/llvm/llvm-project/commit/2f7269b6773de2750f9cd1417ef5f21cd6cf7a91.diff

[PATCH] D80590: [WIP][OPENMP] Fix assertion error for using alignas with OpenMP directive

ABataev added a comment. Must be fixed in 2f7269b6773de2750f9cd1417ef5f21cd6cf7a91 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80590/new/ https://reviews.llvm.org/D80590 __

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

MaskRay added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:676 + Value v = vals[vd]; + if (isUninitialized(v)) +handler.handleConstRefUseOfUninitVariable(vd, getUninitUse(ex, vd, v)); This should use isAlwaysUninit. I fixed it in

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

MaskRay added a subscriber: olista01. MaskRay added a comment. In D80828#2069287 , @nickdesaulniers wrote: > May I please have a non-Googler to review+(accept|reject) the revision? I guess @olista01 is an inactive account. Changed to @ostannard Reposi

[PATCH] D80925: Fix compiler crash when an expression parsed in the tentative parsing and must be claimed in the another evaluation context.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2f7269b6773d (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80925/new/ https://reviews.llvm.org/D80925 Files: clang/include/clang/Ba

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 267947. pestctrl added a comment. Copy pasted error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2068976 , @ABataev wrote: > Still: Did you think about implementing it in the compiler instead of the > runtime? I'm not sure I understand your question, which part of code are you asking? The main work compiler needs to

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

arsenm added a comment. In D79744#2050498 , @rjmccall wrote: > > For the purpose here, only the callee exists. This is essentially a > > freestanding function, the entry point to the program. > > I'm definitely not going to let you add a new "generic" arg

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 267950. pestctrl added a comment. Copy pasted error messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D79972#2069322 , @cchen wrote: > In D79972#2068976 , @ABataev wrote: > > > Still: Did you think about implementing it in the compiler instead of the > > runtime? > > > I'm not sure I und

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2069358 , @ABataev wrote: > In D79972#2069322 , @cchen wrote: > > > In D79972#2068976 , @ABataev wrote: > > > > > Still: Did you think about

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM with 2 small nits, but I'd still give a few days see if anyone else wants to weight in. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAs

[PATCH] D77866: [analyzer][CallAndMessage] Add checker options for each bug category

NoQ added a comment. > While this sounds really good for basic use cases I think it quickly becomes > unmanageable for power users. It's strictly better than the current situation because nothing prevents us from keeping the existing checker names as a subset of tags (i.e., #core/#core.CallAnd

[clang] 237be34 - [WebAssembly] Improve macro hygiene in wasm_simd128.h

Author: Thomas Lively Date: 2020-06-02T12:55:06-07:00 New Revision: 237be3404b448637ec3b36f8992434193c5bc64c URL: https://github.com/llvm/llvm-project/commit/237be3404b448637ec3b36f8992434193c5bc64c DIFF: https://github.com/llvm/llvm-project/commit/237be3404b448637ec3b36f8992434193c5bc64c.diff

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. If we want want to have the default on windows be dependent on mingw vs not-mingw then we should do it across the board so it applies to llvm-ar, lld, and other tools. Right now I don't think any of those other tools have any special mingw handling. Would it make sense

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

echristo accepted this revision. echristo added a comment. This looks good to me. Might want to open a project around migrating everything. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80883/new/ https://reviews.llvm.org/D80883

[PATCH] D80876: [clang] Default to windows response files when running on windows

sbc100 added a comment. The problem I ran into regarding the quoting style differences was trying to refer to filenames that contains single quote characters: Here is our test case that I've currently disabled on windows pending the resolution of this issue: https://github.com/emscripten-core/e

[PATCH] D80903: [analyzer] Ignore calculated indices of <= 0 in VLASizeChecker

Szelethus accepted this revision. Szelethus added a comment. LGTM! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80903/new/ https://reviews.llvm.org/D80903 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea marked an inline comment as done. aganea added a comment. In D80833#2069246 , @amccarth wrote: > Does the full path to the tool end up only in the object file, or does this > make it all the way to the final executable or library? The `LF_BUILDIN

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D79972#2069366 , @cchen wrote: > In D79972#2069358 , @ABataev wrote: > > > In D79972#2069322 , @cchen wrote: > > > > > In D79972#2068976

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk updated this revision to Diff 267960. kwk marked 4 inline comments as done. kwk added a comment. - Return macro name by reference - Add colon to paragraph showing code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llv

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:676 + Value v = vals[vd]; + if (isUninitialized(v)) +handler.handleConstRefUseOfUninitVariable(vd, getUninitUse(ex, vd, v)); Ma

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk added a comment. Done. Comment at: clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAssignMacroCheck.h:52 + + const std::string getMacroName() const { return MacroName; } + njames93 wrote: > Return by reference here. Yeah, that makes sense. St

[PATCH] D80968: [WebAssembly] Improve macro hygiene in wasm_simd128.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG237be3404b44: [WebAssembly] Improve macro hygiene in wasm_simd128.h (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80968/new/ https://

[clang] d61ad66 - [Analyzer][WebKit] Check record definition is available in NoUncountedMembers checker

Author: Jan Korous Date: 2020-06-02T13:10:36-07:00 New Revision: d61ad660503d2e0c7ba9981ba6526ae0c2f3b7cc URL: https://github.com/llvm/llvm-project/commit/d61ad660503d2e0c7ba9981ba6526ae0c2f3b7cc DIFF: https://github.com/llvm/llvm-project/commit/d61ad660503d2e0c7ba9981ba6526ae0c2f3b7cc.diff LO

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:768 Opts.DebugFwdTemplateParams = Args.hasArg(OPT_debug_forward_template_params); + Opts.DebugUnusedTypes = Args.hasArg(OPT_eliminate_unused_debug_types_fno); Opts.EmbedSource = Ar

[PATCH] D81017: [Analyzer][WebKit] Check record definition is available in NoUncountedMembers checker

This revision was automatically updated to reflect the committed changes. Closed by commit rGd61ad660503d: [Analyzer][WebKit] Check record definition is available in NoUncountedMembers… (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] 086be9f - Fix test on PS4 linux bot.

Author: Douglas Yung Date: 2020-06-02T20:17:02Z New Revision: 086be9fb20489540e6228a6d9eb4afad533202fa URL: https://github.com/llvm/llvm-project/commit/086be9fb20489540e6228a6d9eb4afad533202fa DIFF: https://github.com/llvm/llvm-project/commit/086be9fb20489540e6228a6d9eb4afad533202fa.diff LOG:

Re: [PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

thanks for letting me know. it is annoying that the test is flaky, but I don't see that flakiness on any other buildbot I've access to. Is there any chance that you are running in a custom build configuration that I can try to repro the failure? Also what's the falkiness ratio? On Tue, Jun 2, 202

[clang] 7694b57 - [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

Author: Fangrui Song Date: 2020-06-02T13:22:12-07:00 New Revision: 7694b571d9fd6a8a6c96af1e7995068f7066f6f1 URL: https://github.com/llvm/llvm-project/commit/7694b571d9fd6a8a6c96af1e7995068f7066f6f1 DIFF: https://github.com/llvm/llvm-project/commit/7694b571d9fd6a8a6c96af1e7995068f7066f6f1.diff

[clang] 26cb706 - [NFC][ASTMatchers] StringRef-ify and Twine-ify ASTMatchers tests.

Author: Nathan James Date: 2020-06-02T21:20:58+01:00 New Revision: 26cb70683bd4ffa49d94a8dad5ecfda549a673b0 URL: https://github.com/llvm/llvm-project/commit/26cb70683bd4ffa49d94a8dad5ecfda549a673b0 DIFF: https://github.com/llvm/llvm-project/commit/26cb70683bd4ffa49d94a8dad5ecfda549a673b0.diff

[PATCH] D80931: AMDGPU: Fix clang side null pointer value for private

dyung added a comment. Matt, this change to the test was causing a failure in the upstream PS4 linux bot here: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68593 I put in a fix for the test to unbreak the bot in 086be9fb20489540e6228a6d9eb4afad533202fa <

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:10695 +// Truncate to prevent a DUP with an over wide constant +SDValue Trunc = DAG.getNode(ISD::TRUNCATE, DL, EltTy, Dup->getOperand(0)); + It's not legal to gene

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 267970. nickdesaulniers added a comment. - add documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D80900: [clangd] Use different FS in PreambleThread

kadircet added a comment. In D80900#2066327 , @sammccall wrote: > TL;DR: I think there are three viable paths that we should consider: > A) minimal change: put the FSProvider in ParseInputs > B) this patch, but with more documentation and safety > C) fi

[PATCH] D80883: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG7694b571d9fd: [Driver] Add multiclass OptInFlag and OptOutFlag to simplify boolean option… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] b5f2c4e - PR23029 / C++ DR2233: Allow expanded parameter packs to follow

Author: Richard Smith Date: 2020-06-02T13:48:59-07:00 New Revision: b5f2c4e45b8d54063051e6955cef0bbb7b6ab0f8 URL: https://github.com/llvm/llvm-project/commit/b5f2c4e45b8d54063051e6955cef0bbb7b6ab0f8 DIFF: https://github.com/llvm/llvm-project/commit/b5f2c4e45b8d54063051e6955cef0bbb7b6ab0f8.diff

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

psmith accepted this revision. psmith added a comment. LGTM from an Arm person now that the Android changes have been made. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:22 #include "InputInfo.h" +#include "MSP430.h" #include "PS4CPU.h" nickdesaulniers wr

[PATCH] D80828: [Clang][A32/T32][Linux] -O1 implies -fomit-frame-pointer

efriedma accepted this revision. efriedma added a comment. LGTM. For non-Android, I think it makes sense to align with gcc as much as possible. > This is mostly > for legacy/compatibility reasons, and the 2019 Q4 revision of the ARM > AAPCS looks to standardize r11 as the frame pointer for aa

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. In D79744#2069324 , @arsenm wrote: > In D79744#2050498 , @rjmccall wrote: > > > > For the purpose here, only the callee exists. This is essentially a > > > freestanding function, the entry

[PATCH] D80660: clang: Add support for relative linker paths with -fuse-ld

keith updated this revision to Diff 267991. keith added a comment. Fix test on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80660/new/ https://reviews.llvm.org/D80660 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/fuse-ld.c

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk added a comment. In D80531#2069383 , @njames93 wrote: > LGTM with 2 small nits, but I'd still give a few days see if anyone else > wants to weight in. I'm okay with this but I'd like to understand when it's time to wait for others? Only when a patc

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:5317 /// EmitTopLevelDecl - Emit code for a single top level declaration. void CodeGenModule::EmitTopLevelDecl(Decl *D) { // Ignore depend

[PATCH] D80876: [clang] Default to windows response files when running on windows

mstorsjo added a subscriber: mati865. mstorsjo added a comment. In D80876#2069418 , @sbc100 wrote: > If we want want to have the default on windows be dependent on mingw vs > not-mingw then we should do it across the board so it applies to llvm-ar, > lld

[clang] 1643799 - Undo removal of test for dr777.

Author: Richard Smith Date: 2020-06-02T14:19:42-07:00 New Revision: 16437992cac249f6fe1efd392d20e3469b47e39e URL: https://github.com/llvm/llvm-project/commit/16437992cac249f6fe1efd392d20e3469b47e39e DIFF: https://github.com/llvm/llvm-project/commit/16437992cac249f6fe1efd392d20e3469b47e39e.diff

cfe-commits@lists.llvm.org

miyuki added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16160 } case WebAssembly::BI__builtin_wasm_narrow_s_i8x16_i16x8: case WebAssembly::BI__builtin_wasm_narrow_u_i8x16_i16x8: miyuki wrote: > This chunk does not belong to the patch Oo

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2068902 , @aaron.ballman wrote: > My experience with clang-tidy has been that template instantiations are a > double-edged sword. The instantiation is the only place at which you have > sufficient information to perfo

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

efriedma updated this revision to Diff 267994. efriedma added a comment. "Address" the review comments. Not really happy with this, but not sure what else to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79052/new/ https://reviews.llvm.org/D7

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2068865 , @ymandel wrote: > Thank you for bringing up this issue. I think it highlights an underlying > problem -- editing templates is quite difficult -- that neither setting will > address, as Dmitri expanded on abov

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

steveire added a comment. In D80961#2067638 , @gribozavr2 wrote: > If IgnoreUnlessSpelledInSource is indeed for novice users (and not to be > strictly interpreted as "it does what it says") we should think about whether > it more useful to ignore instant

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 added a comment. @jfb Does the current implementation look good? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77168/new/ https://reviews.llvm.org/D77168 ___ cfe-commits mailing list cfe

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

efriedma planned changes to this revision. efriedma added a comment. Hang on, I submitted this too early. Need to look a bit more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79052/new/ https://reviews.llvm.org/D79052

[PATCH] D80950: [clang-format] [PR44542,38872] String << String always get a forced newline.

curdeius added a comment. The change seems to me technically sound, but I'm not sure of the scope of its effects. There might be users that rely on this behaviour. On the other hand, adding an option to keep the old behaviour doesn't seem appropriate, and personally I consider the old behaviour

[PATCH] D81037: [OPENMP]Fix PR46170: partial mapping for array sections of data members.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the quick fix! I

[PATCH] D80933: [clang-format] [PR46157] Wrong spacing of negative literals with use of operator

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:981 consumeToken(); +if (CurrentToken->is(tok::comma) && +CurrentToken->Previous->isNot(tok::kw_operator)) Shouldn't you check `CurrentToken` for not bein

[PATCH] D81037: [OPENMP]Fix PR46170: partial mapping for array sections of data members.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81037/new/ https://reviews.llvm.org/D81037 __

[PATCH] D79052: [clang codegen] Fix alignment of "Address" for incomplete array pointer.

efriedma updated this revision to Diff 267999. efriedma added a comment. This should work correctly, now, I think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79052/new/ https://reviews.llvm.org/D79052 Files: clang/lib/CodeGen/CodeGenModule.cp

<    1   2   3   >