njames93 accepted this revision.
njames93 added a comment.
This revision is now accepted and ready to land.
LGTM with 2 small nits, but I'd still give a few days see if anyone else wants
to weight in.
================
Comment at:
clang-tools-extra/clang-tidy/modernize/ReplaceDisallowCopyAndAssignMacroCheck.h:52
+
+ const std::string getMacroName() const { return MacroName; }
+
----------------
Return by reference here.
================
Comment at:
clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:17
+
+When running this check on a code like this
+
----------------
Put a colon on the end of this line.
================
Comment at:
clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:26
+
+It will be transformed to this
+
----------------
Ditto here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80531/new/
https://reviews.llvm.org/D80531
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
