zequanwu marked an inline comment as done. zequanwu added inline comments.
================ Comment at: clang/lib/Analysis/UninitializedValues.cpp:676 + Value v = vals[vd]; + if (isUninitialized(v)) + handler.handleConstRefUseOfUninitVariable(vd, getUninitUse(ex, vd, v)); ---------------- MaskRay wrote: > This should use isAlwaysUninit. I fixed it in > 7096e04a6831d4668c39b388ccd166f84de69191 > > Otherwise there are multiple false positives in stage2 build of llvm-project, > e.g. > > ``` > if (a < 42) > var = 1; > if (a < 42) > const_ref_use(var); > ``` Thanks for the fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.org/D79895 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits