[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260551. asmith added a comment. Fix line breaks like this: enum { a=1, b=2, c=3 } myEnum; which becomes: enum { a=1, b=2, c=3 } myEnum; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: cla

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein marked 8 inline comments as done. hokein added a comment. In D78350#2006469 , @hubert.reinterpretcast wrote: > In D78350#1988416 , @hokein wrote: > > > @ebevhan, @hubert.reinterpretcast, the patch is based o

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#2007038 , @baloghadamsoftware wrote: > As I wrote, I debugged and analyzed it and I am facing a problem for which I > need help. Operator calls are very poorly implemented in the AST. Yes, indeed very poorl

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 260552. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp clang/include/

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#2006106 , @NoQ wrote: > If your change causes a crash, please debug it. That's a completely normal > thing that programmers do every day. Unfortunately, I can't afford to > spoon-feed you the solution step-by

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 260554. gamesh411 added a comment. Remove arch target from another invocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/C

[clang] 62e747f - [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

Author: Gabor Marton Date: 2020-04-28T10:00:50+02:00 New Revision: 62e747f6172942db0e9fd55a6a25f166f338459a URL: https://github.com/llvm/llvm-project/commit/62e747f6172942db0e9fd55a6a25f166f338459a DIFF: https://github.com/llvm/llvm-project/commit/62e747f6172942db0e9fd55a6a25f166f338459a.diff

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. > Yes, indeed very poorly. A C++ operator call is either implemented as > CXXOperatorCall or CXXMethodCall randomly. In the former case the this > parameter is explicit at the beginning, in the latter case it is implicit. We have methods on `CallEvent` to handle this, namel

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. Oh, it is not only //Objective-C//. I have been programming in //C// for 25+ years and teaching it for 15+ years, but I never met such syntactical construction: dispatch_sync(queue, ^(void){ Here it is worse than at the //Objective-C// code above, because

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG62e747f61729: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] f03b505 - Revert f8990feb125a "[libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON"

Author: Hans Wennborg Date: 2020-04-28T10:10:33+02:00 New Revision: f03b505ee7f23018493b93e3828fc3672c6f903c URL: https://github.com/llvm/llvm-project/commit/f03b505ee7f23018493b93e3828fc3672c6f903c DIFF: https://github.com/llvm/llvm-project/commit/f03b505ee7f23018493b93e3828fc3672c6f903c.diff

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#2007125 , @NoQ wrote: > > Yes, indeed very poorly. A C++ operator call is either implemented as > > CXXOperatorCall or CXXMethodCall randomly. In the former case the this > > parameter is explicit at the begi

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added a comment. Before looking into the merit of the change, it needs a couple of things - This needs unit tests in clang/unittests/Format to demonstrate the problem and test this fixing it - This also needs the ClangStyleOptions.rst file generated with the clang/tools/dump_styl

[PATCH] D77641: [analyzer] StdLibraryFunctionsChecker: Associate summaries to FunctionDecls

martong added a comment. In D77641#2004273 , @Szelethus wrote: > I think you can go ahead and commit. You seem to have a firm grasp on this > project, I believe your experience with ASTImporter has more then prepared > you for digging functions out of th

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SymbolManager.cpp:601-603 +if (LCtx->getAnalysis()->isLive(Loc, + PR->getOriginExp

[PATCH] D78534: [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

hans added a comment. This broke builds configured with -DLLVM_ENABLE_PIC=OFF, e.g. $ cmake -GNinja -DCMAKE_BUILD_TYPE=Release '-DLLVM_ENABLE_PROJECTS=clang' '-DLLVM_TARGETS_TO_BUILD=X86' -DLLVM_ENABLE_PIC=OFF ../llvm

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Silence few PEP8 warnings. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78985 Files: clang-tools-extra/clang-tidy/add_new_che

[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

danielkiss added a comment. Please update the title and the summary because those will be the commit message. IMHO the test a case would be extended with a test where the body of the modified if condition is tested. Otherwise LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/ne

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added a comment. I think the name should be `AllowShortEnumsOnASingleLine` As once the enum goes over a certain width it will revert to as it was before. enum { EOF, VOID, CHAR, SHORT, DOT, NUMBER, IDENTIFIER } A; vs enum { EOF, VOID, CHAR, SHORT, INT,

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added a comment. So it doesn't overcome the trailing "," issue. (which is sometimes used to put enums on multiple lines) - (NOTE: maybe it shouldn't) --- Language: Cpp BasedOnStyle: LLVM AllowEnumsOnASingleLine: true enum { B, C, D, } A, B; vs enu

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks for cleaning up. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:1 -#!/usr/bin/env python +#!/usr/bin/env python3 # we should keep using `p

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

Abpostelnicu added a comment. In D78879#2004856 , @MyDeveloperDay wrote: > @sylvestre.ledru , @Abpostelnicu > > I believe to fix your original request you need a combination of D76850: > clang-format: Fix pointer alignment for overloaded operators (PR451

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

Abpostelnicu added a comment. Just to clarify something here, for me the patch looks good but until I will accept the revision I want to test it on the mozilla codebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78879/new/ https://reviews.llvm.org/D78879

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowEnumsOnASingleLine = false; Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None; You'll need to fix up th

[PATCH] D78990: [analyzer] Allow bindings of the CompoundLiteralRegion

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. CompoundLiteralR

[PATCH] D78777: [AST] Use PrintingPolicy for format string diagnosis

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78777/new/ https://reviews.llvm.org/D78777 ___ cfe-commits mailing list cfe-comm

[PATCH] D77378: [Clang] Include size and maximum in vector size error message.

fhahn abandoned this revision. fhahn added a comment. With the recent size increase for vector dimensions I am not sure this is too useful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77378/new/ https://reviews.llvm.org/D77378 ___

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a subscriber: svenvh. Anastasia added a comment. > I'm somewhat confused by the way this is supposed to work, or why a > separate option exists for OpenCL. The other language flags seem to be > implemented in the driver, not cc1 like OpenCL. I'm not sure this is > the right set

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko updated this revision to Diff 260580. vsavchenko added a comment. Move getSelfSVal from CallEvent to ProgramState Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286/new/ https://reviews.llvm.org/D78286 Files: clang/include/clang/Stat

[PATCH] D78882: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

dblaikie accepted this revision. dblaikie added a comment. Looks great - thanks for the pointer type fixup(s) along the way too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78882/new/ https://reviews.llvm.org/D78882 ___

[PATCH] D78882: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

This revision was automatically updated to reflect the committed changes. Closed by commit rGa58b62b4a2b9: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand(). (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D77923: OpenCL: Fix some missing predefined macros

Anastasia added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. The current solution seems very specific and doesn't provide generic uniform mechanisms for the targets. Would something based on a triple component not work? CHANGES SINCE LAST ACTION https://r

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

krasimir added a comment. Thank you! I think this is OK as-is. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/ https://reviews.llvm.org/D78694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] fe667e8 - [OpenCL] Fixed test for the cast operators.

Author: Anastasia Stulova Date: 2020-04-28T12:46:36+01:00 New Revision: fe667e8522a6be5f73b2aed1adf4ec92d0470695 URL: https://github.com/llvm/llvm-project/commit/fe667e8522a6be5f73b2aed1adf4ec92d0470695 DIFF: https://github.com/llvm/llvm-project/commit/fe667e8522a6be5f73b2aed1adf4ec92d0470695.d

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

llunak added a comment. @aganea: This change reverts only a small part of my previous change (see my comment here from Feb 23). Hans reverted the original change only until this problem gets sorted out (see his comment from Feb 27 right before the revert). Repository: rC Clang CHANGES SINCE

[PATCH] D78979: OpenCL: Include builtin header by default

svenvh added a comment. In D78979#2007356 , @Anastasia wrote: > Originally we didn't want to include the header by default for 2 reasons: > > 1. Many vendors used their own header. > 2. It takes long time to parse the header. > > However, we might be in

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke marked an inline comment as done. fanjinke added inline comments. Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:85 + (Ecx == signature_HYGON_ecx); + if (!IsIntel && !IsAMD && !IsHygon) return false; craig.topper wrote: > f

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. Me too LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78694/new/ https://reviews.llvm.org/D78694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D78915: [clang-format] Improved parser for C# properties

jbcoe updated this revision to Diff 260599. jbcoe marked 3 inline comments as done. jbcoe added a comment. Added missing comments. Complied with LLVM style. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78915/new/ https://reviews.llvm.org/D78915 Files: clang/lib/Format/UnwrappedLine

[PATCH] D78915: [clang-format] Improved parser for C# properties

krasimir accepted this revision. krasimir added a comment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78915/new/ https://reviews.llvm.org/D78915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D78812: [SVE][CodeGen] Fix legalisation for scalable types

kmclaughlin updated this revision to Diff 260603. kmclaughlin added a comment. - Use ElementCount with getVectorVT CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78812/new/ https://reviews.llvm.org/D78812 Files: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp llvm/lib/CodeGen/

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov updated this revision to Diff 260604. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. @baloghadamsoftware I have added regression tests as you asked. You can now check them. Thanks. @NoQ, I kindly ask you to look at the changes, seems that it has a

[PATCH] D78995: [SveEmitter] NFCI: Describe splat operands like any other modifier

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma. Herald added a subscriber: tschuett. Herald added a reviewer: rengolin. For scalar operands that need to be splat to a vector, this patch adds a bool to the SVEType struct so that the `applyModifier` function sets

[clang] c577201 - [SveEmitter] Add builtins for bitcount operations

Author: Sander de Smalen Date: 2020-04-28T13:53:54+01:00 New Revision: c57720125fa7596be2403e7810957655d04dfece URL: https://github.com/llvm/llvm-project/commit/c57720125fa7596be2403e7810957655d04dfece DIFF: https://github.com/llvm/llvm-project/commit/c57720125fa7596be2403e7810957655d04dfece.di

[clang] 476ba81 - [SveEmitter] Add builtins for zero/sign extension and bit/byte reversal.

Author: Sander de Smalen Date: 2020-04-28T14:06:51+01:00 New Revision: 476ba8127bfa4553bf5ce1654cd844803e8d6dea URL: https://github.com/llvm/llvm-project/commit/476ba8127bfa4553bf5ce1654cd844803e8d6dea DIFF: https://github.com/llvm/llvm-project/commit/476ba8127bfa4553bf5ce1654cd844803e8d6dea.di

[clang] 44ad58b - [clang-format] Improved parser for C# properties

Author: Jonathan Coe Date: 2020-04-28T14:11:09+01:00 New Revision: 44ad58b9915d29eb48be4f89368be6d30d174825 URL: https://github.com/llvm/llvm-project/commit/44ad58b9915d29eb48be4f89368be6d30d174825 DIFF: https://github.com/llvm/llvm-project/commit/44ad58b9915d29eb48be4f89368be6d30d174825.diff

[clang] 55bcb96 - recommit c77a4078e01033aa2206c31a579d217c8a07569b with fix

Author: Yaxun (Sam) Liu Date: 2020-04-28T09:14:13-04:00 New Revision: 55bcb96f3154808bcb5afc3fb46d8e00bf1db847 URL: https://github.com/llvm/llvm-project/commit/55bcb96f3154808bcb5afc3fb46d8e00bf1db847 DIFF: https://github.com/llvm/llvm-project/commit/55bcb96f3154808bcb5afc3fb46d8e00bf1db847.dif

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

kbobyrev updated this revision to Diff 260606. kbobyrev added a comment. Don't create a separate directory for proto files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78885/new/ https://reviews.llvm.org/D78885 Files: clang-tools-extra/clangd/

[PATCH] D78812: [SVE][CodeGen] Fix legalisation for scalable types

kmclaughlin marked 2 inline comments as done. kmclaughlin added inline comments. Comment at: llvm/test/CodeGen/AArch64/llvm-ir-to-intrinsic.ll:107 + ret %div +} efriedma wrote: > Maybe also worth adding a testcase for ``, assuming that > doesn't expose anythin

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin added a comment. In D78938#2007037 , @dblaikie wrote: > (peanut gallery: I'd consider, while you're touching these all anyway, > changing them all to non-member (friended where required) as I believe that's > best practice - allows equal implicit

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. > > >> I am looping in @svenvh to discuss this further. Sven, do you think we >> should rename this flag due to current proposed change? Should it be moved >> out of `-cc1` too? > > I would leave `-fdeclare-opencl-builtins` as it is, until it is complete and > ta

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

aganea added a comment. My point is that all the changes in this patch are already in the upstream. If you want to re-land D69778 , you should rather re-open and update that patch instead? (and close this current one) Repository: rC Clang CHANGES SINCE LAST

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:22 + +DONT_CHECK_FILE_LIST ) would be nice to avoid specifying this here if it's not needed Comment at: clang-tools-extra/clangd/index/re

[PATCH] D79000: [clang-format] C# property accessor formatting can be controlled by config options

jbcoe created this revision. jbcoe added reviewers: krasimir, MyDeveloperDay. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow brace wrapping in C# property accessors to be controlled by configuration options. Add new tests and rev

[PATCH] D78915: [clang-format] Improved parser for C# properties

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG44ad58b9915d: [clang-format] Improved parser for C# properties (authored by Jonathan Coe ). Changed pri

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

kbobyrev updated this revision to Diff 260618. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78885/new/ https://reviews.llvm.org/D78885 Files: clang-to

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2007563 , @Anastasia wrote: > > > > > >> I am looping in @svenvh to discuss this further. Sven, do you think we > >> should rename this flag due to current proposed change? Should it be moved > >> out of `-cc1` too?

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:8 ) -target_compile_definitions(clangd-index-server PRIVATE -D GOOGLE_PROTOBUF_NO_RTTI=1) -clang_target_link_libraries(clangd-index-server sammccall wrote:

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

Eugene.Zelenko added a comment. It would be great to also run Flake9 and PyLint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78985/new/ https://reviews.llvm.org/D78985 ___ cfe-commits mailing list cf

[PATCH] D78995: [SveEmitter] NFCI: Describe splat operands like any other modifier

SjoerdMeijer added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:68 TypeSpec TS; + bool IsSplat; bool Float, Signed, Immediate, Void, Constant, Pointer; I was wondering if IsSplat belongs here or somewhere else. It doesn't sound like a

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

kbobyrev updated this revision to Diff 260627. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Remove python3 from shebang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78985/new/ https://reviews.llvm.org/D78985 Files: clan

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

kbobyrev added a comment. In D78985#2007669 , @Eugene.Zelenko wrote: > It would be great to also run Flake9 and PyLint. Those were actually from pylint. That's a good idea, but I didn't fix all the warnings there and while I might get back to this in t

[PATCH] D78885: [clangd] Fix remote index build without shared libs mode

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/server/CMakeLists.txt:8 ) -target_compile_definitions(clangd-index-server PRIVATE -D GOOGLE_PROTOBUF_NO_RTTI=1

[PATCH] D78979: OpenCL: Include builtin header by default

yaxunl added a comment. In D78979#2007643 , @Anastasia wrote: > ah I guess if we leave it under `-cc1 ` we will have the command line > interface as follows: > > - Driver (without `-cc1`) adds OpenCL header by default that can be > overridden by the flag

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

pratlucas marked 4 inline comments as done. pratlucas added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:3008 +/// Insertion operator for diagnostics. +inline const DiagnosticBuilder & +operator<<(const DiagnosticBuilder &DB, rnk wrote: > It

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

pratlucas updated this revision to Diff 260630. pratlucas added a comment. Updateing test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78573/new/ https://reviews.llvm.org/D78573 Files: clang/include/clang/AST/ASTContext.h clang/lib/Sema/Sema

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

llunak added a comment. What is the practical difference? Either way the end result will be the same. And given that I get to wait ages for reviews of my PCH changes I find it more likely to get a review for a small patch rather than a large one. Repository: rC Clang CHANGES SINCE LAST ACTI

[PATCH] D78995: [SveEmitter] NFCI: Describe splat operands like any other modifier

sdesmalen marked an inline comment as done. sdesmalen added a comment. Thanks for having a look @SjoerdMeijer Comment at: clang/utils/TableGen/SveEmitter.cpp:68 TypeSpec TS; + bool IsSplat; bool Float, Signed, Immediate, Void, Constant, Pointer; SjoerdMe

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

aganea added a comment. Once you do that, maybe you could send another message to the cfe-dev mailing list to ask for reviewers who have interest into optimizing PCH? I do, but I don't have the deep knowledge of this code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D78985: [clang-tidy] NFC: Cleanup Python scripts

Eugene.Zelenko added a comment. In D78985#2007715 , @kbobyrev wrote: > In D78985#2007669 , @Eugene.Zelenko > wrote: > > > It would be great to also run Flake9 and PyLint. > > > Those were actually from pylint. That

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

aganea added a comment. To ease reviewers comprehension you have to propose patches that diff against the master. People sometimes apply the patches locally before accepting them. This current patch is a subtraction after D69778 is applied locally on master. It

[PATCH] D79008: [clang-format] insert space after C# keyword var in var (key, value)

jbcoe created this revision. jbcoe added reviewers: krasimir, MyDeveloperDay. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79008 Files: clang/lib/Format/TokenAnnotator

[PATCH] D79009: [AST] Preserve the incomplete-type member expr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79009 Files: clang/lib/Sema/SemaExprCXX.cpp clang/test/AST/ast-dump-recovery.cpp Index: clang/test/AST/ast-dump-recovery.cpp

[PATCH] D79012: [AST] Fix a crash on a dependent vector_size attribute

erik.pilkington created this revision. erik.pilkington added reviewers: erichkeane, aaron.ballman. Herald added subscribers: ributzka, dexonsmith, jkorous. Looks like this was just a copy & paste mistake from `getDependentSizedExtVectorType`. rdar://60092165 Repository: rC Clang https://rev

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

sscalpone added a comment. type in the commit message: //esle// the frontend name is hard-coded to "flang", use that to Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73951/new/ https://reviews.llvm.org/D73951 ___

[PATCH] D79008: [clang-format] insert space after C# keyword var in var (key, value)

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79008/new/ https://reviews.llvm.org/D79008

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong updated this revision to Diff 260647. martong added a comment. - Rebase to master - Add the option to the lit test analyzer-config.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118 Files: clang/in

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

MyDeveloperDay added a comment. Do you think we need to support verifyFormat(R"(// public class SaleItem { public decimal Price { get; set; } })"Style); Is that currently possible, and what if users actually want? public string Host { set; get; } Do you thin

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

sscalpone added inline comments. Comment at: clang/test/Driver/flang/flang-driver-2-frontend01.f90:1 +! Check wich name of flang frontend is invoked by the driver + typo //wich// Comment at: clang/test/Driver/flang/flang-driver-2-frontend02.f90

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

dblaikie added a comment. In D78938#2007571 , @BRevzin wrote: > In D78938#2007037 , @dblaikie wrote: > > > (peanut gallery: I'd consider, while you're touching these all anyway, > > changing them all to non-member

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong updated this revision to Diff 260651. martong added a comment. - Better description for the option in Checkers.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118 Files: clang/include/clang/StaticA

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong added a comment. In D78118#1981592 , @Szelethus wrote: > This is a great idea, but the tests just seem to, well, test the new > functionality? > > On a different issue, take a look at how certain help related frontend flags > (not `-analyzer-conf

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong marked an inline comment as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:299 + "DisplayLoadedSummaries", + "If set to true, the checker displays all loaded summaries.", +

[clang] e770153 - [AArch64] Add support for -ffixed-x30

Author: Francis Visoiu Mistrih Date: 2020-04-28T08:48:28-07:00 New Revision: e770153865c53c4fd72a68f23acff33c24e42a08 URL: https://github.com/llvm/llvm-project/commit/e770153865c53c4fd72a68f23acff33c24e42a08 DIFF: https://github.com/llvm/llvm-project/commit/e770153865c53c4fd72a68f23acff33c24e42

Re: [PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

Welcome to my another idea to improve RangeConstraintManager? https://reviews.llvm.org/D78933 Denys Petrov Senior С++ Developer | Kharkiv, Ukraine От: Balazs Benics via Phabricator Отправлено: 10 апреля 2020 г. 15:53 Кому: benic

[clang] 102b410 - [CMSE] Clear padding bits of struct/unions/fp16 passed by value

Author: Momchil Velikov Date: 2020-04-28T17:05:58+01:00 New Revision: 102b4105e3fd568ed2c758ed7e6fd266a819d6db URL: https://github.com/llvm/llvm-project/commit/102b4105e3fd568ed2c758ed7e6fd266a819d6db DIFF: https://github.com/llvm/llvm-project/commit/102b4105e3fd568ed2c758ed7e6fd266a819d6db.dif

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong added a comment. In D78118#1988464 , @balazske wrote: > The new option will simply list the (found) functions that have a summary > based check enabled. (The term "Loaded" may be misleading in the current > implementation, somebody can think if i

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

dblaikie added a comment. (updating the previous review has the advantage that reviewers can review the diff relative to the previous version of the patch, using Phabricator's "History" feature, so they can review the delta since the committed/reverted version) Repository: rC Clang CHANGES

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 260657. baloghadamsoftware added a comment. Getting the type of parameter regions has no crashes on the test suite. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files: clang/include/clang/Sta

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov, mgorny. Herald added a project: clang. sammccall added a comment. Of the pieces I was unsure about: - I

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

dblaikie added a comment. Yeah, I was confused by all this too - @aganea's right - this review doesn't make sense to me, since it doesn't show a proposed change to LLVM, it shows a proposed change on top of another patch, that would necessarily be committed together/in a single commit (a propos

[PATCH] D79000: [clang-format] C# property formatting can be controlled by config options

krasimir added a comment. I'm curious why we don't go the opposite direction -- why are even those two styles needed separately? public int Style1 { get; set } // vs. public int Style2 { get; set } I'm sure there is a good reason; part of this is to make sure we document it so we may c

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 260659. baloghadamsoftware added a comment. Wrong diff uploaded previously. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files: clang/include/clang/StaticAnalyzer/Checkers/SValExplainer.h c

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. Of the pieces I was unsure about: - I didn't move `Protocol` - it's not a perfect fit, though it may still end up here - I moved `FSProvider` but not `FS` - I didn't move `URI` - I suspect that will *probably* end up wherever `Protocol` does, though it may belong in s

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

ASDenysPetrov added a comment. @steakhal What about unsigneds? Does it work for unsigned values as well? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77792/new/ https://reviews.llvm.org/D77792 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D76369: [CMSE] Clear padding bits of struct/unions/fp16 passed by value

This revision was automatically updated to reflect the committed changes. Closed by commit rG102b4105e3fd: [CMSE] Clear padding bits of struct/unions/fp16 passed by value (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added a comment. Very slow progress, but lots of open questions. @NoQ, please try to answer them. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:614 + SVB.makeLoc(MRMgr.getParamRegion(ICC-

[clang] 7443f86 - [clang-format] insert space after C# keyword var in var (key, value)

Author: Jonathan Coe Date: 2020-04-28T17:31:40+01:00 New Revision: 7443f86eabbae0fdef90fe796c3956ed65238e99 URL: https://github.com/llvm/llvm-project/commit/7443f86eabbae0fdef90fe796c3956ed65238e99 DIFF: https://github.com/llvm/llvm-project/commit/7443f86eabbae0fdef90fe796c3956ed65238e99.diff

[clang] 015bca3 - [clang-format] C# property formatting can be controlled by config options

Author: Jonathan Coe Date: 2020-04-28T17:35:33+01:00 New Revision: 015bca3e67cbb88f74f01fb5ae4e46392bec6416 URL: https://github.com/llvm/llvm-project/commit/015bca3e67cbb88f74f01fb5ae4e46392bec6416 DIFF: https://github.com/llvm/llvm-project/commit/015bca3e67cbb88f74f01fb5ae4e46392bec6416.diff

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall updated this revision to Diff 260665. sammccall added a comment. Avoid dep on clang header for thread stack size. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 Files: clang-tools-extra/clangd/

  1   2   3   >