hokein marked 8 inline comments as done. hokein added a comment. In D78350#2006469 <https://reviews.llvm.org/D78350#2006469>, @hubert.reinterpretcast wrote:
> In D78350#1988416 <https://reviews.llvm.org/D78350#1988416>, @hokein wrote: > > > @ebevhan, @hubert.reinterpretcast, the patch is based on > > fd7a34186137168064ffe2ca536823559b92d939 > > <https://reviews.llvm.org/rGfd7a34186137168064ffe2ca536823559b92d939>, it > > should contain all the fixes. > > it would be nice if you can test it again in your downstream clang. Thanks! > > > Got it. I'll put together a build. Thank you! Look forward to the result. The patch should work on the latest master (b73290be9fa413d8bc426512cdf4fa01bc005954 <https://reviews.llvm.org/rGb73290be9fa413d8bc426512cdf4fa01bc005954>). ================ Comment at: clang/test/CXX/class.access/p4.cpp:1 // RUN: %clang_cc1 -triple %itanium_abi_triple -fcxx-exceptions -fexceptions -fsyntax-only -verify -std=c++98 %s // RUN: %clang_cc1 -triple %itanium_abi_triple -fcxx-exceptions -fexceptions -fsyntax-only -verify -std=c++11 %s ---------------- for review, this reverts the changes introduced in https://github.com/llvm/llvm-project/commit/9657385960350150b77ed652175b4c3801abd7fa. ================ Comment at: clang/test/CXX/special/class.ctor/p5-0x.cpp:1 // RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++11 -Wno-defaulted-function-deleted ---------------- for review, this reverts the changes introduced in https://github.com/llvm/llvm-project/commit/9657385960350150b77ed652175b4c3801abd7fa. ================ Comment at: clang/test/CXX/stmt.stmt/stmt.iter/stmt.ranged/p1.cpp:23 template<typename T> + auto begin(T &&t) -> decltype(t.alt_begin()) { return t.alt_begin(); } // expected-note {{selected 'begin' template [with T = }} \ ---------------- this reverts the changes introduced in https://github.com/llvm/llvm-project/commit/89d9912cbf45068770ac8c1e2ef97b74c3b662ab. ================ Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:880 constexpr Base *nullB1 = 0; -static_assert((Bottom*)nullB == 0, ""); // expected-error {{static_assert expression is not an integral constant expression}} +static_assert((Bottom*)nullB == 0, ""); static_assert((Derived*)nullB1 == 0, ""); ---------------- This reverts the changes introduced in https://github.com/llvm/llvm-project/commit/89d9912cbf45068770ac8c1e2ef97b74c3b662ab. ================ Comment at: clang/test/SemaCXX/cxx0x-deleted-default-ctor.cpp:1 // RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s ---------------- This reverts the changes introduced in https://github.com/llvm/llvm-project/commit/9657385960350150b77ed652175b4c3801abd7fa. ================ Comment at: clang/test/SemaCXX/for-range-dereference.cpp:88 // expected-error@-1 {{no viable conversion from 'Data' to 'Data *'}} + // expected-note@4 {{selected 'begin' function with iterator type 'Data *'}} } ---------------- This reverted the changes in https://github.com/llvm/llvm-project/commit/89d9912cbf45068770ac8c1e2ef97b74c3b662ab, ================ Comment at: clang/test/SemaCXX/virtual-base-used.cpp:43 // expected-note@-9 {{default constructor of 'B' is implicitly deleted because field 'x' has an inaccessible destructor}} - // expected-note@-10 {{destructor of 'B' is implicitly deleted}} #endif #endif ---------------- This reverts the changes introduced in https://github.com/llvm/llvm-project/commit/9657385960350150b77ed652175b4c3801abd7fa. ================ Comment at: clang/test/SemaObjCXX/arc-0x.mm:118 // ARC is enabled and the union has an ObjC pointer field. union U0 { + id f0; // expected-note 6 {{'U0' is implicitly deleted because variant field 'f0' is an ObjC pointer}} ---------------- This reverts the changes introduced in https://github.com/llvm/llvm-project/commit/9657385960350150b77ed652175b4c3801abd7fa. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
