baloghadamsoftware marked an inline comment as done.
baloghadamsoftware added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/SymbolManager.cpp:601-603
+    if (LCtx->getAnalysis<RelaxedLiveVariables>()->isLive(Loc,
+                                                          PR->getOriginExpr()))
+      return true;
----------------
NoQ wrote:
> > I implemented the basic `isLive()` and `getBinding()` functions which 
> > reduced the number of failing tests by `0`.
> 
> This line in particular is very incorrect. In fact, most of the time the 
> result will be `false`.
OK, but what should I check for liveness here? We do not have a `Decl`. We 
could retrieve the `Expr` for the `Arg`, except for `CXXNewOperator` because 
there the size argument cannot be retrieved.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77229/new/

https://reviews.llvm.org/D77229



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to