[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:1209 // FIXME: Print template instantiation parameters. -HI.Name = "initializer_list"; +HI.Name = "initializer_list"; HI.Kind = index::

[PATCH] D71650: [AST] Fix compilation with GCC < 8 for MinGW

mstorsjo created this revision. mstorsjo added reviewers: rsmith, rjmccall, rnk, Mordante. Herald added a project: clang. GCC 7 and earlier, when targeting MinGW, seems to have a bug in layout/size of bitfield structs if they contain a nested enum, making the size of the struct 8 bytes, while we

[PATCH] D71533: [clangd] Show template arguments in type hierarchy when possible

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:687 - const Decl *D = Decls[0]; + const Decl *D = nullptr; + for (const Decl *Candidate : Decls) { maybe just ``` const Decl *D = Decls.front() for(const auto *C : Decls) { if(i

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234479. arichardson added a comment. Also handle -h/-v as short options. Does the adjusted test look okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files:

[PATCH] D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71615/new/ https://reviews.llvm.org/D71615 ___ cfe-commits mailing list cfe

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60990 tests passed, 1 failed and 728 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_timedmutex_requirements/thread_timedmutex_class/lock.pass.cpp {icon times-circle color=

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234487. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Files: clang-tools-ex

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > >

[PATCH] D71545: [clangd] Improve hover for auto on template instantiations

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:1209 // FIXME: Print template instantiation parameters. -HI.Name = "initializer_list"; +HI.Name = "initial

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

teemperor added a comment. Another bug report for this: https://bugs.llvm.org/show_bug.cgi?id=44331 Please close when landing this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71378/new/ https://reviews.llvm.org/D71378 ___ cfe-commits ma

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan updated this revision to Diff 234488. skan edited the summary of this revision. skan added a comment. **Simplify** Drop the subtype of `MCBoundaryAlignFragment` and add data member `EmitNops` to indicate whether NOPs should be emitted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// returns D. +const NamedDecl *getExplicitSpec(const NamedDecl *D) { + if (auto *CTSD = llvm::dyn_cast(D)) { kadircet wrote:

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60982 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:191 + // attached to that. + if (auto *CTSD = llvm::dyn_cast(D)) { +if (!CTSD->isExplicitInstantiationOrSpecialization()) You might need to do the same for specializations o

[clang] 308b8b7 - [OpenCL] Add builtin function extension handling

Author: Sven van Haastregt Date: 2019-12-18T10:13:51Z New Revision: 308b8b76ceee805c964faf9f2176e3e05532a45b URL: https://github.com/llvm/llvm-project/commit/308b8b76ceee805c964faf9f2176e3e05532a45b DIFF: https://github.com/llvm/llvm-project/commit/308b8b76ceee805c964faf9f2176e3e05532a45b.diff

[PATCH] D71476: [OpenCL] Add builtin function extension handling

This revision was automatically updated to reflect the committed changes. Closed by commit rG308b8b76ceee: [OpenCL] Add builtin function extension handling (authored by svenvh). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D71476?vs=233826&id=234491#toc Repo

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71652 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60978 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

ilya-biryukov updated this revision to Diff 234494. ilya-biryukov marked 6 inline comments as done. ilya-biryukov added a comment. - Fix a header guard - Make firstLeaf and lastLeaf methods inside Tree - Mark non-modifiable nodes with I (for immutable) Repository: rG LLVM Github Monorepo CHAN

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

ilya-biryukov marked an inline comment as not done. ilya-biryukov added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:57 + return nullptr; +} + gribozavr2 wrote: > Seems like these first/last helpers should be methods on `syntax::Node`

[clang] bc5b7e2 - recommit: [ASTImporter] Friend class decl should not be visible in its context

Author: Gabor Marton Date: 2019-12-18T11:43:46+01:00 New Revision: bc5b7e21e32b23603f4d6148adeb88cd34dd287e URL: https://github.com/llvm/llvm-project/commit/bc5b7e21e32b23603f4d6148adeb88cd34dd287e DIFF: https://github.com/llvm/llvm-project/commit/bc5b7e21e32b23603f4d6148adeb88cd34dd287e.diff

[PATCH] D71020: [ASTImporter] Friend class decl should not be visible in its context

martong added a comment. Recommited in bc5b7e21e32 . I changed `llvm:is_contained` to a simple for loop over the lookup result. This way the copy assignment of the iterator is avoided even if windows STL is used. Repository

Re: [PATCH] D71545: [clangd] Improve hover for auto on template instantiations

Ok, sorry for getting the wrong end of the stick re the history. Arguments vs parameters - are we sure this is a distinction worth surfacing to users/uis? I guess modeling both using the same struct is awkward. On Wed, Dec 18, 2019, 10:57 AM Kadir Cetinkaya via Phabricator < revi...@reviews.llvm.

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

JonasToth added a comment. Somewhat related: https://reviews.llvm.org/D40854 This is a check that tried to enforce not mixing any signed/unsigned arithmetic. there was no feedback from the cppcoreguideline-ppl on how to proceed with edge cases and occassion where mixing is not avoidable (e.g. `

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin added a comment. In D71460#1783390 , @asavonic wrote: > What about `get_image_num_mip_levels` functions defined in the extension > specification? > > Edit: I mean, should the `get_image_num_mip_levels(write_only img)` function > be only avai

[clang] 1ad1504 - [Syntax] Allow to mutate syntax trees

Author: Ilya Biryukov Date: 2019-12-18T12:19:03+01:00 New Revision: 1ad15046dcf6ff8bafc4a1ea13f214f8d6ba7de6 URL: https://github.com/llvm/llvm-project/commit/1ad15046dcf6ff8bafc4a1ea13f214f8d6ba7de6 DIFF: https://github.com/llvm/llvm-project/commit/1ad15046dcf6ff8bafc4a1ea13f214f8d6ba7de6.diff

[clang] 038f538 - [Syntax] Uppercase the first letter of the test name. NFC

Author: Ilya Biryukov Date: 2019-12-18T12:20:30+01:00 New Revision: 038f53882e7cc25da0a71018d1c7f9b4706675c2 URL: https://github.com/llvm/llvm-project/commit/038f53882e7cc25da0a71018d1c7f9b4706675c2 DIFF: https://github.com/llvm/llvm-project/commit/038f53882e7cc25da0a71018d1c7f9b4706675c2.diff

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ad15046dcf6: [Syntax] Allow to mutate syntax trees (authored by ilya-biryukov). Changed prior to commit: https://reviews.llvm.org/D64573?vs=234494&id=234496#toc Repository: rG LLVM Github Monorepo

[clang] c1bbefe - [Syntax] Use a hash table to search for tokens by their location

Author: Ilya Biryukov Date: 2019-12-18T12:24:00+01:00 New Revision: c1bbefef9d36e84e469513374ef404b9e354b262 URL: https://github.com/llvm/llvm-project/commit/c1bbefef9d36e84e469513374ef404b9e354b262 DIFF: https://github.com/llvm/llvm-project/commit/c1bbefef9d36e84e469513374ef404b9e354b262.diff

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:528 +void test() { + HALF_IF HALF_IF_2 else {} +})cpp", ilya-biryukov wrote: > gribozavr2 wrote: > > Could you also do so

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin marked an inline comment as done. AlexeySotkin added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t i

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille updated this revision to Diff 234501. serge-sans-paille added a comment. Patch rebased, validation ongoing. I'll merge that once I'm back from holidays, don't feel like commiting that 3h before holidays. Thanks **a lot** @Meinersbur for all the reviews! Repository: rG LLVM

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. I looked over this again, and also studied CrashRecoveryContext some more. I don't really understand why this patch needs to modify the code for how the CRC is enabled and installed, etc. I thought all we need for in-process-cc1 is to add the DumpStackAndCleanupOnFailure

[PATCH] D71554: [llvm-ranlib] Handle -D and -U command line flag

arichardson updated this revision to Diff 234506. arichardson added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71554/new/ https://reviews.llvm.org/D71554 Files: llvm/test/tools/llvm-ranlib/D-flag.test llvm/test/tools

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234514. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments - Extend handling to: - var and function templates - non-auto case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60981 tests passed, 2 failed and 727 were skipped. failed: Clangd Unit Tests._/ClangdTests/Hover.DocsFromMostSpecial failed: lit.lit/shtest-format.py {icon check-circle color=green} clang-tidy: pass. {icon ch

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan updated this revision to Diff 234515. skan added a comment. 1. rename `MCBoundaryAlignFragment::hasEmitNop()` to `MCBoundaryAlignFragment::canEmitNop()` 2. reduce the number of `MCBoundaryAlignFragment` emitted as possible CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

gribozavr2 added a comment. Updated version LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64573/new/ https://reviews.llvm.org/D64573 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:188 +// Returns the decl that should be used for querying comments, either from index +// or ast. +const NamedDecl *getDeclForComment(const NamedDecl *D) { NIT: AST ===

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan updated this revision to Diff 234520. skan added a comment. Fix a typo in `MCFragment::dump()` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 Files: llvm/include/llvm/MC/MCAsmBackend.h llvm/include/llvm/MC/MCAssembler.h llvm/include/

[PATCH] D69223: WDocumentation: Implement the \anchor.

gribozavr2 added a comment. LGTM, feel free to push. Comment at: clang/lib/AST/TextNodeDumper.cpp:493 + case comments::InlineCommandComment::RenderAnchor: +OS << " RenderAnchor"; +break; Mordante wrote: > Mordante wrote: > > gribozavr2 wrote: > > > Ple

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234522. kadircet marked 4 inline comments as done. kadircet added a comment. - Expose explicitReferenceTargets Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Files:

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

gribozavr2 added a comment. Updated version LGTM, thanks! Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:346 +/// static_assert(, ) +/// static_assert() +class StaticAssertDeclaration final : public Declaration { ilya-biryukov wrote: > gribozavr2 wrote:

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60982 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

aganea added a comment. In D70568#1789527 , @hans wrote: > I looked over this again, and also studied CrashRecoveryContext some more. > > I don't really understand why this patch needs to modify the code for how the > CRC is enabled and installed, etc. >

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

nathanchance added a comment. As a follow up to my previous post, I have sent patches to clean up all of the warnings that I see in the Linux kernel. However, I found one that I do believe is a false positive: ../drivers/staging/uwb/allocator.c:353:3: warning: misleading indentation; stateme

[clang] d129aa1 - Add an -fno-temp-file flag for compilation

Author: Hans Wennborg Date: 2019-12-18T15:07:43+01:00 New Revision: d129aa1d5369781deff6c6b854cb612e160d3fb2 URL: https://github.com/llvm/llvm-project/commit/d129aa1d5369781deff6c6b854cb612e160d3fb2 DIFF: https://github.com/llvm/llvm-project/commit/d129aa1d5369781deff6c6b854cb612e160d3fb2.diff

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. In D70615#1789142 , @zahen wrote: > Any additional changes required? If not could someone please submit on my > behalf? @rnk, @hans, @thakis ? Sorry, this got lost in my email. I've committed it as d129aa1d5369781deff6c6b854cb61

[PATCH] D70615: Add an -fno-temp-file flag for compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rGd129aa1d5369 (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 Files: clang/include/clang/Drive

[PATCH] D71659: Adde new option to allow setting spaces before and after the operator

Luis created this revision. Luis added reviewers: djasper, klimek, owenpan, mitchell-stellar. Luis added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new option is called SpaceBeforeAndAfterArrows True: (pointer instance) -> (member) False:

[PATCH] D71659: [clang-format] Added new option to allow setting spaces before and after the operator

mitchell-stellar requested changes to this revision. mitchell-stellar added a comment. This revision now requires changes to proceed. This feature is missing unit tests. Also, what is the reason for all the comment changes? I don't think the changed comment lines originally exceeded 80 character

[PATCH] D71463: Implement VectorType conditional operator GNU extension.

erichkeane added a comment. Ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71463/new/ https://reviews.llvm.org/D71463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D71661: I broke clangd

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. goncharov removed subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits. Repository: rG LLVM

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. > The way `Enable()/Disable()` is currently implemented will not work when the > tool executes jobs in parallel (ie. llvm-buildozer > I presented at LLVM conference; > or our re-implementation of /MP >

[PATCH] D71594: testing clang-tidy

Eugene.Zelenko added a comment. In D71594#1789275 , @goncharov wrote: > In D71594#1788194 , @Eugene.Zelenko > wrote: > > > Where set of Clang-tidy checks come from? .clang-tidy? Could stricter set > > of custom ru

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:194 +llvm::SmallVector +explicitReferenceTargets(ast_type_traits::DynTypedNode N, + DeclRelationSet Mask = {}); No need to fix this. The name could pro

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:305 + llvm::raw_string_ostream OS(Result); + if (auto *TD = QT->getAsTagDecl()) +OS << getQualification(CurContext.getParentASTContext(), &CurContext, TD, Why not use `explici

[PATCH] D71659: [clang-format] Added new option to allow setting spaces before and after the operator

Luis added a comment. In D71659#1789694 , @mitchell-stellar wrote: > This feature is missing unit tests. Also, what is the reason for all the > comment changes? I don't think the changed comment lines originally exceeded > 80 characters. Yup, I will a

[PATCH] D71615: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir

This revision was automatically updated to reflect the committed changes. Closed by commit rG6207b060ad80: [clang] [cmake] Fix gen_ast_dump_json_test.py binary dir (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:136 HI.Kind = index::SymbolKind::Class; - HI.Definition = "template class vector {}"; - HI.TemplateParameters = { -

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

kadircet updated this revision to Diff 234541. kadircet marked 2 inline comments as done. kadircet added a comment. - Document limitation on Mask parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71596/new/ https://reviews.llvm.org/D71596 Fi

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60982 tests passed, 1 failed and 727 were skipped. failed: lit.lit/shtest-format.py {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71598: [clangd] Filter implicit references from index while renaming

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:217 +SourceLocation positionToSourceLoc(const SourceManager &SM, Position Pos, + StringRef Filename) { this one isn't used anywhere?

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 234554. lildmh marked 3 inline comments as done. lildmh added a comment. Address Alexey's comments to change mapper function size and refactor code CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: cla

[clang] b19d87b - Revert "Add an -fno-temp-file flag for compilation"

Author: Mitch Phillips Date: 2019-12-18T09:05:09-08:00 New Revision: b19d87b16f81e7c0a22a0a103c867c1b844eb8bc URL: https://github.com/llvm/llvm-project/commit/b19d87b16f81e7c0a22a0a103c867c1b844eb8bc DIFF: https://github.com/llvm/llvm-project/commit/b19d87b16f81e7c0a22a0a103c867c1b844eb8bc.diff

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hctim added a comment. This change broke the sanitizer buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/37446 Reverted in `b19d87b16f81e7c0a22a0a103c867c1b844eb8bc` TEST 'Clang-Unit :: Frontend/./FrontendTests/PCHPreambleTest.ParseWithBom'

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

ilya created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Replace tidy::utils::lexer::getConstQualifyingToken with a corrected and also generalized to other qualifiers variant - getQualifyingToken. Fixes: http://llvm.org/PR44326 Repository: r

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added a comment. Looks much better in general, need to resolve last one issue with number of elements/size and you're ready. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperC

[PATCH] D71650: [AST] Fix compilation with GCC < 8 for MinGW

rjmccall added a comment. Wow, that's novel. Please add a comment explaining that this is a compiler workaround, but otherwise LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71650/new/ https://reviews.llvm.org/D71650 _

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. Sorry for the breakage, and thanks for reverting! I'll try to follow up and fix this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 __

RE: [PATCH] D70615: Add an -fno-temp-file flag for compilation

Sorry about that! I'll have a corrected patch ready later today. -Original Message- From: Hans Wennborg via Phabricator Sent: Wednesday, December 18, 2019 11:27 AM To: Zachary Henkel ; rich...@metafoo.co.uk; r...@google.com; ztur...@roblox.com Cc: mitchphill...@outlook.com; cfe-commits

[PATCH] D71666: [clang-tidy] Fix readability-const-return-type identifying the wrong `const` token

ilya updated this revision to Diff 234560. ilya added a comment. Fix documentation in LexerUtils.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71666/new/ https://reviews.llvm.org/D71666 Files: clang-tools-extra/clang-tidy/readability/ConstRetu

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen reopened this revision. zahen added a comment. This revision is now accepted and ready to land. Sorry about that I'll add a corrected patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 __

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked 2 inline comments as done. lildmh added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen updated this revision to Diff 234563. zahen added a comment. Fixed MemorySanitizer: use-of-uninitialized-value warning CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 Files: clang/include/clang/Driver/Options.td clang/include/clang/Fro

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:9244 +llvm::Function * +CGOpenMPRuntime::getUserDefinedMapperFunc(const OMPDeclareMapperDecl *D) { + auto I = UDMMap.find(D); lildmh wrote: > ABataev wrote: > > `getOrEmitUserDefine

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

kadircet updated this revision to Diff 234564. kadircet added a comment. - Use explicitTargetReferences - Added some testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71652/new/ https://reviews.llvm.org/D71652 Files: clang-tools-extra/clangd

[PATCH] D71596: [clangd] Improve documentation for auto and implicit specs

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:136 HI.Kind = index::SymbolKind::Cl

[PATCH] D71542: [coroutines][PR41909] don't build dependent coroutine statements if the coroutine still has a dependent promise type

modocache requested changes to this revision. modocache added a comment. This revision now requires changes to proceed. Great minds think alike! This looks like the patch I sent in November, D70579 . I only just committed it two days ago in rG376cf43

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked 2 inline comments as done. lildmh added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt

[PATCH] D71652: [clangd] Replace shortenNamespace with getQualification

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor updated this revision to Diff 234567. epastor added a comment. - Removing accidental artifacts of local testing... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71436/new/ https://reviews.llvm.org/D71436 Files: clang/lib/Sema/SemaStmtAsm

[PATCH] D71542: [coroutines][PR41909] don't build dependent coroutine statements if the coroutine still has a dependent promise type

blastrock abandoned this revision. blastrock added a comment. Indeed, I'm closing this then, I haven't tested your patch yet but the fix seems to be the exact same. You seem to have a better idea of what you are doing and your patch reflects that ^^ Thanks for the fix! Repository: rG LLVM G

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor updated this revision to Diff 234566. epastor marked 2 inline comments as done. epastor added a comment. Fix issues around enum values and labels - Only rewrite variables as offset operands; fixes crash due to conflicting rewrites for labels - Recognize inline assembly references to enum

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

epastor added inline comments. Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1821 +getParser().parsePrimaryExpr(Val, End)) + return Error(Start, "unexpected token!"); + } else if (ParseIntelInlineAsmIdentifier(Val, ID, Info, false, End, true)) { ---

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings . {icon times-circle color=red} clang-forma

[PATCH] D71436: [X86][AsmParser] re-introduce 'offset' operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60854 tests passed, 0 failed and 726 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked 2 inline comments as done. lildmh added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8986 CGM.getTypes().ConvertTypeForMem(C.getPointerType(PtrTy))); llvm::Value *PtrEnd = MapperCGF.Builder.CreateGEP(PtrBegin, Size); llvm::Value *M

[PATCH] D71669: [Clang FE, SystemZ] Don't add "true" value for the "mnop-mcount" attribute.

jonpa created this revision. jonpa added a reviewer: uweigand. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Let the "mnop-mcount" function attribute simply be present or non-present. Update SystemZ backend as well to use hasFnAttribute() instead. https://reviews.llvm.org/

[clang] a85f5ef - Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

Author: Amy Huang Date: 2019-12-18T10:41:12-08:00 New Revision: a85f5efd9597d0036f5c347b362cb873bdf51f16 URL: https://github.com/llvm/llvm-project/commit/a85f5efd9597d0036f5c347b362cb873bdf51f16 DIFF: https://github.com/llvm/llvm-project/commit/a85f5efd9597d0036f5c347b362cb873bdf51f16.diff LOG

[PATCH] D71612: [analyzer] Add PlacementNewChecker

NoQ added a comment. I wonder if this checker will find any misuses of placement into `llvm::TrailingObjects`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71612/new/ https://reviews.llvm.org/D71612

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa85f5efd9597: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr. (authored by akhuang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71039/

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt64(ElementSize.getQuantity())); llvm:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 234579. lildmh added a comment. Change the function name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/Cod

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

tra added a comment. > ... I'm curious if it's particularly useful. Last time I checked NVIDIA > didn't ship libcudart for FreeBSD and without it it's rather cumbersome to > use CUDA in practice. FYI, I've just got our internal proof-of-concept runtime support library which may get CUDA apps r

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8981-8982 + // Convert the size in bytes into the number of array elements. + Size = MapperCGF.Builder.CreateExactUDiv( + Size, MapperCGF.Builder.getInt

[PATCH] D71669: [Clang FE, SystemZ] Don't add "true" value for the "mnop-mcount" attribute.

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71669/new/ https://reviews.llvm.org/D71669 ___ cfe-commits mailing list cfe-comm

[PATCH] D71650: [AST] Fix compilation with GCC < 8 for MinGW

mstorsjo added a comment. In D71650#1789897 , @rjmccall wrote: > Wow, that's novel. Please add a comment explaining that this is a compiler > workaround, but otherwise LGTM. The post-patch form doesn't look that odd to me (and we wouldn't want one com

  1   2   >