[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 230841. kadircet added a comment. - Move TargetContext generation logic to a separate function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/ https://reviews.llvm.org/D70535 Files: clang-tools-ext

[PATCH] D70633: clang-format-vs : Fix Unicode formatting

hans added a reviewer: klimek. hans added a comment. klimek, What do you think? empty2fill: Do you have an example input that I could use to hit the "Specified argument was out of the range of valid values." error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D70535: [clangd] Define out-of-line qualify return value

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "627221d6588eb650759f39e80858abb2a3848ccb". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead..

[PATCH] D70656: [clangd] Define out-of-line qualify function name

kadircet updated this revision to Diff 230843. kadircet added a comment. - Get rid of debug output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70656/new/ https://reviews.llvm.org/D70656 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOut

[PATCH] D70656: [clangd] Define out-of-line qualify function name

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet updated this revision to Diff 230843. kadircet added a comment. - Get rid of debug output When

[PATCH] D70656: [clangd] Define out-of-line qualify function name

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "0a2c8c14d3aa16ca964a8e643f9a5bfdd5459de3". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead..

[PATCH] D70656: [clangd] Define out-of-line qualify function name

merge_guards_bot added a comment. Build result: FAILURE - Could not check out parent git hash "0a2c8c14d3aa16ca964a8e643f9a5bfdd5459de3". It was not found in the repository. Did you configure the "Parent Revision" in Phabricator properly? Trying to apply the patch to the master branch instead..

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:961 TEST(IgnoreDiags, FromNonWrittenInclude) { TestTU TU = TestTU::withCode(""); ---

[PATCH] D70633: clang-format-vs : Fix Unicode formatting

klimek added a comment. generally makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70633/new/ https://reviews.llvm.org/D70633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang-tools-extra] 97d6e8e - [clangd] Helper for getting nested namespace qualification

Author: Kadir Cetinkaya Date: 2019-11-25T10:42:13+01:00 New Revision: 97d6e8e0f3748e6fe2b27983803e2df75874507e URL: https://github.com/llvm/llvm-project/commit/97d6e8e0f3748e6fe2b27983803e2df75874507e DIFF: https://github.com/llvm/llvm-project/commit/97d6e8e0f3748e6fe2b27983803e2df75874507e.dif

[clang-tools-extra] 5075c68 - [clangd] Improve symbol qualification in DefineInline code action

Author: Kadir Cetinkaya Date: 2019-11-25T10:42:13+01:00 New Revision: 5075c68219826a199c67f7450c7cf60a55a71c0b URL: https://github.com/llvm/llvm-project/commit/5075c68219826a199c67f7450c7cf60a55a71c0b DIFF: https://github.com/llvm/llvm-project/commit/5075c68219826a199c67f7450c7cf60a55a71c0b.dif

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

kadircet updated this revision to Diff 230847. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68261/new/ https://reviews.llvm.org/D68261 Files: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp clang-t

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. In D31130#1711841 , @lebedev.ri wrote: > The description only says what the patch does, not why this is the desired > behavior. > Also, this is now under a wrong license. What are the options in case the original author has aband

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

kadircet updated this revision to Diff 230849. kadircet marked an inline comment as done. kadircet added a comment. - Group similar tests together Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70494/new/ https://reviews.llvm.org/D70494 Files: cl

[PATCH] D69608: [clangd] Helper for getting nested namespace qualification

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG97d6e8e0f374: [clangd] Helper for getting nested namespace qualification (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] e841029 - [clangd] Fix diagnostic location for macro expansions

Author: Kadir Cetinkaya Date: 2019-11-25T10:45:14+01:00 New Revision: e841029aef74d99d1cb9443edd4a7b761d84ff45 URL: https://github.com/llvm/llvm-project/commit/e841029aef74d99d1cb9443edd4a7b761d84ff45 DIFF: https://github.com/llvm/llvm-project/commit/e841029aef74d99d1cb9443edd4a7b761d84ff45.dif

[PATCH] D69033: [clangd] Improve symbol qualification in DefineInline code action

This revision was automatically updated to reflect the committed changes. Closed by commit rG5075c6821982: [clangd] Improve symbol qualification in DefineInline code action (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D69033?vs=230424&id=230851#toc Repository: rG

[PATCH] D70494: [clangd] Fix diagnostic location for macro expansions

This revision was automatically updated to reflect the committed changes. Closed by commit rGe841029aef74: [clangd] Fix diagnostic location for macro expansions (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70494/new/ https:/

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. In D68720#1755546 , @xbolva00 wrote: > https://reviews.llvm.org/rG397fa687691876de9ff0fbaaf0def3ac5a48899c > > Commited? No, still waiting for @rnk feedback. This commit is just me using the wrong remote when pushing f

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. For the record : this validates fine on OSX, Linux and Windows, using the github actions setup by @tstellar https://github.com/serge-sans-paille/llvm-project/pull/3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D70546: [ARM][MVE][Intrinsics] Add MVE VMUL intrinsics.

dmgreen added inline comments. Comment at: clang/test/CodeGen/arm-mve-intrinsics/vmulq.c:12 +// +uint32x4_t test_vmulq_u32(uint32x4_t a, uint32x4_t b) +{ I think its worth adding some extra tests types. The way I like to think of it is that if someone went and c

[PATCH] D68261: [clangd] Add "inline" keyword to prevent ODR-violations in DefineInline

merge_guards_bot added a comment. Build result: pass - 60290 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

dmgreen added inline comments. Comment at: clang/include/clang/Basic/arm_mve.td:33 let params = T.Int in { +def vabdq: Intrinsic $a, $b)>; def vaddq: Intrinsic; Can this and vadbqf below be combined into one using T.Usual? I believe the differences only usuall

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

JonasToth added a comment. In D31130#1758453 , @fiesh wrote: > In D31130#1711841 , @lebedev.ri > wrote: > > > The description only says what the patch does, not why this is the desired > > behavior. > > Also, thi

[PATCH] D31130: B32239 clang-tidy should not warn about array to pointer decay on system macros

fiesh added a comment. > I guess we need specific permission from the author. maybe writing a mail to > him/her would work? Then he/she can give permission (or decline it, which is > unexpected i guess). I already wrote an email a couple weeks ago but haven't received a reply so far. Let's ho

[PATCH] D70632: clang-format-vs : Fix typo NUGET_EXE_DIR on README

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access, or if not would you like me to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70632/new/ h

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:49 +Result = New; + else if (Result != New) +Result = SelectionTree::Partial; I might be missing something, I don't understand why we set Partial if `Result != New`.

[PATCH] D70664: update string comparison in clang-format.py

pseyfert created this revision. pseyfert added reviewers: MyDeveloperDay, klimek, llvm-commits, cfe-commits. pseyfert added a project: clang-format. Herald added a project: clang. Python 3.8 introduces a SyntaxWarning about string comparisons with 'is'. This commit updates the string comparison i

[PATCH] D69266: [clangd] Define out-of-line availability checks

hokein added a comment. still lgtm. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:72 +// definition even if we are inside a source file. +if (!Sel.AST.getASTContext().getLangOpts().IsHeaderFile) + return false; nit: we have

[PATCH] D70632: clang-format-vs : Fix typo NUGET_EXE_DIR on README

empty2fill added a comment. In D70632#1758572 , @hans wrote: > Thanks! > > Do you have commit access, or if not would you like me to commit on your > behalf? Commit on my behalf please. Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D70633: clang-format-vs : Fix Unicode formatting

empty2fill added a comment. In D70633#1758372 , @hans wrote: > klimek, What do you think? > > empty2fill: Do you have an example input that I could use to hit the > "Specified argument was out of the range of valid values." error? F10867396: Main.cpp

[PATCH] D70664: update string comparison in clang-format.py

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70664/new/ https://reviews.llvm.org/D70664 ___ c

[PATCH] D69298: [clangd] Define out-of-line initial apply logic

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:53 +// template keyword for templated functions. +// FIXME: This is shared with define inli

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

gbencze marked 5 inline comments as done. gbencze added a comment. Mark comments as Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70052/new/ https://reviews.llvm.org/D70052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov added a comment. In D70440#1756262 , @thakis wrote: > Do we need to add a dep on Frontend to DriverTests here? That's a heavy > dependency (it pulls in Sema etc). If it is needed, maybe the test is in the > wrong binary? We need it solely

[PATCH] D70664: update string comparison in clang-format.py

pseyfert added a comment. PS: I do not have commit access, so someone with the rights would need to land this for me. Thanks in advance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70664/new/ https://reviews.llvm.org/D70664 __

[PATCH] D70545: [ARM][MVE][Intrinsics] Add MVE VABD intrinsics.

MarkMurrayARM updated this revision to Diff 230890. MarkMurrayARM added a comment. Merge all VABD intrinis types under T.Usual instead of doing the floats separately. Add more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70545/new/ https:/

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM updated this revision to Diff 230891. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70547/new/ https://reviews.llvm.org/D70547 Files: clang/include/clang/Basic/arm_mve.td clang/include/clang

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

hans added a comment. We're now getting a ton of warnings about this in Chromium. (https://crbug.com/1028110) And I'm not really sure what the warning wants us to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.o

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM updated this revision to Diff 230895. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70547/new/ https://reviews.llvm.org/D70547 Files: clang/include/clang/Basic/arm_mve.td clang/include/clang

[PATCH] D69092: [CodeGen] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69092/new/ https://reviews.llvm.org/D69092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D70547: [ARM][MVE][Intrinsics] Add MVE VAND/VORR/VORN/VEOR/VBIC intrinsics.

MarkMurrayARM updated this revision to Diff 230896. MarkMurrayARM added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70547/new/ https://reviews.llvm.org/D70547 Files: clang/include/clang/Basic/arm_mve.td clang/include/clang

[PATCH] D70671: [clang][CodeGen] Fix wrong memcpy size of no_unique_address in FieldMemcpyizer

zsrkmyn created this revision. zsrkmyn added reviewers: erichkeane, aaron.ballman, MaskRay, rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. When generating ctor, FieldMemcpyizer wrongly treated zero-sized class members as what should be copied, and generated wrong

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @sylvestre.ledru backport for release/9.x branch: https://sergesanspaille.fedorapeople.org/0001-Stack-clash-mir-attempt.patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. Add copy ctor/op= manually. If you have a lot of warnings, you can use -Wno-deprecated-copy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342

Re: [clang] 21f2647 - Revert 3f91705ca54 "ARM-NEON: make type modifiers orthogonal and allow multiple modifiers."

+Tim, I've reverted this since it seems to have broken the vector initialization intrinsics. (I would have replied to the llvm-commits email for the original change, but it seems it didn't reach the list?) On Mon, Nov 25, 2019 at 4:35 PM Hans Wennborg via cfe-commits wrote: > > > Author: Hans We

[PATCH] D69618: NeonEmitter: clean up prototype modifiers

t.p.northover added a comment. Sorry about the delay investigating this, your e-mail bypassed my inbox for some reason and I only noticed the issue when Hans reverted the change this afternoon. I'm looking into it now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69618/new/ https://r

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

ilya-biryukov added a comment. The test also break in our internal integrate. Relying on having programs in path and ignoring the `-B` and sysroot is definitely a bad idea. I would suggest reverting this patch and re-landing after doing another round of review and fixing those issues. @thakis,

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

lebedev.ri added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70539/new/ https://reviews.llvm.org/D70539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein updated this revision to Diff 230905. hokein marked 2 inline comments as done. hokein added a comment. address comments - add related test for ast-based xrefs - add comments to clarify using different location for symbols/references. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:280 (Roles & static_cast(index::SymbolRole::Reference)) && - SM.getFileID(SpellingLoc) == SM.getMainFileID()) + SM.getFileID(SM.getSpellingLoc(Loc)) == SM.getMainFileID()

[PATCH] D70480: [clangd] Use expansion location when the ref is inside macros.

merge_guards_bot added a comment. Build result: pass - 60296 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

yaxunl added a comment. LGTM. But I am wondering how it affects -g. Do we need to keep frame pointer when -g is specified? Should we add a test for -O3 -g? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70424/new/ https://reviews.llvm.org/D70424 __

[PATCH] D70539: [clang][CodeGen] Implicit Conversion Sanitizer: handle increment/derement (PR44054)

lebedev.ri added a comment. Thank you for the review! I'll hold this off for a bit in case anyone else wants to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70539/new/ https://reviews.llvm.org/D70539 ___

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added a comment. Thanks for the feedback Russell! Can you possibly try again with `/MT`? (ie. `-DLLVM_USE_CRT_RELEASE=MT`) In the `abba_test.ps1` script, `ninja check-all` is only used for preparing clang.exe with the patch. The A/B loop //does not// use `check-all`. I've modified the `

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

hans added a comment. In D70342#1758832 , @xbolva00 wrote: > Add copy ctor/op= manually. Does the warning mean that the implicitly defined copy ctor is not going to work in some later version of the language? I'm just trying to understand what it's war

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0619r4.html#3.2 So C++20 or C++23. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 _

[PATCH] D70675: [AIX] Disable clang python binding tests

daltenty created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. The Python ctypes FFI interface is broken on AIX, it cannot properly pass structures containing arrays ( https://bugs.python.org/issue38628). So disable the clang python binding tests on

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish marked an inline comment as done. sunfish added a comment. In D70500#1757735 , @thakis wrote: > Please don't add code to the driver that runs programs off PATH. Nothing else > does this. Clang's normal `GetProgramPath` does do this: https://git

[PATCH] D70677: [WebAssembly] Change the llvm-lto dir to use the LLVM Version

sunfish created this revision. sunfish added reviewers: sbc100, dschuff. Herald added subscribers: cfe-commits, dexonsmith, aheejin, jgravelle-google, inglorion. Herald added a project: clang. Using the version instead of the VCS revision, which isn't available when LLVM_APPEND_VC_REV is set. Th

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish added a comment. I've now posted https://reviews.llvm.org/D70677 which should fix the test failure when `LLVM_APPEND_VC_REV=NO` is set. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70500/new/ https://reviews.llvm.org/D70500 ___

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70549/new/ https://reviews.llvm.org/D70549

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added a comment. I still have to try out the patch. In D61446#1756211 , @serge-sans-paille wrote: > @Meinersbur to make your reviewer job easier, I've setup validation for that > patch, see https://github.com/serge-sans-paille/llvm-project/pu

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 230928. jdoerfert marked 4 inline comments as done. jdoerfert added a comment. use streams, remove caching Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 Files: ll

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert added a comment. @ABataev @JonChesterfield anything else blocking this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 ___ cfe-commits mailin

[clang] 872a53e - [WebAssembly] Change the llvm-lto dir to use the LLVM Version

Author: Dan Gohman Date: 2019-11-25T10:29:51-08:00 New Revision: 872a53ef9489fcfbb48c6f8dd30bd9a9a026934f URL: https://github.com/llvm/llvm-project/commit/872a53ef9489fcfbb48c6f8dd30bd9a9a026934f DIFF: https://github.com/llvm/llvm-project/commit/872a53ef9489fcfbb48c6f8dd30bd9a9a026934f.diff LO

[PATCH] D69628: [Clang] Pragma vectorize_width() implies vectorize(enable), take 3

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69628/new/ https://reviews.llvm.org/D69628 ___ cfe-commits mailing list cfe-c

[PATCH] D70677: [WebAssembly] Change the llvm-lto dir to use the LLVM Version

This revision was automatically updated to reflect the committed changes. Closed by commit rG872a53ef9489: [WebAssembly] Change the llvm-lto dir to use the LLVM Version (authored by sunfishcode). Changed prior to commit: https://reviews.llvm.org/D70677?vs=230919&id=230934#toc Repository: rG

[PATCH] D70684: [clangd] Shutdown cleanly on signals.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a reviewer: jfb. Herald added a project: clang. This avoids leaking PCH files if editors don't use the LSP

[PATCH] D70687: [WebAssembly] Add an llvm-lto path for compiler-rt.

sunfish created this revision. Herald added subscribers: cfe-commits, dexonsmith, aheejin, jgravelle-google, inglorion, sbc100, mehdi_amini, dberris, dschuff. Herald added a project: clang. This allows LTO-enabled builds of compiler-rt to be used. Repository: rG LLVM Github Monorepo https://

[PATCH] D70684: [clangd] Shutdown cleanly on signals.

merge_guards_bot added a comment. Herald added a subscriber: dexonsmith. Build result: fail - 60239 tests passed, 1 failed and 732 were skipped. failed: Clangd.Clangd/exit-signal.test Log files: console-log.txt

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

Anastasia added a comment. In D69938#1755709 , @rjmccall wrote: > In D69938#1754894 , @Anastasia wrote: > > > In D69938#1752024 , @rjmccall > > wrote: > > > > > Yes, in that

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

sammccall updated this revision to Diff 230948. sammccall marked 10 inline comments as done. sammccall added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70512/new/ https://reviews.llvm.org/D70512 Files: clan

[PATCH] D70689: [analyzer] Fix SARIF column locations

jranieri-grammatech created this revision. jranieri-grammatech added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. This fixes SARIF column

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

merge_guards_bot added a comment. Build result: fail - 60299 tests passed, 1 failed and 732 were skipped. failed: Clangd Unit Tests._/ClangdTests/SelectionTest.PathologicalPreprocessor Log files: console-log.txt

[clang] 7b86188 - [Diagnostic] add a warning which warns about misleading indentation

Author: Tyker Date: 2019-11-25T20:46:32+01:00 New Revision: 7b86188b50bf6e537fe98b326f258fbd23108b83 URL: https://github.com/llvm/llvm-project/commit/7b86188b50bf6e537fe98b326f258fbd23108b83 DIFF: https://github.com/llvm/llvm-project/commit/7b86188b50bf6e537fe98b326f258fbd23108b83.diff LOG: [D

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b86188b50bf: [Diagnostic] add a warning which warns about misleading indentation (authored by Tyker). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github M

[clang] bbc328c - [OPENMP]Fix PR41826: symbols visibility in device code.

Author: Alexey Bataev Date: 2019-11-25T15:01:28-05:00 New Revision: bbc328c62430dd3e2e72973ca85c5c6fb550b227 URL: https://github.com/llvm/llvm-project/commit/bbc328c62430dd3e2e72973ca85c5c6fb550b227 DIFF: https://github.com/llvm/llvm-project/commit/bbc328c62430dd3e2e72973ca85c5c6fb550b227.diff

[PATCH] D70549: [OPENMP]Fix PR41826: symbols visibility in device code.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbc328c62430: [OPENMP]Fix PR41826: symbols visibility in device code. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70549/new/ https:

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker added a comment. Thanks for the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D70692: IRGen: Call SetLLVMFunctionAttributes{, ForDefinition} on __cfi_check_fail.

pcc created this revision. pcc added a reviewer: eugenis. Herald added a project: clang. This has the main effect of causing target-cpu and target-features to be set on __cfi_check_fail, causing the function to become ABI-compatible with other functions in the case where these attributes affect AB

Github build status reporting

Hello everyone, I have configured buildbot to report build statuses to github. It is running in a pilot mode. Only the following 4 builders annotate revisions they build for now: * llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast * llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast * llvm-clang-x86_64-ex

[PATCH] D70693: [scan-build-py] Set of small fixes

xazax.hun created this revision. xazax.hun added reviewers: NoQ, haowei, rizsotto.mailinglist. Herald added subscribers: Charusso, gamesh411, Szelethus, dkrupp, rnkovacs, whisperity. Herald added a project: clang. xazax.hun added a subscriber: phosek. This patch fix some small errors in scan-buil

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

rnk marked an inline comment as done. rnk added a comment. Thanks! Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// aaron.ballman wrote: > This should read `Attrs.h` instead, but

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

t-tye added a comment. @scott.linder can answer about the -g question, but I would expect that the CFI is capable of describing the address of the CFA regardless of whether there is a frame pointer by simply knowing the constant offset from the stack pointer. For AMDGPU it seems to me what we r

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// rnk wrote: > aaron.ballman wrote: > > This should read `Attrs.h` instead, but I find the naming

[clang] 0e12815 - Revert "[Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy"

Author: Tom Stellard Date: 2019-11-25T13:19:57-08:00 New Revision: 0e12815566b2f8dd2d3bfe2319e55b3ffb9767ae URL: https://github.com/llvm/llvm-project/commit/0e12815566b2f8dd2d3bfe2319e55b3ffb9767ae DIFF: https://github.com/llvm/llvm-project/commit/0e12815566b2f8dd2d3bfe2319e55b3ffb9767ae.diff

[clang] 3c51425 - Revert "[Diagnostic] add a warning which warns about misleading indentation"

Author: Tom Stellard Date: 2019-11-25T13:19:57-08:00 New Revision: 3c5142597a451a03db21c2ffe8f6520c7eacce59 URL: https://github.com/llvm/llvm-project/commit/3c5142597a451a03db21c2ffe8f6520c7eacce59 DIFF: https://github.com/llvm/llvm-project/commit/3c5142597a451a03db21c2ffe8f6520c7eacce59.diff

[PATCH] D70692: IRGen: Call SetLLVMFunctionAttributes{, ForDefinition} on __cfi_check_fail.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70692/new/ https://reviews.llvm.org/D70692 _

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:891 +if (getLangOpts().OpenCL) + EPI.TypeQuals.addAddressSpace(LangAS::opencl_generic); + This should probably check that there isn't already an address space, right? CHANGES SIN

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song created this revision. yonghong-song added reviewers: dblaikie, aprantl, RKSimon. yonghong-song added a project: debug-info. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Extern variable usage in BPF is different from traditional

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// aaron.ballman wrote: > rnk wrote: > > aaron.ballman wrote: > > > Th

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// rnk wrote: > aaron.ballman wrote: > > rnk wrote: > > > aaron.ballman wrote: > > > > This should

[PATCH] D70625: [DebugInfo][BPF] Support to emit debugInfo for extern variables

yonghong-song abandoned this revision. yonghong-song added a comment. @dblaikie As suggested, just submitted two separate patches: - https://reviews.llvm.org/D70696 for clang/llvm change to generate debuginfo for extern variables - https://reviews.llvm.org/D70697 for BPF backend to consume such

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. The corresponding BPF patch to consume the debuginfo https://reviews.llvm.org/D70697. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70696/new/ https://reviews.llvm.org/D70696 __

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with the follow-up plan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70627/new/ https://reviews.llvm.org/D70627

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

rnk marked an inline comment as done. rnk added inline comments. Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes --*- C++ -*-===// +// aaron.ballman wrote: > rnk wrote: > > aaron.ballman wrote: > > > rn

[clang] d930ed1 - Disallow use of __has_c_attribute in C++ mode.

Author: Aaron Ballman Date: 2019-11-25T17:35:12-05:00 New Revision: d930ed1acc0ea49d4b3aae7e95b4c6d9cd310578 URL: https://github.com/llvm/llvm-project/commit/d930ed1acc0ea49d4b3aae7e95b4c6d9cd310578 DIFF: https://github.com/llvm/llvm-project/commit/d930ed1acc0ea49d4b3aae7e95b4c6d9cd310578.diff

Re: [clang] d930ed1 - Disallow use of __has_c_attribute in C++ mode.

Isn't this unnecessarily annoying to users? You have the same syntax to use the attributes, and the attributes are expected to be compatible when named the same way, but you can't use the same #if conditional to check for availability, when writing a header intended to work in both modes? On Mon,

[clang] 90b8bc0 - IRGen: Call SetLLVMFunctionAttributes{, ForDefinition} on __cfi_check_fail.

Author: Peter Collingbourne Date: 2019-11-25T15:16:43-08:00 New Revision: 90b8bc003caacd165dedbb9cafc32de10d610ea7 URL: https://github.com/llvm/llvm-project/commit/90b8bc003caacd165dedbb9cafc32de10d610ea7 DIFF: https://github.com/llvm/llvm-project/commit/90b8bc003caacd165dedbb9cafc32de10d610ea7

  1   2   >