hokein added a comment. still lgtm.
================ Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:72 + // definition even if we are inside a source file. + if (!Sel.AST.getASTContext().getLangOpts().IsHeaderFile) + return false; ---------------- nit: we have the `isHeaderFile` helper in the `SourceCode.h`, please use it (it is more precise). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69266/new/ https://reviews.llvm.org/D69266 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
