dmgreen added inline comments.
================
Comment at: clang/test/CodeGen/arm-mve-intrinsics/vmulq.c:12
+//
+uint32x4_t test_vmulq_u32(uint32x4_t a, uint32x4_t b)
+{
----------------
I think its worth adding some extra tests types. The way I like to think of it
is that if someone went and completely changed the arm_mve.td in the future,
there should be enough tests for them to tell they didn't miss anything. Even
if they are not someone from Arm, that knows a lot about MVE intrinsics.
================
Comment at: llvm/test/CodeGen/Thumb2/LowOverheadLoops/wlstp.mir:219
; CHECK: renamable $r3, dead $cpsr = tSUBi8 killed renamable $r3, 16, 14,
$noreg
- ; CHECK: renamable $q0 = MVE_VMULt1i8 killed renamable $q1, killed
renamable $q0, 0, $noreg, undef renamable $q0
+ ; CHECK: renamable $q0 = MVE_VMULi8 killed renamable $q1, killed renamable
$q0, 0, $noreg, undef renamable $q0
; CHECK: MVE_VSTRBU8 killed renamable $q0, killed renamable $r4, 0, 0,
killed $noreg :: (store 16 into %ir.scevgep1, align 1)
----------------
This I like
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70546/new/
https://reviews.llvm.org/D70546
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
