hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:961 TEST(IgnoreDiags, FromNonWrittenInclude) { TestTU TU = TestTU::withCode(""); ---------------- I'd move this to the end of the file, so that all `DiagsInHeaders` are grouped together. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70494/new/ https://reviews.llvm.org/D70494 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits