[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

sberg added a comment. In D58896#1737242 , @edward-jones wrote: > In D58896#1737113 , @sberg wrote: > > > But how about literals like `'\x80'` where the promoted value depends on > > whether plain `char` is signed

[PATCH] D67156: [Analyzer] Debug Checkers for Container and Iterator Inspection

This revision was automatically updated to reflect the committed changes. baloghadamsoftware marked an inline comment as done. Closed by commit rG0f88caeef8f2: [Analyzer] Checker for Debugging Iterator Checkers (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

uabelho added a comment. Don't you need to also remove case LinkageSpecDecl::lang_cxx_11: case LinkageSpecDecl::lang_cxx_14: from VisitLinkageSpecDecl in clang-tools-extra/modularize/Modularize.cpp? (added in r372714 / e07376a320d to silence a clang warning). I can't see how that code would

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

aaron.ballman added a comment. In D58896#1738263 , @sberg wrote: > In D58896#1737242 , @edward-jones > wrote: > > > In D58896#1737113 , @sberg wrote: > > > > > But how about

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. It's probably worth collecting a list of things we need to fix before enabling cross-file rename and putting it somewhere (a GitHub issue, maybe?) Important things that imm

[PATCH] D69961: [clangd] Fix a regression of not showing documentation from forward declarations.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/Merge.cpp:195 +bool IsClass = S.SymInfo.Kind == index::SymbolKind::Class || + S.SymInfo.Kind == index::SymbolKind::Struct; +if (!IsClass || !S.Definition) NI

[PATCH] D58896: Suppress -Wchar-subscripts if the index is a literal char

sberg added a comment. In D58896#1738288 , @aaron.ballman wrote: > In D58896#1738263 , @sberg wrote: > > > In D58896#1737242 , @edward-jones > > wrote: > > > > > In D58896#

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:326 +// class Foo, but the token under the cursor is not corresponding to the +// "Foo" range, though the final result is correct. SourceLocation Loc = getBeginningOfIdentifier

[PATCH] D69934: [clangd] Implement rename by using SelectionTree and findExplicitReferences.

ilya-biryukov added a comment. NIT: a typo in the description: s/Aslo/Also Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69934/new/ https://reviews.llvm.org/D69934 ___ cfe-commits mailing list cfe-comm

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

SouraVX added a comment. I created that patch, for purpose of emitting C++ language standards C++11, C++14 in the debug information to be available for consumer's[GDB,LLDB]. DW_TAG_lang_c_plus_plus_11 .. 14 --new tags for languages in DWARF5. Sorry, I think, I missed this unintended additions in

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske added a comment. From the description `The original stream (if it exists) is closed.` I think it is possible that the original stream does "not exist". But a test program crashed with NULL argument (but not with a closed file). So null argument is not permitted or at least does not wor

[PATCH] D69961: [clangd] Fix a regression of not showing documentation from forward declarations.

hokein updated this revision to Diff 228380. hokein marked 2 inline comments as done. hokein added a comment. - include union type; - add testcase for non-class symbols; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69961/new/ https://reviews.llvm.

[PATCH] D69995: [clang][IFS] Adding support for processing more decl types in clang interface stubs.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds support for more decl types that need to be processable, as part of clang-ifs hardening. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov, hokein. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. vscode always escapes the colon on the file uri, w

[PATCH] D69961: [clangd] Fix a regression of not showing documentation from forward declarations.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/unittests/IndexTests.cpp:416 R.Documentation = "Forward declarations because x.h is too big to include"; + EXPECT_

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 planned changes to this revision. lh123 added a comment. it will cause whitspace escaped problem. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 ___ cfe-c

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 updated this revision to Diff 228393. lh123 added a comment. update diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: clang-tools-extra/clangd/clients/clangd-vscode/1.patch clang-tools-extra/clangd/clients/clangd-vscode/packa

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 updated this revision to Diff 228397. lh123 added a comment. Remove irrelevant files from the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: clang-tools-extra/clangd/clients/clangd-vscode/package.json clang-tools-extra/cl

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

khchen marked an inline comment as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:498 +CmdArgs.push_back( +Args.MakeArgString(Twine("-plugin-opt=-target-abi=") + ABIName)); } efriedma wrote: > I don't think

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 updated this revision to Diff 228405. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: clang-tools-extra/clangd/clients/clangd-vscode/package.json clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts Index:

[PATCH] D70003: [clang-format] Ensure dump_format_style.py can generate ClangFormatStyleOptions.rst without manual intervention

MyDeveloperDay added a comment. Just in case you want proof the generated html looks the same: F10665472: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70003/new/ https://reviews.llvm.org/D70003 __

[PATCH] D70003: [clang-format] Ensure dump_format_style.py can generate ClangFormatStyleOptions.rst without manual intervention

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, klimek, sammccall, owenpan. MyDeveloperDay added projects: clang-format, clang. MyDeveloperDay added a comment. Just in case you want proof the generated html looks the same: F10665472: image.png

[PATCH] D69800: [AArch64][SVE] Implement remaining floating-point arithmetic intrinsics

sdesmalen added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-fp-arith.ll:767 ; -; FSCALE +; FNEG ; Why are you moving this test and changing fscale -> fneg here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D69858: [AArch64][SVE] Implement floating-point comparison & reduction intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69858/new/ https://reviews.llvm.org/D69858

[PATCH] D69800: [AArch64][SVE] Implement remaining floating-point arithmetic intrinsics

kmclaughlin marked an inline comment as done. kmclaughlin added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-fp-arith.ll:767 ; -; FSCALE +; FNEG ; sdesmalen wrote: > Why are you moving this test and changing fscale -> fneg here? The res

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. In D69935#1738311 , @SouraVX wrote: > I created that patch, for purpose of emitting C++ language standards C++11, > C++14 in the debug information to be available for consumer's[GDB,LLDB]. > DW_TAG_lang_c_plus_plus_11 .. 14 --new

[PATCH] D69707: [AArch64][SVE] Implement additional floating-point arithmetic intrinsics

sdesmalen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:10064 + SDNodeXFormgetTargetConstant((N->getSExtValue() / 90), SDLoc(N), MVT::i64); +}]>> { should the target constant not

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

SouraVX added a comment. In D69935#1738563 , @ekatz wrote: > In D69935#1738311 , @SouraVX wrote: > > > I created that patch, for purpose of emitting C++ language standards C++11, > > C++14 in the debug information

[PATCH] D63131: arm64_32: implement the desired ABI for the ILP32 triple.

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. Minor comments, but otherwise LGTM. Comment at: clang/lib/Basic/Targets/AArch64.cpp:167 // Target properties. - if (!getTriple().isOSWind

[clang] 6b45e1b - Revert "[clang] Report sanitizer blacklist as a dependency in cc1"

Author: Jeremy Morse Date: 2019-11-08T12:07:42Z New Revision: 6b45e1bc11e91ea7b57a6ab1c19461a86dba33f8 URL: https://github.com/llvm/llvm-project/commit/6b45e1bc11e91ea7b57a6ab1c19461a86dba33f8 DIFF: https://github.com/llvm/llvm-project/commit/6b45e1bc11e91ea7b57a6ab1c19461a86dba33f8.diff LOG:

Re: [clang] 03b84e4 - [clang] Report sanitizer blacklist as a dependency in cc1

Hi Jan, As the dfsan tests have been failing for a bit, I've reverted this in 6b45e1bc, and the follow-up patch in d6be9273c, to clear the buildbots. -- Thanks, Jeremy ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:128 +this.highlighter.highlight( +vscode.Uri.parse(params.textDocument.uri).toString(), lines); } Could we accept a `URI`

[clang] b0a03f2 - test commit

Author: Abel Kocsis Date: 2019-11-08T13:35:49+01:00 New Revision: b0a03f29d9a2d316d6be99e6a4825114f240c0b2 URL: https://github.com/llvm/llvm-project/commit/b0a03f29d9a2d316d6be99e6a4825114f240c0b2 DIFF: https://github.com/llvm/llvm-project/commit/b0a03f29d9a2d316d6be99e6a4825114f240c0b2.diff L

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Szelethus added a comment. Nice catch! Though, wouldn't the memory sanitizer buildbots break on this reliably? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69962/new/ https://reviews.llvm.org/D69962 ___ cfe-commits

[clang] 3182027 - Revert "Revert "[clang] Report sanitizer blacklist as a dependency in cc1""

Author: Abel Kocsis Date: 2019-11-08T14:00:44+01:00 New Revision: 3182027282c59c51d5080d83365917fccd695854 URL: https://github.com/llvm/llvm-project/commit/3182027282c59c51d5080d83365917fccd695854 DIFF: https://github.com/llvm/llvm-project/commit/3182027282c59c51d5080d83365917fccd695854.diff L

[clang] 9b8413a - Revert "Revert "Revert "[clang] Report sanitizer blacklist as a dependency in cc1"""

Author: Abel Kocsis Date: 2019-11-08T14:08:15+01:00 New Revision: 9b8413ac6e56e7a6e0ba884773d13bcf9414bd43 URL: https://github.com/llvm/llvm-project/commit/9b8413ac6e56e7a6e0ba884773d13bcf9414bd43 DIFF: https://github.com/llvm/llvm-project/commit/9b8413ac6e56e7a6e0ba884773d13bcf9414bd43.diff L

[clang] 9fcf2a3 - Revert "test commit"

Author: Abel Kocsis Date: 2019-11-08T14:08:46+01:00 New Revision: 9fcf2a38c202efcf7d221173a2b3a484d66c67e8 URL: https://github.com/llvm/llvm-project/commit/9fcf2a38c202efcf7d221173a2b3a484d66c67e8 DIFF: https://github.com/llvm/llvm-project/commit/9fcf2a38c202efcf7d221173a2b3a484d66c67e8.diff L

[clang] c0a7732 - Revert "test commit"

Author: Abel Kocsis Date: 2019-11-08T14:09:09+01:00 New Revision: c0a77329d46f3577357645e0aa316174798e54cc URL: https://github.com/llvm/llvm-project/commit/c0a77329d46f3577357645e0aa316174798e54cc DIFF: https://github.com/llvm/llvm-project/commit/c0a77329d46f3577357645e0aa316174798e54cc.diff L

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

pseyfert added a comment. thanks for the ping. looking back at Code Reviews with Phabricator , the following applies to me: "If you do not have commit access, someone has to commit the change for you (with attribution)." so, yes I need help landing. Rep

[clang] 6bf9e88 - [clang-format] update comments in clang-format.py for python3 compatibility

Author: paulhoad Date: 2019-11-08T13:17:04Z New Revision: 6bf9e88ae4a45ee43eef3c7978040d33cead59ce URL: https://github.com/llvm/llvm-project/commit/6bf9e88ae4a45ee43eef3c7978040d33cead59ce DIFF: https://github.com/llvm/llvm-project/commit/6bf9e88ae4a45ee43eef3c7978040d33cead59ce.diff LOG: [cla

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel added a comment. In D69979#1738099 , @craig.topper wrote: > I checked Redhat 7.4 that's on the server I'm using for work. And I had a > coworker check his Ubuntu 18.04 system with this program. And both systems > printed 1f80 as the value of MXCS

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bf9e88ae4a4: [clang-format] update comments in clang-format.py for python3 compatibility (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D38446?vs=117280&id=228419#toc

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Szelethus added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:5882 + // FIXME: Should we return the terminator here? + if (size() == 0) What would that even be? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69962/ne

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 updated this revision to Diff 228421. lh123 added a comment. address comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.org/D69996 Files: package.json src/semantic-highlighting.ts Index: src/semantic-highlighting.ts

[PATCH] D69996: [clangd] Fixed colon escaping on Windows

lh123 marked 2 inline comments as done. lh123 added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:128 +this.highlighter.highlight( +vscode.Uri.parse(params.textDocument.uri).toString(), lines); } -

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, provided that the inlines are addressed! Thanks! Comment at: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:102-103 /// system call etc. - bool che

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske updated this revision to Diff 228424. balazske marked an inline comment as done. balazske added a comment. - Do not allow null stream to freopen. - Added comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69948/new/ https://reviews.ll

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

balazske marked 2 inline comments as done. balazske added a comment. I am still not sure in the `auto` type, I did not see that way of `auto` usage often in clang code. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:176 + const LocationContext *LCtx = C.getPr

[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

usaxena95 updated this revision to Diff 228431. usaxena95 added a comment. Hopefully reverting unintended changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69937/new/ https://reviews.llvm.org/D69937 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D69937: [clangd] Use name of Macro to compute its SymbolID.

usaxena95 updated this revision to Diff 228430. usaxena95 added a comment. - [clangd] Store xref for Macros in ParsedAST. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69937/new/ https://reviews.llvm.org/D69937 Files: clang-tools-extra/clangd/AS

[PATCH] D69292: Proposal to add -Wtautological-compare to -Wall

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69292/new/ https://reviews.llvm.org/D69292 ___ cfe-commits mailing lis

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

aaron.ballman added a comment. I'd probably go with `"non-void %select{function|block|coroutine}0 does not return a value %select{|in all control paths}1"` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

spatel added a reviewer: cameron.mcinally. spatel added a comment. Also, I may have missed some discussions. Does this patch series replace the proposal to add instruction-level FMF for denorms? http://lists.llvm.org/pipermail/llvm-dev/2019-September/135183.html Ie, did we decide that a function

[PATCH] D70003: [clang-format] Ensure dump_format_style.py can generate ClangFormatStyleOptions.rst without manual intervention

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70003/new/ https://reviews.llvm.org/D70003 ___

[PATCH] D69800: [AArch64][SVE] Implement remaining floating-point arithmetic intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-fp-arith.ll:767 ; -; FSCALE +; FNEG ; kmclaughlin wrote: > sdesmalen wrote: > > Why are you

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

mitchell-stellar added inline comments. Comment at: clang/include/clang/Format/Format.h:1309 + // clang-format off /// Indent case labels one level from the switch statement. Can this documentation be formatted in a way that avoids clang-format reformattin

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1309 + // clang-format off /// Indent case labels one level from the switch statement. mitchell-stellar wrote: > Can this

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! Should I land this patch for you? If you don't have commit access yet, you could consider applying to get one

[clang] eb00839 - [clang-format] Ensure dump_format_style.py can generate ClangFormatStyleOptions.rst without manual intervention

Author: paul_hoad Date: 2019-11-08T14:40:36Z New Revision: eb00839c6eb4f5dc6adadc83be93f32bd6143362 URL: https://github.com/llvm/llvm-project/commit/eb00839c6eb4f5dc6adadc83be93f32bd6143362 DIFF: https://github.com/llvm/llvm-project/commit/eb00839c6eb4f5dc6adadc83be93f32bd6143362.diff LOG: [cl

[PATCH] D70003: [clang-format] Ensure dump_format_style.py can generate ClangFormatStyleOptions.rst without manual intervention

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb00839c6eb4: [clang-format] Ensure dump_format_style.py can generate ClangFormatStyleOptions. (authored by paul_hoad ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

mitchell-stellar added inline comments. Comment at: clang/include/clang/Format/Format.h:1309 + // clang-format off /// Indent case labels one level from the switch statement. MyDeveloperDay wrote: > mitchell-stellar wrote: > > Can this documentation be form

[PATCH] D69996: [clangd] Fixes colon escaping on Windows

lh123 added a comment. Thanks for your reminder, I have sent an email to apply for commit access, but I don't know how long it will take. > Should I land this patch for you? Yes, you can land this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69996/new/ https://reviews.llvm.or

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 added a comment. Please ignore the changes from patch https://reviews.llvm.org/D69937 Will fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 _

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. usaxena95 added a project: clang. This patch adds the cross references for Macros in the MainFile. We add references for the main file to the ParsedAST. We query the references from it using the SymbolID. Xref outside main file w

[libclc] 00eca0b - libclc: Drop travis

Author: Jan Vesely Date: 2019-11-08T09:58:27-05:00 New Revision: 00eca0bf0bd9a70735a4d6d39ab3776c858d915c URL: https://github.com/llvm/llvm-project/commit/00eca0bf0bd9a70735a4d6d39ab3776c858d915c DIFF: https://github.com/llvm/llvm-project/commit/00eca0bf0bd9a70735a4d6d39ab3776c858d915c.diff LO

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1309 + // clang-format off /// Indent case labels one level from the switch statement. mitchell-stellar wrote: > MyDevelop

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay updated this revision to Diff 228446. MyDeveloperDay added a comment. remove one set of // clang-format on/off that has no visual impact to the html NOTE: it does change the baseline .rst which is why its been added into the review. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4435-4437 +if (DMIB == DMIB_alloc) Kind = OMPC_MAP_alloc; +else if (DMIB == DMIB_to) Kind = OMPC_MAP_to; +else if (DMIB == DMIB_from) Kind = OMPC_MAP_from; cchen wrot

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_num(%struct.ident_t*) Not sur

[PATCH] D70008: [clangd] Store xref for Macros in ParsedAST.

usaxena95 updated this revision to Diff 228456. usaxena95 added a comment. Removing changes from different patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70008/new/ https://reviews.llvm.org/D70008 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/IR/OpenMPIRBuilder.cpp:153-159 +// Search the entry block, not needed once all thread id calls go through +// here and are cached in the OpenMPIRBuilder. +for (Instruction &I : Fn->getEntryBlock()) + if (CallIns

[clang] 2073dd2 - Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

Author: Adrian Prantl Date: 2019-11-08T08:23:22-08:00 New Revision: 2073dd2da702baca447efaf1879cb6151e8c6100 URL: https://github.com/llvm/llvm-project/commit/2073dd2da702baca447efaf1879cb6151e8c6100 DIFF: https://github.com/llvm/llvm-project/commit/2073dd2da702baca447efaf1879cb6151e8c6100.diff

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2073dd2da702: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they… (authored by aprantl). Changed prior to commit: https://reviews.llvm.org/D68108?vs=227801&id=228467#toc Rep

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] 9e48a94 - Fix two typos in one test name, three days before its 10th birthday! (NFC)

Author: Adrian Prantl Date: 2019-11-08T09:03:46-08:00 New Revision: 9e48a946b7b5cb90690bbeb196b185eda2fd8982 URL: https://github.com/llvm/llvm-project/commit/9e48a946b7b5cb90690bbeb196b185eda2fd8982 DIFF: https://github.com/llvm/llvm-project/commit/9e48a946b7b5cb90690bbeb196b185eda2fd8982.diff

[PATCH] D69995: [clang][IFS] Adding support for processing more decl types in clang interface stubs.

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:202 + // or templated type. + if (cast(ND)->getType()->isDependentType() || + cas

[clang] 51adeae - remove redundant LLVM version from version string when setting CLANG_VENDOR

Author: Nick Desaulniers Date: 2019-11-08T09:24:17-08:00 New Revision: 51adeae1c90c966f5ae7eb1aa8a380fcc7cd4806 URL: https://github.com/llvm/llvm-project/commit/51adeae1c90c966f5ae7eb1aa8a380fcc7cd4806 DIFF: https://github.com/llvm/llvm-project/commit/51adeae1c90c966f5ae7eb1aa8a380fcc7cd4806.di

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song updated this revision to Diff 228474. yonghong-song retitled this revision from "[RFC][BPF] Add preserve_access_index attribute to record definition" to "[BPF] Add preserve_access_index attribute for record definition". yonghong-song edited the summary of this revision. yonghong-son

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

This revision was automatically updated to reflect the committed changes. Closed by commit rG51adeae1c90c: remove redundant LLVM version from version string when setting CLANG_VENDOR (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

ast added a comment. Looks great. This is a big improvement in usability. Is there a use case to apply that attribute to inner types automatically ? struct s1 { int foo; }; struct s2 { struct s1 *ptr; } __reloc__ *s2; s2->ptr->foo -- will both deref be relocatable or only first?

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 added a comment. We cannot use it for block; it is a hard error. Corountine and function can be merged as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 _

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

mitchell-stellar added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1589 + statement. Switch statement body is always indented one level more than + case labels. \code false: true: This generated rst

[PATCH] D69952: [OPENMP50]Generalize handling of context matching/scoring.

ABataev updated this revision to Diff 228481. ABataev added a comment. Score is part of context data. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69952/new/ https://reviews.llvm.org/D69952 Files: clang/include/clang/Basic/Attr.td clang/inclu

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

eandrews added a subscriber: mibintc. eandrews added a comment. Thank you for taking a look Reid and Dmitri. There were no fails with check-all. My commit rights have not been transferred from SVN to Github yet, so Melanie (@mibintc) has kindly agreed to commit this patch for me. CHANGES SINCE

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. For the below: struct s1 { int foo; }; struct s2 { struct s1 *ptr; } __reloc__ *s2; s2->ptr->foo -- will both deref be relocatable or only first? Only s2->ptr is relocated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 2 inline comments as done. jdoerfert added inline comments. Comment at: llvm/lib/IR/OpenMPIRBuilder.cpp:153-159 +// Search the entry block, not needed once all thread id calls go through +// here and are cached in the OpenMPIRBuilder. +for (Instructio

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

ast added a comment. Is the attribute sticky with forward delcarations? struct s __reloc; struct s { int foo; } *s; what is s->foo ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69759/new/ https://reviews.llvm.org/D69759

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 added a comment. While I am fine making `-fuse-ld=lld` mean "use that lld driver most appropriate for the clang driver", in principle the clang driver and lld driver choices are orthogonal, and I'd want to expose that with something like `-fuse-ld=ld.lld` to compliment `-fuse-ld=lld

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

aprantl updated this revision to Diff 228484. aprantl marked 3 inline comments as done. aprantl added a reviewer: vsk. aprantl added a comment. Address comments from Vedant. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66121/new/ https://reviews.llvm.org/D66121 Files: clang/lib/Code

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

Ericson2314 added a comment. Reading https://llvm.org/docs/DeveloperPolicy.html it looks like I need to submit an patch email? Is that true, or can/will someone with perms see the approval and eventually merge it from phabricator? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc added a comment. Thanks @aaron.ballman, I don't have commit access so will someone else commit this? To address the minor nit, should I upload a new patch with post-increment/post-decrement changed to pre-increment/pre-decrement? (Does uploading changes undo the "Ready to Land" status

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

This revision was automatically updated to reflect the committed changes. Closed by commit rG759948467ea3: Reapply "Fix crash on switch conditions of non-integer types in templates" (authored by mibintc). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang] 7599484 - Reapply "Fix crash on switch conditions of non-integer types in templates"

Author: Melanie Blower Date: 2019-11-08T10:17:06-08:00 New Revision: 759948467ea3181615d44d80f74ffeb260180fd0 URL: https://github.com/llvm/llvm-project/commit/759948467ea3181615d44d80f74ffeb260180fd0 DIFF: https://github.com/llvm/llvm-project/commit/759948467ea3181615d44d80f74ffeb260180fd0.diff

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. > Is the attribute sticky with forward delcarations? forward declaration is not a record type, so an error will be emited if you have attribute on a forward declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D69951: [clang-format] NFC allow Format.h to be clang-formatted but still maintain the same doc layout in ClangFormatStyleOptions.rst

MyDeveloperDay updated this revision to Diff 228491. MyDeveloperDay marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69951/new/ https://reviews.llvm.org/D69951 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h Index: cl

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. For question > Is there a use case to apply that attribute to inner types automatically ? It is possible, but I feel make attribute per record is better. For example, struct s1 { int foo; }; struct s2 { struct s1 *ptr; } __reloc__ *s2; If we impl

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

ABataev added inline comments. Comment at: clang/test/OpenMP/barrier_codegen.cpp:22 +// CLANGCG-NOT: readonly +// IRBUILDER: ; Function Attrs: nofree nosync nounwind readonly +// IRBUILDER-NEXT: declare i32 @__kmpc_global_thread_num(%struct.ident_t*) jdoerfe

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. But it does not work for inner structs any more. -bash-4.4$ cat t.c #define __reloc__ __attribute__((preserve_access_index)) struct __reloc__ p; struct p { int a; struct { int b; }; }; int test(struct p *arg) { return arg->b; } -bash-4.4$ In onl

[PATCH] D69971: clang-format: [JS] support null operators.

mprobst updated this revision to Diff 228495. mprobst added a comment. Add tests for .?(foo) and .?[foo]. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69971/new/ https://reviews.llvm.org/D69971 Files: clang/lib/Format/FormatToken.h clang/lib/

  1   2   >