compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:202 + // or templated type. + if (cast<VarDecl>(ND)->getType()->isDependentType() || + cast<VarDecl>(ND)->isTemplated() || !ND->getIdentifier()) ---------------- Not sure if I prefer this or: ``` if (!ND->getIdentifier()) return true; const auto *VD = cast<VarDecl>(ND); if (VD->isTemplated() || VD->getType()->isDependent()) return true; ``` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69995/new/ https://reviews.llvm.org/D69995 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
