Re: r365030 - Make a buildbot using a buggy gcc happy

Thank you so much! Sorry for the inconvencience, I'll be that much more careful next time :) On Mon, 8 Jul 2019, 21:42 Richard Smith, wrote: > I'll commit the change below once my testing finishes :) > > On Mon, 8 Jul 2019 at 12:40, Kristóf Umann via cfe-commits < > cfe-commits@lists.llvm.org> w

r365377 - Add missing declarations of explicit member specializations.

Author: rsmith Date: Mon Jul 8 12:45:46 2019 New Revision: 365377 URL: http://llvm.org/viewvc/llvm-project?rev=365377&view=rev Log: Add missing declarations of explicit member specializations. This should fix the build under -Wundefined-func-template and certain versions of GCC. Modified: c

Re: r365030 - Make a buildbot using a buggy gcc happy

Committed as r365377. On Mon, 8 Jul 2019 at 12:43, Kristóf Umann via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Thank you so much! Sorry for the inconvencience, I'll be that much more > careful next time :) > =) No worries. It's one of those pesky "no diagnostic required" cases; they're

[PATCH] D64058: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

logan-5 added a comment. I believe I need someone to commit it for me... brand new to all this and unsure, frankly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64058/new/ https://reviews.llvm.org/D64058 ___ cfe-co

[PATCH] D64058: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

rsmith accepted this revision. rsmith added a comment. Do you have commit access or do you need someone to commit this for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64058/new/ https://reviews.llvm.org/D64058 ___

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

vitalybuka marked 2 inline comments as done. vitalybuka added inline comments. Comment at: llvm/include/llvm/Analysis/MemorySSA.h:1109 // else. -if (MemoryPhi *MP = dyn_cast(Access)) +if (const MemoryPhi *MP = dyn_cast(Access)) return MP->getIncomingValue(ArgN

[PATCH] D64058: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

logan-5 added a comment. I had the exact same thought about factoring out this and the function pointer conversion condition. I didn't bother, but I agree it could be a useful function to have. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64058/new/ https://re

Re: r365030 - Make a buildbot using a buggy gcc happy

Thanks Richard! > On Jul 8, 2019, at 12:46 PM, Richard Smith via cfe-commits > wrote: > > Committed as r365377. > > On Mon, 8 Jul 2019 at 12:43, Kristóf Umann via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Thank you so much! Sorry for the inconvencience, I'll be that much more

[PATCH] D62888: [NewPM] Port Sancov

leonardchan added a comment. *ping* @chandlerc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62888/new/ https://reviews.llvm.org/D62888 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D60456: [RISCV] Hard float ABI support

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, I think you can commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60456/new/ https://reviews.llvm.org/D60456 ___ cfe-commit

[PATCH] D60456: [RISCV] Hard float ABI support

asb added a comment. Thanks for the careful review John, I really appreciate it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60456/new/ https://reviews.llvm.org/D60456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang-tools-extra] r365380 - A test commit following 'Obtaining Commit Access' (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)

Author: jcai19 Date: Mon Jul 8 12:53:22 2019 New Revision: 365380 URL: http://llvm.org/viewvc/llvm-project?rev=365380&view=rev Log: A test commit following 'Obtaining Commit Access' (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access) Modified: clang-tools-extra/trunk/test/c

r365382 - [Sema] Resolve placeholder types before type deduction to silence

Author: ahatanak Date: Mon Jul 8 13:04:39 2019 New Revision: 365382 URL: http://llvm.org/viewvc/llvm-project?rev=365382&view=rev Log: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings The spurious -Warc-repeated-use-of-weak warnings

[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/include/llvm/Option/Arg.h:59 /// The argument values, as C strings. SmallVector Values; I'm not sure this is really true: > For conve

[PATCH] D64364: [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012

yaxunl created this revision. yaxunl added reviewers: ashi1, tra. Herald added a subscriber: jholewinski. https://reviews.llvm.org/D64364 Files: include/clang/Basic/Cuda.h lib/Basic/Cuda.cpp lib/Basic/Targets/NVPTX.cpp lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp Index: lib/CodeGen/CGOpenMPRunti

[PATCH] D62645: [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

This revision was automatically updated to reflect the committed changes. ahatanak marked an inline comment as done. Closed by commit rL365382: [Sema] Resolve placeholder types before type deduction to silence (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a subs

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari marked an inline comment as done. vzakhari added a comment. In D63846#1574102 , @rjmccall wrote: > Please don't check IR names in test output. That actually includes anonymous > names like `%2`; these should always be tested with FileCheck varia

[PATCH] D63857: [clang-doc] Add a structured HTML generator

jakehehrlich added a comment. This looks good to me! Comment at: clang-tools-extra/clang-doc/Generators.cpp:75-77 extern volatile int YAMLGeneratorAnchorSource; extern volatile int MDGeneratorAnchorSource; +extern volatile int HTMLGeneratorAnchorSource; I don

[PATCH] D63857: [clang-doc] Add a structured HTML generator

jakehehrlich added a comment. As in I'm not quite ready for this to land but It looks preety solid. I think if you respond to those comments I'll take one last look and then give an actual accept CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/ https://reviews.llvm.org/D63857

[PATCH] D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

erik.pilkington added a comment. Ping! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63912/new/ https://reviews.llvm.org/D63912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D63856: [ObjC] Add a -Wtautological-compare warning for BOOL

erik.pilkington added a comment. Ping! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63856/new/ https://reviews.llvm.org/D63856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

rjmccall added a comment. I don't know what I think about widespread use of `-fno-discard-value-names` for now; please continue to use FileCheck variables, and we can make a holistic decision about that flag later. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6

[PATCH] D63856: [ObjC] Add a -Wtautological-compare warning for BOOL

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63856/new/ https://reviews.llvm.org/D63856 ___ cfe-commi

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

rnk accepted this revision. rnk added a subscriber: zturner. rnk added a comment. This revision is now accepted and ready to land. lgtm I think @zturner wanted to teach lit to completely remove the Output/ directory for every test so we don't have to deal with stale files from previous tests ha

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

vzakhari added a comment. In D63846#1574302 , @rjmccall wrote: > I don't know what I think about widespread use of `-fno-discard-value-names` > for now; please continue to use FileCheck variables, and we can make a > holistic decision about that flag lat

[PATCH] D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

rjmccall added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3251 + "the only well defined values for BOOL are YES and NO">, + InGroup; The `from` seems awkward here; `%0` is the number, not the type. (I agree that the type i

[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

rjmccall added a comment. In D63846#1574311 , @vzakhari wrote: > In D63846#1574302 , @rjmccall wrote: > > > I don't know what I think about widespread use of > > `-fno-discard-value-names` for now; please continue

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

rjmccall added inline comments. Comment at: lib/CodeGen/TargetInfo.h:274 +return LangAS::Default; + } + This target hook should just return the address space of the `__cxa_atexit` argument, not to claim anything specific about the relation between that add

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. In D63602#1570884 , @ro wrote: > Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has > remained unreviewed for two weeks.

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

leonardchan added a comment. In D63638#1560991 , @craig.topper wrote: > In D63638#1560846 , @spatel wrote: > > > I skimmed D63174 but haven't applied > > either of these patches t

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

zhangxy988 updated this revision to Diff 208500. zhangxy988 marked 2 inline comments as done. zhangxy988 added a comment. - Remove empty line and add assertion message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64151/new/ https://reviews.llvm.o

[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

zhangxy988 marked an inline comment as done. zhangxy988 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/abseil-faster-strsplit-delimiter.cpp:55 + + absl::StrSplit("ABC", R"(A)"); + // CHECK-MESSAGES: [[@LINE-1]]:25: warning: absl::StrSplit() called with a

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

craig.topper added a comment. There's some inliner running because the intrinsics are implemented as always_inline functions and they are clearly being inlined in -O0. In a previous post, Chandler said the new PM has a special inliner for always_inline in -O0 and the old pass manager just used

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

rnk added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2283 if (Attr *ClassAttr = getDLLAttr(Class)) { - if (auto *BaseTemplate = dyn_cast_or_null( - BaseType->getAsCXXRecordDecl())) { This file seems untouched except for wh

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre updated this revision to Diff 208505. mgehre marked 11 inline comments as done. mgehre added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61749/new/ https://reviews.llvm.org/D61749 Files: clang-tools-

[PATCH] D61749: [clang-tidy] initial version of readability-static-const-method

mgehre marked 2 inline comments as done. mgehre added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ReadabilityTidyModule.cpp:96 +CheckFactories.registerCheck( +"readability-static-method"); CheckFactories.registerCheck(

[PATCH] D63894: [CXX] Exercise all paths through these tests

dblaikie added a comment. I would've assumed these conditionals were added by Sony folks for their change in default dialect - that doesn't necessarily mean these tests are needed upstream (the functionality may be tested elsewhere) Repository: rC Clang CHANGES SINCE LAST ACTION https://r

r365393 - Revert [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

Author: rnk Date: Mon Jul 8 14:59:07 2019 New Revision: 365393 URL: http://llvm.org/viewvc/llvm-project?rev=365393&view=rev Log: Revert [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings This reverts r365382 (git commit 8b1becf2e31d9

r365395 - Add parentheses to silence warnings.

Author: void Date: Mon Jul 8 15:01:07 2019 New Revision: 365395 URL: http://llvm.org/viewvc/llvm-project?rev=365395&view=rev Log: Add parentheses to silence warnings. Modified: cfe/trunk/lib/Tooling/Syntax/BuildTree.cpp Modified: cfe/trunk/lib/Tooling/Syntax/BuildTree.cpp URL: http://llvm.

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

ro added a comment. In D63602#1574337 , @vitalybuka wrote: > In D63602#1570884 , @ro wrote: > > > Ping^2. This one, like its companion https://reviews.llvm.org/D63601 has > > remained unreviewed for two weeks. > >

[PATCH] D63663: [clang-doc] Add html links to references

jakehehrlich added a comment. The code looks good to me. I'll let Julie give the final architectural approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63663/new/ https://reviews.llvm.org/D63663 ___ cfe-commits mailing list cfe-commits

r365396 - [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

Author: ro Date: Mon Jul 8 15:04:25 2019 New Revision: 365396 URL: http://llvm.org/viewvc/llvm-project?rev=365396&view=rev Log: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris As explained in https://reviews.llvm.org/D63601, there's no point using clang_rt.sancov_{begin,end} on So

[PATCH] D63602: [Sanitizers] Don't use clang_rt.sancov_{begin, end} on Solaris

This revision was automatically updated to reflect the committed changes. Closed by commit rL365396: [Sanitizers] Don't use clang_rt.sancov_{begin,end} on Solaris (authored by ro, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. I don't know much about OpenMP, but i guess i can help with the CFG a bit. I strongly recommend adding a few direct tests for the CFG so that to check that the order of statements and the overall topology of the CFG is as you intended. Currently those tests are routed throu

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

ABataev added inline comments. Comment at: test/OpenMP/nvptx_unsupported_type_codegen.cpp:79 } - -// CHECK: define weak void @__omp_offloading_{{.+}}foo{{.+}}_l75([[BIGTYPE:.+]]* MaskRay wrote: > ABataev wrote: > > MaskRay wrote: > > > ABataev wrote: > > > > Ma

r365402 - Fix line endings. NFC

Author: probinson Date: Mon Jul 8 15:35:30 2019 New Revision: 365402 URL: http://llvm.org/viewvc/llvm-project?rev=365402&view=rev Log: Fix line endings. NFC Modified: cfe/trunk/test/Driver/ps4-analyzer-defaults.cpp Modified: cfe/trunk/test/Driver/ps4-analyzer-defaults.cpp URL: http://llvm.

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso created this revision. Charusso added reviewers: NoQ, ravikandhadai. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, mgorny. It models the LLVM casts: - `cast<>` - `

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:75 +Children.emplace_back( +llvm::make_unique(Text.str(), !InlineChildren)); + } jakehehrlich wrote: > I think you can just write `Children.emplace_back(

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Charusso marked an inline comment as done. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:175 + else*/ +Param = CE->getArg(0); + This CXXMemberCallExpr business is necessary? I am not sure as I have not see

[PATCH] D63857: [clang-doc] Add a structured HTML generator

DiegoAstiazaran updated this revision to Diff 208527. DiegoAstiazaran marked 5 inline comments as done. DiegoAstiazaran added a comment. Add helper function to move a vector's elements to another vector. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63857/new/ https://reviews.llvm.org/D

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked an inline comment as done. ABataev added a comment. In D64356#1574540 , @NoQ wrote: > I don't know much about OpenMP, but i guess i can help with the CFG a bit. Thanks a lot! > I strongly recommend adding a few direct tests for the CFG so

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert created this revision. jdoerfert added reviewers: kkwli0, ABataev, RaviNarayanaswamy, gtbercea, Hahnfeld. Herald added subscribers: jfb, guansong, bollu. Herald added a project: clang. This adds a more fine-grained list of OpenMP features with their implementation status and associated

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

NoQ added a comment. In D64356#1574625 , @ABataev wrote: > That's strange. Maybe the patch applied incorrectly? Whoops, i needed to pull rC365334 . The patch has applied cleanly "with fuzz 2", which meant "oh there's n

r365405 - [Frontend] Explicitly include Bitstream/BitCodes.h and BitstreamWriter.h

Author: thegameg Date: Mon Jul 8 16:02:50 2019 New Revision: 365405 URL: http://llvm.org/viewvc/llvm-project?rev=365405&view=rev Log: [Frontend] Explicitly include Bitstream/BitCodes.h and BitstreamWriter.h This fixes a modules issue: error: declaration of 'bitc' must be imported from module 'C

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added a comment. The scheme itself looks good in general. Just as an improvement, it would be good to use coloring for the feature status. Also, what's the difference between claimed, mostly done and done? Comment at: clang/docs/OpenMPSupport.rst:153 ++

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

jdoerfert marked 2 inline comments as done. jdoerfert added a comment. In D64375#1574662 , @ABataev wrote: > The scheme itself looks good in general. Good. Once we agreed on a scheme we can improve the actual process, excel sheet, generator script, etc.

r365406 - [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

Author: dblaikie Date: Mon Jul 8 16:24:41 2019 New Revision: 365406 URL: http://llvm.org/viewvc/llvm-project?rev=365406&view=rev Log: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable. This is a fix for rG864949 which only disabled default constru

[PATCH] D64058: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default-constructible and assignable.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365406: [cxx2a] P0624R2 fix: only lambdas with no lambda-capture are default… (authored by dblaikie, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D59919: [Attributor] Deduce "returned" argument attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL365407: [Attributor] Deduce the "returned" argument attribute (authored by jdoerfert, committed by ). Changed prior to commit: https://reviews.llvm.org/D59919?vs=207924&id=208536#toc Repository: rL L

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added a comment. In D64375#1574698 , @jdoerfert wrote: > In D64375#1574662 , @ABataev wrote: > > > The scheme itself looks good in general. > > > Good. Once we agreed on a scheme we can improve the actual pr

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis updated this revision to Diff 208538. thakis marked 2 inline comments as done. thakis added a comment. Herald added a subscriber: mstorsjo. comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64349/new/ https://reviews.llvm.org/D64349 Files: clang/include/clang/Basic/Attr.t

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis added a comment. Thanks! Comment at: clang/test/Sema/pragma-section.c:57 + +// Not sure if this should warn or not. +__attribute__((section(".drectve"))) int drectve_int; rnk wrote: > I agree it probably shouldn't, I imagine mingw users will want to be a

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

leonardchan added a comment. In D63638#1574373 , @craig.topper wrote: > There's some inliner running because the intrinsics are implemented as > always_inline functions and they are clearly being inlined in -O0. In a > previous post, Chandler said the n

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm May I ask what inspired this? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64349/new/ https://reviews.llvm.org/D64349 ___ cfe-commit

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:25-27 + using CastCheck = + std::function; Kinda nice, but a simple pointer-to-member would have been sufficient and much more lightweight: ```lang=c++ using Cas

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added a comment. The overall code looks great! It's well-structured and easy to understand, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64374/new/ https://reviews.llvm.org/D64374 ___ cfe-commits mailin

r365408 - [ObjC] Add a -Wtautological-compare warning for BOOL

Author: epilk Date: Mon Jul 8 16:42:52 2019 New Revision: 365408 URL: http://llvm.org/viewvc/llvm-project?rev=365408&view=rev Log: [ObjC] Add a -Wtautological-compare warning for BOOL On macOS, BOOL is a typedef for signed char, but it should never hold a value that isn't 1 or 0. Any code that e

[PATCH] D63856: [ObjC] Add a -Wtautological-compare warning for BOOL

erik.pilkington added a comment. In D63856#1561160 , @rjmccall wrote: > In D63856#1561132 , @erik.pilkington > wrote: > > > In D63856#1561112 , @rjmccall > > wrote: > > > >

[PATCH] D64374: [analyzer] CastValueChecker: Model casts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:124 + +Out << "Cast from a null pointer results in a null pointer"; +return Out.str(); `Assuming null pointer is passed into cast` o.o Repository: rC

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

thakis added a comment. In D64349#1574742 , @rnk wrote: > lgtm Thanks! > May I ask what inspired this? :) I was looking through lld/COFF/Driver.cpp for something…ah, right, because D64156 touched it, and because I loo

[PATCH] D63856: [ObjC] Add a -Wtautological-compare warning for BOOL

This revision was automatically updated to reflect the committed changes. Closed by commit rL365408: [ObjC] Add a -Wtautological-compare warning for BOOL (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

thakis added a comment. > lgtm Thanks! > 5381 361257 out/clang/browser_tests.exe.rsp Looking at that file, that looks like 10554 distinct args from the rsp file. That's ~80kB for the additional pointer, which for a link that's going to consume hundreds of MB isn't all that much overhead. (

r365410 - [analyzer] exploded-graph-rewriter: Implement a topology-only mode.

Author: dergachev Date: Mon Jul 8 16:54:14 2019 New Revision: 365410 URL: http://llvm.org/viewvc/llvm-project?rev=365410&view=rev Log: [analyzer] exploded-graph-rewriter: Implement a topology-only mode. In this mode the rewriter will only rewrite program points and omit program states. Useful fo

[PATCH] D64263: [analyzer] exploded-graph-rewriter: Implement a single-path mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365409: [analyzer] exploded-graph-rewriter: Implement a single-path mode. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

r365409 - [analyzer] exploded-graph-rewriter: Implement a single-path mode.

Author: dergachev Date: Mon Jul 8 16:54:11 2019 New Revision: 365409 URL: http://llvm.org/viewvc/llvm-project?rev=365409&view=rev Log: [analyzer] exploded-graph-rewriter: Implement a single-path mode. Instead of rewriting the whole graph, rewrite the leftmost path in the graph. Useful for trimme

[PATCH] D64264: [analyzer] exploded-graph-rewriter: Implement a topology-only mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365410: [analyzer] exploded-graph-rewriter: Implement a topology-only mode. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64067/new/ https://reviews.llvm.org/D64067 ___ cfe-commits mailing

r365411 - clang-cl: Port cl.exe's C4659 to clang-cl

Author: nico Date: Mon Jul 8 17:02:23 2019 New Revision: 365411 URL: http://llvm.org/viewvc/llvm-project?rev=365411&view=rev Log: clang-cl: Port cl.exe's C4659 to clang-cl Differential Revision: https://reviews.llvm.org/D64349 Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/in

[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rL365411: clang-cl: Port cl.exe's C4659 to clang-cl (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

emmettneyman updated this revision to Diff 208544. emmettneyman added a comment. Undo clang-format changes to SemaDecl.cpp and SemaDeclAttr.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64380/new/ https://reviews.llvm.org/D64380 Files: clang

[PATCH] D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

erik.pilkington updated this revision to Diff 208545. erik.pilkington marked 2 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63912/new/ https://reviews.llvm.org/D63912 Files: clang/include/clang/Basic/

[PATCH] D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3251 + "the only well defined values for BOOL are YES and NO">, + InGroup; rjmccall wrote: > The `from` seems awkward here; `%0` is the number, not the type.

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

juliehockett created this revision. juliehockett added reviewers: dlj, phosek. Herald added a reviewer: EricWF. The DetectLibcxxIncludePath function had been using llvm::sys::fs::directory_iterator, and this updates it to use llvm::vfs::directory_iterator. https://reviews.llvm.org/D64381 File

[PATCH] D64382: Use getMostFrequentByte to decide if should used memset+stores

vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. vitalybuka added a parent revision: D64111: Add getMostFrequentByte and use for isBytewiseValue implementation. Previous implementatio

[PATCH] D64381: Update libc++ include path detection to use VFS on Linux

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Driver/ToolChains/Linux.cpp:868 -static std::string DetectLibcxxIncludePath(StringRef base) { +static std::string DetectLibcxxIncludePath(StringR

r365412 - [X86][PPC] Support -mlong-double-64

Author: maskray Date: Mon Jul 8 17:27:43 2019 New Revision: 365412 URL: http://llvm.org/viewvc/llvm-project?rev=365412&view=rev Log: [X86][PPC] Support -mlong-double-64 -mlong-double-64 is supported on some ports of gcc (i386, x86_64, and ppc{32,64}). On many other targets, there will be an err

[PATCH] D64067: [X86][PPC] Support -mlong-double-64

This revision was automatically updated to reflect the committed changes. Closed by commit rL365412: [X86][PPC] Support -mlong-double-64 (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D57086: Ignore trailing NullStmts in StmtExprs for GCC compatibility

domdom updated this revision to Diff 208550. domdom added a comment. Thank you for catching that @aaron.ballman! I forgot to update the test after the running clang-format. I thought I ran the tests again before submitting, but I guess I didn't :P Thanks again! CHANGES SINCE LAST ACTION htt

[PATCH] D63912: [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3251 + "the only well defined values for BOOL are YES and NO">, + InGroup; erik.pilk

[PATCH] D64062: Remove both -dumpversion and __VERSION__

rnk added a comment. In D64062#1567175 , @sylvestre.ledru wrote: > This isn't firefox per say but thirdparty apps. > If you feel confident, sure, we can land that and see what happens :) One concern that I have is that we don't have a replacement for `

r365413 - Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

Author: nico Date: Mon Jul 8 17:34:08 2019 New Revision: 365413 URL: http://llvm.org/viewvc/llvm-project?rev=365413&view=rev Log: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics With this, `clang-cl /source-charset:utf-16 test.cc`

r365414 - Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

Author: nico Date: Mon Jul 8 17:36:18 2019 New Revision: 365414 URL: http://llvm.org/viewvc/llvm-project?rev=365414&view=rev Log: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source This is a better fix for the problem fixed in r334972. Also remove the rm'ing of the sym

[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

This revision was automatically updated to reflect the committed changes. Closed by commit rL365414: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64253: Let unaliased Args track which Alias they were created from, and use that in Arg::getAsString() for diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rL365413: Let unaliased Args track which Alias they were created from, and use that in… (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D64253?vs=208192&id=208553#toc

[PATCH] D19312: Warn about UB at member function calls from base class ctor initializers.

NoQ added a comment. Sorry, couldn't help it. This patch looks so useful and so lonely :) Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6782 +def warn_member_call_in_ctor_init : Warning< + "member function call %0 in ctor-initializer for base class %1 results in " +

[PATCH] D64380: Add 'require_designated_init' and 'required' attribute to clang

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1948 +def RequireDesignatedInit : InheritableAttr { + let Spellings = [GNU<"require_designated_init">]; + let Subjects = SubjectList<[Type]>; This seems like an extension? I think th

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

craig.topper added a comment. In D63638#1574740 , @leonardchan wrote: > In D63638#1574373 , @craig.topper > wrote: > > > There's some inliner running because the intrinsics are implemented as > > always_inline fun

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

craig.topper added a comment. What if we just only check the output from the new pass manager. I don't think I care about the differences between the two. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63638/new/ https://reviews.llvm.org/D63638 ___

[PATCH] D64383: build: use multiple `install` rather than building up a list

compnerd created this revision. compnerd added reviewers: smeenai, beanz, EricWF. Herald added subscribers: libcxx-commits, ldionne, mgorny. Rather than building up a list to iterate over later, just create multiple `install` commands based on the configuration. This makes it easier to see what

[PATCH] D64317: [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272

MaskRay updated this revision to Diff 208565. MaskRay added a comment. Fix getPPTransparentSanitizers (test/Modules/check-for-sanitizer-feature.cpp) & ubsan_blacklist.txt Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64317/new/ https://reviews.llvm.org/D64317 F

<    1   2   3   >