thakis added a comment. In D64349#1574742 <https://reviews.llvm.org/D64349#1574742>, @rnk wrote:
> lgtm Thanks! > May I ask what inspired this? :) I was looking through lld/COFF/Driver.cpp for something…ah, right, because D64156 <https://reviews.llvm.org/D64156> touched it, and because I looked through all uses of getSpelling() for D64253 <https://reviews.llvm.org/D64253>, and noticed that LinkerDriver::parseDirectives() had an empty branch for OPT_natvis. I figured that was probably from before lld-link supported /natvis: and made a note to implement support for /natvis: in a .drectve (anticlimatic result of that sidequest was "link.exe doesn't allow /natvis in .drective", resulting in D64352 <https://reviews.llvm.org/D64352>), and I remembered `#pragma data_seg(".drectve")` before remembering `#pragma comment(linker)` and saw that cl.exe had this warning and I thought it was kind of useful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64349/new/ https://reviews.llvm.org/D64349 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
