rnk added inline comments.

================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2283
     if (Attr *ClassAttr = getDLLAttr(Class)) {
-      if (auto *BaseTemplate = 
dyn_cast_or_null<ClassTemplateSpecializationDecl>(
-              BaseType->getAsCXXRecordDecl())) {
----------------
This file seems untouched except for whitespace changes, let's revert them.


================
Comment at: clang/test/Sema/pragma-section.c:57
+
+// Not sure if this should warn or not.
+__attribute__((section(".drectve"))) int drectve_int;
----------------
I agree it probably shouldn't, I imagine mingw users will want to be able to 
use this kind of code pattern to interop between GCC and Clang:
  __attribute__((section(".drective")))
  const char LinkerFlags[] = "-export:foo -export:bar";


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64349/new/

https://reviews.llvm.org/D64349



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to