[PATCH] D14484: Formatting constructor initializer lists by putting them always on different lines

nhlubek added a comment. Is it possible to discuss about this feature again? This is only a corner case if you allow only 80 characters per line. If you allow more characters (e.g. you use doxygen for inline formatting and want some space on the right) this quickly becomes very relevant, because

[clang-tools-extra] r364008 - [clang-tidy] Move test files of rL363975 into Inputs directory

Author: kadircet Date: Fri Jun 21 00:54:27 2019 New Revision: 364008 URL: http://llvm.org/viewvc/llvm-project?rev=364008&view=rev Log: [clang-tidy] Move test files of rL363975 into Inputs directory Added: clang-tools-extra/trunk/test/clang-tidy/Inputs/empty-database/ clang-tools-extra/tr

[clang-tools-extra] r364010 - [clang-tidy] Fix a typo in the doc.

Author: hokein Date: Fri Jun 21 00:58:19 2019 New Revision: 364010 URL: http://llvm.org/viewvc/llvm-project?rev=364010&view=rev Log: [clang-tidy] Fix a typo in the doc. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-duration-addition.rst Modified: clang-tools-extra/trunk/do

Re: [PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

Hi Richard, This commit broke ARM bots, logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/13576/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Atail-padding.cpp Thanks, Yvan On Thu, 20 Jun 2019 at 23:06, John McCall via Phabricator via llvm-commits wro

RE: [clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty database fields

Hi Serge, The test you added here is failing on the PS4 Windows build bot, can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26513/steps/test/logs/stdio FAIL: Clang Tools :: clang-tidy/empty-database.cpp (14917 of 50455) *

r364011 - [clang] Small improvments after Adding APValue to ConstantExpr

Author: tyker Date: Fri Jun 21 01:26:21 2019 New Revision: 364011 URL: http://llvm.org/viewvc/llvm-project?rev=364011&view=rev Log: [clang] Small improvments after Adding APValue to ConstantExpr Summary: this patch has multiple small improvements related to the APValue in ConstantExpr. changes:

[PATCH] D63376: [clang] Small improvments after Adding APValue to ConstantExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL364011: [clang] Small improvments after Adding APValue to ConstantExpr (authored by Tyker, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D61842: [clangd] [WIP] [Not ready for review] Semantic highlighting

nik added a comment. Some general notes regarding the current state of this patch as I was testing it with a language client: - It still applies for current trunk, except for a *Tests* file. - Note that a VersionedTextDocumentIdentifier has to be used, e.g. a "version" must be included in the r

[PATCH] D63559: [clang-tidy] Added functionality for getting semantic highlights for variable and function declarations

hokein added a comment. Thanks, I think we can simplify the interface further, see my comments inline. The boundary of this patch seems unclear, currently it contains C++ APIs, and some implementations for semantic highlighting LSP. I think we should merely focus on the C++ APIs in this patch.

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

Hi Rainer, Your change appears to have broken the one platform you didn't test, Windows. :) http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26514/steps/test/logs/stdio FAIL: Clang :: Driver/cl-response-file.c (8601 of 50455) TEST 'Cl

[PATCH] D63621: [git-clang-format] recognize hxx as a C++ file

ilya-biryukov accepted this revision. ilya-biryukov added a reviewer: ilya-biryukov. ilya-biryukov added a comment. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63621/new/ https://reviews.llvm.org/D63621 ___ c

Re: [clang-tools-extra] r363975 - [clang-tidy] Fail gracefully upon empty database fields

On Fri, Jun 21, 2019 at 08:16:42AM +, douglas.y...@sony.com wrote: > Hi Serge, > > The test you added here is failing on the PS4 Windows build bot, can you take > a look? Sure, thanks for fwding it! > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/

r364014 - [git-clang-format] recognize hxx as a C++ file

Author: vmiklos Date: Fri Jun 21 02:49:38 2019 New Revision: 364014 URL: http://llvm.org/viewvc/llvm-project?rev=364014&view=rev Log: [git-clang-format] recognize hxx as a C++ file clangd, clang-tidy, etc does that already, no reason why git-clang-format should skip hxx files. Reviewed By: ilya-

[PATCH] D63621: [git-clang-format] recognize hxx as a C++ file

This revision was automatically updated to reflect the committed changes. Closed by commit rL364014: [git-clang-format] recognize hxx as a C++ file (authored by vmiklos, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D63621: [git-clang-format] recognize hxx as a C++ file

vmiklos added a comment. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63621/new/ https://reviews.llvm.org/D63621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus updated this revision to Diff 205954. Szelethus added a comment. - Collect only `ExplodedNode`s. Lesson learned! - Add a `TODO:` in `trackExpressionValue` about maybe tracking conditions to all bug locations, rather than only for tracked variables. CHANGES SINCE LAST ACTION https://

[PATCH] D63498: [RISC-V] Add -msave-restore and -mno-save-restore to clang driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL364018: [RISC-V] Add -msave-restore and -mno-save-restore to clang driver (authored by lenary, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker created this revision. Tyker added a reviewer: rsmith. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: clang. Herald added a subscriber: cfe-commits. Tyker edited the summary of this revision. Herald added a subscriber: rnkovacs. Changes: - initial

r364021 - [cmake] Add llvm-dwarfdump to clang test dependencies

Author: svenvh Date: Fri Jun 21 03:26:20 2019 New Revision: 364021 URL: http://llvm.org/viewvc/llvm-project?rev=364021&view=rev Log: [cmake] Add llvm-dwarfdump to clang test dependencies Commit r363496 ("[Clang] Harmonize Split DWARF options with llc", 2019-06-15) introduced the use of llvm-dwarf

r364020 - [OpenCL] Remove duplicate read_image declarations

Author: svenvh Date: Fri Jun 21 03:26:10 2019 New Revision: 364020 URL: http://llvm.org/viewvc/llvm-project?rev=364020&view=rev Log: [OpenCL] Remove duplicate read_image declarations Patch by Pierre Gondois. Modified: cfe/trunk/lib/Headers/opencl-c.h Modified: cfe/trunk/lib/Headers/opencl-c

[PATCH] D59673: [Clang] Harmonize Split DWARF options with llc

svenvh added a comment. As a followup to r363496, I've added llvm-dwarfdump as a clang test dependency in r364021. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59673/new/ https://reviews.llvm.org/D59673 ___ cfe-comm

r364023 - [Sema] Improved diagnostic for qualifiers in reference binding

Author: stulova Date: Fri Jun 21 03:50:02 2019 New Revision: 364023 URL: http://llvm.org/viewvc/llvm-project?rev=364023&view=rev Log: [Sema] Improved diagnostic for qualifiers in reference binding Improved wording and also simplified by using printing method from qualifiers. Differential Revisio

[PATCH] D62914: [Sema] Fix diagnostic for addr spaces in reference binding

This revision was automatically updated to reflect the committed changes. Closed by commit rL364023: [Sema] Improved diagnostic for qualifiers in reference binding (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D63426: [clangd] Narrow rename to local symbols.

hokein updated this revision to Diff 205963. hokein added a comment. Improve the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63426/new/ https://reviews.llvm.org/D63426 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-extra

[PATCH] D63642: [analyzer] Add a debug analyzer config to place an event for each tracked condition

Szelethus created this revision. Szelethus added reviewers: NoQ, baloghadamsoftware, xazax.hun, Charusso, rnkovacs, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Exactly what it s

r364032 - [Sema] Fix diagnostic for addr spaces in reference binding

Author: stulova Date: Fri Jun 21 04:36:15 2019 New Revision: 364032 URL: http://llvm.org/viewvc/llvm-project?rev=364032&view=rev Log: [Sema] Fix diagnostic for addr spaces in reference binding Extend reference binding behavior to account for address spaces. Differential Revision: https://reviews

r364033 - Fix test/AST/ast-dump-records-json.cpp after ConstantExpr change in D63376

Author: maskray Date: Fri Jun 21 04:39:41 2019 New Revision: 364033 URL: http://llvm.org/viewvc/llvm-project?rev=364033&view=rev Log: Fix test/AST/ast-dump-records-json.cpp after ConstantExpr change in D63376 Modified: cfe/trunk/test/AST/ast-dump-records-json.cpp Modified: cfe/trunk/test/AST

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov updated this revision to Diff 205974. ilya-biryukov added a comment. - A few more renames and docs - Cleanups and comments - Reformat the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61637/new/ https://reviews.llvm.org/D61637 F

r364018 - [RISC-V] Add -msave-restore and -mno-save-restore to clang driver

Author: lenary Date: Fri Jun 21 03:03:31 2019 New Revision: 364018 URL: http://llvm.org/viewvc/llvm-project?rev=364018&view=rev Log: [RISC-V] Add -msave-restore and -mno-save-restore to clang driver Summary: The GCC RISC-V toolchain accepts `-msave-restore` and `-mno-save-restore` to control whet

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63134/new/ https://reviews.llvm.org/D63134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov marked 13 inline comments as done. ilya-biryukov added a comment. This is ready for another round now. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:37 + /// and \p Last are added as children of the new node. + void learnNode(SourceLocation Fist, SourceLoca

[PATCH] D61637: [Syntax] Introduce syntax trees

ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. Although there are still rough edges, I believe the storage model is agreed upon and we can hopefully address the rest in the follow-ups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev updated this revision to Diff 205978. anton-afanasyev added a comment. Hi @lebedev.ri, I've turned back to the solution with one `TimeTraceScope` for "Frontend" inside `BackendConsumer::HandleTranslationUnit()`, since it looks more robust. This admits several (two for now) "Front

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

lebedev.ri resigned from this revision. lebedev.ri added a comment. I'm sorry, i should have noticed that earlier, the handling of `"Frontend"` section still looks way too intrusive to me, it breaks abstractions. The only simple solution i see is to 1. Insert a timer for `PrettyStackTraceStrin

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

lebedev.ri added a comment. Hm, i started writing previous comment before you posted your last comment, so i didn't see the last update. This looks less intrusive, yes, but two observations: 1. You now have two `"Frontend"` sections - first one being for lexing time 2. That lexing section is not

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. In D63325#1553458 , @lebedev.ri wrote: > Hm, i started writing previous comment before you posted your last comment, > so i didn't see the last update. > This looks less intrusive, yes, but two observations: > > 1. You no

[clang-tools-extra] r364044 - [clangd] Add include-mapping for C symbols.

Author: hokein Date: Fri Jun 21 06:32:18 2019 New Revision: 364044 URL: http://llvm.org/viewvc/llvm-project?rev=364044&view=rev Log: [clangd] Add include-mapping for C symbols. Summary: This resolves the issue of introducing c++-style includes for C files. - refactor the gen_std.py, make it reus

[PATCH] D63264: [clang][Driver] Deduce target triplet from clang executable name

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63264/new/ https://reviews.llvm.org/D63264 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

sylvestre.ledru added a comment. FYI, I had similar patches for Linux/Debian packaging. Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 ___ cfe-commits mailing list cfe

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

kadircet marked an inline comment as done. kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63194/new/ https://reviews.llvm.org/D63194 ___ cfe-commits mailing list cfe-commi

[PATCH] D62804: [clangd] Enable extraction of system includes from custom toolchains

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62804/new/ https://reviews.llvm.org/D62804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D63270: [clangd] Add include-mapping for C symbols.

This revision was automatically updated to reflect the committed changes. Closed by commit rL364044: [clangd] Add include-mapping for C symbols. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D63648: [Preprocessor] Honor absolute paths in diagnostics

aganea created this revision. aganea added reviewers: hans, thakis, rsmith. aganea added a project: clang. Previously, `-fdiagnostics-absolute-paths` did not have an effect in some cases, for example: when using relative include paths, or relative CPP paths, or `--show-includes`, or `-E` or disp

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

anton-afanasyev added a comment. Also, first `"Frontend"` section contains `"ParseTemplate"` and `"PerformPendingInstantiations"` sections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325/new/ https://reviews.llvm.org/D63325 ___

[PATCH] D63649: AMDGPU: Fix target builtins for gfx10

arsenm created this revision. arsenm added a reviewer: rampitec. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. This wasn't setting some of the features from older generations. https://reviews.llvm.org/D63649 Files: lib/Basic/Targets/AMDGPU.cpp

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land. LGTM! Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63579/new/ https://reviews.llvm.org/D63579 ___ cfe-commits mailing list c

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

tejohnson added a comment. Adding Wei who works on SamplePGO on our end currently. Comment at: llvm/lib/Passes/PassBuilder.cpp:665-668 +// We must also remove exception handling before attaching sample profile +// data. +MPM.addPass( +createModuleToPostOrder

[PATCH] D62584: [OpenCL][PR42033] Deducing addr space with template parameter types

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/Sema/TreeTransform.h:5363 +if (ResultType.getAddressSpace() != LangAS::Default && +(ResultType.getAddressSpace() != LangAS::opencl_private)) { SemaRef.Diag(TL.getReturn

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

davidxl added a comment. Is there a bug reference somewhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63626/new/ https://reviews.llvm.org/D63626 ___ cfe-commits mailing list cfe-commits@lists.llvm

r364055 - Add an automated note to files produced by gen_ast_dump_json_test.py.

Author: aaronballman Date: Fri Jun 21 07:37:39 2019 New Revision: 364055 URL: http://llvm.org/viewvc/llvm-project?rev=364055&view=rev Log: Add an automated note to files produced by gen_ast_dump_json_test.py. This also details what filters, if any, were used to generate the test output. Updates

[PATCH] D63264: [clang][Driver] Deduce target triplet from clang executable name

ilya-biryukov added a comment. After looking at this, adjusting arguments on the clangd side seems to be a better approach. Let's abandon this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63264/new/ https://reviews.llvm.org/D63264 ___

[PATCH] D63194: [clangd] Link in target infos and pass target and mode while invoking driver

ilya-biryukov added a comment. Sorry about the confusion, I can now see why the original version of the patch was actually simpler. I was put off by the fact that we override by adding command-line arguments instead of passing things around in the code, but it appears that's actually simpler th

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:132 + Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast( + CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy); r

r364061 - [OPENMP]Fix PR42159: do not capture threadprivate variables.

Author: abataev Date: Fri Jun 21 08:08:30 2019 New Revision: 364061 URL: http://llvm.org/viewvc/llvm-project?rev=364061&view=rev Log: [OPENMP]Fix PR42159: do not capture threadprivate variables. The threadprivate variables should not be captured in the outlined regions, otherwise it leads to the

Re: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

Hi Douglas, > Your change appears to have broken the one platform you didn't test, Windows. > :) sorry about that. Unfortunately, I know next to nothing about Windows and don't have access to any system to test. That said... > Script: > -- > : 'RUN: at line 7'; printf > '/IC:\ps4-buildslave2\

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

tuktuk updated this revision to Diff 206006. tuktuk added a comment. Herald added subscribers: Sanitizers, kubamracek, srhines. I followed Roman Lebedev's advice and adapted the `sanitizer_coverage_no_prune.cc` test to create a `sanitizer_coverage_whitelist_blacklist.cc` test under `make check_s

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 206009. dgoldman added a comment. - Fix ambiguity handling and add more tests Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-corre

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 added a comment. Any comments? If no, please approve.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63423/new/ https://reviews.llvm.org/D63423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

dgoldman updated this revision to Diff 206011. dgoldman added a comment. - Add another test and fix up comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62648/new/ https://reviews.llvm.org/D62648 Files: lib/Sema/SemaExprCXX.cpp test/Sema/typo-correction-

r364066 - [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

Author: leonardchan Date: Fri Jun 21 09:03:06 2019 New Revision: 364066 URL: http://llvm.org/viewvc/llvm-project?rev=364066&view=rev Log: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests As per the discussion on D58375, we disable test that have optimizations under the new PM. This

[PATCH] D63156: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL364066: [clang][NewPM] Add -fno-experimental-new-pass-manager to tests (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D63156?vs=205906&id=206013#toc Reposi

r364067 - Print more type node information when dumping the AST to JSON.

Author: aaronballman Date: Fri Jun 21 09:06:09 2019 New Revision: 364067 URL: http://llvm.org/viewvc/llvm-project?rev=364067&view=rev Log: Print more type node information when dumping the AST to JSON. Added: cfe/trunk/test/AST/ast-dump-types-json.cpp Modified: cfe/trunk/include/clang/AST

r364071 - [OpenCL][PR41963] Add generic addr space to old atomics in C++ mode

Author: stulova Date: Fri Jun 21 09:19:16 2019 New Revision: 364071 URL: http://llvm.org/viewvc/llvm-project?rev=364071&view=rev Log: [OpenCL][PR41963] Add generic addr space to old atomics in C++ mode Add overloads with generic address space pointer to old atomics. This is currently only added f

[PATCH] D62373: [ASTImporter] Store import errors for Decls

martong updated this revision to Diff 206017. martong added a comment. - Remove formatv b/c it can't handle braces in code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62373/new/ https://reviews.llvm.org/D62373 Files: clang/include/clang/AST/AS

[PATCH] D63603: [ASTImporter] Propagate error from ImportDeclContext

martong updated this revision to Diff 206018. martong added a comment. - Remove formatv b/c it can't handle braces in code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63603/new/ https://reviews.llvm.org/D63603 Files: clang/lib/AST/ASTImporter.

[PATCH] D62335: [OpenCL][PR41963] Add overloads of old atomics with generic pointer type in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL364071: [OpenCL][PR41963] Add generic addr space to old atomics in C++ mode (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D63649: AMDGPU: Fix target builtins for gfx10

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63649/new/ https://reviews.llvm.org/D63649 ___ cfe-commits mailing list cfe-commi

[PATCH] D62373: [ASTImporter] Store import errors for Decls

martong updated this revision to Diff 206020. martong added a comment. - Remove unused include and using Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62373/new/ https://reviews.llvm.org/D62373 Files: clang/include/clang/AST/ASTImporter.h clan

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

jfb added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:508 def Varargs : DiagGroup<"varargs">; +def XorUsedAsPow : DiagGroup<"xor-used-as-pow">; Does this match the naming that GCC ended up with? Comment at: include/c

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

martong updated this revision to Diff 206022. martong added a comment. - Add test ErrorPropagatesThroughImportCycles - Change existing test to new behaviour Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62375/new/ https://reviews.llvm.org/D62375 F

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

martong added a comment. Alexei, Thank you for the review, I have added a test which demonstrates the changes. By tracking the import paths and cycles we implement a very strict error handling mechanism, but this seems to be the way to avoid reaching any faulty AST nodes for the ASTImporter cli

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

Quuxplusone added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10950 + + // Do not diagnose binary literals. + if (ExprStr.find("0b") != llvm::StringRef::npos) I would rather see this whole section as a three-liner: // Do not diagnose binary, octal,

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked 3 inline comments as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:508 def Varargs : DiagGroup<"varargs">; +def XorUsedAsPow : DiagGroup<"xor-used-as-pow">; jfb wrote: > Does this match the naming tha

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10983 + +S.Diag(Loc, diag::note_xor_used_as_pow_silence) << ("0x2 ^ " + RHSStr); + } else if (LeftSideValue == 10) { Quuxplusone wrote: > Do you curr

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

martong added a comment. Alexei, Thanks for the review! I have provided test cases for the 3 previous patches on which this one depends on. I will provide additional tests next week for this one, and of course will address the other comments. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

Quuxplusone added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10929 +// Do not diagnose if xor keyword is used. +if (ExprStr.find("xor") != llvm::StringRef::npos) + return; xbolva00 wrote: > jfb wrote: > > Doesn't this match any expression tha

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10929 +// Do not diagnose if xor keyword is used. +if (ExprStr.find("xor") != llvm::StringRef::npos) + return; Quuxplusone wrote: > xbolva00

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

jfb added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10929 +// Do not diagnose if xor keyword is used. +if (ExprStr.find("xor") != llvm::StringRef::npos) + return; xbolva00 wrote: > Quuxplusone wrote: > > xbolva00 wrote: > > > jfb wrote: > >

[PATCH] D63180: [clang-doc] Adds HTML generator

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:87 +std::string CloseTag = I.SelfClosing ? "/>" : ">"; +writeLine("<" + I.Name + Attrs.str() + CloseTag, OS); + } else if (I.Kind == "HTMLEndTagComment") { You

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10929 +// Do not diagnose if xor keyword is used. +if (ExprStr.find("xor") != llvm::StringRef::npos) + return; jfb wrote: > xbolva00 wrote: >

r364078 - Ensure that top-level QualType objects also have a "kind" field when dumping the AST to JSON.

Author: aaronballman Date: Fri Jun 21 10:14:25 2019 New Revision: 364078 URL: http://llvm.org/viewvc/llvm-project?rev=364078&view=rev Log: Ensure that top-level QualType objects also have a "kind" field when dumping the AST to JSON. Modified: cfe/trunk/lib/AST/JSONNodeDumper.cpp cfe/trun

r364080 - [OPENMP]Fix PR42068: Vla type is not captured.

Author: abataev Date: Fri Jun 21 10:28:41 2019 New Revision: 364080 URL: http://llvm.org/viewvc/llvm-project?rev=364080&view=rev Log: [OPENMP]Fix PR42068: Vla type is not captured. If the variably modified type is declared outside of the captured region and then used in the cast expression along

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10929 +// Do not diagnose if xor keyword is used. +if (ExprStr.find("xor") != llvm::StringRef::npos) + return; xbolva00 wrote: > jfb wrote: >

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

aaron.ballman added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10929 +// Do not diagnose if xor keyword is used. +if (ExprStr.find("xor") != llvm::StringRef::npos) + return; xbolva00 wrote: > xbolva00 wrote: > > jfb wrote: > > > xbolva00 wrot

[PATCH] D63423: [Diagnostics] Diagnose misused xor as pow

jfb added inline comments. Comment at: lib/Sema/SemaExpr.cpp:10929 +// Do not diagnose if xor keyword is used. +if (ExprStr.find("xor") != llvm::StringRef::npos) + return; aaron.ballman wrote: > xbolva00 wrote: > > xbolva00 wrote: > > > jfb wrote: >

r364081 - Fix ARM buildbot.

Author: rsmith Date: Fri Jun 21 10:41:20 2019 New Revision: 364081 URL: http://llvm.org/viewvc/llvm-project?rev=364081&view=rev Log: Fix ARM buildbot. Modified: cfe/trunk/test/CodeGenCXX/tail-padding.cpp Modified: cfe/trunk/test/CodeGenCXX/tail-padding.cpp URL: http://llvm.org/viewvc/llvm-p

Re: [PATCH] D63451: P0840R2: support for [[no_unique_address]] attribute

Thanks, should hopefully be fixed by r364081. On Fri, 21 Jun 2019 at 01:12, Yvan Roux via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, > > This commit broke ARM bots, logs are available here: > > > http://lab.llvm.org:8011/builders/clang-cmake-armv8-quick/builds/13576/steps/ninj

[clang-tools-extra] r364087 - Quote path to Python executable in case it has spaces

Author: rnk Date: Fri Jun 21 11:17:04 2019 New Revision: 364087 URL: http://llvm.org/viewvc/llvm-project?rev=364087&view=rev Log: Quote path to Python executable in case it has spaces These days Python 3 is typically installed into C:/Program Files, so cope with that. Similar to r364077 in compi

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

Hi Rainer, I tried your patch and it still has problems. First, the "%s" was being replaced with the actual path by LIT, so I replaced that with "%%s" which then created the response file correctly, but now the response file contains this: /IC:\src\git\dev\llvm\tools\clang\test\Driver\Inputs\\c

[PATCH] D63579: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB

This revision was automatically updated to reflect the committed changes. Closed by commit rL364088: [clang-scan-deps] print the dependencies to stdout (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

r364088 - [clang-scan-deps] print the dependencies to stdout

Author: arphaman Date: Fri Jun 21 11:24:55 2019 New Revision: 364088 URL: http://llvm.org/viewvc/llvm-project?rev=364088&view=rev Log: [clang-scan-deps] print the dependencies to stdout and remove the need to use -MD options in the CDB Differential Revision: https://reviews.llvm.org/D63579 Modif

[PATCH] D63600: [test][Driver] Fix Clang :: Driver/cl-response-file.c

rnk added a comment. This causes the test to fail on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/7712 There seems to be something wrong with the blamelist, so it didn't send email. I see this in the log from the previous build on that bot: Updating llvm to 363241

r364089 - Revert [test][Driver] Fix Clang :: Driver/cl-response-file.c

Author: rnk Date: Fri Jun 21 11:33:20 2019 New Revision: 364089 URL: http://llvm.org/viewvc/llvm-project?rev=364089&view=rev Log: Revert [test][Driver] Fix Clang :: Driver/cl-response-file.c This reverts r363985 (git commit d5f16d6cfccc4b0b13b6c01d16c673886d53e695) This test can't use printf on

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

leonardchan added a comment. In D63626#1553054 , @chandlerc wrote: > See inline comment, but I think we should just drop the testing of the > function attribute bit here rather than adjusting the pipeline. Ok. Removed the pipeline change for now. In D6

[PATCH] D63626: [clang][NewPM] Remove exception handling before loading pgo sample profile data

leonardchan updated this revision to Diff 206041. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63626/new/ https://reviews.llvm.org/D63626 Files: clang/test/CodeGen/pgo-sample.c Index: clang/test/Cod

RE: r363985 - [test][Driver] Fix Clang :: Driver/cl-response-file.c

Hi Rainer, I figured it out. Because you are using printf, you no longer need the '\\c'. If I use the following RUN line, the test passes on both Windows/linux (I don't have solaris to test unfortunately): // RUN: printf '%%s\n' '/I%S\Inputs\cl-response-file\ /DFOO=2' > %t.rsp I can submit thi

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich, lebedev.ri. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. tags are added for the parents of records. The link redirects to the parent's info file

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5609 +def warn_mul_in_bool_context : Warning< + "'*' in bool context, maybe you mean '&&'?">, + InGroup; xbolva00 wrote: > aaron.ballman wrote: > > I would appreciate se

[PATCH] D63663: [clang-doc] Add html links to the parents of a RecordInfo

juliehockett added a comment. General design thought: could we move the path name construction to `Serialize.cpp`? Essentially, move the logic that builds the path name from the namespaces and name to the serialize step (you'll have to add the `OutDirectory` to the `ClangDocContext` so that you

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:5625 + "evaluate to 'true'">, + InGroup; + aaron.ballman wrote: > xbolva00 wrote: > > aaron.ballman wrote: > > > This one seems lik

  1   2   >