[PATCH] D59533: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc.

craig.topper created this revision. craig.topper added reviewers: spatel, RKSimon. Herald added a project: clang. craig.topper updated this revision to Diff 191251. craig.topper added a comment. Add the test file that I forgot to git add before running arcanist gcc has these intrinsics in ia32in

[PATCH] D59533: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc.

craig.topper updated this revision to Diff 191251. craig.topper added a comment. Add the test file that I forgot to git add before running arcanist Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59533/new/ https://reviews.llvm.org/D59533 Files: lib/Headers/ia32

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin marked an inline comment as done. ikudrin added inline comments. Comment at: test/Frontend/absolute-paths-windows.test:4 +// RUN: mkdir -p %t.dir\real +// RUN: cmd /c mklink /j %t.dir\junc %t.dir\real +// RUN: echo "wrong code" > %t.dir\real\foo.cpp ikudr

[PATCH] D57662: [clang-tidy] Parallelize clang-tidy-diff.py

zinovy.nis added a comment. One more gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

zinovy.nis added a comment. Any comments? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59449/new/ https://reviews.llvm.org/D59449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

teemperor updated this revision to Diff 191257. teemperor retitled this revision from "[ASTImporter] Allow adding a shim to the ASTImporter" to "[ASTImporter] Allow adding a import strategy to the ASTImporter". teemperor edited the summary of this revision. teemperor added a comment. Thanks for

[PATCH] D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous.

kadircet added inline comments. Comment at: lib/Tooling/Core/Lookup.cpp:165 +if (UnspelledScopes.empty()) { + Disambiguated = "::" + Disambiguated; +} else { ioeric wrote: > kadircet wrote: > > maybe return or break afterwards? > I also struggled a b

[PATCH] D59440: add steps to preprocess file and reduce command line args

serge-sans-paille added inline comments. Comment at: clang/utils/creduce-clang-crash.py:45 + result = [] + for i, arg in enumerate(cmd): +if arg.startswith('$'): Useless enumerate here. You could even use a list comprehension here ``` return ' '.join(arg i

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

balazske added a comment. It looks better now. One "problem" is that now there is the strategy and there is the `Imported` function. It would be possible to unify these into a strategy that contains maybe a "import" and a "post-import" callback. (But this requires big changes in the `ASTImporte

[PATCH] D40181: [libcxx] Allow to set locale on Windows.

halyavin added a comment. Yes, I considered it. But Microsoft documentation is not clear whether it will work or not for restoring inconsistent locales. The documentation shows how to save inconsistent locales with LC_ALL but doesn't provide an example for restoring them. Repository: rL LLV

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet marked 2 inline comments as done. kadircet added a comment. In D59481#1432881 , @ioeric wrote: > I'm not sure if FileIndex is the correct layer to make decision about how > References is calculated. Currently, we have two use cases in clangd 1) o

[clang-tools-extra] r356445 - [clangd] Add support for type hierarchy (super types only for now)

Author: kadircet Date: Tue Mar 19 02:27:04 2019 New Revision: 356445 URL: http://llvm.org/viewvc/llvm-project?rev=356445&view=rev Log: [clangd] Add support for type hierarchy (super types only for now) Summary: Patch by Nathan Ridge(@nridge)! This is an LSP extension proposed here: https://githu

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

This revision was automatically updated to reflect the committed changes. Closed by commit rL356445: [clangd] Add support for type hierarchy (super types only for now) (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

ioeric added a comment. > I don't follow why this can over-count, FileIndex keeps only one RefSlab per > each file, so we can't over-count? Did you mean it will be more than #TUs ? Yes. This is how `Symbol::References` is described in its documentation. If we want to change/expand the semantic,

[PATCH] D59457: [analyzer][NFC] Use capital variable names, move methods out-of-line, rename some in CheckerRegistry

Szelethus added a comment. In D59457#1433180 , @baloghadamsoftware wrote: > Please rename the patch. Its name does not really express its content. Good point, sorry about that. In D59457#1433816 , @xazax.hun wro

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov added a comment. Hi Jan, Sure! And sorry for posting these metrics for a while (we had other patches mentioning them) without proper explanation. We simulate a bunch of completions at random points in random files from our internal codebase. We assume the desired completion item

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

teemperor planned changes to this revision. teemperor added a comment. I think we could also refactor the strategy into a `PreImport` call. That way we don't break all the user-code out there and it seems less intrusive to the ASTImporter code. I'll update the patch. CHANGES SINCE LAST ACTION

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

ilya-biryukov added a comment. @ioeric is the author of these completion metrics and evaluation tools. Eric, please feel free to correct me if I got something wrong or missed something. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59300/new/ https://reviews.llvm

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 191265. kadircet added a comment. - Only surface diagnostics with level fatal or error Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 Files: clangd/ClangdServer.cpp

r356446 - [Tooling] Add more scope specifiers until spelling is not ambiguous.

Author: ioeric Date: Tue Mar 19 03:12:15 2019 New Revision: 356446 URL: http://llvm.org/viewvc/llvm-project?rev=356446&view=rev Log: [Tooling] Add more scope specifiers until spelling is not ambiguous. Summary: Previously, when the renamed spelling is ambiguous, we simply use the full-qualfied na

[PATCH] D59487: [Tooling] Add more scope specifiers until spelling is not ambiguous.

This revision was automatically updated to reflect the committed changes. ioeric marked an inline comment as done. Closed by commit rL356446: [Tooling] Add more scope specifiers until spelling is not ambiguous. (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subsc

[PATCH] D59354: [clangd] Print arguments in template specializations

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a few NITs. Thanks for fixing this! Comment at: clang-tools-extra/clangd/AST.cpp:86 +auto TL = Cls->getTypeAsWritten()->getTypeLoc(); +if (aut

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added a comment. In D59302#1431274 , @kadircet wrote: > The optional part is rather limiting number of diagnostics that is going to > be surfaced. So if you have thousands of errors inside preamble only first > 100 of them will appear insid

[PATCH] D59527: [clang-format] Don't insert break between JS template string and tag identifier

mprobst accepted this revision. mprobst added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59527/new/ https://reviews.llvm.org/D59527 ___ cfe-commits

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:170 I.first->second = mergeSymbol(I.first->second, Sym); +// We re-count number of references while merging refs from scratch. +

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added inline comments. Comment at: clangd/ClangdUnit.cpp:256 +// directive inside main file. +// If a header is transitively included in multiple direct includes of main, we +// choose the first one. We should find a way to point into an exact `incl

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

balazske added a comment. Another observation: The `Import` function of the strategy now has no way to return an error. An even better version of it would be to include the possibility of import error (with `ImportError`, or other error type). Or the "PreImport" function could indicate if the D

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

balazske added a comment. By the way if the `Import` of the strategy uses recursive import of other things this can cause same problems as it was in `ASTImporter` before the `GetImportedOrCreateDecl` was introduced. So this should be avoided or something similar to `GetImportedOrCreateDecl` mus

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: JonasToth, aaron.ballman, alexfh, michaelplatings. MyDeveloperDay added a project: clang-tools-extra. Herald added subscribers: jdoerfert, xazax.hun. While testing clang-tidy for D59251: [Documentation] Proposal for plan to ch

r356447 - [clang-format] [JS] Don't break between template string and tag

Author: mprobst Date: Tue Mar 19 04:15:52 2019 New Revision: 356447 URL: http://llvm.org/viewvc/llvm-project?rev=356447&view=rev Log: [clang-format] [JS] Don't break between template string and tag Before: const x = veryLongIdentifier `hello`; After: const x = veryLongIden

[PATCH] D59527: [clang-format] Don't insert break between JS template string and tag identifier

mprobst closed this revision. mprobst added a comment. Landed as r356447. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59527/new/ https://reviews.llvm.org/D59527 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D59516: [analyzer] Make GenericTaintChecker configurable

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. I'm very much guilty of doing functional and refactoring changes within the same patch, but I think working on `GenericTaintChecker` AND in the same patch doing (seemingly unre

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia added a comment. In D59492#1433796 , @arsenm wrote: > Should it be downgraded to a warning about an extension instead of just > removing it? What would you suggest to put in a warning message? Clang normally doesn't warn about extensions...

[PATCH] D59292: [clang-format] messes up indentation when using JavaScript private fields and methods

MyDeveloperDay added subscribers: mitchellwills, mprobst. MyDeveloperDay added a comment. ping @mprobst,@mitchellwills noticed you just reviewed another clang-format-js commit, wondered if you were interested in reviewing this for me?, finding it hard to get any review traction. CHANGES SINCE

[PATCH] D59292: [clang-format] messes up indentation when using JavaScript private fields and methods

mprobst accepted this revision. mprobst added a comment. This revision is now accepted and ready to land. Actually I'll fix the nits. Comment at: clang/docs/ReleaseNotes.rst:174 -- ... +- Add support for correct indenting of private fields and methods in Javascript. --

[PATCH] D59486: [OpenCL] Improve testing of default header in C++ mode

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: test/Headers/opencl-c-header.cl:57-65 char f(char x) { -#if __OPENCL_C_VERSION__ != CL_VERSION_2_0 +#if !defined(__OPENCL_CPP_VERSION__) && (__OPENCL_C_VERSION__ != CL_VERSION_2_0) retur

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM (landed here too https://github.com/mydeveloperday/clang-experimental/releases) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55170/new/ https://reviews.llvm.org

r356449 - [clang-format] [JS] handle private members.

Author: mprobst Date: Tue Mar 19 05:28:41 2019 New Revision: 356449 URL: http://llvm.org/viewvc/llvm-project?rev=356449&view=rev Log: [clang-format] [JS] handle private members. Addresses PR40999 https://bugs.llvm.org/show_bug.cgi?id=40999 Private fields and methods in JavaScript would get incor

[PATCH] D59292: [clang-format] messes up indentation when using JavaScript private fields and methods

mprobst closed this revision. mprobst added a comment. Landed in r356449, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59292/new/ https://reviews.llvm.org/D59292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D59485: [ASTImporter] Allow adding a import strategy to the ASTImporter

martong added a comment. > We can't reliable import templates with the ASTImporter, so actually > reconstructing the template in the debug info AST and then importing it > doesn't work. Could you please elaborate how the import of templates fails in ASTImporter? Is it because the AST you build

r356450 - [OpenCL] Improved testing of default header.

Author: stulova Date: Tue Mar 19 06:04:17 2019 New Revision: 356450 URL: http://llvm.org/viewvc/llvm-project?rev=356450&view=rev Log: [OpenCL] Improved testing of default header. Improved some checks and moved testing of the default header in C++ mode into the Headers folder. Differential Revisi

[PATCH] D59486: [OpenCL] Improve testing of default header in C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC356450: [OpenCL] Improved testing of default header. (authored by stulova, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5948

[PATCH] D59459: [analyzer][NFC] Prefer binary searches in CheckerRegistry

baloghadamsoftware requested changes to this revision. baloghadamsoftware added inline comments. This revision now requires changes to proceed. Comment at: lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:70 + Collection, Info, + FullNameLT{}); +} Please

r356452 - [ASTImporter] Fix redecl failures of ClassTemplateSpec

Author: martong Date: Tue Mar 19 06:34:10 2019 New Revision: 356452 URL: http://llvm.org/viewvc/llvm-project?rev=356452&view=rev Log: [ASTImporter] Fix redecl failures of ClassTemplateSpec Summary: Redecl chains of class template specializations are not handled well currently. We want to handle t

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rL356452: [ASTImporter] Fix redecl failures of ClassTemplateSpec (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

martong updated this revision to Diff 191286. martong added a comment. - Rebase to master Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58668/new/ https://reviews.llvm.org/D58668 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unitte

r356455 - [ASTImporter] Fix redecl failures of FunctionTemplateSpec

Author: martong Date: Tue Mar 19 07:04:50 2019 New Revision: 356455 URL: http://llvm.org/viewvc/llvm-project?rev=356455&view=rev Log: [ASTImporter] Fix redecl failures of FunctionTemplateSpec Summary: Redecl chains of function template specializations are not handled well currently. We want to ha

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

This revision was automatically updated to reflect the committed changes. Closed by commit rL356455: [ASTImporter] Fix redecl failures of FunctionTemplateSpec (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGE

[PATCH] D59544: [OpenCL] Minor improvements in default header testing

Anastasia created this revision. Anastasia added a reviewer: bader. Herald added subscribers: ebevhan, yaxunl. Suggested in https://reviews.llvm.org/D59486 https://reviews.llvm.org/D59544 Files: test/Headers/opencl-c-header.cl Index: test/Headers/opencl-c-header.cl =

[PATCH] D59544: [OpenCL] Minor improvements in default header testing

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59544/new/ https://reviews.llvm.org/D59544 ___ cfe-commits mailing list cfe-co

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

arsenm added a comment. In D59492#1434636 , @Anastasia wrote: > In D59492#1433796 , @arsenm wrote: > > > Should it be downgraded to a warning about an extension instead of just > > removing it? > > > What would you

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

JonasToth added a comment. What happens on `[=]() ...`, direct capture `[&Columns]()...` and `[Columns]()...`? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59540/new/ https://reviews.llvm.org/D59540 ___ cfe-commits mailing list cfe-commit

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

baloghadamsoftware added a comment. Great work! Thank you! I only have minor comment: did you consider moving the refactoring of `ExceptionAnalyzer` into a separate (prerequisite) patch? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59466/new/ http

[PATCH] D59520: [WebAssembly] Address review comments on r352930

aaron.ballman added a comment. I love functional changes that remove code and add tests -- thank you for these! > Removes errnoneous use of diag::err_alias_is_definition, which turned out to > be ineffective anyway since functions can be defined later in the translation > unit and avoid detecti

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Mon, Mar 18, 2019 at 7:08 PM Dan Gohman wrote: > > > > On Fri, Mar 15, 2019 at 10:55 AM Aaron Ballman wrote: >> >> >> Ping. > > > I apologize for the extraordinarily delays here. I've now posted a patch to > address the review comments here: > > https://reviews.llvm.org/D59520 Delays happen

[PATCH] D59466: [clang-tidy] openmp-exception-escape - a new check

lebedev.ri added a comment. In D59466#1434841 , @baloghadamsoftware wrote: > Great work! Thank you! I only have minor comment: did you consider moving the > refactoring of `ExceptionAnalyzer` into a separate (prerequisite) patch? Yes, absolutely, that

[PATCH] D59546: [clang-format] structured binding in range for detected as Objective C

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: djasper, klimek, JonasToth, reuk. MyDeveloperDay added a project: clang-tools-extra. Sometime after 6.0.0 and the current trunk 9.0.0 the following code would be considered as objective C and not C++ Reported by: https://twitt

[PATCH] D57896: Variable names rule

Charusso added subscribers: chandlerc, Charusso. Charusso added a comment. In D57896#1406812 , @lattner wrote: > I can understand Zach's position here, but LLDB has historically never > conformed to the general LLVM naming or other conventions due to its

r356458 - Ensure that const variables declared at namespace scope correctly have external linkage when marked as dllexport and targeting the MSVC ABI.

Author: aaronballman Date: Tue Mar 19 07:53:52 2019 New Revision: 356458 URL: http://llvm.org/viewvc/llvm-project?rev=356458&view=rev Log: Ensure that const variables declared at namespace scope correctly have external linkage when marked as dllexport and targeting the MSVC ABI. Patch thanks to

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman closed this revision. aaron.ballman added a comment. > Would you mind committing the changes please? Thanks. Happy to do so! I've committed in r356458. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay planned changes to this revision. MyDeveloperDay added a comment. In D59540#1434837 , @JonasToth wrote: > What happens on `[=]() ...`, direct capture `[&Columns]()...` and > `[Columns]()...`? Thanks for the review... in answer to your que

[PATCH] D59461: [analyzer] Fix an assertion failure if plugins added dependencies

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. This one seems straightforward. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59461/new/ https://reviews.llvm.org/D59461 ___

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho updated this revision to Diff 191305. mikhail.ramalho added a comment. Fix copy-and-paste error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 Files: clang/CMakeLists.txt clang/cmake/modules/FindZ3.cmake clang/include/cla

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho marked an inline comment as done. mikhail.ramalho added a comment. Fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay updated this revision to Diff 191311. MyDeveloperDay added a comment. Minor modification to improve the `[=]` case `[&Columns]` and `[Columns]` are not yet fixed and will not be correctly renamed to `[&columns]` and `[columns]` But at least they are left unaltered CHANGES SINCE

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

alexfh added a comment. Thanks for fixing this! Could you expand the test a bit? See the inline comment. Comment at: test/clang-tidy/readability-identifier-naming.cpp:506 +bool Foo() { + bool Columns=false; +// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: invalid case style for lo

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 191323. kadircet marked 2 inline comments as done. kadircet added a comment. - Show include stack in diagnostic message - Point to exact include location Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/

[PATCH] D57662: [clang-tidy] Parallelize clang-tidy-diff.py

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG with a nit Comment at: clang-tidy/tool/clang-tidy-diff.py:90 + # the top level key 'Diagnostics' in the output yaml files + mergekey="Diagnostics" + merged=[] -

Re: r356222 - [analyzer] Support C++17 aggregates with bases without constructors.

A reduced test case: $ cat test-RegionStoreManager__bindStruct.cc struct a {}; class b : a {}; b c() { b d{c()}; } $ ./clang-tidy -checks="-*,clang-analyzer*" test-RegionStoreManager__bindStruct.cc -- -std=c++17 assert.h assertion failed at tools/clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2362 i

Re: r356222 - [analyzer] Support C++17 aggregates with bases without constructors.

Filed this as https://bugs.llvm.org/show_bug.cgi?id=41142. Any hope for a prompt fix here? On Tue, Mar 19, 2019 at 5:34 PM Alexander Kornienko wrote: > A reduced test case: > $ cat test-RegionStoreManager__bindStruct.cc > struct a {}; > class b : a {}; > b c() { b d{c()}; } > $ ./clang-tidy -che

r356472 - [OPENMP] Codegen for local variables with the allocate pragma.

Author: abataev Date: Tue Mar 19 09:41:16 2019 New Revision: 356472 URL: http://llvm.org/viewvc/llvm-project?rev=356472&view=rev Log: [OPENMP] Codegen for local variables with the allocate pragma. Added initial codegen for the local variables with the #pragma omp allocate directive. Instead of al

[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

alexfh added a comment. How is this functionality different from the clang-tidy-diff.py script with the -j option being added in the other patch? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59449/new/ https://reviews.llvm.org/D59449 __

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:790 if (const auto *DeclRef = Result.Nodes.getNodeAs("declRef")) { -SourceRange Range = DeclRef->getNameInfo().getSourceRange(); -addUsage(NamingCheckFailures, DeclRef->g

r356475 - [Sema] Adjust addr space of reference operand in compound assignment

Author: stulova Date: Tue Mar 19 09:50:21 2019 New Revision: 356475 URL: http://llvm.org/viewvc/llvm-project?rev=356475&view=rev Log: [Sema] Adjust addr space of reference operand in compound assignment When we create overloads for the builtin compound assignment operators we need to preserve add

[PATCH] D59367: [Sema] Adjust address space of operands in remaining builtin operators

This revision was automatically updated to reflect the committed changes. Closed by commit rC356475: [Sema] Adjust addr space of reference operand in compound assignment (authored by stulova, committed by ). Herald added a subscriber: kristina. Herald added a project: clang. Repository: rC Clan

[PATCH] D59367: [Sema] Adjust address space of operands in remaining builtin operators

Anastasia added a comment. In D59367#1434353 , @rjmccall wrote: > This patch LGTM. > > You might consider adding tests for weird cases like class types with > conversion operators to reference types. To a certain extent that sort of > thing is unimpleme

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

alexfh added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp:115 +Expr::EvalResult EvalResult; +if (!E->EvaluateAsInt(EvalResult, Ctx, Expr::SE_AllowSideEffects)) + return false; courbet wrote: > a

r356479 - [OpenCL] Minor improvements in default header testing

Author: stulova Date: Tue Mar 19 10:09:06 2019 New Revision: 356479 URL: http://llvm.org/viewvc/llvm-project?rev=356479&view=rev Log: [OpenCL] Minor improvements in default header testing Differential Revision: https://reviews.llvm.org/D59544 Modified: cfe/trunk/test/Headers/opencl-c-header

r356480 - [OPENMP]Remove unused parameter, NFC.

Author: abataev Date: Tue Mar 19 10:09:52 2019 New Revision: 356480 URL: http://llvm.org/viewvc/llvm-project?rev=356480&view=rev Log: [OPENMP]Remove unused parameter, NFC. Parameter CodeGenModule &CGM is not required for CGOpenMPRuntime member functions, since class holds the reference to the CGM

[PATCH] D59544: [OpenCL] Minor improvements in default header testing

This revision was automatically updated to reflect the committed changes. Closed by commit rL356479: [OpenCL] Minor improvements in default header testing (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:

Re: r356222 - [analyzer] Support C++17 aggregates with bases without constructors.

Hi, I'll try to fix this ASAP! It sounds as if i don't have nearly enough C++17 codebases for testing, are there any obvious open-source projects that you could recommend? I'd love to try to reincarnate http://green.lab.llvm.org/green/view/Experimental/job/StaticAnalyzerBenchmarks/ with thos

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet planned changes to this revision. kadircet added a comment. - Limit per include directive - Use hardcoded value for limit Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/new/ https://reviews.llvm.org/D59302 __

Re: r356222 - [analyzer] Support C++17 aggregates with bases without constructors.

On Tue, Mar 19, 2019 at 6:24 PM Artem Dergachev wrote: > Hi, > > I'll try to fix this ASAP! > Thanks! > It sounds as if i don't have nearly enough C++17 codebases for testing, > are there any obvious open-source projects that you could recommend? No, but this particular example comes from C++

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel marked 4 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:54 +/// boolean expression language for constructing filters. +class MatchFilter { +public: ilya-biryukov wrote: > Intuitive

Re: r356222 - [analyzer] Support C++17 aggregates with bases without constructors.

On Tue, 19 Mar 2019 at 10:24, Artem Dergachev via cfe-commits wrote: > > Hi, > > I'll try to fix this ASAP! It sounds like there might be a missing check for InitListExpr::isTransparent somewhere. (A transparent InitListExpr should be treated as equivalent to its one and only subexpression.) Eith

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. In D59388#1433233 , @dexonsmith wrote: > Yes, it's safe. The reference count is "intrusive", meaning it's stored in > the object itself (via inherit

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

wuhao5 added a comment. > Okay, so really just a block self-reference. We could really just add a > feature for that that would avoid both the complexity and the expense of the > self-capture dance. Is there a plan to cover this case? or is it a legitimate use case that Clang should handle?

r356496 - [OPENMP]Check that global vars require predefined allocator.

Author: abataev Date: Tue Mar 19 11:39:11 2019 New Revision: 356496 URL: http://llvm.org/viewvc/llvm-project?rev=356496&view=rev Log: [OPENMP]Check that global vars require predefined allocator. According to OpenMP, 2.11.3 allocate Directive, Restrictions, C / C++, if a list item has a static sto

r356497 - Fix unused variable warning. NFCI.

Author: rksimon Date: Tue Mar 19 11:39:46 2019 New Revision: 356497 URL: http://llvm.org/viewvc/llvm-project?rev=356497&view=rev Log: Fix unused variable warning. NFCI. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp URL: http://llvm.o

[PATCH] D57896: Variable names rule

lattner added a comment. In D57896#1434877 , @Charusso wrote: > static Optional > getConcreteIntegerValue(const Expr *CondVarExpr, const ExplodedNode *N) { > //... > > if (const auto *DRE = dyn_cast_or_null(CondVarExpr)) { > if (const auto *VD = dy

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay updated this revision to Diff 191365. MyDeveloperDay added a comment. Address review comments This may not be a more satisfactory solution but it at least now covers the other cases raised by @JonasToth Add more tests around this area. CHANGES SINCE LAST ACTION https://review

[PATCH] D59540: [clang-tidy] [PR41119] readability-identifier-naming incorrectly fixes lambda capture

MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added inline comments. Comment at: test/clang-tidy/readability-identifier-naming.cpp:509 +// CHECK-FIXES: {{^}} bool columns=false; + auto ptr=[&]{return Columns;}(); +// CHECK-FIXES: {{^}} auto ptr=[&]{return col

[PATCH] D57896: Variable names rule

Charusso added a comment. In D57896#1435245 , @lattner wrote: > FWIW, my suggestion is *not* to expand names like DRE to decl_ref_expr, I > agree that doesn't add clarity to the code. Two possibilities: "dre", or > "decl" which is what I would write tod

[PATCH] D57965: Clean up ObjCPropertyDecl printing

dgoldman added a comment. friendly ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57965/new/ https://reviews.llvm.org/D57965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia added a comment. In D59492#1434822 , @arsenm wrote: > In D59492#1434636 , @Anastasia wrote: > > > In D59492#1433796 , @arsenm wrote: > > > > > Should it be downgrad

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia updated this revision to Diff 191366. Anastasia added a comment. Instead of removing the diagnostic completely change into a warning in pedantic mode. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 Files: include/clang/Basic/Diagno

[PATCH] D58514: Avoid needlessly copying blocks that initialize or are assigned to local auto variables to the heap

rjmccall added a comment. In D58514#1435228 , @wuhao5 wrote: > > Okay, so really just a block self-reference. We could really just add a > > feature for that that would avoid both the complexity and the expense of > > the self-capture dance. > > Is ther

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

boga95 created this revision. boga95 added reviewers: Szelethus, xazax.hun, dkrupp, NoQ. Herald added subscribers: cfe-commits, Charusso, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, whisperity. Herald added a project: clang. Parse the yaml configuration file and

r356507 - Move options to separate checks that do not need to immediately follow the previous option. NFCI

Author: dyung Date: Tue Mar 19 12:34:15 2019 New Revision: 356507 URL: http://llvm.org/viewvc/llvm-project?rev=356507&view=rev Log: Move options to separate checks that do not need to immediately follow the previous option. NFCI Modified: cfe/trunk/test/Driver/hip-toolchain-mllvm.hip Modifi

  1   2   >