ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a few NITs.
Thanks for fixing this!
================
Comment at: clang-tools-extra/clangd/AST.cpp:86
+ auto TL = Cls->getTypeAsWritten()->getTypeLoc();
+ if (auto STL = TL.getAs<TemplateSpecializationTypeLoc>()) {
+ llvm::SmallVector<TemplateArgumentLoc, 8> ArgLocs;
----------------
NIT: maybe inline `TL`?
```
if (auto STL =
Cls->getTypeAsWritten()->getTypeLoc().getAs<TemplateSpecializationTypeLoc>()) {
/// ...
}
```
================
Comment at: clang-tools-extra/clangd/AST.cpp:89
+ ArgLocs.reserve(STL.getNumArgs());
+ for (unsigned I = 0; I < STL.getNumArgs(); I++)
+ ArgLocs.push_back(STL.getArgLoc(I));
----------------
Tiny NIT: [[ https://llvm.org/docs/CodingStandards.html#prefer-preincrement |
prefer preincrement ]]
================
Comment at: clang/lib/AST/TypePrinter.cpp:1635
+static void printArgument(const TemplateArgument &A, const PrintingPolicy &PP,
+ llvm::raw_ostream &OS) {
----------------
NIT: consider also adding a test in the clang code.
Some developers don't build `tools-extra`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59354/new/
https://reviews.llvm.org/D59354
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
