mprobst accepted this revision. mprobst added a comment. This revision is now accepted and ready to land.
Actually I'll fix the nits. ================ Comment at: clang/docs/ReleaseNotes.rst:174 -- ... +- Add support for correct indenting of private fields and methods in Javascript. ---------------- Honestly, I think we don't really do release notes for clang-format. Revert this, or I'll drop it when committing your change. ================ Comment at: clang/lib/Format/FormatToken.h:66 TYPE(JsTypeOptionalQuestion) \ + TYPE(JsPrivateIdentifier) \ TYPE(LambdaArrow) \ ---------------- nit: please keep alpha sorted, i.e. before Js[T] CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59292/new/ https://reviews.llvm.org/D59292 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
