kadircet added inline comments.
================
Comment at: lib/Tooling/Core/Lookup.cpp:165
+ if (UnspelledScopes.empty()) {
+ Disambiguated = "::" + Disambiguated;
+ } else {
----------------
ioeric wrote:
> kadircet wrote:
> > maybe return or break afterwards?
> I also struggled a bit here. But I decided to let `IsAmbiguousSpelling`
> handle it because it seemed a bit more natural. Otherwise, we would somewhat
> duplicate the logic that spelling with leading "::" is not ambiguous.
ok sgtm
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59487/new/
https://reviews.llvm.org/D59487
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
