[PATCH] D52695: [clang][Parse] Diagnose useless null statements (PR39111)

lebedev.ri added a comment. ping. I wonder if @aaron.ballman has any opinion on this. Repository: rC Clang https://reviews.llvm.org/D52695 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D53488: [clang-tidy] Catching narrowing from double to float.

gchatelet added inline comments. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:178 + return; +// Conversions to unsigned integer are well defined and follow modulo 2 +// arithmetic. JonasToth wrote: > I am surprised by `follo

[PATCH] D53488: [clang-tidy] Catching narrowing from double to float.

gchatelet updated this revision to Diff 172904. gchatelet marked 2 inline comments as done. gchatelet added a comment. - Addressing comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53488 Files: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp clang-tidy/cpp

[PATCH] D52034: [Clang] Add options -fprofile-filter-files and -fprofile-exclude-files to filter the files to instrument with gcov

calixte updated this revision to Diff 172905. calixte added a comment. Update doc. Repository: rC Clang https://reviews.llvm.org/D52034 Files: docs/UsersManual.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp lib/Driver/ToolCha

[PATCH] D54171: [MS] Zero out ECX in __cpuid in intrin.h

hans added a comment. Thanks for fixing! Repository: rL LLVM https://reviews.llvm.org/D54171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53651: [clangd] Use thread pool for background indexing.

uabelho added a comment. Hi, I've got a post-review comment about the use of SCHED_IDLE vs the needed gcc version. Comment at: clang-tools-extra/trunk/clangd/Threading.cpp:110 + T.native_handle(), + Priority == ThreadPriority::Low ? SCHED_IDLE : SCHED_OTHER, &priori

[PATCH] D53334: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too

whisperity updated this revision to Diff 172908. whisperity added a comment. Test was added. Repository: rC Clang https://reviews.llvm.org/D53334 Files: lib/Frontend/CompilerInstance.cpp test/Modules/Inputs/module-mismatch.cppm test/Modules/mismatch-diagnostics.cpp Index: test/Module

Re: [PATCH] D53651: [clangd] Use thread pool for background indexing.

On Wed, Nov 7, 2018 at 10:32 AM Mikael Holmén via Phabricator < revi...@reviews.llvm.org> wrote: > uabelho added a comment. > > Hi, > > I've got a post-review comment about the use of SCHED_IDLE vs the needed > gcc version. > > > > > Comment at: clang-tools-extra/trunk/clangd/Thre

r346301 - [CodeComplete] Do not complete self-initializations

Author: ibiryukov Date: Wed Nov 7 02:02:31 2018 New Revision: 346301 URL: http://llvm.org/viewvc/llvm-project?rev=346301&view=rev Log: [CodeComplete] Do not complete self-initializations Summary: Removes references to initialized variable from the following completions: int x = ^; Handles

[PATCH] D54156: [CodeComplete] Do not complete self-initializations

This revision was automatically updated to reflect the committed changes. Closed by commit rL346301: [CodeComplete] Do not complete self-initializations (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54156 Files:

Re: [PATCH] D53651: [clangd] Use thread pool for background indexing.

Hi, On 11/7/18 11:03 AM, Sam McCall wrote: > On Wed, Nov 7, 2018 at 10:32 AM Mikael Holmén via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > > uabelho added a comment. > > Hi, > > I've got a post-review comment about the use of SCHED_IDLE vs the > needed gcc version.

Re: [PATCH] D53651: [clangd] Use thread pool for background indexing.

I'll send a patch shortly to unbreak this. Is emitting a warning a problem for you? (i.e. do you build with -Werror) I'd like to do something like #ifdef SCHED_IDLE ... #else #warning "old libc?" #endif That way if this isn't actually working we'll break in linux configurations covered by -Werror

Re: [PATCH] D53651: [clangd] Use thread pool for background indexing.

On 11/7/18 11:31 AM, Sam McCall wrote: > I'll send a patch shortly to unbreak this. > > Is emitting a warning a problem for you? (i.e. do you build with -Werror) Yes "unfortunately" we use -Werror. > I'd like to do something like #ifdef SCHED_IDLE ... #else #warning "old > libc?" #endif > Tha

[PATCH] D50926: [SourceManager] Extract 'findFileIDsForFile' from 'translateFile' to allow mapping from one file entry to multiple FileIDs

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM and it seems like all of Eric's comments were answered too. Repository: rC Clang https://reviews.llvm.org/D50926 ___ cfe-commits mailin

[PATCH] D50801: [rename] Use isPointWithin when looking for a declaration at location

jkorous accepted this revision. jkorous added a comment. This revision is now accepted and ready to land. LGTM Thanks for fixing this! Repository: rC Clang https://reviews.llvm.org/D50801 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D54148: [NFC][Clang][Aarch64] Add missing test file

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D54148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

r346302 - [mips][msa] Fix msa_[st/ld] offset check

Author: abeserminji Date: Wed Nov 7 03:37:05 2018 New Revision: 346302 URL: http://llvm.org/viewvc/llvm-project?rev=346302&view=rev Log: [mips][msa] Fix msa_[st/ld] offset check This patch fixes a minimum divider for offset in intrinsics msa_[st/ld]_[b/h/w/d], when value is known in compile time

[PATCH] D54038: [mips][msa] Fix msa_[st/ld] offset check

This revision was automatically updated to reflect the committed changes. Closed by commit rC346302: [mips][msa] Fix msa_[st/ld] offset check (authored by abeserminji, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D54038 Files: lib/Sem

r346303 - [NFC][Clang][Aarch64] Add missing test file

Author: dnsampaio Date: Wed Nov 7 03:42:02 2018 New Revision: 346303 URL: http://llvm.org/viewvc/llvm-project?rev=346303&view=rev Log: [NFC][Clang][Aarch64] Add missing test file The commit rL345273 by @LukeCheeseman has a missing test file, see https://reviews.llvm.org/D51429 This patch adds th

[PATCH] D54148: [NFC][Clang][Aarch64] Add missing test file

This revision was automatically updated to reflect the committed changes. Closed by commit rL346303: [NFC][Clang][Aarch64] Add missing test file (authored by dnsampaio, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D54148?vs=172743&id

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov updated this revision to Diff 172917. AlexeySachkov added a comment. Updated opencl-c.h header: fixed typos in built-in declarations. Applied comment from Alexey https://reviews.llvm.org/D51484 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

hokein added a comment. >> If you're suggesting proceeding with this regex based solution, I > > don't think that's a good idea. Why commit a hack which people will object to > ever removing? Just see if we can do the right thing instead. +1, my main concern is the complexity of the patch and m

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

donat.nagy updated this revision to Diff 172922. donat.nagy marked an inline comment as done. donat.nagy added a comment. Use ASTContext::getFloatTypeSemantics() Repository: rC Clang https://reviews.llvm.org/D52730 Files: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp test/Analysis/co

[clang-tools-extra] r346308 - [clangd] [NFC] Fix clang-tidy warnings.

Author: kadircet Date: Wed Nov 7 04:25:27 2018 New Revision: 346308 URL: http://llvm.org/viewvc/llvm-project?rev=346308&view=rev Log: [clangd] [NFC] Fix clang-tidy warnings. Reviewers: ioeric, sammccall, ilya-biryukov, hokein Subscribers: MaskRay, jkorous, arphaman, cfe-commits Differential Re

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

donat.nagy added a comment. Could someone with commit rights commit this patch (if it is acceptable)? I don't have commit rights myself. Comment at: lib/StaticAnalyzer/Checkers/ConversionChecker.cpp:158-162 +unsigned FloatingSize = AC.getTypeSize(DestType); +// getAllO

[PATCH] D54157: [clangd] [NFC] Fix clang-tidy warnings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL346308: [clangd] [NFC] Fix clang-tidy warnings. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54157 Files: clang-tools

[PATCH] D54202: [clangd] Drop namespace references in the index.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Namespace references is less useful compared with other symbols, and they contribute large part of the index. This patch drops them. The number

[PATCH] D54202: [clangd] Drop namespace references in the index.

hokein updated this revision to Diff 172926. hokein added a comment. Fix a typo. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54202 Files: clangd/index/SymbolCollector.cpp clangd/index/SymbolCollector.h unittests/clangd/SymbolCollectorTests.cpp Index: unittests/clangd

[PATCH] D54202: [clangd] Drop namespace references in the index.

kadircet added inline comments. Comment at: clangd/index/SymbolCollector.cpp:359 return true; - if (CollectRef && + if (CollectRef && !isa(ND) && (Opts.RefsInHeaders || SM.getFileID(SpellingLoc) == SM.getMainFileID())) Why not handle in `shouldColle

r346311 - [OpenCL] Fix diagnostic message about overload candidates

Author: asavonic Date: Wed Nov 7 05:07:18 2018 New Revision: 346311 URL: http://llvm.org/viewvc/llvm-project?rev=346311&view=rev Log: [OpenCL] Fix diagnostic message about overload candidates Summary: I wonder if there are some extension which need to be disabled to get overloadable candidate av

[PATCH] D54152: [OpenCL] Fix diagnostic message about overload candidates

This revision was automatically updated to reflect the committed changes. Closed by commit rC346311: [OpenCL] Fix diagnostic message about overload candidates (authored by asavonic, committed by ). Repository: rC Clang https://reviews.llvm.org/D54152 Files: include/clang/Basic/DiagnosticSem

[PATCH] D54141: [clang-tidy] add deduplication support for run-clang-tidy.py

steveire added a comment. @hokein you and I seem to be making the same proposal :) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D52730: [analyzer] ConversionChecker: handle floating point

Szelethus added inline comments. Comment at: test/Analysis/conversion.c:195 +return r; + } else if (b>1<<25) { +float f = b; // expected-warning {{Loss of precision}} NoQ wrote: > Szelethus wrote: > > This too -- how about running clang-format on this fi

[clang-tools-extra] r346312 - [clangd] Fix mainfile filtering for diagnostics: don't emit diagnostics for builtin headers. (Relevant for clang-tidy)

Author: sammccall Date: Wed Nov 7 05:21:09 2018 New Revision: 346312 URL: http://llvm.org/viewvc/llvm-project?rev=346312&view=rev Log: [clangd] Fix mainfile filtering for diagnostics: don't emit diagnostics for builtin headers. (Relevant for clang-tidy) Modified: clang-tools-extra/trunk/cla

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

Szelethus added a comment. Herald added a subscriber: donat.nagy. Bad news, this approach doesn't work too well, and here's why: https://github.com/llvm-mirror/clang/blob/master/lib/StaticAnalyzer/Core/CheckerRegistry.cpp#L115 void CheckerRegistry::initializeManager(CheckerManager &checkerMgr,

[PATCH] D50211: [analyzer] Fix displayed checker name for InnerPointerChecker

Szelethus added a comment. I personally find the registration process very error-prone, the current infrastructure around it makes it super easy to mess up in a way that won't be detected for months, so we probably need a better approach altogether. It shouldn't be possible to do any harm withi

[PATCH] D52984: [analyzer] Checker reviewer's checklist

Szelethus added a comment. In https://reviews.llvm.org/D52984#1269850, @NoQ wrote: > - Warning and note messages should be clear and easy to understand, even if a > bit long. > - Messages should start with a capital letter (unlike Clang warnings!) and > should not end with `.`. > - Articles

[PATCH] D54204: [clangd] Initial clang-tidy diagnostics support.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny, srhines. This runs checks over a restricted subset of the TU: - preprocessor callbacks just receive the truncated PP ev

[PATCH] D53974: [clang-tidy] new check: bugprone-too-small-loop-variable

ztamas updated this revision to Diff 172938. ztamas added a comment. - no `else` after `return` - `static constexpr llvm::StringLiteral` - CamelCase variable names - Remove unneeded isIntegerType() check - Better terminology: not terminating condition, but iteration's upper bound. Repository:

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

AlexeySachkov updated this revision to Diff 172946. AlexeySachkov added a comment. Rebased to ToT. https://reviews.llvm.org/D51484 Files: include/clang-c/Index.h include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/OpenCLExtensionTypes.def include/clang/Basic/Op

[PATCH] D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer.

hokein updated this revision to Diff 172949. hokein added a comment. Move forward the patch based on the offline discussion. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53427 Files: clangd/index/Index.cpp clangd/index/Index.h clangd/index/Merge.cpp clangd/index/Seria

[PATCH] D54202: [clangd] Drop namespace references in the index.

hokein added inline comments. Comment at: clangd/index/SymbolCollector.cpp:359 return true; - if (CollectRef && + if (CollectRef && !isa(ND) && (Opts.RefsInHeaders || SM.getFileID(SpellingLoc) == SM.getMainFileID())) kadircet wrote: > Why not handle

[PATCH] D54202: [clangd] Drop namespace references in the index.

hokein updated this revision to Diff 172950. hokein marked an inline comment as done. hokein added a comment. Fix another typo. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54202 Files: clangd/index/SymbolCollector.cpp clangd/index/SymbolCollector.h unittests/clangd/Sym

[clang-tools-extra] r346319 - [clangd] Drop namespace references in the index.

Author: hokein Date: Wed Nov 7 06:59:24 2018 New Revision: 346319 URL: http://llvm.org/viewvc/llvm-project?rev=346319&view=rev Log: [clangd] Drop namespace references in the index. Summary: Namespace references is less useful compared with other symbols, and they contribute large part of the ind

[PATCH] D52554: [WIP] [clangd] Tests for special methods code-completion

jkorous marked 6 inline comments as done. jkorous added inline comments. Comment at: clangd/CodeCompleteTests.cpp:2043 +TEST(CompletionTestNoExplicitMembers, Struct) { + clangd::CodeCompleteOptions Opts; sammccall wrote: > sammccall wrote: > > (Should this be

[PATCH] D54202: [clangd] Drop namespace references in the index.

This revision was automatically updated to reflect the committed changes. Closed by commit rL346319: [clangd] Drop namespace references in the index. (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D54202 Files: clan

[PATCH] D52554: [WIP] [clangd] Tests for special methods code-completion

jkorous updated this revision to Diff 172951. jkorous marked 4 inline comments as done. jkorous added a comment. Rewritten tests to shared implementation different cases. https://reviews.llvm.org/D52554 Files: unittests/clangd/CodeCompleteTests.cpp Index: unittests/clangd/CodeCompleteTests.c

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

grimar updated this revision to Diff 172953. grimar retitled this revision from "[Clang] - Add -gsingle-file-split-dwarf option." to "[Clang] - Add -fdwarf-fission=split,single option.". grimar added a comment. Reimplemented option as `-fdwarf-fission[=split,single]`. https://reviews.llvm.org/D

r346326 - [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

Author: asavonic Date: Wed Nov 7 07:44:01 2018 New Revision: 346326 URL: http://llvm.org/viewvc/llvm-project?rev=346326&view=rev Log: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension Summary: Documentation can be found at https://www.khronos.org/registry/OpenCL/exten

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

This revision was automatically updated to reflect the committed changes. Closed by commit rL346326: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension (authored by asavonic, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D52296: [Clang] - Add -fdwarf-fission=split,single option.

dblaikie added a comment. Thanks! - though on reflection I'm going to invoke @echristo again about the naming. It's unfortunately a bit backwards that the pre-standard flag is -gsplit-dwarf and what we're proposing as the standard flag is -fdwarf-fission, when the DWARF standard doesn't use the

[PATCH] D54204: [clangd] Initial clang-tidy diagnostics support.

hokein added a comment. I think this is in a good shape as initial patch! Comment at: clangd/ClangdUnit.cpp:168 +// The placeholder check here does not use hasAncestor() so is unaffected. +CTOpts.Checks = "bugprone-sizeof-expression"; +CTContext.emplace(llvm::make_u

[PATCH] D54169: [clang-tidy] Zircon ->

juliehockett added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; aa

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. > I think the only way to realistically make this work for all platforms would > be to separate the source file from the input/output. The source file would > be the test case, and if you wanted to support a different debugger you would > need to supply a different inpu

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

probinson added subscribers: gbedwell, probinson. probinson added a comment. +gbedwell Just to throw the idea out there, why not abandon debuginfo-tests entirely and try using Dexter for this. Dexter's design center is debug-info quality, not correctness, but it already knows how to drive sever

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

zturner added a comment. In https://reviews.llvm.org/D54187#1290247, @aprantl wrote: > > I think the only way to realistically make this work for all platforms > > would be to separate the source file from the input/output. The source file > > would be the test case, and if you wanted to suppor

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

zturner added a comment. In https://reviews.llvm.org/D54187#1290282, @probinson wrote: > +gbedwell > > Just to throw the idea out there, why not abandon debuginfo-tests entirely > and try using Dexter for this. Dexter's design center is debug-info quality, > not correctness, but it already know

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

probinson added a comment. In https://reviews.llvm.org/D54187#1290294, @zturner wrote: > In https://reviews.llvm.org/D54187#1290282, @probinson wrote: > > > +gbedwell > > > > Just to throw the idea out there, why not abandon debuginfo-tests entirely > > and try using Dexter for this. Dexter's de

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. In https://reviews.llvm.org/D54187#1290293, @zturner wrote: > Especially since as far as I can tell, nobody has even run debuginfo-tests > since late August, because it was actually broken by r341135 on August 30 > (fixed in r346060 yesterday) Can you please refrain f

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. In https://reviews.llvm.org/D54187#1290298, @probinson wrote: > In https://reviews.llvm.org/D54187#1290294, @zturner wrote: > > > In https://reviews.llvm.org/D54187#1290282, @probinson wrote: > > > > > +gbedwell > > > > > > Just to throw the idea out there, why not abando

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

zturner added a comment. In https://reviews.llvm.org/D54187#1290297, @aprantl wrote: > In https://reviews.llvm.org/D54187#1290293, @zturner wrote: > > > Especially since as far as I can tell, nobody has even run debuginfo-tests > > since late August, because it was actually broken by r341135 on

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. In https://reviews.llvm.org/D54187#1290317, @zturner wrote: > In https://reviews.llvm.org/D54187#1290297, @aprantl wrote: > > > In https://reviews.llvm.org/D54187#1290293, @zturner wrote: > > > > > Especially since as far as I can tell, nobody has even run > > > debuginf

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

gbedwell added a comment. In https://reviews.llvm.org/D54187#1290282, @probinson wrote: > +gbedwell > > Just to throw the idea out there, why not abandon debuginfo-tests entirely > and try using Dexter for this. Dexter's design center is debug-info quality, > not correctness, but it already kno

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

xbolva00 added a comment. @aaron.ballman https://reviews.llvm.org/D52835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54214: [RISCV] Set triple based on -march flag

simoncook created this revision. simoncook added a reviewer: asb. Herald added subscribers: cfe-commits, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, mgrang, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, johnrusso, rbar. For RISC-V the valu

r346338 - Revert r346326 [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation

Author: asavonic Date: Wed Nov 7 10:34:19 2018 New Revision: 346338 URL: http://llvm.org/viewvc/llvm-project?rev=346338&view=rev Log: Revert r346326 [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation This patch breaks Index/opencl-types.cl LIT test: Script: -- : 'RUN: at line 1

[PATCH] D53427: [clangd] Replace StringRef in SymbolLocation with a char pointer.

MaskRay added inline comments. Comment at: clangd/index/Index.h:84 inline bool operator==(const SymbolLocation &L, const SymbolLocation &R) { - return std::tie(L.FileURI, L.Start, L.End) == - std::tie(R.FileURI, R.Start, R.End); + return std::make_tuple(llvm::StringRef

[PATCH] D51484: [OpenCL] Add support of cl_intel_device_side_avc_motion_estimation extension

asavonic added a comment. I reverted this change in r346338, as it breaks Index/opencl-types.cl LIT test. See http://lab.llvm.org:8011/builders/clang-ppc64le-linux/builds/21503/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aopencl-types.cl Repository: rL LLVM https://reviews.llvm.org/D51

[PATCH] D53952: [clang-format] Support breaking consecutive string literals for TableGen

rupprecht added a comment. @djasper -- ping Repository: rC Clang https://reviews.llvm.org/D53952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

rnk added a comment. I hadn't realized that Dexter knew how to drive VS tools. I'll have to go read more and get back to you all. I think it would be more promising than attempting to come up with a new llgdb.py-like abstraction for cdb. Specifically, abstracting over setting breakpoints and r

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

probinson added a comment. In https://reviews.llvm.org/D54187#1290340, @gbedwell wrote: > (Dexter) will step through every line of the program it can, collecting info > about each step until it reaches the program exit. It won't currently > produce a pass/fail, but rather a score. That is, if

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

zturner added a comment. In https://reviews.llvm.org/D54187#1290432, @rnk wrote: > I hadn't realized that Dexter knew how to drive VS tools. I'll have to go > read more and get back to you all. > > I think it would be more promising than attempting to come up with a new > llgdb.py-like abstract

r346343 - [OPENMP]Fix handling of the globals during compilation for the device.

Author: abataev Date: Wed Nov 7 11:11:14 2018 New Revision: 346343 URL: http://llvm.org/viewvc/llvm-project?rev=346343&view=rev Log: [OPENMP]Fix handling of the globals during compilation for the device. Fixed lookup for the target regions in unused virtual functions + fixed processing of the gl

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

nastafev added a comment. Hello. It seems you were well aware that you are changing the semantics of FP operation here by ignoring the signaling/quiet portion of the immediate. But what shall the user do now? There was no way to force quiet FP comparison behavior in C language, so intrinsics an

[PATCH] D54169: [clang-tidy] Zircon ->

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/FblLimitsCheck.cpp:47 +SrcMgr::CharacteristicKind FileType) { + if (FileName == "fbl/limits.h") { +unsigned End = std::strcspn(SM.getCharacterData(HashLoc), "\n") + 1; j

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

efriedma added a comment. > It seems you were well aware that you are changing the semantics of FP > operation here by ignoring the signaling/quiet portion of the immediate. There's ongoing work to support code that accesses the floating point environment (see http://llvm.org/docs/LangRef.html

[PATCH] D51575: [clang-tidy/checks] Implement a clang-tidy check to verify Google Objective-C function naming conventions 📜

benhamilton added inline comments. Comment at: docs/clang-tidy/checks/google-objc-function-naming.rst:20 + static bool is_positive(int i) { return i > 0; } + bool IsNegative(int i) { return i < 0; } + This is not actually handled by the check, right? (You even

[PATCH] D54222: [clang-tidy/checks] Add a checker to detect returning static locals in public headers

jranieri-grammatech created this revision. jranieri-grammatech added reviewers: aaron.ballman, alexfh, NoQ. Herald added subscribers: cfe-commits, mgorny. This adds a checker, llvm-problematic-statics, that detects functions in header files that return the address of a local static variable. Thes

[PATCH] D53675: [WebAssembly] Lower select for vectors

aheejin added a comment. I tried to add `ISD::SELECT` in the expansion list, like for (auto Op : {ISD::VSELECT, ISD::SELECT_CC, ISD::SELECT}) { ... } And the code generation apparently works for current test `simd-select.ll`. I'm not sure if it's optimal though. Could you check again?

[PATCH] D53334: [Frontend/Modules] Show diagnostics on prebuilt module configuration mismatch too

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. While I'm not 100% sure about the actual fix - I'm confident enough that @rsmith can provide any further clarification in post-commit. the test case can probably be simplified before commi

[PATCH] D54222: [clang-tidy/checks] Add a checker to detect returning static locals in public headers

Eugene.Zelenko added a comment. C++ Core Guidelines also mentioned similar patterns, so may be this check belongs to bugprone module? Comment at: docs/clang-tidy/checks/llvm-problematic-statics.rst:7 + +Looks for functions defined in "public" headers that return the address of

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

JonasToth added a comment. I agree with @Eugene.Zelenko that this check should rather live in `bugprone-` as the issue its diagnosing is not LLVM specific. It is ok to add an alias into the llvm module. Comment at: clang-tidy/llvm/ProblematicStaticsCheck.cpp:22 +void Problema

[PATCH] D54169: [clang-tidy] Zircon ->

steveire added a comment. This is https://bugs.llvm.org//show_bug.cgi?id=32739 . I think checks not relevant to a general audience (ie including the boost directory) should be in external plugins. It's not really clear to me what has to happen for that, but it seems increasingly relevant. htt

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

aaron.ballman added inline comments. Comment at: clang-tidy/llvm/ProblematicStaticsCheck.cpp:33 + const auto *VD = Result.Nodes.getNodeAs("var"); + const auto *Return = Result.Nodes.getNodeAs("return"); + diag(Return->getBeginLoc(), "address of static local variable %0 may not

[PATCH] D45616: [X86] Lower _mm[256|512]_cmp[.]_mask intrinsics to native llvm IR

nastafev added a comment. > can trigger arbitrary floating-point exceptions anywhere in your code I believe this statement reflects the current state of many compilers on the market, I guess I just don't see the reason why making things worse. It seems the original intent of the commit was to

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete updated this revision to Diff 173056. Rakete added a comment. Addressed review comments! :) Repository: rC Clang https://reviews.llvm.org/D53847 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Parse/Parser.h include/clang/Sema/Sema.h lib/Parse/ParseDecl

[PATCH] D54222: [clang-tidy] Add a check to detect returning static locals in public headers

Eugene.Zelenko added a comment. Please mention new check in Release Notes (in alphabetical order). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D54222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

Rakete marked 9 inline comments as done. Rakete added a comment. I also found another diagnostic regression: template T::type(); The previous error message was something with "nested name specifier does not refer to class ...". Now, the T::type part is interpreted as type and so we

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh marked 2 inline comments as done. neerajksingh added a comment. Will update revision... Comment at: test/Driver/cl-options.c:619 + +// RUN: %clang_cl -O2 -### -- %s 2>&1 | FileCheck -check-prefix=NOCLANG %s +// NOCLANG: "--dependent-lib=libcmt" han

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh updated this revision to Diff 173072. neerajksingh marked an inline comment as done. https://reviews.llvm.org/D53457 Files: docs/UsersManual.rst include/clang/Driver/CLCompatOptions.td include/clang/Driver/Driver.h lib/Driver/Driver.cpp test/Driver/cl-options.c Index: test

[PATCH] D53457: clang-cl: Add "/clang:" pass-through arg support.

neerajksingh added a comment. Reid, Hans, or someone else with commit access. If the revision looks good, could you please submit to SVN? Any particular testing I should run beforehand? I ran the clang tests locally on Windows. https://reviews.llvm.org/D53457 __

r346378 - [clang] Set CMP0075 to new

Author: smeenai Date: Wed Nov 7 16:29:33 2018 New Revision: 346378 URL: http://llvm.org/viewvc/llvm-project?rev=346378&view=rev Log: [clang] Set CMP0075 to new Make the check_include_file* macros honor CMAKE_REQUIRED_LIBRARIES. This shouldn't cause any of the configuration checks to give differe

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 173090. leonardchan marked an inline comment as done. leonardchan added a comment. Herald added a subscriber: arphaman. - Added a new type sugar node `MacroDefinedType` which wraps `AttributedType`s for the purpose of determining if an attribute was defin

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added inline comments. Comment at: lib/Sema/SemaType.cpp:5817-5822 + IdentifierInfo *AddressSpaceMacroII = nullptr; + auto FoundMacro = S.PP.AddressSpaceMacros.find( + S.SourceMgr.getSpellingLoc(Attr.getLoc())); + if (FoundMacro != S.PP.Address

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:958-964 + // Remove the address_space qualifier so it does not get printed. We + // instead want to print the macro only. + SplitQualType SplitTy = AttrTy->getModifiedType().split(); +

[PATCH] D54243: DebugInfo: Add a driver flag for DWARF debug_ranges base address specifier use.

dblaikie created this revision. dblaikie added reviewers: JDevlieghere, aprantl, probinson. Herald added a subscriber: cfe-commits. This saves a lot of relocations in optimized object files (at the cost of some cost/increase in linked executable bytes), but gold's 32 bit gdb-index support has a bu

[PATCH] D54245: [VFS] Implement `RedirectingFileSystem::getRealPath`.

vsapsai created this revision. vsapsai added reviewers: bruno, benlangmuir. Herald added subscribers: dexonsmith, hiraditya. It fixes the case when Objective-C framework is added as a subframework through a symlink. When parent framework infers a module map and fails to detect a symlink, it would

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/abseil/DurationFactoryScaleCheck.cpp:36 +GetScaleForFactory(llvm::StringRef FactoryName) { + static const auto *ScaleMap = + new std::unordered_map( This will cause memory leaks, so may be unique_

[PATCH] D53522: [Frontend] Include module map header declaration in dependency file output

vsapsai added inline comments. Comment at: clang/lib/Frontend/DependencyFile.cpp:100 + +DepCollector.maybeAddDependency(HeaderPath, /*FromModule=*/false, IsSystem, +/*IsModuleFile*/ false, This `/*FromModule=*/false` looks

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

smeenai added a comment. In https://reviews.llvm.org/D52674#1281747, @rjmccall wrote: > In https://reviews.llvm.org/D52674#1271814, @smeenai wrote: > > > @rjmccall I prototyped the ForRTTI parameter approach in > > https://reviews.llvm.org/D53546. It could definitely be cleaned up a bit, > > bu

  1   2   >