[PATCH] D54202: [clangd] Drop namespace references in the index.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clangd/index/SymbolCollector.cpp:359
     return true;
-  if (CollectRef &&
+  if (CollectRef && !isa<NamespaceDecl>(ND) &&
       (Opts.RefsInHeaders || SM.getFileID(SpellingLoc) == SM.getMainFileID()))
----------------
kadircet wrote:
> Why not handle in `shouldCollectSymbol` ?
`shouldCollectSymbol` is shared between the code collecting symbols and the 
code collecting references, we still want to collect namespace symbols.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54202



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits