kadircet added inline comments.
================
Comment at: clangd/index/SymbolCollector.cpp:359
return true;
- if (CollectRef &&
+ if (CollectRef && !isa<NamespaceDecl>(ND) &&
(Opts.RefsInHeaders || SM.getFileID(SpellingLoc) == SM.getMainFileID()))
----------------
Why not handle in `shouldCollectSymbol` ?
================
Comment at: clangd/index/SymbolCollector.h:60
+ /// Note that references of namespace decls are not collected, as they
+ /// contribute large part of the index, anbd they are less useful compared
+ /// with other decls.
----------------
another typo anbd -> and
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54202
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
