[PATCH] D52549: [VFS] Add a VFS wrapper which avoids opening nonexistent files by reading dirs.

sammccall updated this revision to Diff 167435. sammccall added a comment. Herald added a subscriber: mgrang. Tests, tweaks to fix edge cases. Repository: rC Clang https://reviews.llvm.org/D52549 Files: include/clang/Basic/VirtualFileSystem.h lib/Basic/AvoidStatsVFS.cpp lib/Basic/CMake

[PATCH] D52581: [AST] Revert mangling changes from r339428

theraven added a comment. In https://reviews.llvm.org/D52581#1248306, @smeenai wrote: > The simplest option is something like https://reviews.llvm.org/P8109, where > we add a `.objc` discriminator when mangling the RTTI itself. It would > require the GNUStep runtime for Windows to be altered ac

[PATCH] D52549: [VFS] Add a VFS wrapper which avoids opening nonexistent files by reading dirs.

sammccall marked 2 inline comments as done. sammccall added a comment. Though logs looked good, actual profiles and straces shows we're still stat()ing every file in listed directories. https://reviews.llvm.org/D44960/https://reviews.llvm.org/rL329338 is the culprit, will make a new patch to fix

[PATCH] D51949: [WIP][clang-tidy] initial ideas to isolate variable declarations

JonasToth updated this revision to Diff 167437. JonasToth added a comment. - write user-facing documentation Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/IsolateDeclCheck.cpp clang-tidy/readabilit

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

Hahnfeld added a comment. Just tested this and got very weird results for register usage: void func(double *a) { #pragma omp target teams distribute parallel for map(a[0:100]) // dist_schedule(static) for (int i = 0; i < 100; i++) { a[i]++; } } Compiling with current trunk

[PATCH] D27621: [clang-tidy] check to find declarations declaring more than one name

JonasToth added a comment. Hi @firolino, I implemented a less general version of you check https://reviews.llvm.org/D51949 as I wanted to achieve a slightly different goal (and this revision seems to be abonded). My aim is to have general transformation capabilities to separate declarations (va

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

lebedev.ri added a comment. I have looked through tests, and it is possible that i just missed it, but does it test/handle the cases like: struct S { int X, Y, Z; // <- should be diagnosed. } Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343 + auto Diag =

r343304 - [ARM] Alter test to account for change to armv6k default CPU

Author: psmith Date: Fri Sep 28 02:04:31 2018 New Revision: 343304 URL: http://llvm.org/viewvc/llvm-project?rev=343304&view=rev Log: [ARM] Alter test to account for change to armv6k default CPU Review D52594 will change the default in llvm for armv6k from the non-existent cpu arm1176jf-s to mpcor

[PATCH] D52595: [ARM] Alter test to account for change to armv6k default CPU

This revision was automatically updated to reflect the committed changes. Closed by commit rL343304: [ARM] Alter test to account for change to armv6k default CPU (authored by psmith, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5259

[PATCH] D52595: [ARM] Alter test to account for change to armv6k default CPU

This revision was automatically updated to reflect the committed changes. Closed by commit rC343304: [ARM] Alter test to account for change to armv6k default CPU (authored by psmith, committed by ). Repository: rC Clang https://reviews.llvm.org/D52595 Files: test/Driver/arm-cortex-cpus.c

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added a comment. In https://reviews.llvm.org/D51949#1248850, @lebedev.ri wrote: > I have looked through tests, and it is possible that i just missed it, but > does it test/handle the cases like: > > struct S { > int X, Y, Z; // <- should be diagnosed. > } > Unfortunatly not

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added inline comments. Comment at: clang-tidy/readability/IsolateDeclCheck.cpp:343 + auto Diag = + diag(WholeDecl->getBeginLoc(), "this statement declares %0 variables") + << static_cast( lebedev.ri wrote: > JonasToth wrote: > > aaron.ballman

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

lebedev.ri added a comment. In https://reviews.llvm.org/D51949#1248861, @JonasToth wrote: > In https://reviews.llvm.org/D51949#1248850, @lebedev.ri wrote: > > > I have looked through tests, and it is possible that i just missed it, but > > does it test/handle the cases like: > > > > struct S {

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added inline comments. Comment at: test/clang-tidy/readability-isolate-decl.cpp:184 + + int member1, member2; + // TODO: Transform FieldDecl's as well @lebedev.ri :P Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 __

[PATCH] D52591: Fix Bug 39067: The keyword "try" in C++ function-try-blocks doesn't obey BraceWrapping settings

owenpan abandoned this revision. owenpan added a comment. Closed by r343305 Repository: rC Clang https://reviews.llvm.org/D52591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth updated this revision to Diff 167445. JonasToth added a comment. - add tests for auto and decltype - rename check to 'readability-isolate-declaration' Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/read

[clang-tools-extra] r343306 - [docs] Fix links in Clangd documentation

Author: omtcyfz Date: Fri Sep 28 02:32:47 2018 New Revision: 343306 URL: http://llvm.org/viewvc/llvm-project?rev=343306&view=rev Log: [docs] Fix links in Clangd documentation Add missing `_` after each `external link `_, as required by the reStructuredText specification. Modifi

Re: r338255 - [CodeComplete] Fix the crash in code completion on access checking

On Mon, Jul 30, 2018 at 5:19 PM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryukov > Date: Mon Jul 30 08:19:05 2018 > New Revision: 338255 > > URL: http://llvm.org/viewvc/llvm-project?rev=338255&view=rev > Log: > [CodeComplete] Fix the crash in code completion o

[PATCH] D52620: Added Support for StatOnly Files in VFS.

sammccall added a comment. Could you give some more detail about what this is for? - it sounds like this is for record-replay. In the replayed compilation, we assume the accessed files are the same, is it safe to assume we never read files we previously stat()ed? What are these files in practic

[PATCH] D52620: Added Support for StatOnly Files in VFS.

kbobyrev added inline comments. Comment at: lib/Basic/VirtualFileSystem.cpp:2097 void YAMLVFSWriter::write(llvm::raw_ostream &OS) { - llvm::sort(Mappings, [](const YAMLVFSEntry &LHS, const YAMLVFSEntry &RHS) { + llvm::sort(Mappings.begin(), Mappings.end(), + [](con

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

lebedev.ri added a comment. Thank you for working on this! Tried on a pet project , Two hits: $ ninja [16/376] Checking validity of cameras.xml /home/lebedevri/rawspeed/data/cameras.xml validates [100/376] Building CXX object src/CMakeFiles/raw

r343309 - [ARM] Prevent DSP and SIM32 being set for v6m

Author: sam_parker Date: Fri Sep 28 03:18:02 2018 New Revision: 343309 URL: http://llvm.org/viewvc/llvm-project?rev=343309&view=rev Log: [ARM] Prevent DSP and SIM32 being set for v6m My previous change (rL340911) set the two features for architectures >= 6, which wrongly includes v6m. Now set to

[PATCH] D52644: [ARM] Prevent DSP and SIM32 being set for v6m

This revision was automatically updated to reflect the committed changes. Closed by commit rC343309: [ARM] Prevent DSP and SIM32 being set for v6m (authored by sam_parker, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D52644?vs=167444&

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added a comment. LLVM works, Blender doesn't, the offending piece is `float (((*f_ptr2)))[42], *f_ptr3, f_value2 = 42.f;` (parens around the pointer). I am trying to fix that. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

(Oops, forgot there was this thread. Pasting my response to r338255 here). > The code seemed obviously wrong there (calling accessibility checking, passing a possibly unrelated class) and the tests didn't break after reverting it. It turns out that this was due to my lacking LIT test skill. LIT d

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

gtbercea added a comment. In https://reviews.llvm.org/D52434#1248844, @Hahnfeld wrote: > Just tested this and got very weird results for register usage: > > void func(double *a) { > #pragma omp target teams distribute parallel for map(a[0:100]) // > dist_schedule(static) > for (int i =

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

Hahnfeld added a comment. In https://reviews.llvm.org/D52434#1248974, @gtbercea wrote: > One big problem your code has is that the trip count is incredibly small, > especially for STREAM and especially on GPUs. You need a much larger loop > size otherwise the timings will be dominated by OpenMP

[PATCH] D52620: Added Support for StatOnly Files in VFS.

usaxena95 added a comment. > it sounds like this is for record-replay. Yes this is for record-replay purpose. > What are these files in practice? During loading a modules the files that were required to make the module are stat()ed and their sizes are used to verify that the module is still va

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

gtbercea added a comment. In https://reviews.llvm.org/D52434#1248975, @Hahnfeld wrote: > In https://reviews.llvm.org/D52434#1248974, @gtbercea wrote: > > > One big problem your code has is that the trip count is incredibly small, > > especially for STREAM and especially on GPUs. You need a much

[PATCH] D52647: [CodeComplete] Re-fix accessibilty of protected members from base class.

ioeric created this revision. ioeric added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. The initial fix (r337453) had bug and was partially reverted (r338255). This simplies the original fix by explicitly passing the naming class to the completion consumer. Repository: rC

[PATCH] D52620: Added Support for StatOnly Files in VFS.

usaxena95 added inline comments. Comment at: lib/Basic/VirtualFileSystem.cpp:2097 void YAMLVFSWriter::write(llvm::raw_ostream &OS) { - llvm::sort(Mappings, [](const YAMLVFSEntry &LHS, const YAMLVFSEntry &RHS) { + llvm::sort(Mappings.begin(), Mappings.end(), + [](co

Re: r337453 - [CodeComplete] Fix accessibilty of protected members from base class.

PTAL: https://reviews.llvm.org/D52647 On Fri, Sep 28, 2018 at 2:13 PM Eric Liu wrote: > (Oops, forgot there was this thread. Pasting my response to r338255 here). > > > The code seemed obviously wrong there (calling accessibility checking, > passing a possibly unrelated class) and the tests didn

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

patricklyster added a comment. In https://reviews.llvm.org/D52625#1248436, @ABataev wrote: > I forgot to mention that you need an ast print test (the positive test) Thanks for the reminder. I will add that Repository: rC Clang https://reviews.llvm.org/D52625

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

patricklyster updated this revision to Diff 167459. patricklyster added a comment. Added AST print test for `unified_shared_memory https://reviews.llvm.org/D52625 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang/Basic/OpenMPKi

[PATCH] D52625: [OPENMP] Add 'unified_shared_memory' clause to OMP5 'requires' directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D52625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D52586: [X86] Add the movbe instruction intrinsics from icc.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D52586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D50850: clang: Add triples support for MIPS r6

atanasyan added a comment. Fine. Now this patch has modifications for LLVM (not Clang) and all these changes were applied at https://reviews.llvm.org/rL343185 already. Could you attach an actual patch brings https://reviews.llvm.org/source/compiler-rt/ support to the Clang driver? https://rev

[PATCH] D51464: clang: fix MIPS/N32 triple and paths

atanasyan added inline comments. Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:85 if (ABIName.empty() && (Triple.getVendor() == llvm::Triple::MipsTechnologies || Is possible to rewrite this piece of code (lines 85-114) as follows? ``` if (ABIName.

[PATCH] D52650: [clangd] NFC: Migrate to LLVM STLExtras API where possible

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, dexonsmith, mgrang, jkorous, MaskRay, javed.absar, ilya-biryukov. This patch improves readability by migrating `std::function(For

[PATCH] D52650: [clangd] NFC: Migrate to LLVM STLExtras API where possible

kbobyrev added a comment. Also, I'm not sure whether I should update Clang-Tidy and other tools in the scope of this patch. It makes sense to me, but I don't know whether the maintainers of these projects are happy with the change. WDYT? https://reviews.llvm.org/D52650 _

r343305 - [ClangFormat] 'try' of function-try-block doesn't obey BraceWrapping

Author: owenpan Date: Fri Sep 28 02:17:00 2018 New Revision: 343305 URL: http://llvm.org/viewvc/llvm-project?rev=343305&view=rev Log: [ClangFormat] 'try' of function-try-block doesn't obey BraceWrapping It should respond to AfterFunction, not AfterControlStatement. Fixes PR39067 Modified: c

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

gtbercea added a comment. In https://reviews.llvm.org/D52434#1248975, @Hahnfeld wrote: > In https://reviews.llvm.org/D52434#1248974, @gtbercea wrote: > > > One big problem your code has is that the trip count is incredibly small, > > especially for STREAM and especially on GPUs. You need a much

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

AlexeySachkov created this revision. AlexeySachkov added reviewers: Anastasia, yaxunl. Repository: rC Clang https://reviews.llvm.org/D52654 Files: include/clang/AST/OperationKinds.def lib/AST/Expr.cpp lib/AST/ExprConstant.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGExprAgg.cpp lib/Cod

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added a comment. Blender looks better now, code compiles after full transformation F7327473: blender_isolated_decls.patch Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 ___ cfe-co

[PATCH] D52654: [OpenCL][NFC] Unify ZeroToOCL* cast types

AlexeySachkov added a comment. This is an initial version. I guess there are some other enums related to CK_ZeroToOCL* which also can be merged. Also, I'm not sure that `CK_ZeroToOCLOpaqueType` is a good name. Thoughts? Repository: rC Clang https://reviews.llvm.org/D52654 ___

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

Hahnfeld added a comment. In https://reviews.llvm.org/D52434#1249102, @gtbercea wrote: > You report a slow down which I am not able to reproduce actually. Do you use > any additional clauses not present in your previous post? No, only `dist_schedule(static)` which is faster. Tested on a `Tesla

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added a comment. llvm and clang look fine as well. No miscompilation after fixing, tests run as well. (i do exclude all targets except x86 for build-speed) F7327680: cfe_isolated_decl.patch F7327681: llvm_isolated_decl.patch

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth updated this revision to Diff 167491. JonasToth added a comment. Herald added subscribers: jsji, kbarton, nemanjai. - fix paren issue, introduced non-local changes i will extract and post in a separate patch - remove debug output for paren search Repository: rCTE Clang Tools Extra

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth added inline comments. Comment at: docs/clang-tidy/checks/readability-isolate-declaration.rst:33 + for (int Begin = 0, End = 100; Begin < End; ++Begin); + it (int Begin = 42, Result = some_function(Begin); Begin == Result); + typo mention `if () int i

[PATCH] D52384: [Sema] Fix redeclaration contexts for enumerators in C

aaron.ballman updated this revision to Diff 167496. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Herald added a subscriber: jsji. Updated based on review feedback. https://reviews.llvm.org/D52384 Files: lib/AST/DeclBase.cpp test/Sema/enum.c Index: test/Se

[PATCH] D52384: [Sema] Fix redeclaration contexts for enumerators in C

aaron.ballman added inline comments. Comment at: lib/AST/DeclBase.cpp:1711-1712 + // contexts are always skipped. + while (SkipRecords ? Ctx->isTransparentContext() || Ctx->isRecord() + : Ctx->isTransparentContext()) Ctx = Ctx->getParent();

r343335 - [DRIVER][OFFLOAD] Do not invoke unbundler on unsupported file types.

Author: abataev Date: Fri Sep 28 09:17:59 2018 New Revision: 343335 URL: http://llvm.org/viewvc/llvm-project?rev=343335&view=rev Log: [DRIVER][OFFLOAD] Do not invoke unbundler on unsupported file types. clang-offload-bundler should not be invoked with the unbundling action when the input file typ

[PATCH] D52658: [OpenCL] Remove PIPE_RESERVE_ID_VALID_BIT from the common header

sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added a subscriber: cfe-commits. PIPE_RESERVE_ID_VALID_BIT is implementation defined, so lets not keep it in the header. Previously the topic was discussed here: https://reviews.llvm.org/D32896 Repository: rC

[PATCH] D52400: Improve -Wshadow warnings with enumerators

erik.pilkington added inline comments. Comment at: lib/Sema/SemaDecl.cpp:16320 +// Check for other kinds of shadowing not already handled. +CheckShadow(New, PrevDecl, R); + I don't think we should do this for scoped enums in C++, i.e. this should be fine

r343338 - AST: add missing ObjC extensions to MS style name decoration

Author: compnerd Date: Fri Sep 28 09:47:53 2018 New Revision: 343338 URL: http://llvm.org/viewvc/llvm-project?rev=343338&view=rev Log: AST: add missing ObjC extensions to MS style name decoration Add support for encoding type arguments for lightweight generics in Objective-C++ mode. Additionally

[PATCH] D52586: [X86] Add the movbe instruction intrinsics from icc.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343343: [X86] Add the movbe instruction intrinsics from icc. (authored by ctopper, committed by ). Repository: rC Clang https://reviews.llvm.org/D52586 Files: lib/Basic/Targets/X86.cpp lib/Headers

r343343 - [X86] Add the movbe instruction intrinsics from icc.

Author: ctopper Date: Fri Sep 28 10:09:51 2018 New Revision: 343343 URL: http://llvm.org/viewvc/llvm-project?rev=343343&view=rev Log: [X86] Add the movbe instruction intrinsics from icc. These intrinsics exist in icc. They can be found on the Intel Intrinsics Guide website. All the backend supp

[PATCH] D52586: [X86] Add the movbe instruction intrinsics from icc.

This revision was automatically updated to reflect the committed changes. Closed by commit rL343343: [X86] Add the movbe instruction intrinsics from icc. (authored by ctopper, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52586?vs=16

[PATCH] D52400: Improve -Wshadow warnings with enumerators

aaron.ballman updated this revision to Diff 167507. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Updating based on review feedback. https://reviews.llvm.org/D52400 Files: lib/Sema/SemaDecl.cpp test/Sema/warn-shadow.c test/SemaCXX/warn-shadow.cpp Index:

[PATCH] D52400: Improve -Wshadow warnings with enumerators

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:16320 +// Check for other kinds of shadowing not already handled. +CheckShadow(New, PrevDecl, R); + erik.pilkington wrote: > I don't think we should do this for scoped enums in C++, i.

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added subscribers: cfe-commits, mgorny. Herald added a reviewer: EricWF. We don't need to support legacy ABI and hence we can use the new one. Repository: rC Clang https://reviews.llvm.org/D52660 Files: cl

[PATCH] D52660: [CMake][Fuchsia] Use libc++ ABIv2 for Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D52660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D52434: [OpenMP] Make default distribute schedule for NVPTX target regions in SPMD mode achieve coalescing

gtbercea added a comment. In https://reviews.llvm.org/D52434#1249186, @Hahnfeld wrote: > In https://reviews.llvm.org/D52434#1249102, @gtbercea wrote: > > > You report a slow down which I am not able to reproduce actually. Do you > > use any additional clauses not present in your previous post? >

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

erik.pilkington added a comment. Ping! This doesn't really affect CUDA or OpenCL more than any change to the compiler, so I don't think it makes sense to block this until we hear from them. Repository: rC Clang https://reviews.llvm.org/D52339 __

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

aaron.ballman added a comment. Can you add some tests for cases like: // C code void (*signal(int sig, void (*func)(int)))(int); // One decl int i = sizeof(struct S { int i;}); // One decl int j = sizeof(struct T { int i;}), k; // Two decls void g(struct U { int i; } s); // One decl v

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D52339#1249432, @erik.pilkington wrote: > Ping! This doesn't really affect CUDA or OpenCL more than any change to the > compiler, so I don't think it

[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles

danzimm created this revision. danzimm added a reviewer: modocache. Herald added a subscriber: cfe-commits. Previous to this the example didn't work out of the box, it seems some cmake config changed between when this was written and now. Repository: rC Clang https://reviews.llvm.org/D52664

[PATCH] D52665: [X86] Add more of the icc unaligned load/store to/from 128 bit vector intrinsics

craig.topper created this revision. craig.topper added reviewers: spatel, RKSimon. This patch adds _mm_loadu_si32 _mm_loadu_si16 _mm_storeu_si64 _mm_storeu_si32 _mm_storeu_si16 We already had _mm_load_si64. https://reviews.llvm.org/D52665 Files: lib/Headers/emmintrin.h test/CodeGen/sse2-bu

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

Eugene.Zelenko added a comment. How about creating CERT alias? Comment at: clang-tidy/readability/IsolateDeclarationCheck.cpp:58 + // number of transformations. + while (Indirections--) { +Start = findPreviousAnyTokenKind(Start, SM, LangOpts, tok::star, tok::amp); ---

[PATCH] D51949: [clang-tidy] new check 'readability-isolate-declaration'

JonasToth updated this revision to Diff 167523. JonasToth added a comment. - simplify matcher slighty, as initStmt in if/switch don't have a compundstmt as parent, add suggested tests Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51949 Files: clang-tidy/bugprone/ArgumentCom

[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Yes, `add_llvm_executable` uses `target_link_libraries` with `PRIVATE` for `LLVM_PTHREAD_LIB`. It is designed so that if you use the `PUBLIC|PRIVATE|INTERFACE` keyword with a target once,

r343350 - [cxx2a] P0614R1: Support init-statements in range-based for loops.

Author: rsmith Date: Fri Sep 28 11:44:09 2018 New Revision: 343350 URL: http://llvm.org/viewvc/llvm-project?rev=343350&view=rev Log: [cxx2a] P0614R1: Support init-statements in range-based for loops. We don't yet support this for the case where a range-based for loop is implicitly rewritten to an

[PATCH] D52667: [analyzer] Fix conversion from LocAsInteger to Loc symbol.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, baloghadamsoftware. The thing i promised to fix in the last bullet of https://reviews.llvm.org/D44347: > `Symb

r343352 - [analyzer] Provide an option to dump generated exploded graphs to a given file.

Author: george.karpenkov Date: Fri Sep 28 11:49:21 2018 New Revision: 343352 URL: http://llvm.org/viewvc/llvm-project?rev=343352&view=rev Log: [analyzer] Provide an option to dump generated exploded graphs to a given file. Dumping graphs instead of opening them is often very useful, e.g. for tran

r343353 - [analyzer] [NFC] Remove unused parameters, as found by -Wunused-parameter

Author: george.karpenkov Date: Fri Sep 28 11:49:41 2018 New Revision: 343353 URL: http://llvm.org/viewvc/llvm-project?rev=343353&view=rev Log: [analyzer] [NFC] Remove unused parameters, as found by -Wunused-parameter Differential Revision: https://reviews.llvm.org/D52640 Modified: cfe/trunk

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

rsmith added a comment. In https://reviews.llvm.org/D52339#1249457, @aaron.ballman wrote: > In https://reviews.llvm.org/D52339#1249432, @erik.pilkington wrote: > > > Ping! This doesn't really affect CUDA or OpenCL more than any change to the > > compiler, so I don't think it makes sense to block

[PATCH] D52637: [analyzer] Provide an option to dump generated exploded graphs to a given file.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343352: [analyzer] Provide an option to dump generated exploded graphs to a given file. (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: ht

[PATCH] D52640: [analyzer] [NFC] Remove unused parameters, as found by -Wunused-parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rC343353: [analyzer] [NFC] Remove unused parameters, as found by -Wunused-parameter (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://

[PATCH] D52538: [MinGW] Allow using ASan

mstorsjo added a comment. Ping @rnk in case you have time to look at it despite CppCon Repository: rC Clang https://reviews.llvm.org/D52538 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D52664: Update CMakeLists.txt snippet so that example compiles

smeenai added a comment. Yep, that's my doing (https://reviews.llvm.org/rL319840). I didn't think about the documentation, whoops. Repository: rC Clang https://reviews.llvm.org/D52664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:

Re: [PATCH] D52650: [clangd] NFC: Migrate to LLVM STLExtras API where possible

I think it's fine to update others too, this is a trivially-safe change and a nice readability improvement. No need to put everything in the same patch though. On Fri, Sep 28, 2018, 16:23 Kirill Bobyrev via Phabricator < revi...@reviews.llvm.org> wrote: > kbobyrev added a comment. > > Also, I'm n

[PATCH] D52650: [clangd] NFC: Migrate to LLVM STLExtras API where possible

sammccall added subscribers: ioeric, kbobyrev. sammccall added a comment. I think it's fine to update others too, this is a trivially-safe change and a nice readability improvement. No need to put everything in the same patch though. https://reviews.llvm.org/D52650 ___

r343356 - [OPENMP]Fix PR39084: Check datasharing attributes of reduction variables only.

Author: abataev Date: Fri Sep 28 12:33:14 2018 New Revision: 343356 URL: http://llvm.org/viewvc/llvm-project?rev=343356&view=rev Log: [OPENMP]Fix PR39084: Check datasharing attributes of reduction variables only. According to OpenMP, the reduction item must be shared in parent region. But the ite

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

aaron.ballman added a comment. In https://reviews.llvm.org/D52339#1249531, @rsmith wrote: > In https://reviews.llvm.org/D52339#1249457, @aaron.ballman wrote: > > > In https://reviews.llvm.org/D52339#1249432, @erik.pilkington wrote: > > > > > Ping! This doesn't really affect CUDA or OpenCL more th

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

This revision was automatically updated to reflect the committed changes. Closed by commit rC343360: Support enums with a fixed underlying type in all language modes. (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D52339?vs=166397&id=167538#toc Repository

[PATCH] D52339: Support enums with a fixed underlying type in all language modes

erik.pilkington added a comment. In https://reviews.llvm.org/D52339#1249457, @aaron.ballman wrote: > However, short of that concern, this LGTM. I've spoken with the paper author > for the WG14 paper and I think this approach fits their general proposal, so > I don't think we'll have divergence

r343360 - Support enums with a fixed underlying type in all language modes.

Author: epilk Date: Fri Sep 28 13:24:58 2018 New Revision: 343360 URL: http://llvm.org/viewvc/llvm-project?rev=343360&view=rev Log: Support enums with a fixed underlying type in all language modes. Previously we supported these in C++, ObjC, and C with -fms-extensions. rdar://43831380 Different

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri created this revision. lebedev.ri added reviewers: JonasToth, aaron.ballman, alexfh, hokein, xazax.hun. lebedev.ri added a project: clang-tools-extra. Herald added subscribers: rnkovacs, mgorny. Detects when the integral literal or floating point (decimal or hexadecimal) literal has non

[PATCH] D52650: [clangd] NFC: Migrate to LLVM STLExtras API where possible

kbobyrev added a comment. In https://reviews.llvm.org/D52650#1249556, @sammccall wrote: > I think it's fine to update others too, this is a trivially-safe change and > a nice readability improvement. > No need to put everything in the same patch though. Great, thanks! I'll submit the patch on

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52673: [HIP] Remove disabled irif library

ashi1 created this revision. ashi1 added reviewers: yaxunl, b-sumner, scchan. Herald added a subscriber: cfe-commits. Device Libraries has removed irif.amdgcn.bc, so we need to remove this requirement from HIP Toolchains. Also a few header functions need to be updated. Repository: rC Clang h

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:96 +- New alias :doc:`cert-dcl16-c + ` to :doc:`readability-uppercase-literal-suffix Please move alias after new checks. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

Eugene.Zelenko added a comment. May be we should also create MISRA module? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52670 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri updated this revision to Diff 167547. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. Move alias to after the new check, Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52670 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeL

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri added inline comments. Comment at: docs/ReleaseNotes.rst:96 +- New alias :doc:`cert-dcl16-c + ` to :doc:`readability-uppercase-literal-suffix Eugene.Zelenko wrote: > Please move alias after new checks. BTW, is there some tool to actually add this a

[PATCH] D52670: [clang-tidy] Add new 'readability-uppercase-literal-suffix' check (CERT DCL16-C, MISRA C:2012, 7.3, MISRA C++:2008, 2-13-4)

lebedev.ri updated this revision to Diff 167552. lebedev.ri added a comment. - Deduplicate one test. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52670 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/cert/CMakeLists.txt clang-tidy/readability/CMakeLists.txt clang

[PATCH] D52334: [clang-tidy] Build it even without static analyzer

aaron.ballman added a comment. I think that we need some sort of developer documentation change that explains 1) that this option exists when configuring clang-tidy, and 2) that this impacts the MPI module as well as the static analyzer. Comment at: clang-tidy/CMakeLists.txt:

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

smeenai created this revision. smeenai added reviewers: compnerd, DHowett-MSFT, rjmccall, rnk, theraven. Herald added a subscriber: erik.pilkington. Obj-C classes are mangled as C++ structs with the same name (in both the Itanium and the Microsoft ABIs), but we want to be able to distinguish them

[PATCH] D52581: [AST] Revert mangling changes from r339428

smeenai added a comment. https://reviews.llvm.org/D52674 adds the RTTI Obj-C discriminator. I put it up as a separate change so it could be reviewed independently and more thoroughly. Repository: rC Clang https://reviews.llvm.org/D52581 ___ cfe-

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

smeenai updated this revision to Diff 167555. smeenai added a comment. arc fail Repository: rC Clang https://reviews.llvm.org/D52674 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenObjCXX/msabi-objc-exceptions-gnustep.mm Index: test/CodeGenObjCXX/msabi-objc-exceptions-gnustep.mm ===

  1   2   >